[00:19:43] the reluctant slayer [00:31:49] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10EMartin) @Elliott Eggleston This is great news! Will it resolve unsettled items that remain pending from 12/1 forward? Or just from today forward?... [01:04:00] (03PS2) 10Eileen: Stop enabling eoy receipt on dev sites [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744098 [01:04:02] (03PS1) 10Eileen: Goodbye old templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744108 (https://phabricator.wikimedia.org/T297159) [01:04:04] (03PS1) 10Eileen: Add Send api, move tests over. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) [01:04:06] (03PS1) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [01:07:48] (03PS1) 10Eileen: Fix message to be more accurate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744111 [01:10:09] (03CR) 10Eileen: "ejegg I've just gone through this feedback - the important fix is https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/744110/1 - " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739653 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [01:13:12] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10Eileenmcnaughton) [01:17:22] (03CR) 10jerkins-bot: [V: 04-1] End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:19:14] (03CR) 10jerkins-bot: [V: 04-1] Fix message to be more accurate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744111 (owner: 10Eileen) [02:08:57] (03PS2) 10Eileen: Fix message to be more accurate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744111 [02:08:59] (03PS2) 10Eileen: Add Send api, move tests over. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) [02:13:55] (03PS2) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [02:20:59] (03CR) 10jerkins-bot: [V: 04-1] Add Send api, move tests over. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:25:47] (03CR) 10jerkins-bot: [V: 04-1] End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:38:21] (03PS3) 10Eileen: Add Send api, move tests over. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) [02:40:52] (03PS3) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [02:42:14] I've disabled eoy_module on prod & put up a patch to do the same on dev - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/744098/2 - we need to deploy those before I can fully remove it [02:56:09] (03CR) 10Eileen: [C: 03+2] "Code looks good. I stepped through it to be sure & it hit all the right notes. One less weird db thang" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743225 (https://phabricator.wikimedia.org/T296813) (owner: 10Ejegg) [03:08:23] (03Merged) 10jenkins-bot: Run TY initial query via Civi query function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743225 (https://phabricator.wikimedia.org/T296813) (owner: 10Ejegg) [03:31:57] (03PS1) 10Cstone: Sort recurring contributions tab links [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744114 (https://phabricator.wikimedia.org/T291133) [04:37:40] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/744093 (https://phabricator.wikimedia.org/T297012) (owner: 10AndyRussG) [04:37:52] ejegg: thx! [04:38:00] ty for the fix [04:38:30] ah very minimal [04:40:01] (03Merged) 10jenkins-bot: Fix monthly convert button height [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/744093 (https://phabricator.wikimedia.org/T297012) (owner: 10AndyRussG) [04:44:21] ejegg: btw just tested locally on Chrome on my android phone, works fine! [04:45:25] haven't tested on i-devices of any kind though, lemme just see what it looks like on Chafarri [04:52:18] ejegg: confirmed looks fine on Chafarri including skinny form factor [05:00:12] (03CR) 10Eileen: "cstone - one discussion thing & one 'this breaks stuff' thing...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744114 (https://phabricator.wikimedia.org/T291133) (owner: 10Cstone) [06:05:35] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/744247 (owner: 10L10n-bot) [07:52:06] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/744247 (owner: 10L10n-bot) [10:26:55] (03PS7) 10Damilare Adedoyin: WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) [10:27:49] (03CR) 10jerkins-bot: [V: 04-1] WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [12:12:30] (03PS1) 10Umherirrender: Remove PHP entry point [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/744775 (https://phabricator.wikimedia.org/T140850) [13:43:50] (03CR) 10Jgleeson: "Nice spot. I missed that! Will fix now." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/743464 (https://phabricator.wikimedia.org/T296881) (owner: 10Jgleeson) [14:23:03] (03PS9) 10Jgleeson: Adyen Checkout: Add method to pick out best apple pay contact name [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/743464 (https://phabricator.wikimedia.org/T296881) [16:12:23] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10MBeat33) @Eileenmcnaughton many t... [16:16:55] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10Jgreen) @Eileenmcnaughton testing on frdev1001 is definitely... [16:54:33] argh damilare I just realised we've got a bunch of different variable naming conventions going on across the tests for the pending trxn stuff. We've got camelCase for some and snake_case for others... probably a knock on of some early copy and paste when originally setting the tests up I think [17:03:44] (03PS3) 10Jgleeson: testResolveToCompleteCreatesValidPaymentsInitMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) [17:05:07] (03CR) 10jerkins-bot: [V: 04-1] testResolveToCompleteCreatesValidPaymentsInitMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [17:10:08] ah looks like we need to rebase the civilint patch over the latest on master as it's causing a merge conflict right up the chain [17:12:56] jgleeson: I guess some of those variable names would be based on my inclination to camelCase, I'd update my patch too [17:13:20] (03PS4) 10Jgleeson: testResolveCreatesValidPaymentsInitMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) [17:13:49] (03CR) 10jerkins-bot: [V: 04-1] testResolveCreatesValidPaymentsInitMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [17:19:42] (03PS4) 10Jgleeson: Add composer scripts for civilint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) [17:24:40] damilare: it might be easier to do that last [17:25:19] I just fixed the composer.lock merge conflict so once jenkins +2s that I will rebase the existing chain over it in the gerrit UI up to our new patches [17:26:02] also I think you can mark ejegg|away's patch as abandoned if you've squashed your follow-on into his [17:27:08] and thennnnnn we can start the process of consolidating the newly complete antifraud and payments-init queue stuff into the original implementation & tests patches... easy right? [17:27:28] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:29:25] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): Post-payment Monthly Convert *Yes* button text overflows container on some devices - https://phabricator.wikimedia.org/T297012 (10AndyRussG) The change has been merged and has been verified on the follo... [17:32:28] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:36:17] (03PS13) 10Jgleeson: Resolve pending transactions w/o DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [17:36:43] (03PS19) 10Jgleeson: Add tests for Pending Transaction Consumer and Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) [17:37:32] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:38:27] (03PS5) 10Jgleeson: testResolveCreatesValidPaymentsInitMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742530 (https://phabricator.wikimedia.org/T291223) [17:40:25] seeing connectivity issues on the yubico endpoint but only from codfw. [17:41:31] (03PS8) 10Jgleeson: WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [17:46:44] cstone: do you a few minutes to jump on a call to push the apple pay name thingy over the line? [17:46:58] sure jgleeson [17:47:28] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:47:41] let's use today's sprint review call. see ya there cstone [17:52:28] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:53:20] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): Post-payment Monthly Convert *Yes* button text overflows container on some devices - https://phabricator.wikimedia.org/T297012 (10DStrine) This looks fine on Chrome on a Macbook pro [17:56:12] (03CR) 10jerkins-bot: [V: 04-1] WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [18:02:33] (03CR) 10Cstone: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/743464 (https://phabricator.wikimedia.org/T296881) (owner: 10Jgleeson) [18:04:23] (03PS2) 10Ejegg: Goodbye old templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744108 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:04:29] (03CR) 10Ejegg: [C: 03+2] Goodbye old templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744108 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:04:41] (03PS3) 10Ejegg: Stop enabling eoy receipt on dev sites [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744098 (owner: 10Eileen) [18:04:46] (03CR) 10Ejegg: [C: 03+2] Stop enabling eoy receipt on dev sites [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744098 (owner: 10Eileen) [18:05:04] (03Merged) 10jenkins-bot: Adyen Checkout: Add method to pick out best apple pay contact name [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/743464 (https://phabricator.wikimedia.org/T296881) (owner: 10Jgleeson) [18:05:39] (03PS3) 10Ejegg: Fix message to be more accurate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744111 (owner: 10Eileen) [18:05:45] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744111 (owner: 10Eileen) [18:07:23] thanks for the code review cstone!!! [18:12:00] (03CR) 10Ejegg: "Looks like a good start on the Send action, but maybe still missing a couple things. Test enhancements look good." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:12:43] (03CR) 10Ejegg: "Happy to +2 as-is if those missing bits are coming in a follow-on patch" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:14:51] (03Merged) 10jenkins-bot: Goodbye old templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744108 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:15:43] (03Merged) 10jenkins-bot: Stop enabling eoy receipt on dev sites [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744098 (owner: 10Eileen) [18:15:52] (03PS4) 10Ejegg: Add Send api, move tests over. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:16:25] (03CR) 10Ejegg: [C: 03+2] "Ah, I see 'This is still not the final version'. Looks good for now!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:17:47] (03Merged) 10jenkins-bot: Fix message to be more accurate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744111 (owner: 10Eileen) [18:22:47] (03CR) 10Ejegg: "Will download and test to give more feedback, just on first glance the potential multiple totals seems funny to me in the EOYEmail." [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/742590 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [18:27:54] (03Merged) 10jenkins-bot: Add Send api, move tests over. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744109 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [18:30:36] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Forwarding script tunnels IPN listeners, can use autossh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/738598 (owner: 10AndyRussG) [18:34:40] fr-tech just gonna grab dinner but when back gonna try and deploy the apple pay name fix. I your patch is also good to go AndyRussG if you want me to push that out too? [18:34:51] jgleeson: :) not qite [18:34:52] I think* your [18:35:00] ah ok no worries [18:35:17] back later! [18:35:27] sure [18:35:38] ah, was it still overflowing on some devices? [18:37:38] ejegg: I think not overflowing? damilare do you mean the button patch is not quite ready, maybe that we should change it to "auto", or you were talking about something unrelated? [18:42:20] AndyRussG I was replying to jgleeson's message [18:42:40] Where he said "easy right?" [18:42:57] The button patch looks good to me [18:43:45] sorry for the confusion [19:07:29] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:12:29] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:17:29] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:18:04] damilare: ah oki great thx! [19:18:25] ejegg jgleeson ^ yeee button patch seems good to go! [19:22:30] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:24:50] ACKNOWLEDGEMENT - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] Dwisehaupt known - just in codfw https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:27:30] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:27:44] ah ok AndyRussG yeah I thought you were replying to the message about the patch deployment [19:28:00] so is that good to go? [19:28:46] damilare: I've rebased most of the earlier patches over the fixed civilint base patch [19:28:54] I'm now at yours and ejegg's patches [19:29:06] am I safe to skip ejegg's and just use yours? [19:29:22] (03PS1) 10AndyRussG: Reduce length limit for Ingenico city field [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/744851 (https://phabricator.wikimedia.org/T234495) [19:29:48] (03CR) 10Eileen: Short-term fix around displaying localised formatting (031 comment) [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/742590 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:31:15] jgleeson: I think mine should be good to go [19:34:37] hmm damilare when I try clicking on your patch from this link (top of the chain) it takes me to another patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743252 [19:34:47] can you link me to your latest antifraud patch pls? [19:36:02] here: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467 [19:36:46] (03PS4) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [19:36:49] hmm did you change the commit msg on that? [19:38:00] yes I did [19:38:39] jgleeson: yeah the button change for DI is good to go :) [19:40:23] the order the patches is confusing damilare. it looks like your WIP patch is before ejegg's original 'Pending resover: incorporate scores from fredge' patch. checkout https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/742530/5 [19:41:02] but didn't you branch from that? [19:41:18] so the commit should come after it I think [19:41:23] Yes I did [19:41:36] ohh but I squashed it all into "WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall" [19:41:43] (03PS1) 10Eileen: Remove reference to legacy property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744855 (https://phabricator.wikimedia.org/T297159) [19:41:53] That might be the reason [19:42:02] ohhh ok [19:42:04] hmm [19:43:26] (03Abandoned) 10Jgleeson: Pending resover: incorporate scores from fredge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743252 (https://phabricator.wikimedia.org/T296555) (owner: 10Ejegg) [19:44:00] hmm ok so gerrit can't rebase your latest patch over the other stuff here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467/3 [19:44:30] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/744858 [19:44:32] possibly a broken link in the chain [19:44:54] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/744858 (owner: 10Eileen) [19:45:02] I think we'll have to manually rebase damilare and deal with any conflicts [19:45:34] ejegg: am deploying your thank you fix [19:45:49] do you wanna try that at your end, rebase your latest patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467 over the latest payment inits work, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/742530/5 [19:46:34] Ohh ok let me try that [19:47:09] great eileen [19:47:16] it's probably gonna throw up a good few conflicts due to the squashed patch having more changes combined. if you wanna jump on a call to work though it that's cool [19:47:54] Sure please, let's get on the fr-tech call [19:48:41] I'll be there in 5 minutes I'm just gonna prep the payments release to push out the apple pay stuff [19:49:33] !log revision civicrm 311382de -> c47cf762 [19:49:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:50:55] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Product Infrastructure Roadmap, 10Patch-For-Review, 10SEO: CentralNotice code to fix the banner bump with “pageview+1 with exceptions for infrequent visitors and as needed” - https://phabricator.wikimedia.org/T279034 (10Jdlrobson) [19:52:09] (03CR) 10AndyRussG: [C: 03+2] "Wooohoo :) mice with donor-advised funds (and who are not organizations)!!! :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743056 (https://phabricator.wikimedia.org/T296861) (owner: 10Eileen) [19:52:13] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/744860 [19:54:48] (03PS2) 10Cstone: Sort recurring contributions tab links [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744114 (https://phabricator.wikimedia.org/T291133) [19:55:52] (03CR) 10Cstone: Sort recurring contributions tab links (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744114 (https://phabricator.wikimedia.org/T291133) (owner: 10Cstone) [19:56:39] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Product Infrastructure Roadmap, 10Patch-For-Review, 10SEO: CentralNotice code to fix the banner bump with “pageview+1 with exceptions for infrequent visitors and as needed” - https://phabricator.wikimedia.org/T279034 (10AndyRussG) Hi @Jdlrobs... [20:03:05] (03Merged) 10jenkins-bot: Assume import is an individual when donor advised fund specified [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743056 (https://phabricator.wikimedia.org/T296861) (owner: 10Eileen) [20:04:31] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @mbeat33 - OK I... [20:05:15] ejegg: meeting [20:05:36] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10DStrine) 05Open→03Resolved [20:07:06] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) Oh - I see - th... [20:08:43] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices: In need of access to see the actual "email content" under mailing events tab in civi. - https://phabricator.wikimedia.org/T296039 (10DStrine) 05Open→03Resolved [20:09:21] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10MW-1.38-notes (1.38.0-wmf.12; 2021-12-06): Matching Gifts - Employer IDs showing in Field - https://phabricator.wikimedia.org/T292582 (10DStrine) 05Open→03Resolved [20:10:46] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): applepay donations TY email doesn’t have the donor's name - https://phabricator.wikimedia.org/T296881 (10DStrine) [20:11:25] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Amazon donor name shenanigans - https://phabricator.wikimedia.org/T297234 (10DStrine) [20:13:39] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10Patch-For-Review: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10DStrine) [20:15:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Automatically populate start date on relationships - https://phabricator.wikimedia.org/T294487 (10DStrine) [20:18:14] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10Eileenmcnaughton) a:03Eileenmcnaughton [20:38:08] (03PS2) 10Ejegg: Add mailcatcher defaults for dev site [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736625 (owner: 10Eileen) [20:38:15] (03CR) 10Ejegg: [C: 03+2] "Looks good for things coming out of Civi code! I wonder what more it would take to get the old TY mailer sending to mailcatcher too..." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736625 (owner: 10Eileen) [20:50:34] (03Merged) 10jenkins-bot: Add mailcatcher defaults for dev site [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736625 (owner: 10Eileen) [21:17:51] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline, and 3 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10MBeat33) Got it, thanks, @Eileenm... [21:25:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Wireless Zipline: Thank you fail mail - https://phabricator.wikimedia.org/T296813 (10DStrine) 05Open→03Resolved [21:27:19] 10Fundraising-Backlog, 10FR-LATAM: Adding PIX as a payment type for Brazil - https://phabricator.wikimedia.org/T280303 (10DStrine) [21:27:38] 10Fundraising-Backlog, 10FR-India, 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28): re-enable AMEX cards in India - https://phabricator.wikimedia.org/T258509 (10DStrine) [21:32:47] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Amazon donor name shenanigans - https://phabricator.wikimedia.org/T297234 (10DStrine) [21:32:51] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10DStrine) [21:32:57] 10Fundraising Sprint X 2021, 10Fundraising-Backlog: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10DStrine) [21:33:00] 10Fundraising Sprint X 2021, 10Fundraising-Backlog: Adyen forms for Euro Bundle - https://phabricator.wikimedia.org/T293292 (10DStrine) [21:33:02] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10FR-LATAM: Adding PIX as a payment type for Brazil - https://phabricator.wikimedia.org/T280303 (10DStrine) [21:33:05] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10FR-India, 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28): re-enable AMEX cards in India - https://phabricator.wikimedia.org/T258509 (10DStrine) [21:33:07] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10MediaWiki-extensions-DonationInterface: Payments-wiki should send payments-init message on failed PayPal EC - https://phabricator.wikimedia.org/T249276 (10DStrine) [21:33:11] 10Fundraising Sprint X 2021, 10Fundraising-Backlog: Paypal Orphan Slayer Missing PayerID - https://phabricator.wikimedia.org/T205566 (10DStrine) [21:33:15] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): Post-payment Monthly Convert *Yes* button text overflows container on some devices - https://phabricator.wikimedia.org/T297012 (10DStrine) [21:33:19] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): applepay donations TY email doesn’t have the donor's name - https://phabricator.wikimedia.org/T296881 (10DStrine) [21:33:23] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices: Civi is no longer displaying the recurring amount in the same format - correctly. - https://phabricator.wikimedia.org/T296663 (10DStrine) [21:33:27] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10DStrine) [21:33:31] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 6 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) [21:33:35] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10Patch-For-Review: Set up Civilint in composer scripts - https://phabricator.wikimedia.org/T296636 (10DStrine) [21:33:39] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 7 others: Enhance Pending Transaction Resolver to use all available fraud filter scores - https://phabricator.wikimedia.org/T296555 (10DStrine) [21:33:43] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Documentation: Create a place for text source for UML diagrams, and put existing diagrams there - https://phabricator.wikimedia.org/T296344 (10DStrine) [21:33:46] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10FR-Smashpig, 10Patch-For-Review: Adyen payments-init messages getting NULL final_status - https://phabricator.wikimedia.org/T296266 (10DStrine) [21:33:51] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices: Add a second layer of confirmation to the batch merge deduper button - https://phabricator.wikimedia.org/T296042 (10DStrine) [21:33:53] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10DStrine) [21:33:55] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10DStrine) [21:33:58] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising-tech-ops: Document Ingenico integration - https://phabricator.wikimedia.org/T291874 (10DStrine) [21:34:00] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Tech talk on EOY receipt email - https://phabricator.wikimedia.org/T291572 (10DStrine) [21:34:04] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 6 others: Update PaymentsInitQueueConsumer to leave FAILED/REJECTED pending rows for Ingenico - https://phabricator.wikimedia.org/T291228 (10DStrine) [21:34:10] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 6 others: Add existing donor matching to PendingTransaction::resolve - https://phabricator.wikimedia.org/T291226 (10DStrine) [21:34:17] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 7 others: Add PendingTransaction::resolve API call that replicates Ingenico orphan rectifier - https://phabricator.wikimedia.org/T291223 (10DStrine) [21:34:25] 10Fundraising Sprint X 2021, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Wireless Zipline, and 2 others: Recurring "Cancel" button reposition request - https://phabricator.wikimedia.org/T291133 (10DStrine) [21:34:38] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 9 others: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10DStrine) [21:34:44] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 9 others: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10DStrine) [21:34:50] 10Fundraising Sprint Vestigial tails shoot from the hip, 10Fundraising Sprint Window dressing is mostly olive oil, 10Fundraising Sprint X 2021, 10Fundraising-Backlog, and 4 others: Switch PE and UY to dlocal for processing - https://phabricator.wikimedia.org/T208963 (10DStrine) [21:35:19] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 32 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10DStrine) [21:54:50] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) [21:54:58] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) [21:55:42] 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10MW-1.38-notes (1.38.0-wmf.12; 2021-12-06): Matching Gifts - Employer IDs showing in Field - https://phabricator.wikimedia.org/T292582 (10Ejegg) [22:25:33] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/744860 (owner: 10Jgleeson) [22:28:40] 10Fundraising-Backlog, 10FR-Paypal: Delete PayPal pending messages more aggressively - https://phabricator.wikimedia.org/T297246 (10Ejegg) [22:29:15] 10Fundraising-Backlog: Investigate why orphan-slayer job is running for hours - https://phabricator.wikimedia.org/T239756 (10Ejegg) One more thing that might help: T297246 [22:33:57] (03PS1) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/744890 [22:38:15] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/744860 (owner: 10Jgleeson) [22:39:22] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Amazon donor name shenanigans - https://phabricator.wikimedia.org/T297234 (10Ejegg) Here's a [[ https://civicrm.wikimedia.org/civicrm/admin/search#/create/Contribution?params=%7B%22version%22:4,%22select... [22:44:52] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/744890 (owner: 10Jgleeson) [22:50:12] fr-tech, just a heads up that I'm about to push out https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/744860 [22:54:00] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/744890 (owner: 10Jgleeson) [22:55:41] if anyone is around and running a mac with apple pay I'd really appreciate some help with a test donation just confirm all is good? My macbook is upstairs and has and needs some profile updates to switch my apple wallet from the sandbox account to a real account/cc. [22:55:58] -and has [22:56:59] hey jgleeson I can [22:57:22] thanks cstone !!! [22:57:33] ok pushing it out now [22:59:15] hmm this seems to be taking a while 'Refreshing git metadata..........' [22:59:24] yeah sometimes that takes a while for me too [23:01:09] ok there it goes! [23:01:59] !log updated payments-wiki from 4a4ef51d to 2e164062 [23:02:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:02:27] I'm seeing successful apple pay donations still comin through [23:04:19] i was trying to break it let me do a nice one haha [23:05:09] ha [23:17:16] fr-tech I've dug into a few donations and it looks like Apple Pay donations are coming through as expected [23:17:30] oh bah sorry jgleeson my test donation looked good [23:17:35] dstrine: the Apple Pay name fix is deployed [23:17:46] also the patch AndyRussG worked on, button resizing [23:17:47] jgleeson: YAY! thanks! [23:17:52] thanks cstone ! [23:17:56] ah excellent! [23:18:09] and now bed [23:18:13] bye for now [23:18:17] yeah for realz [23:18:21] it's crazy late for you