[00:01:48] cstone: yeah - the middle one is just cleanup [00:02:04] I can rebase that one out if it's not a no-brainer [00:02:18] (03Merged) 10jenkins-bot: Set original currency details in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745336 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:12:29] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:15:40] sorry eileen im back [00:16:13] (03CR) 10Cstone: [C: 03+2] Test readability improvement [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745337 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:16:31] (03CR) 10Cstone: [C: 03+2] Fix field name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745340 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:17:29] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:26:55] (03Merged) 10jenkins-bot: Test readability improvement [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745337 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:27:29] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:27:56] (03Merged) 10jenkins-bot: Fix field name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745340 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:35:15] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745330 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:36:50] This might be an easy one too - can be rebased out of the chain https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/744855 [00:37:29] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:38:10] (03PS3) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) [00:48:39] (03PS5) 10Eileen: Fix error - use custom fields not core fields for original currency [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745330 (https://phabricator.wikimedia.org/T297159) [00:48:41] (03PS2) 10Eileen: Short-term fix around displaying localised formatting [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/742590 (https://phabricator.wikimedia.org/T290253) [00:49:38] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:50:56] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/745330/ is passing now - yay- I rebased it to be first in the chain incase anyone gets a chance [01:13:13] eileen: what are you using to just run those tests? [01:14:56] er like what part of the tests are you running [01:23:14] cstone: EOYEmailTest [01:23:21] in the extension [01:24:53] but the tests started failing when I started re-writing in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/744904 - because I made the test clow more like the real flow [01:25:54] & stopped using the stored db rollup - which then revealed the bug in the civicrm flow - which I guess you would hit in the UI when rendering the mail for a contact with more than 1 currency [01:26:30] i just self sabotaged by somehow dragging the civi folder int he phpstorm UI to somewhere else haha [01:27:02] oh god haha [01:27:43] (03PS5) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [01:27:45] (03PS4) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) [01:27:47] (03PS1) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [01:27:51] lol [01:28:11] or maybe i deleted it [01:30:51] i wish control z worked [01:31:01] aw jeez [01:31:31] just gona rebuild here thennn haha [01:32:53] lol [01:38:55] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:39:46] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:40:48] (03PS1) 10Eileen: Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) [01:41:41] ejegg: do you have any thoughts about this change https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/745348/1/drupal/sites/default/civicrm/extensions/wmf-thankyou/Civi/Api4/Action/EOYEmail/Render.php#132 [01:42:28] it seems wrong to me to email you as "Elliott" but perhaps I'm wrong in assuming it is an oversight? [01:46:46] looking eileen [01:47:19] (03CR) 10Eileen: [C: 03+2] "Just tested on staging & works fine now!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744114 (https://phabricator.wikimedia.org/T291133) (owner: 10Cstone) [01:47:30] thanks eileen ! [01:48:04] eileen: aah, so we were using the same informal name for the email recipient as for the text of the letter [01:48:15] sure, display_name seems good [01:48:25] I guess that's probably what Civi core uses? [01:48:47] (03Abandoned) 10Eileen: WIP Fix fake PayPal cancellations on the fly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/559605 (https://phabricator.wikimedia.org/T217379) (owner: 10XenoRyet) [01:50:06] (03Abandoned) 10Eileen: Fixed mysql db names in suppression list queries [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/640697 (owner: 10Jgleeson) [01:51:18] (03Abandoned) 10Eileen: Deprecation notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742583 (owner: 10Eileen) [01:51:54] ejegg: yeah - I'm assuming our thank yous do too - [01:52:12] (03CR) 10jerkins-bot: [V: 04-1] Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:54:43] (03PS2) 10Eileen: Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) [01:56:59] ah yep - they do - I found it.... [01:57:52] (03Merged) 10jenkins-bot: Sort recurring contributions tab links [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744114 (https://phabricator.wikimedia.org/T291133) (owner: 10Cstone) [02:06:05] (03CR) 10jerkins-bot: [V: 04-1] Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:07:45] (03PS3) 10Eileen: Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) [02:30:48] (03PS6) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [02:30:50] (03PS5) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) [02:30:52] (03PS2) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [02:42:27] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:42:29] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:52:31] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1],minFraud_endpoint_warning 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [02:57:31] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [03:18:35] (03PS3) 10Ejegg: PaymentsFraudDatabase: tests, update, and breakdown [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 [03:19:02] (03CR) 10jerkins-bot: [V: 04-1] PaymentsFraudDatabase: tests, update, and breakdown [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 (owner: 10Ejegg) [03:24:31] (03PS4) 10Ejegg: PaymentsFraudDatabase: tests, update, and breakdown [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 [03:33:43] (03PS1) 10Eileen: Add support and test for emailing single contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745358 (https://phabricator.wikimedia.org/T297159) [03:34:20] (03CR) 10Ejegg: "Thanks for the review, Damilare! PS4 should be able to handle updates to both the parent and child tables. I think the tests cover all the" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 (owner: 10Ejegg) [03:36:09] eileen: uh-oh, silverpop export failed [03:36:13] looking [03:37:08] "Duplicate entry '53922126' for key 'PRIMARY'" [03:37:53] so that's query 5 in update main staging table: Populate, or append to, the storage table all contacts that have an email [03:46:49] weird, that staging.id IS NULL ought to prevent that... [03:49:50] arrr, that select is getting two rows now, one with employer_id and employer_name and one without [03:50:04] I was afraid this employer stuff had something to do with it [03:51:13] let's see what relationships exist [03:54:09] argh, duplicate active relationships of the same type with the same contact IDs [03:54:18] so that's no fun... [03:54:26] let's see how many more of those there are [03:56:02] 13 rows like that [03:56:53] so... something wrong in that latest Save.php change? [03:58:12] I guess I can do a quick data cleanup to make the export run [03:58:21] but we'll have to fix that duplicate creation tomorrow [04:10:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10Ejegg) [04:10:50] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10Ejegg) p:05Triage→03Unbreak! [04:12:33] ok, deleted duplicates, re-running export [04:17:27] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1],minFraud_endpoint_warning 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [04:22:27] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [04:25:15] OK, it got past that query this time around [04:25:45] I'm going to call it a night [04:32:27] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [04:32:48] (03PS7) 10Eileen: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) [04:32:50] (03PS6) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) [04:32:52] (03PS3) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [04:37:27] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [04:40:50] (03PS7) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) [04:40:52] (03PS4) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [04:40:54] (03PS1) 10Eileen: Add limit to EoyEMail::send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745362 (https://phabricator.wikimedia.org/T297159) [04:42:27] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [04:44:14] (03PS5) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [04:44:41] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:52:41] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:53:59] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:55:11] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [07:24:44] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/745405 (owner: 10L10n-bot) [07:26:11] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/745405 (owner: 10L10n-bot) [08:52:31] (03PS11) 10Damilare Adedoyin: WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) [08:55:05] (03CR) 10jerkins-bot: [V: 04-1] WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [09:04:58] (03CR) 10Damilare Adedoyin: [V: 03+1 C: 03+1] "Thanks for the updates, tested and works great. Just a little syntax warning which I think can be overlooked depending on the version of P" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 (owner: 10Ejegg) [09:10:39] Hi jgleeson|away, just pushed the updated patchset (PS11) looks like there'd be need for another rebase. [09:12:11] I reviewed ejegg's patch, looks good to me just a syntax warning that keeps popping up which I mentioned on my comment. Please help with a co-review. [12:33:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7833 7500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 32 days 11 hours - memory use is 6.77M (peak 9.13M, 0.14% of max, fragmentation 1.75%), connected_slaves is 3, donations is 70, jobs is 0, jobs-adyen is 0, jobs-paypal is 120, payments-antifraud is 14, payments-init is 8, pending is 11, refund is 0, unsubscribe is 45 https://icinga.wik [12:33:17] g/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [12:38:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 8241 7500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 32 days 11 hours - memory use is 7.55M (peak 9.13M, 0.15% of max, fragmentation 1.62%), connected_slaves is 3, donations is 351, jobs is 0, jobs-adyen is 0, jobs-paypal is 83, payments-antifraud is 36, payments-init is 124, pending is 16, refund is 1, unsubscribe is 48 https://icinga.w [12:38:17] org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [12:43:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7595 7500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 32 days 11 hours - memory use is 6.72M (peak 9.13M, 0.14% of max, fragmentation 1.68%), connected_slaves is 3, donations is 244, jobs is 0, jobs-adyen is 39, jobs-paypal is 22, payments-antifraud is 18, payments-init is 9, pending is 12, refund is 0, unsubscribe is 54 https://icinga.wi [12:43:17] rg/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [12:48:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7610 7500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 32 days 11 hours - memory use is 6.71M (peak 9.13M, 0.14% of max, fragmentation 1.71%), connected_slaves is 3, donations is 49, jobs is 0, jobs-adyen is 0, jobs-paypal is 34, payments-antifraud is 27, payments-init is 112, pending is 15, refund is 0, unsubscribe is 62 https://icinga.wi [12:48:17] rg/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [12:53:23] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7621 7500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 32 days 11 hours - memory use is 6.90M (peak 9.13M, 0.14% of max, fragmentation 1.70%), connected_slaves is 3, donations is 265, jobs is 0, jobs-adyen is 1, jobs-paypal is 24, payments-antifraud is 21, payments-init is 7, pending is 14, refund is 0, unsubscribe is 66 https://icinga.wik [12:53:23] g/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [12:58:23] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7637 7500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 32 days 11 hours - memory use is 6.90M (peak 9.13M, 0.14% of max, fragmentation 1.71%), connected_slaves is 3, donations is 271, jobs is 0, jobs-adyen is 41, jobs-paypal is 24, payments-antifraud is 42, payments-init is 123, pending is 13, refund is 1, unsubscribe is 79 https://icinga. [12:58:23] .org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:23:23] RECOVERY - check_redis on frqueue1003 is OK: OK: REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 32 days 12 hours - memory use is 6.31M (peak 9.13M, 0.14% of max, fragmentation 1.76%), connected_slaves is 3, donations is 382, jobs is 0, jobs-adyen is 0, jobs-paypal is 40, payments-antifraud is 33, payments-init is 11, pending is 16, recurring is 6284, refund is 0, unsubscribe is 34 https://icinga.wikimedia.org/cgi-b [13:23:23] /extinfo.cgi?type=2&host=frqueue1003&service=check_redis [15:44:55] (03PS5) 10Ejegg: PaymentsFraudDatabase: tests, update, and breakdown [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 [15:46:09] (03CR) 10Ejegg: "Thanks again for the CR, Damilare. I fixed that implode signature in PS5" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 (owner: 10Ejegg) [15:46:26] oh, I need to rebase that user_ip patch manually [15:50:46] oh interesting, what's the difference between inet_pton and ip2long ? [15:51:58] ohhh, we want ip2long here [15:53:09] (03PS2) 10Ejegg: PaymentsFraud: encode/decode user_ip [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741749 [16:02:34] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks Elliot, looks good to me." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 (owner: 10Ejegg) [16:03:14] (03Merged) 10jenkins-bot: PaymentsFraudDatabase: tests, update, and breakdown [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741740 (owner: 10Ejegg) [16:17:06] 10Fundraising-Backlog: Apple Pay first_name can be longer than 64 characters - https://phabricator.wikimedia.org/T295821 (10Cstone) Another one happened today, 113 characters long [16:17:50] sorry for not getting to the coreview damilare. I've been distracted today with car/other stuff [16:17:56] looks good to +2 tho! [16:18:51] np jgleeson! [16:20:04] Thanks, had to +2 after carefully looking through to ensure its in line with our last conversation [16:25:15] 10Fundraising-Backlog: Apple Pay first_name can be longer than 64 characters - https://phabricator.wikimedia.org/T295821 (10Ejegg) Should we use the length as another criteria to decide when to switch to the shipping contact name? [16:32:09] hmm, contact merge link in changelog is giving an error screen [16:43:18] (03PS12) 10Damilare Adedoyin: WIP: testAntiFraudQueueMessageCreatedAfterHostedStatusCall [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) [16:47:28] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1],minFraud_endpoint_warning 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:52:28] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:54:11] hi ejegg: is this patch `PaymentsFraud: encode/decode user_ip` ready for review or do you want to rebase first? [16:57:28] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:03:14] i think it's ready damilare [17:27:30] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:32:30] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:47:51] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 17 others: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdlrobson) [19:17:48] 10Fundraising-Backlog, 10FR-Tech-Analytics: Email Send with Low Clicks - https://phabricator.wikimedia.org/T293926 (10JMando) Hey there, I do not believe this has been resolved, but tagging @EYener to confirm? [19:19:35] if anyone has any time to review this is the most important ... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/745330 [19:46:29] eileen: where can you see that example? [19:47:14] cstone: the example data is what is used to populate the preview screen (ie where all the translations etc are) [19:47:51] ooooh mine was just being super slow at loading [20:07:24] 10Fundraising Sprint Vagranty McVagrantface, 10Fundraising Sprint We all meet again, 10Fundraising-Backlog, 10SRE, and 6 others: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (10ABorbaWMF) Appears to be fixed on 6.8.2 (1868) [20:59:59] (03PS2) 10Ejegg: Remove PHP entry point [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/744775 (https://phabricator.wikimedia.org/T140850) (owner: 10Umherirrender) [21:00:03] (03CR) 10Ejegg: [C: 03+2] Remove PHP entry point [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/744775 (https://phabricator.wikimedia.org/T140850) (owner: 10Umherirrender) [21:03:00] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Jgreen) a:05Eileenmcnaughton→03Jgreen... [21:14:16] omg - just read the emal - we have a new director [21:14:19] (03Merged) 10jenkins-bot: Remove PHP entry point [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/744775 (https://phabricator.wikimedia.org/T140850) (owner: 10Umherirrender) [21:18:47] eileen: :) :) :) [21:20:39] yeah - I wasn't expecting that - I was just reading the email like 'la la la la' & might not have even gotten to that part [21:20:48] & then right at the end it [21:21:04] is like 'holy shit - this is actually relevant to our team; [21:47:08] eileen: in my local testing on the first patch in this chain: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/745348 [21:47:20] I'm not seeing the $name bit of the context being set [21:47:26] it's coming out blank [21:47:54] hmm, I guess I should try on the currently merged stuff [21:48:07] where is that used? [21:48:09] to check if it's just my local setup [21:48:21] eileen: the body of the email starts Dear {$name} [21:48:43] yeah - that's not what the templates in use should have [21:49:11] ah, ok [21:49:26] oh dang - the english one DOES [21:49:40] yep, i'm using english [21:49:51] the others are like {if '{contact.first_name}' && '{contact.last_name}'} [21:49:58] ok [21:50:01] the english one probably should be too [21:50:09] k, i [21:50:14] 'll try editing locally [21:50:41] for the eoy stuff is there a patch i completely missed that enables the module for dev or is it something you do locally? [21:51:28] eg I just fixed on lived - I'll message on the phab about it [21:53:23] (03PS1) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [21:53:32] ejegg: ^^ [21:56:02] (03PS2) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [21:57:58] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @MBeat33 @... [22:02:03] thanks eileen [22:03:18] So to get that new text locally I could delete and resync the managed entities, I think [22:03:35] ehh, easier to just copy paste [22:05:43] (03CR) 10Ejegg: "Thanks! 1 question about empty else clause" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:06:59] (03CR) 10Eileen: Only use name if usable (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:07:31] ejegg: yeah - it won't autoupdate on live - it's mostly about tracking / keeping dev sites somewhat in sync now [22:07:34] (03CR) 10jerkins-bot: [V: 04-1] Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:08:32] ug it failed on formatting [22:13:35] eileen: darn, even with the contact.XXX tokens I'm not seeing it show a name [22:13:54] & your contact has a first & last name? [22:14:30] yep, all of the contacts that share the email address do. When I get down to the WorkflowMessage/Render _run function, i see $this->_model has the contactId set but the contact property is null [22:14:48] (03PS3) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [22:15:19] I figured there was some magic trait to populate the contact property given contactId but I'm not finding it [22:15:20] hmm - how are you rendering? [22:15:31] using the action from the contact summary screen [22:15:47] though I also tried from the API4 explorer with contact ID and year set [22:15:56] yeah the tokens should be rendered through token processor [22:16:24] interestingly it's working in the tests - [22:16:48] k, lemme try stepping into the token processor [22:16:51] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Jgreen) A third change made: 3. Rate-li... [22:17:25] right, I see 'if omitted, will load automatically from contactId' [22:17:26] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Jgreen) 05Open→03Resolved [22:17:28] it's actually rendering on live [22:17:29] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10Jgreen) [22:17:45] ie https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=26220292 - that is a smarty lang [22:19:35] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Eileenmcnaughton) @Jgreen do we have an... [22:20:03] ejegg: also - I haven't fully caught up with Jeff_Green's work ^^ but it's there [22:20:43] the frdev1001 mailserver hack? I was just writing updating tasks [22:22:25] cool - I haven't quite gotten my head around what you've done [22:22:57] ejegg: there are 2 places to update? [22:23:10] there is a non-translated & a en_us translation [22:23:22] I made postfix rewrite the recipient address for everything other than local addresses and a handful of wikimedia.org addresses to a local account "catchmail" [22:24:10] right now it's just going to dump mail in a mailbox under that account, I'm not sure what we want to do with that mail, there are lots of options [22:24:33] oh also I put a rate-limit on mail leaving frdev1001 to 4 messages per second because I have The Fear. [22:24:40] per minute I mean [22:24:53] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10MBeat33) Thank you @Eileenmc... [22:25:34] Jeff_Green: so can we whitelist that emails to @wikimedia & maybe a few or our personal emails can go out [22:25:42] yes exactly [22:26:10] the fr-tech folks @wikimedia.org addresses are already on the allow-out list [22:26:11] (03CR) 10jerkins-bot: [V: 04-1] Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:28:05] (03PS4) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [22:28:33] Jeff_Green: ah that's great - & there is a file where we can add extra emails to? [22:28:51] it's puppetized [22:29:19] so we need to go through you to add? [22:29:25] ya [22:29:36] it might be easier for you if it reads from a file we can edit [22:30:38] I'm hoping this isn't something that changes frequently, there's tremendous potential to break mail routing and suddenly we're mailing the world [22:31:22] :-) [22:31:43] otoh we could fairly easily provide access via pine/mutt to the catchmail mailbox [22:32:00] I guess it's more like if people want to see email on different clients - you could easily wind up with 2 personal emails per fr-tech person [22:32:09] + some non fr-tech [22:32:25] ok, I'll have to ponder that [22:33:12] what is the anticipated use in general? [22:34:14] i.e. from the task context I figured you need a way to test high-volume mail, i.e. to evaluate query performance [22:38:41] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10SHust) @MBeat33 and @Eileenm... [22:39:21] (03CR) 10Ejegg: "Looks good, just one issue with how the contact ID is picked" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:40:01] (03CR) 10jerkins-bot: [V: 04-1] Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [22:40:10] eileen ^^^ needs a small fix but i'm aware it's at the bottom of a pretty tall stack. [22:40:27] want me to +2 in anticipation of a fix? [22:41:18] ejegg: I'm not sure I agree with you - the current sort will priortise most recent donor - which I think makes more sense [22:41:48] eileen: I'm seeing it pick the name from the donor with the LEAST recent contribution [22:42:09] since it's setting this->contactId to $this->contactDetails['ids'][0] [22:42:43] err, not so much $this [22:42:50] 'contactId' => $contactDetails['ids'][0], [22:42:55] for the template_params [22:43:06] ejegg: ah I get it now - so it should be the last on the list - ok - yeah - if you merge I'll follow up [22:43:12] and with the sort being [22:43:13] ->addOrderBy('contact.wmf_donor.all_funds_last_donation_date') [22:43:21] cool cool, will +2 [22:44:15] ahh i see, the sort is also used to make later language and display_name supercede earlier ones [22:44:54] (03PS4) 10Ejegg: Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:45:26] (03PS1) 10Eileen: Use most recent donor for tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745616 [22:45:34] (03CR) 10Ejegg: [C: 03+2] "All looks good besides the selection of contact_id for the template_params. Per IRC that'll be fixed in a follow-on patch." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:45:37] ejegg: does ^^ work - I haven't used 'end' before [22:45:57] oh weird [22:46:03] i can try [22:46:25] seems like it might need a different syntax though [22:46:34] i.e. leave off the [0] inside the parens [22:47:04] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) @MBeat33... [22:47:14] yeah, looks like it would work without the [0] [22:47:46] (03PS2) 10Eileen: Use most recent donor for tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745616 [22:47:51] good point! [22:52:19] cool cool, gives the expected name [22:52:36] (03PS3) 10Ejegg: Use most recent donor for tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745616 (owner: 10Eileen) [22:52:44] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745616 (owner: 10Eileen) [22:53:05] updating that instructional text to say 'donor with the most recent contribtion' might be nice sometime too [22:53:14] or 'contact with the most...' [22:54:07] ejegg: do you want to push that up? I'm thinking you are looking at the code where it applies & I don't think that would conflict [22:54:11] sure [22:55:03] (03PS2) 10Ejegg: Add support and test for emailing single contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745358 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:55:28] (03CR) 10Ejegg: [C: 03+2] "Looks good! Nibbling away another piece of the old code." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745358 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:57:23] (03Merged) 10jenkins-bot: Code cleanup - load preferred language from the contact record [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745348 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:02:11] ugh, my spanish template got replace with english when I tried to save it out of draft status [23:03:01] eileen: have you ever seen that? ^^^ [23:03:19] ejegg: yeah I have :-( [23:03:28] I just clicked on a non-english draft, saw the text was really non-english, clicked 'save and done' and then tried to render [23:03:51] activate seems to be fix but there IS a bug that I need to get replication steps for & log upstream as step 1 [23:03:52] any ideas why? [23:04:06] ok, I can try to replicate with one of the many other drafts [23:04:16] (03Merged) 10jenkins-bot: Use most recent donor for tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745616 (owner: 10Eileen) [23:04:36] cool - I have so shoot out now - I think that when you activiate it still enabled the right thing [23:06:30] (03Merged) 10jenkins-bot: Add support and test for emailing single contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745358 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:13:49] (03PS1) 10Ejegg: Fix EOY action indicating which donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745617 [23:16:13] (03PS2) 10Ejegg: Fix EOY action text explaining contact ID choice [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745617 [23:22:09] (03PS8) 10Ejegg: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:23:00] (03CR) 10Ejegg: [C: 03+2] "¡Viva Noruega!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:24:09] (03PS2) 10Ejegg: Remove reference to legacy property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744855 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:24:16] (03CR) 10Ejegg: [C: 03+2] Remove reference to legacy property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744855 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:24:43] (03PS2) 10Ejegg: Add limit to EoyEMail::send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745362 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:24:48] (03CR) 10Ejegg: [C: 03+2] Add limit to EoyEMail::send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745362 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:35:24] (03Merged) 10jenkins-bot: End of year email render fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744110 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:35:29] (03Merged) 10jenkins-bot: Remove reference to legacy property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744855 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:35:31] (03Merged) 10jenkins-bot: Add limit to EoyEMail::send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745362 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:45:59] (03CR) 10Ejegg: [C: 03+2] "This fixes the problem, but I guess now we can't upstream this. I think you said a future core patch will let us define workflow messages " [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745330 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:55:28] (03CR) 10Ejegg: [C: 03+2] "This works! It uncovers an issue with us using es_MX for all Latin American Spanish though - in Mexico they use '.' for the decimal separa" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/742590 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen)