[00:01:05] (03Merged) 10jenkins-bot: Fix error - use custom fields not core fields for original currency [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745330 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:03:01] whew, cleared out eileen's review backlog! [00:03:21] now to try to fix the issues in my own code... [00:07:36] (03Merged) 10jenkins-bot: Short-term fix around displaying localised formatting [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/742590 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [00:17:11] (03PS2) 10Ejegg: Reduce length limit for Ingenico city field [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/744851 (https://phabricator.wikimedia.org/T234495) (owner: 10AndyRussG) [00:17:17] (03CR) 10Ejegg: [C: 03+2] Reduce length limit for Ingenico city field [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/744851 (https://phabricator.wikimedia.org/T234495) (owner: 10AndyRussG) [00:17:55] (03Merged) 10jenkins-bot: Reduce length limit for Ingenico city field [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/744851 (https://phabricator.wikimedia.org/T234495) (owner: 10AndyRussG) [00:18:05] (03PS3) 10Ejegg: PaymentsFraud: encode/decode user_ip [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741749 [00:34:08] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10Ejegg) Confirmed that all of the contacts (besides the first, which is a staff mem... [01:05:31] (03PS8) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) [01:05:42] (03PS6) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [01:07:44] (03PS1) 10Eileen: submodule commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745636 [01:07:53] (03CR) 10Eileen: [C: 03+2] submodule commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745636 (owner: 10Eileen) [01:17:56] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:18:25] (03Merged) 10jenkins-bot: submodule commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745636 (owner: 10Eileen) [01:40:24] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/745640 [01:41:54] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/745640 (owner: 10Eileen) [01:43:09] cstone: I think I'm gonna push your patch out now - the merge ^^ has that + eoy stuff & seems pretty safe IMHO [01:54:49] !log civicrm revision c47cf762 -> a88cd178 [01:54:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:00:22] eileen: I have a guess as to what's causing those duplicated relationships [02:00:38] I saw you pegged deduping [02:00:59] The merge is probably setting the employer_id on the target contact before updating the old relationship [02:01:36] so it's creating a new relationship with no custom field set [02:01:47] then moving over the existing one with the custom field [02:02:17] i think you mentioned that custom field would make them appear as different relationships to Civi core [02:02:31] trying to decide what the fix would be [02:02:41] move the relationships before saving the contact? [02:02:45] yeah - it worked today? [02:02:57] they didn't run any more employer field tests today [02:03:22] so we didn't get any more employee of relationships with custom fields [02:03:58] hmm - I think core is being too aggressive from the seems - it might be a hack-out & then look at a better fix upstream scenario [02:04:20] k [02:04:57] ejegg: I just rolled out the patches to date - I might squash the last 2 together since they seem to pass in combo [02:05:51] ok, cool [02:06:20] (03PS7) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [02:06:27] (03Abandoned) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/744904 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:06:54] With those merged I think the focus will switch to testing on staging [02:07:11] & documenting / figuring out if the jobs are right [02:11:26] (03PS8) 10Eileen: Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [02:16:37]  [02:22:08] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_donor_receipt [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:23:31] Thanks eileen ! [02:24:02] I'm just trying to paranoid over whether contributions are stil coming in - how often does superset update? [02:24:19] eileen the payments-initial log is a good way to clear that up [02:24:39] ohh you mean to the donation queue and into civi? [02:24:49] ejegg: yeah - I can see some new ones now [02:24:51] well, we can tail the dq consumer logs [02:24:54] ah good [02:24:59] nothing I deployed should have affected the dq [02:25:09] but was looking for some re-assurance [02:25:18] & refreshing superset wasnt it [02:25:41] dang, trying to test locally I get an unrelated error merging: UPDATE civicrm_value_partner_21 SET entity_id = 6008 WHERE entity_id = 10108 [nativecode=1062 ** Duplicate entry '6008' for key 'unique_entity_id'] [02:25:42] I found that search kit was a good way to see the most recent contributions & check their date [02:25:57] ug [02:26:26] Because one row would need to be deleted & the other moved [02:26:58] for that partner field? [02:27:52] I didn't even try to set anything under Partner for the two test contacts I'm using [02:27:57] let's see what the db says [02:29:31] oh yeah, both of them have a row in civicrm_value_partner_21, but the partner_365 value is blank [02:29:49] ah, but this is my old db, let's see what happens under docker [02:30:01] maybe I have 'Partner' set up funny [02:35:55] (03PS1) 10Eileen: Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) [02:36:33] ejegg: I just put up a patch to *just* add the year column - since I managed to get tests failing again I thought it might be easier to lock that in [02:36:42] ok [02:40:05] (03PS2) 10Eileen: Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) [02:51:02] (03CR) 10jerkins-bot: [V: 04-1] Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:51:44] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) Looking at today's logs, every transaction where we got a status 'PENDING_APPROVAL' was successfully pushed through, so th... [03:09:58] (03PS3) 10Eileen: Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) [03:11:30] (03PS1) 10Eileen: Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745666 (https://phabricator.wikimedia.org/T297159) [03:20:21] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) This may not be a problem with the orphan rectifier - I'm looking at the logs for 112047072, and they DID get back to the... [03:38:35] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) OK, 103 of those can be explained by this unexpected 300240 error code. I'll turn on outbound API call logging to make su... [03:47:41] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10Ejegg) Replicated locally: just create 2 contacts with matching name + email, give... [03:53:59] (03PS1) 10Ejegg: Log-outbound without log-level debug [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/745668 [04:11:03] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) Looking at the incidence of the 300240 error message in the payments logs, it seems to have been concentrated on Dec 7th (... [04:16:04] 10Fundraising-Backlog, 10FR-Ingenico, 10MediaWiki-extensions-DonationInterface: Improve Ingenico error checking on payment capture - https://phabricator.wikimedia.org/T297452 (10Ejegg) [04:19:33] 10Fundraising-Backlog, 10FR-Ingenico, 10MediaWiki-extensions-DonationInterface: Use normalized SmashPig response properties for Ingenico on payments - https://phabricator.wikimedia.org/T297453 (10Ejegg) [04:51:07] (03CR) 10Eileen: [C: 03+2] Fix EOY action text explaining contact ID choice [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745617 (owner: 10Ejegg) [05:05:28] (03PS1) 10Ejegg: Deduper: don't duplicate Employee relationships [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745669 (https://phabricator.wikimedia.org/T297336) [05:05:35] eileen: I've replicated the duplicate relationship bug locally and am trying to fix it, but my Relationship::get call keeps coming back empty, even though the SQL query i see it making in the general log has 1 row [05:06:08] anyway, I'm going to call it a night. They say they're not going to do any more employer ID tests over the weekend [05:06:40] thanks for +2ing that wording change! [05:07:59] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, 10Patch-For-Review: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10Ejegg) Status: we've tracked this down to a bug in Civi core... [05:10:05] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10Ejegg) @EMartin are you seeing similarly elevated levels of stranded transactions from the 8th and 9th? Also, do you want to prov... [06:11:17] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Wireless Zipline, 10fr-donorservices: Recurring "Cancel" button reposition request - https://phabricator.wikimedia.org/T291133 (10Cstone) This has been deployed, the cancel button is n... [13:23:13] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10TomaszGorski) @Eileenmcnaugh... [14:00:08] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Jgreen) >>! In T297304#7561535, @Eileenm... [14:03:14] (03CR) 10Jgleeson: [C: 03+2] "We reviewed and it works as expected. Nice work!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741749 (owner: 10Ejegg) [14:07:45] (03Merged) 10jenkins-bot: PaymentsFraud: encode/decode user_ip [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/741749 (owner: 10Ejegg) [14:33:54] (03CR) 10Jgleeson: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [14:34:33] (03PS5) 10Jgleeson: WIP: update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) [14:37:43] (03CR) 10jerkins-bot: [V: 04-1] WIP: update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [14:48:43] (03PS6) 10Jgleeson: Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) [14:50:40] (03CR) 10jerkins-bot: [V: 04-1] Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [16:02:59] howdy damilare. how did that patch do on the new version of smashpig? [16:05:40] hi jgleeson: I had an issue with my payment setup that messed with my tests [16:05:57] Just fixed that by running setup again [16:06:24] About to run the last tests, should +2 in a few mins [16:13:07] awesome damilare! [16:15:54] fr-tech I won't be around for standup I've gotta to to the garage to sort out my car. It's needs more work and the price for the work needed is £300 even after me spending £300 last week on some other work so I need to figure out what to do that. The cars pretty old and becoming a money pit so it might have to go. be back later! [16:16:02] I've emailed around my update [16:16:31] jgleeson|away: good luck! [16:17:17] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10EMartin) @Ejegg The problem seems to have resolved as of the 9th. Perhaps the issue was that I expected it to be resolved as of... [18:49:36] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10EMartin) Things seem to be rectified as of the 9th. We have returned to normal levels now! Thanks for the focus on this. Evely... [20:26:51] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10DStrine) Hey all, specifical... [20:29:06] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10EMartin) ZA ID: I am posting this in this task regarding the requirement for National ID. Change.org had some people on the ground in South Africa and as you wi...