[02:37:19] 10Fundraising-Backlog: Amazon intermittent timeouts 2021-12-10 - https://phabricator.wikimedia.org/T297552 (10Ejegg) We need to update the firewall to allow outbound access from frpig1001 to all the IPs that sns.us-east-1 can resolve to. We have a tool to calculate that (which could maybe be renamed): https://ph... [03:07:49] (03PS1) 10Ejegg: Rename 'whitelist', add comment [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/745998 [03:07:52] (03CR) 10Ejegg: [C: 03+2] Rename 'whitelist', add comment [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/745998 (owner: 10Ejegg) [03:10:05] (03Merged) 10jenkins-bot: Rename 'whitelist', add comment [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/745998 (owner: 10Ejegg) [03:34:19] 10Fundraising-Backlog: Amazon intermittent timeouts 2021-12-10 - https://phabricator.wikimedia.org/T297552 (10Jgreen) I added sns.us-east-1.amazonaws.com to ipset, please let me know if this doesn't fix the timeouts. [03:50:28] 10Fundraising-Backlog: Amazon intermittent timeouts 2021-12-10 - https://phabricator.wikimedia.org/T297552 (10Ejegg) They still seem to be coming in. I'd like to at least turn off failmail for Amazon, but I'm not sure of the best way to do that. If I set the log-level down to 0 we won't get mail, but stuff won'... [03:56:01] (03PS1) 10Ejegg: Add no-op log stream [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/745999 (https://phabricator.wikimedia.org/T297552) [04:02:13] (03CR) 10Ejegg: [C: 03+2] Add no-op log stream [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/745999 (https://phabricator.wikimedia.org/T297552) (owner: 10Ejegg) [04:02:48] (03Merged) 10jenkins-bot: Add no-op log stream [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/745999 (https://phabricator.wikimedia.org/T297552) (owner: 10Ejegg) [04:04:01] (03PS1) 10Ejegg: Add no-op log stream [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/746000 (https://phabricator.wikimedia.org/T297552) [04:04:10] (03CR) 10Ejegg: [C: 03+2] Add no-op log stream [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/746000 (https://phabricator.wikimedia.org/T297552) (owner: 10Ejegg) [04:04:55] (03Merged) 10jenkins-bot: Add no-op log stream [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/746000 (https://phabricator.wikimedia.org/T297552) (owner: 10Ejegg) [04:13:13] (03PS1) 10Ejegg: Add constructor to NullLogStream [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/746001 [04:13:17] (03CR) 10Ejegg: [C: 03+2] Add constructor to NullLogStream [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/746001 (owner: 10Ejegg) [04:13:41] (03PS1) 10Ejegg: Add constructor to NullLogStream [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/746002 [04:13:43] (03CR) 10Ejegg: [C: 03+2] Add constructor to NullLogStream [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/746002 (owner: 10Ejegg) [04:13:59] (03Merged) 10jenkins-bot: Add constructor to NullLogStream [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/746001 (owner: 10Ejegg) [04:14:24] (03Merged) 10jenkins-bot: Add constructor to NullLogStream [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/746002 (owner: 10Ejegg) [04:17:43] !log updated SmashPig standalone (IPN listener) from 211f8e65 to 9e885819 [04:17:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:30:22] (03PS1) 10Ejegg: Update Amazon firewall error message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/746004 [14:55:57] 10Fundraising-Backlog: Amazon intermittent timeouts 2021-12-10 - https://phabricator.wikimedia.org/T297552 (10Jgreen) >>! In T297552#7564876, @Ejegg wrote: > They still seem to be coming in. Now I see why, two issues with ipset: one is that I had forgotten to actually add the policy to use the set, second is th... [20:05:36] (03PS5) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [20:17:15] (03CR) 10jerkins-bot: [V: 04-1] Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [20:18:23] (03PS6) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [20:54:25] (03PS7) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [21:04:25] (03PS1) 10Eileen: Update tests to test sent mail, not db table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746013 (https://phabricator.wikimedia.org/T297159) [21:15:32] (03Abandoned) 10Eileen: Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745666 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [21:38:13] (03PS9) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [21:41:06] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [21:45:30] (03PS10) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [21:47:33] (03PS11) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [21:50:10] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [21:52:57] hey eileen...! I'm working today, so pls don't hesitate to ping if u need some review eh :) [21:53:29] thanks AndyRussG - there are some patches that coule do with review - but I'm still working on the one that ties them all together [21:54:10] it might be nice to get this out though as it adds the new field - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/745645/3 - although I wound up breaking the db changes into 2 to make the co-ordination easier [21:55:44] eileen: cool! oki so the one you linked I can look at to start? [21:55:54] AndyRussG: yep - [21:56:02] cool! thx :) [21:56:08] the goal is to remove job_id & use year instead [21:57:25] (03PS1) 10Eileen: Do not create a job when there is contact id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746015 (https://phabricator.wikimedia.org/T297159) [21:59:01] we'd still calculate the emails to send to at the start (MakeJob) & work through them - because that part seems to help performance-wise [22:03:22] hmmm [22:03:27] oki [22:09:30] eileen: I haven't done much Civi stuff in a while, so I'm gonna update crm, civicrm submodule, buildkit repos, update dependencies and rebuild before doing anything else... unless you'd advise otherwise of course :) [22:09:48] no that makes total sense! [22:19:07] oki thx :) [22:39:32] (03PS12) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [22:42:20] (03CR) 10jerkins-bot: [V: 04-1] Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:43:39] (03PS13) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [22:58:30] they are finally passing! [22:58:41] yay! [22:58:54] eileen: I have an untracked file in the wmff/cicirm, called bin/setup.conf [22:59:07] AndyRussG: yeah - you can delete that [22:59:13] ah oki cool thx! [22:59:24] it doesn't ship with civi but does get created with a civibuild [23:00:49] eileen: hmm should we make something remove it when rebuilding? [23:02:17] AndyRussG: I guess that would be cleaner. As long as there is not much work in it since it's also not much work to deal with the file (but obviously it's a little un-obvious that it is not needed) [23:04:36] (03PS1) 10Eileen: Finally fully remove the drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) [23:14:09] Ah oki... cool, I can make a quick patch for fundraising-dev... should be trivial [23:24:27] (03PS1) 10Eileen: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159)