[00:12:37] (03PS2) 10Eileen: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) [00:58:08] (03PS1) 10Eileen: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) [01:01:19] (03PS14) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [01:01:50] (03PS2) 10Eileen: Finally fully remove the drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) [01:01:52] (03PS3) 10Eileen: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) [01:01:54] (03PS2) 10Eileen: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) [01:02:59] (03CR) 10AndyRussG: Add year column to wmf_eoy_receipt_donor (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:04:40] (03CR) 10Eileen: Add year column to wmf_eoy_receipt_donor (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:08:35] eileen: should I try to smoke test somehow? [01:08:43] (03CR) 10AndyRussG: Add year column to wmf_eoy_receipt_donor (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:09:25] (03CR) 10jerkins-bot: [V: 04-1] Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:12:20] looking at this now: https://wikitech.wikimedia.org/wiki/Fundraising/Internal_Endpoints/End_of_year_emails [01:13:23] Pretty sure we've talked this over in the not-so-distant past [01:14:47] (03CR) 10jerkins-bot: [V: 04-1] Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:18:56] AndyRussG: yeah I've started updating it to reflect where we will wind up [01:19:06] cool! [01:19:18] so I should try "drush @wmff cvapi EOYEmail.MakeJob version=4 year=2021" [01:19:23] and then the other command there? [01:19:28] yep - I just tried that one on staging [01:19:50] of course you need to have 2021 recurring contributions in your db.... [01:20:06] but if you do then it will populate wmf_donor_receipt_email [01:23:21] (03PS3) 10Eileen: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) [01:30:14] eileen: if you've tested it on staging I'm happy to +2, unless you feel more in-depth review is preferred [01:30:46] AndyRussG: I think it's gonna get more testing all the way up the chain so that first one is pretty safe [01:31:13] The last stage is going to be to try some more serious tests on staging - Jeff has set it up so we can email without emailing [01:32:12] ah cool! oki :) [01:32:58] (03CR) 10AndyRussG: [C: 03+2] "yaaay year ;)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:43:26] eileen: I can look at more if u like (though also am supposed to continue with the 600/800 stuff) [01:43:43] (03Merged) 10jenkins-bot: Add year column to wmf_eoy_receipt_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745645 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [01:43:59] AndyRussG: no pressure - if you don't someone else will look tomorrow [01:44:24] eileen: is there anything that it would be especially useful for you to have reviewed sooner rather than later, though? [01:44:52] the one you did :-) [01:45:05] :) [01:45:09] oki... [01:45:40] pls lmk if any others end up in the same category then :) [01:59:30] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 5 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Eileenmcnaughton) @Jgreen I tried to vie... [02:08:20] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 5 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Eileenmcnaughton) @Jgreen also my email... [03:06:59] (03PS1) 10Eileen: Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) [04:34:55] (03PS1) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [04:47:34] (03CR) 10jerkins-bot: [V: 04-1] Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) (owner: 10Eileen) [04:50:49] (03PS2) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [04:53:45] (03PS3) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [05:05:14] (03CR) 10jerkins-bot: [V: 04-1] Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) (owner: 10Eileen) [05:08:01] (03PS4) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [05:44:37] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 7 others: Add PendingTransaction::resolve API call that replicates Ingenico orphan rectifier - https://phabricator.wikimedia.org/T291223 (10AndyRuss... [05:56:44] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 3 others: Norwegian Bokmaal rendering in English - https://phabricator.wikimedia.org/T297577 (10Eileenmcnaughton) [05:57:59] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) Note I've... [05:58:18] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10Eileenmcnaughton) Note I've done some documenting at ht... [06:01:45] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (REL1_35) - 10https://gerrit.wikimedia.org/r/746106 (owner: 10L10n-bot) [06:05:13] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/746177 (owner: 10L10n-bot) [06:30:28] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10AndyRussG) Thanks so much for your work on this, @jgleeson and @Damilare! Great stuff! :) This really helped me figure... [08:01:27] (03PS1) 10Damilare Adedoyin: Update cancelPayment test to reflect response handling change for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746792 [08:06:53] (03CR) 10jerkins-bot: [V: 04-1] Update cancelPayment test to reflect response handling change for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746792 (owner: 10Damilare Adedoyin) [08:34:36] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 3 others: Norwegian Bokmaal rendering in English - https://phabricator.wikimedia.org/T297577 (10TomaszGorski) Hello @Eileenmcnaughton, thank you so much for f... [08:42:46] (03PS2) 10Damilare Adedoyin: Update cancelPayment test to reflect response handling change for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746792 [08:45:33] (03CR) 10jerkins-bot: [V: 04-1] Update cancelPayment test to reflect response handling change for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746792 (owner: 10Damilare Adedoyin) [08:45:36] (03PS3) 10Damilare Adedoyin: Update cancelPayment test to reflect response handling change for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746792 [08:55:46] (03PS1) 10Thiemo Kreuz (WMDE): Fix a series of easy to fix PHPCS violations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746796 [09:04:11] (03PS1) 10Thiemo Kreuz (WMDE): Remove dead code from TestingGenericAdapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746797 [13:08:09] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 5 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Jgreen) >>! In T297304#7565294, @Eileenm... [13:21:42] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 5 others: set up catch-all mail handling on fundraising staging server - https://phabricator.wikimedia.org/T297304 (10Jgreen) >>! In T297304#7565290, @Eileenm... [13:40:41] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/746177 (owner: 10L10n-bot) [13:50:13] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/CentralNotice] (REL1_35) - 10https://gerrit.wikimedia.org/r/746106 (owner: 10L10n-bot) [18:06:04] 10Fundraising-Backlog, 10fr-donorservices: Dot instead of comma in Thank you email confirmation French-France, Italian-Italy and Spanish-Spain - https://phabricator.wikimedia.org/T293275 (10DStrine) [18:06:30] 10Fundraising-Backlog, 10fr-donorservices: Dot instead of comma in Thank you email confirmation French-France, Italian-Italy and Spanish-Spain - https://phabricator.wikimedia.org/T293275 (10DStrine) This did not have our tag on it so we would never have seen it. I'll talk to the team about it today. [18:21:51] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10KHaggard) > @Ppena wanted me... [19:06:08] (03PS7) 10Jgleeson: Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) [19:19:17] (03CR) 10Jgleeson: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [19:21:24] (03Abandoned) 10Jgleeson: Update cancelPayment test to reflect response handling change for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746792 (owner: 10Damilare Adedoyin) [19:30:28] (03CR) 10AndyRussG: [C: 03+2] "Nice!! Thanks!!!! :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) (owner: 10Jgleeson) [19:43:11] (03Merged) 10jenkins-bot: Add composer scripts for civilint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/742494 (https://phabricator.wikimedia.org/T296636) (owner: 10Jgleeson) [20:18:23] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 3 others: Norwegian Bokmaal rendering in English - https://phabricator.wikimedia.org/T297577 (10Eileenmcnaughton) @TomaszGorski - that's interesting - it was... [20:48:18] (03CR) 10Cstone: [C: 03+2] "Thanks for making this more clear!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/746004 (owner: 10Ejegg) [20:48:52] (03Merged) 10jenkins-bot: Update Amazon firewall error message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/746004 (owner: 10Ejegg) [21:01:59] 10Fundraising-Backlog: Amazon intermittent timeouts 2021-12-10 - https://phabricator.wikimedia.org/T297552 (10DStrine) 05Open→03Resolved [21:13:34] hi eileen: this is the one that I feel like should be working: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/745669 [21:19:06] so if I turn on the SQL general log and look at the query generated by the Relationship::get call, then run it. I get 1 row back [21:19:16] but the API call comes back empty [21:27:23] (03PS1) 10Eileen: Error rather than fatal when no contributions [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/746958 [21:28:01] (03CR) 10Ejegg: [C: 03+2] Error rather than fatal when no contributions [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/746958 (owner: 10Eileen) [21:30:10] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/746959 [21:31:00] ejegg: that was quick! [21:33:05] (03PS1) 10Eileen: Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746960 [21:41:03] (03Merged) 10jenkins-bot: Error rather than fatal when no contributions [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/746958 (owner: 10Eileen) [21:48:01] AndyRussG: just realised we didn't talk through the existing orphan rectifier stuff [21:48:16] jgleeson: ah no worries [21:48:29] sounds like other steps are more urgent [21:48:49] I can still look at patches as they come through, and can look at some other stuff for the rest of my afternoon/evening [21:49:23] in short, a quick way to run it would be to make a donation locally but don't run the queue consumer. Instead run the pending queue consumer which will drop your pending queue message into the smashpig pending db tbl. that's the "raw material" needed for the orphan rectifier [21:50:29] once you have that pending record in the db table, you need to modify the date so it's at least 30 minutes old from your machine date. This is because the orphan rectifier ignores pending records which are less than 30m old [21:52:26] one you have that record you can run the module locally using `drush orphan-slayer ingenico` [21:53:19] then you could drop a breakpoint in here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/8a783367ef21fa8f6b486e75e386bb3625955dd9/drupal/sites/all/modules/orphan_slayer/orphan_slayer.module#L7 [21:53:36] and that's pretty much all you need to get into the nitty gritty on the existing code. [21:55:18] hopefully that will follow closely the flow captured in the diagram https://tinyurl.com/2p8bjap6 [21:55:24] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Switch CiviCRM mailing to use smtp fallback, consolidate our smtp use across our codebase - https://phabricator.wikimedia.org/T297647 (10Eileenmcnaughton) [21:55:45] also thanks AndyRussG for the review on the deep dive documentation. i did see that earlier but just haven't had a chance to dig in [21:56:42] jgleeson: thank u! no worries, it's just a few details and thoughts for when we update it to describe the new system :) [21:57:08] it very much served its purpose, I think, in that I got a great overview of how all that is working currently [21:58:00] i guess one worry I had is that the current diagram and docs are maybe missing something so it felt like getting other eyes on those would be wise [21:58:52] some of the code paths got trixy! [21:59:58] heh yeee that's why diagrams :) [22:02:53] I was thinking we could reuse most of that flow to capture what actually happens when we process a donation also and keep that as a reference. Things such as knowing when the queue messages get dropped and what methods they hide in is something I often forget. [22:03:54] and maybe expanding out some of the smashpig steps summarised in the flow into it's own smashpig box of activities [22:04:07] so many fun activities! [22:04:36] gotta run an errand, back in a bit [22:10:06] 10Fundraising-Backlog, 10FR-Tech-Analytics: Email Send with Low Clicks - https://phabricator.wikimedia.org/T293926 (10JMando) These emails are also showing a similar issue in that they are actually not showing up in either the clicks or donations queries above: Emails: 1_20211005_UnitedStates_English(en)_MGEv... [22:10:09] for anyone who hasn't seen Step Brothers https://www.youtube.com/watch?v=ulwUkaKjgY0 (colourful language warning) [22:11:48] yee makes sense jgleeson [22:14:52] also that vid is insane [22:15:18] yeah that whole movie is insane lol [22:15:31] theres blood everywhere [22:15:36] ha! [22:15:40] i think that movie is like 90% ad libbed [22:18:32] I'm gonna call it a day fr-tech. Have a good one all ! Damilare have a great wedding man and holiday break. See you on the other side!!!! [22:18:38] bye jgleeson ! [22:19:04] cya! [22:41:40] (03PS1) 10Eileen: Settings that prevent mysql timing out if you are stepping through breakpoints [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746966 [22:42:44] cstone: I was trying to remember the url to view the mailcatcher container.... [22:44:32] ah http://wmff.localhost:1080/ [22:46:47] (03PS2) 10Eileen: Settings that prevent mysql timing out if you are stepping through breakpoints [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746966 [22:46:49] (03PS1) 10Eileen: Declare url for mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746967 [22:47:29] (03PS2) 10Eileen: Declare url for mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746967 [22:49:02] (03CR) 10Eileen: [C: 03+2] Submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746960 (owner: 10Eileen) [22:49:25] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/746959 (owner: 10Eileen) [23:59:20] oh hey, we should make that wmff site default to civicrm as the main page