[00:00:06] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Declare url for mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746967 (owner: 10Eileen) [01:01:23] (03CR) 10Ejegg: [C: 04-1] "Thanks! Just has one duplicate line" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746966 (owner: 10Eileen) [01:06:42] 10Fundraising-Backlog, 10fr-donorservices: Dot instead of comma in Thank you email confirmation French-France, Italian-Italy and Spanish-Spain - https://phabricator.wikimedia.org/T293275 (10CDenes_WMF) ah noted, thanks @DStrine ! [01:10:19] eileen: ahhh, i see why my API call gets no response - I'm doing it after the moveContactBelongings fn [01:10:50] and when I try to look at it while I've got the code paused at the breakpoint, I'm looking on a different connection that isn't in the merge transaction [01:13:30] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10CDenes_WMF) Thanks all! I'm... [01:15:05] hmm hmm hmm, so maybe the fix is needed inside CRM_Contact_BAO_Contact_Utils::createCurrentEmployerRelationship [01:21:34] 10fundraising-tech-ops: Fundraising environment support for Debian 11 (Bullseye) - https://phabricator.wikimedia.org/T277184 (10Dwisehaupt) Testing come directory size collection to see if we want to split partitions based on the CIS benchmark. Collection running for a week on the combined logs on frav1002. If w... [01:28:30] oh hey, upstream bug filed two years ago: https://lab.civicrm.org/dev/core/-/issues/1161 [01:29:35] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, 10Patch-For-Review: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10Ejegg) Found the upstream bug report. It is indeed a tricky... [01:39:22] ejegg: yep looks like it's gonna be back on us to fix :-) [01:43:36] (03PS3) 10Eileen: Settings that prevent mysql timing out if you are stepping through breakpoints [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746966 [01:44:05] (03CR) 10Eileen: Settings that prevent mysql timing out if you are stepping through breakpoints (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746966 (owner: 10Eileen) [01:44:54] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Settings that prevent mysql timing out if you are stepping through breakpoints [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746966 (owner: 10Eileen) [02:14:33] (03PS8) 10Eileen: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) [02:14:35] (03PS2) 10Eileen: Update tests to test sent mail, not db table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746013 (https://phabricator.wikimedia.org/T297159) [02:14:37] (03PS2) 10Eileen: Do not create a job when there is contact id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746015 (https://phabricator.wikimedia.org/T297159) [02:14:56] (03PS15) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [02:14:58] (03PS3) 10Eileen: Finally fully remove the drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) [02:15:00] (03PS4) 10Eileen: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) [02:15:02] (03PS4) 10Eileen: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) [02:15:04] (03PS2) 10Eileen: Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) [02:15:06] (03PS5) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [02:25:50] (03CR) 10jerkins-bot: [V: 04-1] Update tests to test sent mail, not db table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746013 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:33:54] i may have found a bug in something with address merge conflicts, but I'm not sure [02:34:23] I'll try to capture exactly what's triggering it to describe it, then delete the addresses on one of these to focus on the employer thing [02:34:49] just been merging tons of example data contacts into each other to keep cycling through the employer merge code [02:35:19] and this time, with two addresses on one contact and one address on the other, i'm seeing a new exception in the EquivalentAddressResolver [02:36:18] but I think the problem is from the Merger::getConflicts which is reporting a location_address_1 conflict when only one contact has 2 addresses [02:36:31] gonna eat first... [03:26:05] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746013 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [03:32:59] hmm, this patch makes it stop duplicating the relationship: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/745669 [03:33:19] but on at least one I tried, the merged contact didn't have the current employer set correctly [03:39:17] cool - I'll take a look - I've just been trying to get that drupal mail to go to mailcatcher - I think I have it [03:40:55] hmm, every time I try again I get the current employer set correctly [03:41:10] Guess I'll un-tag that as WIP [03:41:12] ejegg: so is the problem situation [03:41:12] 1) relationships have conflicting custom fields (yes vs no) or [03:41:12] 2) relationships have compatible custom fields (yes vs NULL) [03:42:31] the problem is that on merge, what should be moving a single relationship that exists on one contact and doesn't exist on the other is instead moving that relationship with its custom data AND creating a duplicate relationship with no custom data [03:43:32] since the merger has a block down around line 1521 that sets the 'current_employer' pseudo-field on the target contact to be saved, after calling 'moveAllBelongings' [03:44:57] anyway, the intent of that checkDuplicates block seems to be to only consider relationships unique in re custom values if they both have a custom value [03:45:22] lemme put a couple more links on that commit message [03:47:05] oh I see - I think it's just trying to be a bit too brief - ie the goal is to check for conflicting fields but rather than do some longer array parsing it's been squashed to be brief but flawed [03:47:17] yeah [03:47:25] maybe my way is still flawed [03:47:34] but it works for our case... [03:48:22] cool - I'll give it a spin - I got a bit distracted to get stuck into it earlier today [03:49:15] hah - this never merged - after 5 hours .... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/746959 ! [03:49:31] oh boo [03:49:55] hmm, i see a composer.json update without a corresponding vendor update [03:50:11] ahh, it's just a dev requirement [03:51:54] (03PS4) 10Ejegg: Deduper: don't duplicate Employee relationships [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745669 (https://phabricator.wikimedia.org/T297336) [03:52:14] oops, meant to add one more link [03:54:00] (03PS1) 10Ejegg: Deduper: don't duplicate Employee relationships [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/746987 (https://phabricator.wikimedia.org/T297336) [03:54:04] (03CR) 10Eileen: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/746959 (owner: 10Eileen) [04:37:56] (03PS1) 10Eileen: Update fundraising dev to use mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746988 [04:37:59] cstone: [04:38:10] ^^ gets mailcatcher working for EOY email [04:45:53] Ooh nice eileen !!! I didn't have the port on the host that would explain why mine wasn't working [04:50:03] woo it catches!! [04:51:23] woo and thank yous yay [04:52:05] (03CR) 10Cstone: [C: 03+2] "Yay thanks for this!!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746988 (owner: 10Eileen) [04:52:25] cstone: yep & I spotted a fairly serious bug that wasn't leaping out at me before [05:18:55] (03PS1) 10Eileen: q [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746991 [05:18:57] (03PS1) 10Eileen: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) [05:19:20] (03CR) 10Eileen: [V: 03+2] Update fundraising dev to use mailcatcher [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/746988 (owner: 10Eileen) [05:21:24] (03PS2) 10Eileen: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) [05:21:32] (03Abandoned) 10Eileen: q [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746991 (owner: 10Eileen) [13:06:53] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 3 others: Norwegian Bokmaal rendering in English - https://phabricator.wikimedia.org/T297577 (10TomaszGorski) @Eileenmcnaughton Hello, indeedy, we've double c... [14:10:33] howdy fr-tech [14:52:01] hi jgleeson fr-tech! :) [15:21:32] howdy AndyRussG :) [15:22:35] jgleeson: :) hey [15:22:59] lmk if I there are things to do 600/800-ish btw :) [15:35:24] AndyRussG: this patch could do with some review if you fancy it! https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/736877 [15:35:36] that would allow me to push out the smashpig update [15:35:54] jgleeson: oki cool! :) [15:36:06] (we can't update smashpig in the wild until that patch is ready to go also) [15:36:11] thanks much! [15:37:49] thank u! :) [16:41:01] Hi fr-tech [16:42:50] hey cstone :) [16:51:37] howdy cstone :) [17:11:19] jgleeson|brb: any quick tips on smoke testing that code path? [17:27:09] AndyRussG: the dependencies are the same as the old stuff, pending record, but to run that one you need to call a slightly different command. lemme find it [17:27:31] thx jgleeson! [17:28:10] Also you could drop in a breakpoint in one of the more straightforward tests and see how it's set up and run that way [17:34:05] hmm I was just looking at the api explorer and I can see this cmd AndyRussG `cv api4 PendingTransaction.resolve` [17:34:41] however if wanted to use drush as an entry point you could do `drush cvapi PendingTransaction.resolve` I think! [17:35:12] jgleeson maybe it would be easier to use PendingTable.consume? [17:35:52] maybe! [17:36:28] since with PendingTransaction.resolve you have to send the whole message as a parameter [17:36:36] oh yeah that's right ejegg otherwise we'd have to pass in the message [17:36:56] yeah good call [17:37:11] AndyRussG: ^^ [17:37:28] might be worth also dropping off a breakpoint inside that api call [17:38:53] actually I have a better idea [17:38:57] try this AndyRussG https://wmff.localhost:32353/civicrm/api4#/explorer/PendingTable/consume [17:39:07] then you get to do it all ways! [17:42:06] ejegg jgleeson so first make an ingenico cc payment but with fraud filters turned up so it doesn't capture or something? [17:42:20] like how should i get a transaction into the pending table first? [17:42:40] AndyRussG: sure, that would be a good way of doing it [17:43:25] you shouldn't have to touch the fraud filters at this point [17:44:12] but yeah as explained yesterday, put through a local donation, run the pending queue comsumer but don't run the donation queue consumer [17:44:23] that'll get you a pending record to use [17:45:27] ahh oki sorry if I missed that, thx! [17:45:32] hang on a minute [17:45:52] I think me and ejegg are answering the wrong question [17:46:34] did you want tips on how to smoke test the code path of the patch I linked earlier? [17:46:45] (the one you were going to review) [17:47:29] sorry that's entirely unrelated to the crm code [17:47:38] AndyRussG: ^ [17:48:11] I guess I need to do something to make DI want to cancel a payment or something, no? [17:48:17] yeah exactly [17:48:25] k so when does that happen? [17:48:29] so that code is used in the orphan rectifier that is currently in use [17:48:48] so it would be best reviewing that code with the existing/old orphan rectifier in mind [17:48:58] as that's what we'll immediately change once we deploy that patch [17:49:58] we will also use that code in the new crm pending trxn stuff, but later. Sorry that's why it's so confusing¬ [17:50:00] ! [17:51:03] I guess to smoke test that code path locally you'd need to do a little bit of hackery to simulate that scenario [17:52:33] check out the unit test that dami updated on that patch. you can see to run down that flow we use the ingenico cancelled response [17:57:03] there are other ways you could do it, you could remove the contribution_tracking_id or add a contribution_id to the orphan record during processing. Checkout the checks here that lead to those code paths https://tinyurl.com/2p8bjap6 [18:04:39] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10DStrine) Per the standup tod... [18:04:59] i guess that UML diagram still needs more review! I just realised there are steps missing covering what happens when cancelCreditCardPayment is called [18:07:07] gonna grab dinner [19:12:38] 10Fundraising-Backlog: Production of Monthly Convert Thank You Email in Remaining Languages - https://phabricator.wikimedia.org/T296868 (10DStrine) [19:15:49] (03CR) 10Ejegg: [C: 03+2] Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:16:24] welcome WFan! :) [19:21:23] Face masks just became mandatory back over here in the UK. Parliament also voted to make covid passports (proof of vaccination) required for entry to all "large" events although the details are what constitutes large isn't clear [19:21:57] Covid cases jumped 10% in a week [19:22:11] wow. let's hope the new measures have some effect [19:22:33] In other news, Oscar's test came back negative today which was a relief. Turns out it's just a cold and I've also picked it up! [19:22:40] we had a mask mandante since like early november? and the ICU is finally below 100% this week [19:22:49] aw jgleeson yay for negative at least! [19:22:51] oh man, bad news good news bad news sandwigh [19:22:54] *sandwich [19:23:02] indeed ha! [19:26:01] (03CR) 10Ejegg: [C: 03+2] Update tests to test sent mail, not db table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746013 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [19:28:48] (03Merged) 10jenkins-bot: Only use name if usable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745610 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [19:29:56] The covid passports requirement is an interesting one. On one hand I can see the logic in trying to reduce asymptomatic folks being around lots of other people relying on the fact(I think!) that vaccinated folks are less likely to carry the virus... but on the other hand I can't help but think of 1984 when the general public can only gain access to places if they a) take two jabs of a vaccine [19:29:58] and b) download an bluetooth contact tracing app on their phones to show on request. I've had my vaccines and am by no means an antivaxxer but it still feels a tidgy bit orwellian [19:31:01] compounded by the fact that Boris Johnson is leading the government making these rules [19:33:32] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Cstone) [19:34:17] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Cstone) [19:37:50] (03Merged) 10jenkins-bot: Update tests to test sent mail, not db table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746013 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [19:40:11] jgleeson: the passports in Canada did get my two friends there to finally get vaccinated because they wanted to play badminton [19:41:55] A covid passport blackmarket has sprung up around this over here in the UK. Apparently, you can pay £350 for someone to take the vaccine for you in your name so that the NHS issues you with a pass [19:45:17] I wonder how many people have paid for such a service and now deeply regret it due to no longer being able to request the vaccine (as they'll be down as already having had it) on the back of the omicron wave. It's a criminal offence here now I think so there woul likely be consequences. [19:46:05] there was a case of an anti-vaxer trying to get a shot in a fake arm in Italy I think [19:46:49] https://montrealgazette.com/news/world/italian-anti-vaxxer-fails-attempt-to-get-vaccine-shot-in-fake-arm-for-covid-passport [19:50:28] wtf! [20:00:39] honestly, i'm less worried about the 1984 feel of a vaccine passport and more worried about the over fascism going on in the world. [20:00:45] s/over/overt/ [20:03:10] although that article needs an editor for the first sentence. it's not a suprise he got caught if he showed up with an arm made of silicon (vs silicone). :) [20:15:14] !log a88cd178 -> d0ac9184 [20:15:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:15:49] (03CR) 10AndyRussG: Pending Transaction Resolver: Implementation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [20:17:23] (03PS1) 10Ejegg: Delete cruft from oldest orphan rectifiers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747201 [20:19:19] jgleeson: If it makes you feel any better, the NHS app for vaccine passports is a completely separate app from the contact tracing one [20:19:55] I think many people have uninstalled or turned off the contact tracing one since we had the "pingdemic" a few months ago [20:20:40] dwisehau1t: the Montreal Gazette is a proud bastion of anti-copy editing [20:21:34] (03CR) 10AndyRussG: Pending Transaction Resolver: Implementation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [20:28:02] (03CR) 10AndyRussG: Pending Transaction Resolver: Implementation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [20:31:02] (03CR) 10Eileen: "Just noting I agree with Andy that the pattern he highlighted is not common in newer Civi code" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [20:35:57] ah I still have it installed pcoombe. it "pinged" me today to notify me of the "Plan B" changes. You're right they are separate apps. I'd forgot that you can use the general NHS app for the covid passport QR code [20:46:23] (03PS8) 10Ejegg: Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [20:46:30] (03PS9) 10Ejegg: Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [20:46:54] (03CR) 10Ejegg: [C: 03+2] Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [20:49:05] (03Merged) 10jenkins-bot: Update cancelPayment response handling for ingenico. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736877 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [21:01:55] (03CR) 10Jgleeson: Pending Transaction Resolver: Implementation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [21:59:23] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) [22:06:37] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) Access request sent. Verified details on the Contact List. [22:34:47] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) ` Date: Tue, 14 Dec 2021 14:24:44 From: Lisa Gruwell To: Dallas Wisehaupt Cc: Dylan Kozlowski, Wenjun Fan Subject: Re: Fundraising access request for Wenjun Fan Parts/Attachments: 1 O... [22:35:09] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) [23:29:53] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt)