[00:14:07] (03PS1) 10Ejegg: Move fraud action thresholds to provider-defaults [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747215 [00:51:28] ejegg: well all existing tests pass with your patch as is - I'm just gonna think through it for a bit as to whether there is a missing scenario [01:06:48] ok, cool [01:25:50] (03PS1) 10Ejegg: Correctly normalize IN_PROGRESS hosted checkout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 [01:26:14] AndyRussG: ok, ^^^ should handle the case when the donor hasn't entered any card information [01:28:54] ejegg: cool beans, thanks! [01:42:30] hmm, I have a patch to Resolve.php that adds a bunch of comments and changes the indexing of the result to use order_id [01:42:41] but I realize that will probably make rebasing the following ones tricky [01:42:57] well, let me try just committing it as a separate patch, then see how bad the rebase is [01:43:11] and if it's not too bad I'll squash it into the one we reviewed today [01:48:32] (03CR) 10Eileen: [C: 03+2] "This works - I'm still tinkering as to whether the upstream patch will differ at all - but I'm OK with deploying this now to remove the cu" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/746987 (https://phabricator.wikimedia.org/T297336) (owner: 10Ejegg) [01:48:47] thanks eileen ! [01:49:12] (03PS1) 10Ejegg: Delete oldest orphan rectifier drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747221 [01:49:45] ejegg: yeah - I figured I had enough confidence for us to get it out there - since we don't have any complexity & I haven't found a problem situation yet in my test [01:50:12] right on [02:11:23] (03PS16) 10Ejegg: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [02:11:51] (03PS22) 10Ejegg: Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [02:11:53] (03PS13) 10Ejegg: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [02:12:09] AndyRussG: ok, that rebase wasn't so gnarly [02:12:30] (03CR) 10Ejegg: "PS16 addresses some remarks from today's tech talk:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [02:12:53] (03CR) 10Ejegg: "PS16:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [02:13:52] ejegg: cool! so in a good state for review, then, I guess? [02:13:59] yep! [02:14:07] yay! K getting to it in a few then [02:23:29] (03CR) 10jerkins-bot: [V: 04-1] Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [02:23:37] (03CR) 10jerkins-bot: [V: 04-1] Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [02:30:46] ooh, let me check on those tests [02:31:15] ah right, they're looking for that old session_id index [02:31:29] lemme update that [02:31:55] oki [02:33:25] just gonna finish this rework of the fraud db integration, think I can make it easier to follow [02:41:23] (03PS23) 10Ejegg: Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [02:42:49] (03CR) 10Ejegg: "PS23:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [02:43:18] (03PS14) 10Ejegg: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [02:49:07] (03CR) 10AndyRussG: Pending Transaction Resolver: Implementation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [02:49:44] ejegg: ^ probably not necessary to rebase everything just yet, mostly expecting there to be not too many weighty comments [02:49:57] so maybe we can just get it merged and then rebase the rest on master? [02:50:27] k, I'm doing a little rework as I go so I'm trying to keep it all on top of the latest of the patches before [02:52:11] (03PS2) 10Ejegg: WIP add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) [02:54:19] AndyRussG: k, i have that WS fixed locally, lmk when you want another PS pushed up [02:54:58] ejegg: rework on which patch? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/722703 ? [02:55:13] feel free to push up another PS anytime it works for u [02:55:23] I did some rework on the next 2 as well [02:55:48] (03PS17) 10Ejegg: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [02:57:30] (03CR) 10jerkins-bot: [V: 04-1] Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [02:58:20] ejegg: K now looking at ps 17 [03:03:07] (03CR) 10jerkins-bot: [V: 04-1] WIP add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [03:03:21] (03CR) 10AndyRussG: Pending Transaction Resolver: Implementation (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [03:03:58] AndyRussG: see the following comment on line 80 [03:04:19] and the message written to the log on line 83 [03:04:41] ah right sorry to be so quick on the send comment [03:05:50] ejegg: maybe we can just move the comments on lines 72 and 80-81 together then, maybe all at 72? [03:07:35] ok, sure [03:08:21] thx! [03:12:26] (03PS18) 10Ejegg: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [03:29:52] (03CR) 10AndyRussG: Pending Transaction Resolver: Implementation (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [03:33:36] (03PS19) 10Ejegg: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [03:37:26] ejegg: wow it's super late for u eh! [03:38:09] also adding blank lines must be really CPU-intensive for PHPStorm ;p ;) [03:38:20] jk [03:41:29] i got started pretty late too [03:45:13] ejegg: one more comment that comes to mind, maybe we can add a "TODO" to indicate where the unfinished bit is? not really important tho... looks like that actual patch is at the tip of the chain in WIP? [03:45:36] Yep, I'm working on getting it out of WIP [03:48:05] cool! [03:49:00] ejegg: so just for reference on this patch, where will that matchesUnrefundedDonor() method be called again? [03:49:30] in the $validationAction switch, when it's REJECT or REVIEW [03:49:45] oki thx [03:56:37] ejegg in one of the local queue messages, I get \"response\":\"Response Status: \", I think on the one that the system decided to process [03:57:00] AndyRussG: ah man, that queue message key is actually mostly blank for most messages [03:57:19] I think the old GlobalCollect adapter faithfully set something in there [03:57:26] hmmm ok [03:57:29] but we haven't really set it in the rest of them [03:57:31] so not important I guess then [03:57:34] and honestly nobody's missed it [03:58:40] similarly in the $approveResult->isSuccessful() conditional block, line 108, I guess I'm surprised that the new status is not set in the message before we queue it into the donations queue [03:58:58] but again if that's not taken into account, I guess not important just now [03:59:06] I could make a task to clean that up too as part of our refactor epic [03:59:51] sorry, why would we send the new status in the donations queue? [04:00:11] the donations queue only gets completed donations [04:00:38] right [04:01:31] I mean I guess I feel like a message would say something like that, but I guess its presence in the queue is enough... ahh apologies [04:02:30] ejegg: ahh can u maybe remind me why we drop a message in the payments-init queue again? [04:02:49] AndyRussG: tradition! [04:02:58] lol [04:03:06] If I were a rich man [04:03:28] well, we usually drop one in there when the payment gets to the end of the process on payments-wiki [04:03:43] and these dangling transactions often didn't get all the way through [04:03:44] https://www.youtube.com/watch?v=RBHZFYpQ6nc [04:04:12] :) [04:04:39] anyway, the existing orphan rectifier does it, because it is using the payments-wiki code [04:05:01] I think there are some reports etc that assume payments-init rows exist [04:06:24] ejegg: oki cool..... thx, would it be too much to ask to add something to that effect in a comment too? [04:06:30] I think after that I'd be ready to +2 [04:06:36] k, can do [04:07:07] thx! and thx for all the explanations and updates! [04:09:38] (03PS20) 10Ejegg: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) [04:10:10] ah, and I should rebase that on master too [04:10:27] eh no need if it'll merge [04:11:03] ah, right, i had done that along the way [04:11:56] (03PS24) 10Ejegg: Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [04:12:13] (03PS15) 10Ejegg: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [04:14:42] (03CR) 10AndyRussG: [C: 03+2] "Fantastic stuff, thanks so so much!!! :D" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [04:15:48] eileen: if you're still about I could pivot to civi review for a bit, as you suggested earlier today, if u like [04:16:06] AndyRussG: oh cool [04:16:17] yeah - just driven his highness to volleyball [04:16:27] heheh [04:16:40] I got a similar request earlier today via WhatsApp [04:17:08] to pick up Sofi and her boyfriend from school and take them to the mall [04:17:25] :-) [04:17:26] but since it's the kids' mom's day, I had to check with her before, and she didn't answer [04:18:15] eileen: so attentive to learn what I should look at here [04:18:52] ejegg: regarding the 600/800 stuff, so next in line for review would be the follow-on patchs in that chain, i imagine? [04:19:27] ok - so this is first https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/746015 [04:20:05] AndyRussG: yep, just following that chain on down [04:20:49] AndyRussG: I think David prioritised the 600/800 stuff tho? [04:21:10] (03CR) 10jerkins-bot: [V: 04-1] Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [04:21:20] oh dang! [04:21:37] whaa [04:21:46] how did that break the EOYEmailTest? [04:22:17] i swear i didn't touch 'em! [04:22:17] patches all the way down [04:22:23] maybe a flapping test? [04:22:40] yeah - maybe - I thi nk I've seen that fail before & it went away on recheck [04:22:47] dang [04:22:49] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [04:23:07] eileen: true, though at least I can look at something else while ejegg rebases and checks the tests... [04:23:16] AndyRussG: ok cool [04:23:26] (03CR) 10jerkins-bot: [V: 04-1] Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [04:23:53] well so the context is that the job_id was originally a bit of a half baked concept - I'm not sure the real idea - but in practice it basically mapped to year & made everything more complicated [04:24:16] when the ability to email a single contact was added job_id was required so a fake job was created [04:24:24] that first patch just gets rid of that [04:26:02] AndyRussG: oh actually, I need to tag a new version of SmashPig to make the antifraud integration test work [04:26:24] ejegg: hmmm other than that it's ready for review tho right? [04:26:45] well, I'd like to have that IN_PROGRESS normalization fixed for the new SmashPig version [04:27:12] (03CR) 10AndyRussG: [C: 03+2] "resubmit" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [04:27:14] https://gerrit.wikimedia.org/r/747220 [04:27:23] ah oki [04:27:50] so fortunately there was already a test looking at that response [04:27:59] it had just been looking at the rawRespose [04:28:21] and I was able to just add a couple assertions for the status and rawStatus properties [04:28:30] ejegg: does that patch actually need the preceding one on the chain? [04:28:54] ah nope, that's just the order I wrote 'em in [04:29:18] oki so let's rebase the one that needs merging onto master, I can do that on the UI [04:29:33] (03PS2) 10AndyRussG: Correctly normalize IN_PROGRESS hosted checkout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 (owner: 10Ejegg) [04:30:45] so that diff looks bigger than the actual change [04:31:07] because of indentation and added comments [04:32:47] the only new stuff that's happening is the bit on line 103 [04:33:00] to line 107 [04:36:00] oki [04:36:09] eileen: and this was the tip of ur chain, right? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/746033 [04:36:21] If the current change is confusing, I could do a minimal version of that patch which just adds that same block in a if ( !isset( $rawResponse['createdPaymentOutput'] ) && isset( $rawResponse['status'] ) ) } conditional, right after the call to prepareResponseObject [04:36:52] AndyRussG: Yeah I think that is where it ends [04:36:57] eileen: oki [04:37:11] ejegg: lemme see what meld shows me :) [04:38:18] AndyRussG: this section is sending to a specific contact https://wikitech.wikimedia.org/wiki/Fundraising/Internal_Endpoints/End_of_year_emails#Sending_to_an_individual_contact - note I found a bug that caused the wrong language if the contact has a NULL language - the fix for that is later on so test on a contact who has a language :-) [04:38:24] (03CR) 10jerkins-bot: [V: 04-1] Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [04:39:17] eileen: oki cool thx! [04:40:00] ejegg: by the way I found something odd with the relationships - but am looking to fix upstream. It's actually not blocking picking up when they really do conflict - but I think that's OK for us for now [04:41:04] heh, what's the other oddness? [04:42:48] ejegg: so if the existing relationship has custom data it doesn't actually get loaded - so it would think there was no conflict even if there is. [04:42:59] ufff [04:45:14] yeah I think it's gonna take a bit of re-work to deal with that - I'll poke around but I think it won't hurt us for now [04:48:07] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747230 [04:48:26] ejegg: your patch hasn't gone out yet - but I think they turned on those banners? [04:48:39] ^^ is the merge commit [04:49:03] ah, let's see if we have dupes [04:50:13] that looks good to deploy, eileen [04:50:34] thanks! [04:50:39] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747230 (owner: 10Eileen) [04:53:18] I'm trying to look at that failing test but it's requiring a civibuild because my db has db changes not yet merged [04:54:59] the test fail could indicate a test cleanup issue [04:55:34] eileen: possibly, but the new patch that's failing doesn't add any tests [04:55:42] no... [04:58:19] so it's trying to email someone who is not emailable - I suspect this might help - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/746033/5 - but that is right at the top of the chain [05:01:13] ah I see, the export DID fail tonight [05:01:21] ok, I'll do another data cleanup [05:03:17] k, it should be the higher ID in each dupe pair that doesn't have the custom value [05:06:24] oh, but we're steadily getting more [05:06:31] right, I'll do the data fix after that deploy [05:06:48] ejegg: we're quite certain about this comment (and the related added conditional)? "Fraud results and tokens only come back when a payment has been created" [05:07:05] AndyRussG: look at the node we're finding them in [05:07:31] hmmm I guess I need to debug thru, oki will do in that case [05:07:47] for the IN_PROGRESS ones where no createdPaymentOutput exists, there's no point in looking at ['createdPaymentObject']['tokens'] [05:07:47] !log revision d0ac9184 -> 1ede5365 civicrm [05:07:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:08:27] oki thx ejegg [05:09:21] (03PS1) 10Eileen: Merge "Deduper: don't duplicate Employee relationships" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/747231 [05:09:44] (03CR) 10Eileen: [C: 03+2] Merge "Deduper: don't duplicate Employee relationships" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/747231 (owner: 10Eileen) [05:09:56] ejegg: arg submodule commit hadn't been done - only for my earlier one [05:11:17] ejegg: looks like an incomplete sentence in comment on line 29 of HostedCheckoutStatus.php, "For many of those" [05:12:38] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [05:20:11] AndyRussG: ok, will fix [05:20:22] (03CR) 10AndyRussG: Correctly normalize IN_PROGRESS hosted checkout (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 (owner: 10Ejegg) [05:20:29] ejegg: thx!! [05:21:28] (03Merged) 10jenkins-bot: Merge "Deduper: don't duplicate Employee relationships" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/747231 (owner: 10Eileen) [05:21:34] (03PS21) 10Eileen: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [05:21:36] (03PS1) 10Eileen: Submodule update CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747232 [05:23:29] (03PS2) 10Eileen: Submodule update CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747232 [05:23:47] (03CR) 10Eileen: [C: 03+2] Submodule update CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747232 (owner: 10Eileen) [05:26:25] AndyRussG: maybe I'll convert that warning to an exception, now that I think about it. [05:27:28] ejegg: sounds good :) [05:28:27] (03PS3) 10Ejegg: Correctly normalize IN_PROGRESS hosted checkout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 [05:35:33] oh man, sometimes a volunteer code fix comes in for DonationInterface and I'm just embarrassed [05:35:33] (03Merged) 10jenkins-bot: Submodule update CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747232 (owner: 10Eileen) [05:35:43] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/746796/1/tests/phpunit/AmountTest.php#203 [05:35:54] // Conversion tests depend on Barbadian monetary policy [05:36:22] Well at least that comment is correctly formatted in the new patch [05:37:11] ejegg: is there something wrong with the comment? [05:42:08] (03PS1) 10Eileen: Submodule update CiviCRM [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747234 [05:43:11] (03PS2) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747234 [05:43:23] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747234 (owner: 10Eileen) [05:44:04] (03PS22) 10Eileen: Pending Transaction Resolver: Implementation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/722703 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [05:48:24] !log revision 1ede5365 -> d4cea6a9 civicrm [05:48:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:48:49] ejegg: that relationship update is out now [05:52:36] thanks eileen ! [05:52:39] doing the data update [05:53:15] k, looks like 65 dupes [05:54:18] hmm, that delete statement is taking way longer than the select [05:54:25] it is in a transaction though... [05:55:06] gonna kill it and do it with a temp table [05:56:39] ok, that was way faster [05:56:54] will kick off the export again [05:57:18] ahhh, i still haven't looked into those adyen audit timeouts [05:57:26] bah, that'll have to wait for tomorrow [05:58:07] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/747278 (owner: 10L10n-bot) [05:58:13] (03CR) 10Ejegg: Correctly normalize IN_PROGRESS hosted checkout (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 (owner: 10Ejegg) [05:59:23] AndyRussG: we deal with the CANCELLED status in DonationInterface here: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/ingenico_gateway/ingenico.adapter.php$398 [06:00:52] ejegg: hmm oki [06:01:16] so what's the reason for adding it into that normalizer? so that one day we can deal with it in a proper normalizer-ized way? [06:01:32] but we should update that to use this normalized status as a part of https://phabricator.wikimedia.org/T297453 [06:01:40] yeah, exactly [06:02:02] ideally nothing in DonationInterface should need to look at raw responses [06:02:26] right makes sense [06:02:59] imma make that task a subtask of the refactorepic [06:03:57] 10Fundraising-Backlog, 10FR-Ingenico, 10MediaWiki-extensions-DonationInterface: Use normalized SmashPig response properties for Ingenico on payments - https://phabricator.wikimedia.org/T297453 (10AndyRussG) [06:04:01] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021) - https://phabricator.wikimedia.org/T291697 (10AndyRussG) [06:10:26] ok, going to bed for real now. Good night! [06:16:03] (03PS25) 10Eileen: Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [06:16:44] AndyRussG: that one you +2d is merged now - phew [06:17:13] yaaay! [06:17:32] eileen: I prolly should follow ej egg's lead in a few minutes and try to sleep [06:17:40] for sure! [06:18:00] thanks for the context for the chain and patches and apologies I didn't get to it!!! [06:18:23] I'll try to check it out tomorrow, and in any case what you explained this evening will be helpful! [06:29:27] (03CR) 10AndyRussG: [C: 03+2] "Cool, thanks so much for this!! :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 (owner: 10Ejegg) [06:30:09] (03Merged) 10jenkins-bot: Correctly normalize IN_PROGRESS hosted checkout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747220 (owner: 10Ejegg) [06:33:23] eileen: cya! [07:37:08] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/747278 (owner: 10L10n-bot) [14:36:38] (03CR) 10Jgleeson: "Thanks for the review ejegg! check out the suggestions inline for possible test refactoring." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [14:42:56] ejegg|away: I was originally gonna tag smashpig at 91ef42c63c8bf1a55484e2a08669b597c26b9aed but I can see you've pushed IN_PROGRESS normlizer patch and that got merged. Do you want me to include that in v0.7.8 as it's also relevant to ingenico [15:20:22] jgleeson|skrun: yes, please, let's include it [15:30:01] 10Fundraising-Backlog: New Employer field not allowing manual entries - https://phabricator.wikimedia.org/T297798 (10NNichols) [15:46:56] sure thing ejegg|away [15:53:00] ejegg|away: how do you feel about us moving to specific versions of smashpig [15:53:23] when pulling it in from crm & payments [15:55:50] I feel like it would make it more obvious locally and in prod what version of smashpig we're running, at the cost of having to bump up the composer.json file more often [17:01:53] 10Fundraising-Backlog: New Employer field not allowing manual entries - https://phabricator.wikimedia.org/T297798 (10DStrine) 05Open→03Declined [17:41:35] fr-tech I think we should set up an IRC anabled cloud vm for eyener2-0 [17:41:46] enabled* [17:43:40] XenoRyet: Oscar didn't go to his class tonight so I'm around. I think you're in another meet so I'll go grab dinner now and get back a bit earlier than our scheduled call [17:44:07] Sounds good. Yea, I'm in a call until the top of the hour. [17:44:19] cool cool [18:02:22] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [18:04:34] ^^^ looks like we are seeing this again in codfw like we were seeing off and on last week. i'm betting it clears soon. [18:07:22] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [18:24:58] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) [18:26:58] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) SSL client cert generated and sent via email. Password sent via sms. Civi account created. Superset account created, set with temp password, temp password sent via sms, password change lin... [20:13:49] (03PS1) 10Ejegg: Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 [20:14:33] ^^^ still needs a change to vendor and composer.lock [20:15:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Gateway should always be set to engage when those user hand enter donations in civi - https://phabricator.wikimedia.org/T297825 (10DStrine) [20:15:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Gateway should always be set to engage when those user hand enter donations in civi - https://phabricator.wikimedia.org/T297825 (10DStrine) [20:21:11] looking ejegg [20:35:20] ejegg: CI is taking a while so I thought I'd run some tests locally and I'm seeing some failures that look docker-specific [20:35:58] 10 errors and 39 failures when running `docker@payments:/var/www/html$ ./tests/phpunit/phpunit.php --group DonationInterface` [20:36:22] I have another version of payments installed so I'll try that too [20:40:28] jgleeson: there is a lingering di patch to fix some of them [20:40:40] ok on the other install I'm getting all tests passing for the following [20:41:03] and commenting out stuff in config private local settings also helps [20:41:05] hmmm actually lemme make sure everything is up to date [20:41:58] false positive [20:42:04] (03CR) 10jerkins-bot: [V: 04-1] Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 (owner: 10Ejegg) [20:42:15] I was testing an out of date DI [20:45:04] hmm CI is complaining also ejegg AndyRussG [20:45:06] 20:34:20 - Required package "pear/mail_mime" is in the lock file as "1.10.8" but that does not satisfy your constraint "1.10.11". [20:47:58] (03PS3) 10Eileen: Do not create a job when there is contact id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746015 (https://phabricator.wikimedia.org/T297159) [20:48:00] (03PS16) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [20:48:02] (03PS4) 10Eileen: Finally fully remove the drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) [20:48:04] (03PS5) 10Eileen: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) [20:48:06] (03PS5) 10Eileen: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) [20:48:08] (03PS3) 10Eileen: Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) [20:48:10] (03PS6) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [20:48:12] (03PS3) 10Eileen: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) [20:48:14] (03PS1) 10Eileen: Remove early return [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747607 (https://phabricator.wikimedia.org/T297159) [20:49:07] ug - I was just trying add 1 commit but the whole chain went up [20:49:21] it would be good to get some weight out of the chain [20:51:12] interesting [20:51:21] tests are passing for me locally for that patch ejegg [20:52:46] oh wait I see what the issue is. tests are not passing [20:52:57] ejegg: there's a bunch of failures due to smashpig [20:58:17] ok it looks like that was entirely my side. trying to test on a way outdated payments install [20:59:40] right everything should be up to date now I'll try again [21:03:12] jgleeson: I'll update that patch with a composer.lock and a vendor update [21:03:34] all tests are passing for me and I don't get the error on CI when running tests/phpunit/phpunit.php --group DonationInterface,FundraisingEmailUnsubscribe [21:03:46] but I'm wondering if the jquery change could be risky to deploy [21:04:01] i guess probably not, from 3.4.1 to 3.6 [21:04:15] maybe I'll read those jquery release notes [21:08:08] (03PS1) 10Eileen: Cleanup on sendLetters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747612 (https://phabricator.wikimedia.org/T297159) [21:08:10] (03PS1) 10Eileen: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) [21:08:21] I've gotta wrap up sorry but if anything still needs review by the time y'all finish let me know and I'll jump on it. [21:08:30] thanks jgleeson, have a good night [21:08:30] bye for now fr-tech [21:08:31] dwisehaupt: if you are about in say 20 mins I want to start testing send on staging [21:08:37] night jgleeson [21:09:19] (03PS2) 10Ejegg: Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 [21:12:41] eileen: sure. i'm in a call right now but i am around. [21:22:27] back in a bit [21:23:51] (03CR) 10jerkins-bot: [V: 04-1] Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [21:29:41] (03PS2) 10Eileen: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) [21:35:46] dwisehaupt: ok- I'm ready to try with limit = 1 [21:41:38] cool. [21:42:52] ok running 1 now [21:43:48] i see it went to catchmail. [21:44:37] to gerard [21:45:02] ok - I'll try 10 [21:45:19] yesh. [21:45:34] and 10 more going. looks like it's working. [21:48:03] cool [21:48:42] I'm gonna keep increasing but maybe you have seen enough to feel OK the catchmail is all good [21:50:32] yeah. i see that catchmail running good. and other mail is still going out as expected. [21:54:31] (03PS3) 10Eileen: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) [21:55:24] dwisehaupt: doing 1000 now but no reason why more would be scarier I gues s:-) [21:55:53] ah & hit my first bug - yay - this is why it's good to test on real contacts - I think it;s a weird character [22:48:53] (03PS1) 10Eileen: Improve UI when contact does not have a valid email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) [22:58:18] (03PS1) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [22:58:49] arr, those adyen audits are still timing out [22:58:57] i think i need to clear out some old ones [22:59:30] ok, let's get this mediawiki update out [23:51:40] (03CR) 10Ejegg: [C: 03+2] Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 (owner: 10Ejegg) [23:52:58] 10Fundraising-Backlog, 10FR-Paypal: Delete PayPal pending messages more aggressively - https://phabricator.wikimedia.org/T297246 (10Ejegg) So the minimum age for the expirePendingMessages job is 1 day - I'll set it to that, but it probably won't catch a lot more messages. [23:59:52] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 (owner: 10Ejegg)