[00:00:01] 10Fundraising-Backlog, 10FR-Paypal: Delete PayPal pending messages more aggressively - https://phabricator.wikimedia.org/T297246 (10Ejegg) Looks like the timeout on paypal's side is 3 hours: https://stackoverflow.com/questions/21444721/paypal-payments-standard-expiration [00:00:36] (03PS2) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [00:00:38] (03PS1) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [00:16:22] (03CR) 10jerkins-bot: [V: 04-1] Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:18:50] !log updated payments-wiki from df3ded67 to 55e605dd [00:18:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:20:20] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10FR-Paypal: Delete PayPal pending messages more aggressively - https://phabricator.wikimedia.org/T297246 (10Ejegg) [00:34:15] dwisehaupt: ok sending out like crazy now - assume notihing is leaving the server still? Took 3 mins to send 1000 - trying with 10k [00:34:28] nope hit a problem - ah well [00:35:59] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) [00:36:23] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) added fundraising-tech-ops [00:40:04] (03PS1) 10Ejegg: Stop processing when PaymentActionNotInitiated [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747648 (https://phabricator.wikimedia.org/T205566) [00:40:39] (03PS1) 10Ejegg: Expire pending messages by hours, not just days [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747649 (https://phabricator.wikimedia.org/T297246) [00:43:50] ejegg fr-tech so what is most urgent now wrt 600/800? [00:44:30] AndyRussG: I guess just reviewing the next patches in the chain in CRM [00:44:45] I had some comments on the tests patch, but nothing that should prevent it merging [00:45:31] Ah, I guess the antifraud patch requires that SmashPig update that wfan was doing but hasn't yet pushed up for review [00:49:12] AndyRussG: If you want, you could also try writing a test for the donor match patch [00:49:33] might be a fun introduction to writing tests in CiviCRM [00:51:16] hi WFan ! [00:51:32] have you and cstone had a chance to go over the git-review tool at all? [00:51:57] We set up that for tomorrow I am learning from the video now [00:52:35] ok, cool [00:52:42] let me know if you have any questions [00:52:49] Sure thanks:) [00:58:30] ejegg: what about the patches on this chain? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467 [00:58:56] probably most urgent is finishing the last one, so we can at least get it onto prod? sorry if I'm missing something :) [01:00:15] AndyRussG: yep, those are the patches to review, and the donor match patch is the last one [01:00:26] I guess it's no so much WIP as just needing a test [01:00:45] hmmm and then needs wiring up, the commit message says? [01:00:54] ah, I should update that too [01:00:58] it's wired up in the latest PS [01:01:03] updating... [01:01:33] ahhh, no, I haven't pushed that up yet [01:01:39] ok, let me push up the latest [01:05:35] (03PS26) 10Ejegg: Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [01:05:52] (03PS16) 10Ejegg: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [01:06:17] (03PS3) 10Ejegg: Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) [01:06:31] ok AndyRussG, that's the latest of all the things I've got ^^^ [01:06:42] ejegg: cool thanks! [01:10:22] ejegg: should I look at them in order? or the last one first? also just thinking of how to prioritize timewise [01:11:09] in order should be fine [01:11:23] I guess I could actually +2 the tests one as is [01:16:02] ah oki [01:18:15] (03CR) 10Ejegg: [C: 03+2] "These look like a good start! We could add an integration test for Consume later, but for now let's move ahead. The tricky stuff in the Re" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [01:18:25] (03CR) 10jerkins-bot: [V: 04-1] Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [01:18:40] (03CR) 10jerkins-bot: [V: 04-1] Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [01:29:22] (03Merged) 10jenkins-bot: Pending Transaction Resolver: Tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739354 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [01:33:39] ejegg: looks like the current version of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467/16 has some test code uploaded there [01:40:55] (03PS3) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [01:42:24] (03PS2) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [01:43:04] AndyRussG: yep, that is the one whose tests rely on the new version of SmashPig [01:43:20] the donor match patch (after that one) is the one without any tests [01:45:02] so the only bit to review is the bit under the tests directory [01:45:08] right? [01:46:08] AndyRussG: you don't want to review the whole patch? [01:46:58] Ah i see no yes heh i mean that was my question [01:48:16] Oki so I'll review it all and just ignore the stuff not meant to be merged (or apologies if I'm misunderstanding) [01:50:02] What are you seeing that shouldn't be merged? [01:50:44] you mean the stuff that's getting V-1 ? [01:51:02] those are only because of the not-yet-updated SmashPig version, I think? [01:53:51] ejegg: if you need that version update tonight we can practice git review with something else tomorrow [01:54:55] thanks cstone ! Let's see what other updates AndyRussG suggests [01:55:16] I'll only do that update if i get through the other stuff [01:56:58] ejegg sorry i just looked quickly, must have misunderstood then [01:58:02] I'll look again in 30 min, sorry have been multitasking with non-work [01:58:06] ok [02:00:44] If cstone or u or anyone else feels it's good to merge pls don't hesitate to [02:02:48] i rewrote a bunch there, so I shouldn't self-merge it [02:04:01] (03PS1) 10Ejegg: Stop Adyen audit freatking out over Apple Pay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747664 [02:04:26] cstone: do you have a sec to look at a teeny patch? ^^^ [02:04:52] just adding a value to a switch so the adyen audit log isn't all spammy with 'hitherto unknown' messages [02:07:00] sure ejegg [02:07:12] thanks! [02:07:36] oh derp [02:07:42] comma instead of semicolon [02:07:45] fixing [02:08:18] hah this is a good out of context code for case ew return w [02:08:30] (03PS2) 10Ejegg: Stop Adyen audit freatking out over Apple Pay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747664 [02:09:50] (03CR) 10Cstone: [C: 03+2] "give me an l!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747664 (owner: 10Ejegg) [02:09:58] thanks! [02:10:09] np [02:13:03] hmm, looks like maybe the adyen audit parser isn't marking things as recurring when it should [02:13:27] it's grepping payments logs for order ids like 92160825.15 [02:15:11] oh damn, we never updated the adyen audit parser when we implemented adyen recurring :( [02:16:43] oh nooo [02:17:18] like the inital recurring gets lost? [02:17:35] ahh, i do see a fix to make the initial recurring work [02:18:02] but the audit processor just doesn't understand that the subsequent installments are actually recurring [02:18:07] and so it looks them up wrong [02:18:22] and thinks they're missing from Civi [02:18:38] then it goes digging in the payments logs for redirect lines it's never going to find [02:18:46] ahh i see [02:20:09] looking at the settlement detail report line, I'm not coming up with any good way to tell that it's recurring besides the high number after the . in the order ID [02:20:19] and that's not a definitive sign [02:22:06] (03Merged) 10jenkins-bot: Stop Adyen audit freatking out over Apple Pay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747664 (owner: 10Ejegg) [02:22:17] hmm, it's coding sepadirectdebit as a totally different method from ideal too [02:22:22] which i guess it technically is [02:22:28] yeah it is weird like that [02:23:05] but we send the donations to Civi from the recurring charge job as 'ideal', right? [02:26:13] i know we send sepa to adyen but I guess i dont know how that gets back to us [02:29:06] oops, i tried to use the 'invoice_number' search in the Civi UI and it's still spinning [02:29:13] hope i'm not locking the db [02:29:19] hah we made competing get into smashpig dev patches and neither got merged :P [02:29:56] awww [02:30:30] i was going to just make a test recurring and charge it but then its so complicated [02:30:49] ehhh, easier to look at real data :) [02:31:15] hmm i do have an ideal saved search in adyen [02:31:17] console [02:31:21] i dont know if everyone can see that or just me [02:32:32] I just want to know what we're sending from the recurring job to the queue [02:32:42] i.e. from one part of civi to the other :) [02:32:47] yeah [02:33:17] so cid 15211412 has an ideal recurring [02:33:41] (03PS3) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [02:33:43] (03PS1) 10Eileen: Add error handling and message when render fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 [02:34:04] looks like payment_instrument_id is 9 for all of those [02:34:49] yeah, tagged as iDeal [02:34:57] ok, so the audit processor should do the same [03:10:53] ejegg: woops I figured out what I was looking at that was funny [03:11:09] I had added test code to trigger stuff when I was testing these patches [03:11:22] and that was showing up on my diff, so I thought it was part of the patch to review [03:11:24] sorry!!!!!!!! [03:12:08] ! [remote rejected] HEAD -> refs/for/master%topic=add_year (the number of pushed changes in a batch exceeds the max limit 10) [03:12:17] how do they decide what should be the max? [03:13:08] oh man [03:13:08] based on slower coders than u eileen I guess? [03:13:20] eileen: maybe if you make a new local branch it'll work? [03:13:27] AndyRussG: well it's more that I like smaller commits I think [03:13:35] sorry eileen, i'll try to review some of your stuff tonight! [03:14:02] mmm that was also my plan but have been helping Sofi study for her math final tomorrow [03:14:16] thanks ejegg I've been able to happily test on staging today but that has added a few to the chain... [03:14:23] :) [03:14:49] (03PS4) 10Ejegg: Do not create a job when there is contact id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746015 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [03:15:35] (03CR) 10Ejegg: [C: 03+2] "Looks good! Deletes an exception throw prematurely, but it's one that will go away somewhere down the line." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746015 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [03:19:18] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 3 others: Norwegian Bokmaal rendering in English - https://phabricator.wikimedia.org/T297577 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton... [03:19:24] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) [03:19:27] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 3 others: Norwegian Bokmaal rendering in English - https://phabricator.wikimedia.org/T297577 (10Eileenmcnaughton) [03:21:08] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Set up Civilint in composer scripts - https://phabricator.wikimedia.org/T296636 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [03:27:05] i'mma take a look at the end of the chain to see whether it's worth commenting on things in the first patches [03:28:07] k, so MakeJob does remain, just making the list of emails [03:28:10] (03PS17) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [03:29:15] ejegg: yep - I think this is pretty accurate to the end result - https://wikitech.wikimedia.org/wiki/Fundraising/Internal_Endpoints/End_of_year_emails [03:29:35] ejegg: so I'm inclined right now to +2 the Pending resolver: fraud db integration without detailed smoke testing right at this moment, and then smoke test more later or tomorrow and do a follow-on if actually needed [03:29:36] so far I'm just seeing comments to update [03:29:48] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467 [03:29:52] does that sound ok? [03:29:59] also, any insight on the failing test? [03:30:53] AndyRussG: the test setup uses PaymentsFraudDatabase::get()->storeMessage to store rows in payments_fraud and payments_fraud_breakdown [03:31:22] and then the real code uses the new argument to PaymentsFraudDatabase::getMessageByGatewayOrderId [03:31:35] and both of those are only supported in the new version of SmashPig [03:31:48] so if you just update SmashPig locally that test should pass [03:32:01] ahhh right oki [03:32:25] so something is missing to get the new SP on CI? [03:32:46] that's what WFan was doing in today's call [03:32:50] right [03:32:52] oki [03:32:57] she just hasn't got git-review set up yet [03:33:12] ahhhh oki got it thx for the explanation and apologies [03:33:18] np [03:33:22] my brain is in too many places at once just now... [03:33:31] heh, mine too... [03:33:42] eh we can have a split brain contest [03:33:53] y = mx + b [03:34:05] yay, slope intercept form! [03:34:28] "Inventa las ecuaciones de tres rectas paralelas. Una de ellas debe pasar por el origen." [03:34:37] - Sofi's exam study guide [03:35:03] fortunately last weekend was the last night of algebra and trig en español for me - the suegra has just been awarded her diploma [03:35:23] ohhh ¡¡felicidades!! [03:35:28] :) [03:35:50] here the exam guide is in Spanish but we're studing en inglés [03:35:51] there's still plenty of my wife's English homework to review, and now her cover letter for a part time job :) [03:36:08] ohhhh [03:36:12] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Civi: EOY Auto Thank You Email Receipt - New content is ready for coding - https://phabricator.wikimedia.org/T290253 (10Eileenmcnaughton) I have bee... [03:36:16] ¡suerte! on all counts [03:36:22] thanks! [03:36:47] so anyway I'll start peeking at the next patch now [03:36:52] cool cool [03:38:20] ejegg: re the end of the chain - it's not even all up in gerrit :-( [03:42:29] ejegg: why do we care that $counts['otherDonations'] === 0 ? what is otherContrib about? [03:43:47] 10Fundraising-Backlog, 10FR-Adyen, 10FR-WMF-Audit, 10Recurring-Donations: Adyen audit parser: fix recurring as much as possible - https://phabricator.wikimedia.org/T297856 (10Ejegg) [03:44:26] AndyRussG: the task is to push through new attempts for donors with no refunds, cancellations, or chargebacks [03:44:27] also surprised that the names of tables in the join clauses start with a capital letter, but I guess that's 'cause in fact they're civi entities? (e.g. 'Contribution AS otherContrib', 'LEFT'... [03:44:37] right [03:44:47] so is that what goes in otherContrib? [03:44:49] ah yeah, that's an API4 thing I think [03:45:21] (03PS18) 10Eileen: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) [03:45:23] yeah, otherContrib is all the contributions in a status other than 'Completed' [03:45:23] (03PS5) 10Eileen: Finally fully remove the drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) [03:45:25] (03PS6) 10Eileen: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) [03:45:27] (03PS6) 10Eileen: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) [03:45:29] (03PS4) 10Eileen: Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) [03:45:31] (03PS7) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [03:45:33] (03PS4) 10Eileen: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) [03:45:35] (03PS2) 10Eileen: Remove early return [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747607 (https://phabricator.wikimedia.org/T297159) [03:45:37] (03PS2) 10Eileen: Cleanup on sendLetters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747612 (https://phabricator.wikimedia.org/T297159) [03:45:39] (03PS4) 10Eileen: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) [03:46:06] oh I see thanks ejegg [03:46:49] (03PS2) 10Eileen: Improve UI when contact does not have a valid email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) [03:46:51] (03PS4) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [03:46:53] (03PS2) 10Eileen: Add error handling and message when render fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 [03:46:55] (03PS4) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [03:46:57] (03PS1) 10Eileen: Fix EOYMail sendLetters to handle parse errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 [03:47:03] ok - I think the full chain is up now... [03:47:11] whew [03:47:56] ejegg: I see nothing to gripe about in the final patch there either [03:48:56] though I'm not yet stepping thru that one either just now [03:49:09] great! [03:49:15] yeah thanks so much for all that! [03:49:45] it was a fun puzzle to get that whole lookup in one API call [03:49:52] at a minimum I'll add a "+1" to them this evening (unless I find something that would block, seems unlikely) [03:49:57] cool cool [03:49:58] heheh yeah I can imagine [03:50:06] K [03:50:23] eileen: many apologies also for not being able to do Civi review as I'd planned today [03:50:39] AndyRussG: that's OK - David said what the priorities were [03:53:08] eileen: thx for understanding! [03:56:14] (03CR) 10Ejegg: [C: 03+2] "Looks good! Just found some comments to update - imagine it would be easier at the other end of this patch chain." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:02:30] (03PS1) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [04:07:32] (03Merged) 10jenkins-bot: Stop using job & other legacy fields in eoyEmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:07:58] (03PS2) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [04:08:00] (03PS1) 10Eileen: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 [04:08:49] (03CR) 10Eileen: "OK - I've put up fixes for these" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/745346 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:10:07] (03CR) 10Eileen: "ejegg - we merged an alternate of this didn't we? ( I think there was some patch mess)" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745669 (https://phabricator.wikimedia.org/T297336) (owner: 10Ejegg) [04:10:31] (03CR) 10Ejegg: [C: 03+2] "One more down!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:11:06] whoa, weird eileen, let me look [04:11:37] ahhh [04:11:46] yeah something odd happened in there - we wound up with a merge commit in the mix - but I think the right code went out [04:11:49] I somehow have two change IDs [04:12:29] yeah, the one that got merged has an extra change ID in the footer [04:13:42] somehow my attempt to deduple relationships in the deduper got duplicated [04:13:53] lol [04:14:09] (03Abandoned) 10Ejegg: Deduper: don't duplicate Employee relationships [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/745669 (https://phabricator.wikimedia.org/T297336) (owner: 10Ejegg) [04:20:43] (03PS7) 10Ejegg: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:20:54] (03CR) 10Ejegg: [C: 03+2] "Much simpler!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:22:28] (03Merged) 10jenkins-bot: Finally fully remove the drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746016 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:22:32] (03CR) 10jerkins-bot: [V: 04-1] Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:22:39] eileen: for https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/746020/6 do you think a unique key on year, eamil would be useful? [04:22:59] err email [04:23:10] (03CR) 10jerkins-bot: [V: 04-1] Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 (owner: 10Eileen) [04:32:40] (03Merged) 10jenkins-bot: Simplify calculation of who to email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746019 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:36:07] (03PS7) 10Ejegg: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:37:02] (03CR) 10Ejegg: [C: 03+2] "I had some questions about the single-contact case, but I see that goes away down the line. Do we want to add a unique key to the table fo" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:38:53] (03PS5) 10Ejegg: Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [04:38:58] (03CR) 10Ejegg: [C: 03+2] Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [04:44:42] (03CR) 10Eileen: Alter query to ensure email is unique (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:48:15] (03Merged) 10jenkins-bot: Alter query to ensure email is unique [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746020 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:50:18] (03Merged) 10jenkins-bot: Default year to 'last year' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746032 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [04:51:10] (03PS8) 10Eileen: Separate makeJob from send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) [04:51:12] (03PS5) 10Eileen: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) [04:51:15] (03PS3) 10Eileen: Remove early return [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747607 (https://phabricator.wikimedia.org/T297159) [04:51:16] (03PS3) 10Eileen: Cleanup on sendLetters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747612 (https://phabricator.wikimedia.org/T297159) [04:51:18] (03PS5) 10Eileen: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) [04:51:21] (03PS3) 10Eileen: Improve UI when contact does not have a valid email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) [04:51:23] (03PS5) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [04:51:25] (03PS3) 10Eileen: Add error handling and message when render fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 [04:51:27] (03PS2) 10Eileen: Fix EOYMail sendLetters to handle parse errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 [04:51:29] (03PS5) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [04:54:09] (03PS3) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [04:54:11] (03PS2) 10Eileen: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 [04:54:23] (03CR) 10Ejegg: [C: 03+2] "Definitely a better flow, just might want to add a status check to isJobEmpty" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) (owner: 10Eileen) [04:57:27] (03CR) 10Ejegg: [C: 03+2] Remove early return [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747607 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:58:39] (03CR) 10Ejegg: [C: 03+2] Cleanup on sendLetters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747612 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:59:08] gotta call it quits for tonight [05:02:35] (03PS1) 10Eileen: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) [05:03:31] (03CR) 10Eileen: Separate makeJob from send (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746033 (https://phabricator.wikimedia.org/T279159) (owner: 10Eileen) [05:04:03] thanks ejegg|away [05:15:58] (03CR) 10jerkins-bot: [V: 04-1] Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [07:08:43] (03CR) 10AndyRussG: [C: 03+1] "Hi! This looks great! I haven't finished smoke testing it, though, hence only the +1 so far. :) Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [07:10:09] (03CR) 10AndyRussG: [C: 03+1] "This looks great!!! I haven't fully smoke tested it though, which is why CR is just +1 for now. Thanks!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [08:20:31] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10akosiaris) The problem described by the task (that is forwards from VRTS to donate@ failing) has been resolved. There was a configuration... [13:45:19] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10krobinson) Thanks @akosiaris - this part is indeed solved! I also agree that it makes sense to hand these all over to ITS, if that is... [15:43:31] (03CR) 10Jgleeson: "just a retrospective +2 vote of confidence!" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 (owner: 10Ejegg) [15:45:29] (03CR) 10Jgleeson: "thanks for jumping on this and pushing it out!" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/747603 (owner: 10Ejegg) [16:08:07] 10Fundraising-Backlog, 10fundraising-tech-ops: make frdata inaccesible or delete everything - https://phabricator.wikimedia.org/T297893 (10DStrine) [16:30:43] 10Fundraising-Backlog, 10fundraising-tech-ops: make frdata inaccesible or delete everything - https://phabricator.wikimedia.org/T297893 (10Jgreen) Related tasks T123426, T131413, T86620 [16:35:34] 10Fundraising-Backlog: Update text on frdata - https://phabricator.wikimedia.org/T123426 (10DStrine) 05Open→03Declined [16:36:01] 10Wikimedia-Fundraising: campaign-vs-amount.csv has fundraising campaigns started in 1970-01-01T00:00:00 - https://phabricator.wikimedia.org/T86620 (10DStrine) 05Open→03Declined [16:36:14] 10Fundraising-Backlog: Review campaign conversion rate for public release - https://phabricator.wikimedia.org/T131413 (10DStrine) 05Open→03Declined [16:38:11] (03CR) 10Jgleeson: [C: 03+2] "Looks handy! worked for me locally. Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747649 (https://phabricator.wikimedia.org/T297246) (owner: 10Ejegg) [16:38:49] (03Merged) 10jenkins-bot: Expire pending messages by hours, not just days [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747649 (https://phabricator.wikimedia.org/T297246) (owner: 10Ejegg) [16:39:27] (03CR) 10Jgleeson: [C: 03+2] "looks good and makes sense. thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747215 (owner: 10Ejegg) [16:40:03] (03Merged) 10jenkins-bot: Move fraud action thresholds to provider-defaults [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747215 (owner: 10Ejegg) [16:42:32] cstone: WFan any chance y'all have talked through git-review yet? [16:42:47] was wondering if we could push up those composer changes [16:43:15] not yet shes in PST but feel free to do it we can use something else [16:44:15] jgleeson: ^ [16:47:25] no rush cstone [16:47:31] thanks for the heads up [16:49:45] ejegg: to test this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/747201 I'm gonna mount my DI path (once checked out) to the vendor install dir of DI on CRM and run the existing/current/soon-to-goaway orphan rectifier tests to confirm nothing is broken. I can't think of much else in the way of review for those changes. [16:52:05] jgleeson: ah yeah, that sounds like a good way to do it! [16:52:24] or we could even hold off reviewing that until January [16:53:03] hmm that does sound prudent [16:53:11] let's do that. I'll add a comment [16:53:24] this patch might be more useful in the near term: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/747648 [16:53:48] I guess you could do the same - mount DI in the vendor dir of DI on CRM [16:54:16] then start a PayPal donation, don't sign in at the paypal page, and run the pp orphan rectifier half an hour later [16:54:31] well, with all the queue consumers in between [16:59:08] sounds good. I was also looking at adding a test for your matching donor patch here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/739669 unless you had one in mind already. Looks like AndyRussG has done some review but couldn't smoke test it just yet [16:59:13] ejegg: ^ [16:59:36] TESTS TESTS TESTS!!! [16:59:42] jgleeson: yes please! [17:00:04] sweet [17:02:49] 10Fundraising-Backlog, 10fundraising-tech-ops: make frdata inaccesible or delete everything - https://phabricator.wikimedia.org/T297893 (10DStrine) p:05Triage→03Low [17:08:16] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) a:03Dwisehaupt [17:32:23] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:37:23] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:46:54] (03PS1) 10Ejegg: Adyen: Tag sepadirectdebit as iDeal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747885 (https://phabricator.wikimedia.org/T297856) [17:49:12] (03CR) 10jerkins-bot: [V: 04-1] Adyen: Tag sepadirectdebit as iDeal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747885 (https://phabricator.wikimedia.org/T297856) (owner: 10Ejegg) [17:52:00] (03PS2) 10Ejegg: Adyen: Tag sepadirectdebit as iDeal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/747885 (https://phabricator.wikimedia.org/T297856) [17:57:25] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [18:02:25] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [18:33:34] WFan: we have an IRC-only meeting at this time, in the #fr-tech-alerts channel [18:34:22] Got it, I was in the meeting with Christine haha and she is explaining that to me [18:44:03] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10FR-Paypal: Delete PayPal pending messages more aggressively - https://phabricator.wikimedia.org/T297246 (10Ejegg) [18:44:05] 10Fundraising-Backlog: Investigate why orphan-slayer job is running for hours - https://phabricator.wikimedia.org/T239756 (10Ejegg) [18:46:04] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog: Adyen forms for Euro Bundle - https://phabricator.wikimedia.org/T293292 (10Cstone) a:03Cstone [18:49:02] (03PS1) 10Cstone: WIP: Adding new Adyen countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747897 (https://phabricator.wikimedia.org/T293292) [18:59:02] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/747898 [19:04:52] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/747898 (owner: 10Ejegg) [19:10:21] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/747898 (owner: 10Ejegg) [19:17:27] !log updated standalone SmashPig (IPN listener) from 9e885819 to 235a261b [19:17:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:19:19] (03CR) 10Jgleeson: "Thanks for this. I added a quick thought inline after looking around the code." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [19:22:39] k, that deploy looks fine [19:23:05] nice [19:24:23] cool, i just ran the new --hours 4 job on civi and it deleted almost 10k messages [19:24:37] sweeeet [19:25:09] jgleeson: i feel like we had a good stats push when you created that library, but there are still plenty of things we could be outputting to grafana [19:25:15] like the orphan stats [19:28:48] yeah that feels like an area of the code we'd benefit from some trackable metrics [19:29:41] ok, tailing the slayer logs and grepping for FINAL STATUS I see one timeout in a whole screenful of other FINAL STATUS lines [19:30:30] sounds like progress to me [19:30:44] maybe the paypal job will actually finish tonight! [19:32:12] more metrics, more fun. [19:33:13] more reading of the prometheus docs to remind myself why it works the way it does [19:34:24] ejegg: jgleeson looks like when wenjun was getting her local dev to not fail it lost the changes we did in tech talk yesterday :( [19:34:29] ha. good luck there. each time i read the docs i think i come away 10% smarter and 20% more confused. :) [19:37:23] dwisehaupt: it's not just me then. [19:38:07] oh noes cstone. No worries I can do that now [19:55:21] fr-tech what was the link to add new people to the gerritt repos I think its just a wiki page? [19:58:11] oh yeah cstone I remember that one [19:58:17] seeing it at least [20:06:02] cstone: is this +2 perms? [20:06:05] or just access [20:06:19] I can see WFan in our group on gerrit https://gerrit.wikimedia.org/r/admin/groups/2d819982ec99908ce0c986891033e1728dc38fab,members [20:09:04] its the like thing to add her to projects, when she pushed up a DI change it didn't add any reviewers or anything [20:09:21] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/747902 [20:11:27] found it cstone [20:11:29] https://www.mediawiki.org/wiki/Git/Reviewers [20:11:38] thank you jgleeson ! [20:11:53] https://www.mediawiki.org/wiki/Git/Reviewers#mediawiki/extensions/DonationInterface [20:11:54] np [20:20:59] (03PS1) 10Jgleeson: Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747927 [20:22:51] (03PS17) 10Jgleeson: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [20:22:53] (03PS4) 10Jgleeson: Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [20:34:22] (03PS1) 10Jgleeson: Updates [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/747935 [20:35:26] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747936 [20:35:45] (03CR) 10jerkins-bot: [V: 04-1] Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [20:36:02] oh I thought that update would get that patch passing [20:36:07] let's see why it's still failing [20:36:11] (03CR) 10jerkins-bot: [V: 04-1] Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [20:37:02] Undefined index: user_ip [20:37:14] looks like we've got another hiccup on that test [20:41:32] jgleeson: that deploy commit will require a db update (drush @wmff cvapi Extension.upgrade) - it will only take a second so no impact [20:43:01] (03PS4) 10Eileen: Remove early return [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747607 (https://phabricator.wikimedia.org/T297159) [20:44:35] (03PS4) 10Eileen: Cleanup on sendLetters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747612 (https://phabricator.wikimedia.org/T297159) [20:46:36] oh really eileen. let me add that to the commit [20:46:47] ? [20:46:59] instructions [20:47:11] Oh right - but it's going out now-ish isn't it? [20:47:31] it needs review I think [20:48:39] actually the composer packages update can be +2'd now [20:48:45] (the one to master) [20:49:05] once that's +2'd I could self-merge the one to deployment [20:49:09] and then push that out [20:50:48] ok I see what's wrong with that teast [20:50:54] test even [20:51:19] our PaymentsFraudDatabase fixture doesn't have a 'user_ip' value [20:51:27] so let's add that [20:52:09] (03PS18) 10Jgleeson: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [20:54:22] eileen or ejegg|food if you're happy to +2 composer updates patch to master https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/747927/1 i can then push out the deployment branch which merges in that change and run the extension update as mentioned [20:54:50] I'm wrapping up for the day now so if not I can put it in my end of day [20:54:57] and give folks more time [20:55:17] just gonna hang around to see if the 600=>800 antifraud patch finally passes CI [20:58:44] (03PS6) 10Eileen: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) [20:58:46] (03PS6) 10Eileen: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) [20:58:48] (03PS4) 10Eileen: Improve UI when contact does not have a valid email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) [20:58:50] (03PS6) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [20:58:52] (03PS4) 10Eileen: Add error handling and message when render fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 [20:58:54] (03PS3) 10Eileen: Fix EOYMail sendLetters to handle parse errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 [20:58:56] (03PS6) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [20:58:58] (03PS4) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [20:59:00] (03PS3) 10Eileen: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 [20:59:02] (03PS2) 10Eileen: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) [21:01:48] jgleeson: I took a quick look at the composer update & ran it but I might just wait on ejegg|food [21:02:20] sounds good! [21:02:21] thanks [21:02:33] My instinct is that if it has been already approved elsewhere then a +2 for composer should be straight forward but will wait & chck in [21:05:55] (03PS2) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747936 [21:06:08] just added that db update cmd to the commit [21:07:02] cool - we can deploy that now can't we? [21:07:09] (I can) [21:11:14] eileen: hmm [21:11:39] the composer patch is in the deployment patch [21:12:12] not sure how jenkins will behave if we try to merge a patch to deployment that isn't merged to master? [21:12:18] maybe it will be fine [21:12:37] does that make sense [21:12:43] now I'm confused - oh so vendor was updated on master branch not deployment? [21:13:06] no only the composer files were updated [21:13:13] and they got merged into deployment [21:13:19] with that commit [21:13:33] the vendor update was on deployment [21:13:43] technically the composer files don't matter on deployment I guess? [21:14:34] eileen: checkout out the last commit in the cmt message here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/747936 [21:14:38] and it might make more sense [21:15:15] yayyy the antifraud tests are passing [21:15:28] Ok - so I'm a bit confused now - the composer files aren't merged to master - how did they get merged to deployment? [21:16:10] (03PS5) 10Jgleeson: Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) (owner: 10Ejegg) [21:18:07] eileen: we do the composer install after the merge to deployment [21:18:39] the vendor submodule only exists on deployment [21:19:42] I just wrote up where things are at ejegg in my EOD [21:19:49] thanks jgleeson [21:19:50] I've gotta drop off soon [21:19:58] I'll fix that method name [21:20:25] thanks! sorry if that feels nit picccy [21:20:30] ah, thanks for that antifraud fix [21:21:05] so I'll try to add a test to that donor match thing too [21:21:38] ah ok. I got to looking at the civicrm database records needed [21:21:45] for fixture dta [21:21:48] data [21:21:52] (03CR) 10Ejegg: [C: 03+2] Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747927 (owner: 10Jgleeson) [21:23:08] ok that'll do it. have a good one fr-tech and catch you next week ejegg [21:26:36] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) Thank you very much @akosiaris and @krobinson would love to move those over to ITS as its part of an epic task (to move all the al... [21:26:50] ejegg: yeah - I am still confused tbh - but also happy to let it go :-) [21:34:46] (03Merged) 10jenkins-bot: Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747927 (owner: 10Jgleeson) [21:36:35] (03CR) 10Ejegg: [C: 03+2] Updates [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/747935 (owner: 10Jgleeson) [21:44:16] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) 05Open→03Resolved a:03Dzahn optimistcally calling resolved based on previous comments [21:47:10] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Updates [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/747935 (owner: 10Jgleeson) [21:48:30] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747936 (owner: 10Jgleeson) [21:48:55] eileen: I'm going to deploy that, ok? ^^^ [21:49:05] ejegg: yep [21:49:23] it just needs the db update per the commit [21:49:27] got it [21:51:09] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/747936 (owner: 10Jgleeson) [21:51:49] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE: move donation,donate, donations (otrs, wikimania) exim aliases from SRE to ITS - https://phabricator.wikimedia.org/T297915 (10Dzahn) [21:52:18] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: move donation,donate, donations (otrs, wikimania) exim aliases from SRE to ITS - https://phabricator.wikimedia.org/T297915 (10Dzahn) [21:53:56] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) >>! In T297307#7574634, @akosiaris wrote: > I am inclined to resolve this task, but I think there might be a followup action item... [21:55:47] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) P.S. Since you are all here. There is also open ticket T252932 which is called "Forwarding or alias for fundraising@" and you can... [22:04:23] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) a:05Dzahn→03None [22:13:15] !log updated fundraising CiviCRM from d4cea6a9 to 07efd9fb [22:13:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:14:17] argh, The following module is missing from the file system: wmf_eoy_receipt. [22:14:28] I'mma just roll that back quick to disable it [22:14:36] somehow it was still enabled on live [22:15:55] oh weird, no, it was disabled [22:16:03] why was it complaining then? [22:18:29] boo, still complaining [22:18:39] oh well [22:19:25] has no row in drupal.system [22:19:36] wmf_reports does though, let's just get rid of that [22:21:48] k, database update is complete [22:24:38] (03CR) 10Ejegg: "Looks like the EOYEmailTest setup still depended on the single contact ID calculation you remove here." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:25:32] (03PS7) 10Ejegg: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:25:38] (03CR) 10Ejegg: [C: 03+2] Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:34:02] (03PS7) 10Ejegg: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:34:48] (03CR) 10Ejegg: [C: 03+2] "Faithfully moves the functionality over. Couple of suggestions inline for where clause refinements." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:36:02] (03PS5) 10Ejegg: Improve UI when contact does not have a valid email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:36:11] (03CR) 10Ejegg: [C: 03+2] "Nice sanity check" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:36:57] (03Merged) 10jenkins-bot: Fix bug where no language was falling back to first translation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/746992 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:37:00] whoa, i hadn't noticed that new bit of php 7.1 syntax [22:37:07] catch( AError | BError $e ) [22:37:13] nice [22:47:24] (03Merged) 10jenkins-bot: Fold EOYSummary class into Send class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747613 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:48:44] (03Merged) 10jenkins-bot: Improve UI when contact does not have a valid email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747625 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:09:42] (03PS7) 10Eileen: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) [23:09:44] (03PS5) 10Eileen: Add error handling and message when render fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 [23:09:46] (03PS4) 10Eileen: Fix EOYMail sendLetters to handle parse errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 [23:09:48] (03PS7) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [23:09:50] (03PS5) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [23:09:52] (03PS4) 10Eileen: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 [23:09:54] (03PS3) 10Eileen: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) [23:32:53] (03CR) 10jerkins-bot: [V: 04-1] Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:33:12] (03CR) 10jerkins-bot: [V: 04-1] Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 (owner: 10Eileen) [23:34:39] ejegg: I'll check out that fail now [23:35:09] (03CR) 10jerkins-bot: [V: 04-1] Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [23:37:19] (03PS6) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [23:46:53] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) [23:47:09] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) Yubikey request made by Dylan. [23:58:54] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt)