[00:20:58] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising-tech-ops: Document Ingenico integration - https://phabricator.wikimedia.org/T291874 (10Ejegg) Added a bit to the overview and card donor flow, and added a card API calls section with deta... [00:23:04] (03PS5) 10Eileen: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 [00:23:06] (03PS4) 10Eileen: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) [00:37:22] (03CR) 10Ejegg: [C: 03+2] "Thanks for bringing this new PHP syntax to my attention!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:48:57] (03Merged) 10jenkins-bot: Also catch CRM_Core_Exception [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747626 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [00:54:09] (03CR) 10Ejegg: [C: 03+2] "Good to have this handling! Message runs a couple of words together, but given that the problem it warns about is fixed in a subsequent pa" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 (owner: 10Eileen) [00:56:14] (03PS1) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [00:57:51] (03CR) 10Ejegg: [C: 04-1] "Let's sanitize those emails better in the SQL" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 (owner: 10Eileen) [00:58:00] (03PS2) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [00:58:43] ejegg: I haven't got an idea of how to do ^^ without doing some pretty deep digging at this stage because they are coming out of civicrm internal token system [00:59:13] eileen: the emails in that failure list? [00:59:28] ah - re-reading - its' just that part - ok [00:59:43] I was thinking the next patch in the chaing [01:00:16] ah yeah, I was hoping there's some Civi util for formatting a list of strings for sql [01:03:24] hmm, not really seeing it though [01:04:57] I think I can pass as a param - just trying to test [01:05:01] BaseParamQuery::interpolate seems to try [01:05:32] ah yeah, it just maps the array through BaseParamQuery::escapeString [01:05:49] yep [01:05:54] which calls CRM_Core_DAO::escapeString [01:06:08] (03PS5) 10Eileen: Fix EOYMail sendLetters to handle parse errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 [01:06:13] every time i successfully rebase on a branch that has been sitting around for a while, i think i deserve a celebration cake. [01:06:19] the change I pushed up should be the fix - just trying to test tho [01:06:28] dwisehaupt: you do deserve one! [01:06:39] yay dwisehaupt [01:07:08] now i need to keep the branch up to date so i can actually roll the changes in january and i don't have to rebase all over again. :) [01:08:07] ohhh, there's even CRM_Code_DAO::escapreStrings that builds the whole list for you [01:08:15] *escapeStrings [01:08:36] yep that worked [01:08:41] nice [01:09:31] interesting that it uses dblquotes and not sql-standard single [01:09:54] (03CR) 10Eileen: Fix EOYMail sendLetters to handle parse errors (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 (owner: 10Eileen) [01:10:17] (03Merged) 10jenkins-bot: Add error handling and message when render fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 (owner: 10Eileen) [01:10:19] thanks! [01:10:52] (03CR) 10jerkins-bot: [V: 04-1] Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [01:15:17] (03CR) 10Ejegg: "I have doubts about this way" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 (owner: 10Eileen) [01:16:37] (03CR) 10Eileen: Fix EOYMail sendLetters to handle parse errors (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 (owner: 10Eileen) [01:23:00] (03PS8) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [01:23:02] (03PS7) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [01:23:04] (03PS6) 10Eileen: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 [01:23:06] (03PS5) 10Eileen: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) [01:23:08] (03PS3) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [01:23:58] (03PS4) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [01:25:52] (03PS5) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [01:27:00] (03CR) 10Ejegg: [C: 03+2] "OK, let's get rid of the implode at the end of the chain" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 (owner: 10Eileen) [01:28:43] (03PS1) 10Eileen: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 [01:29:22] (03CR) 10Eileen: "fix added for the space issue https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/747988" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747666 (owner: 10Eileen) [01:37:00] (03CR) 10jerkins-bot: [V: 04-1] Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [01:37:16] (03CR) 10jerkins-bot: [V: 04-1] Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [01:38:57] (03Merged) 10jenkins-bot: Fix EOYMail sendLetters to handle parse errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747671 (owner: 10Eileen) [01:40:16] (03CR) 10jerkins-bot: [V: 04-1] Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 (owner: 10Eileen) [01:40:42] (03PS2) 10Eileen: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 [01:53:31] (03CR) 10jerkins-bot: [V: 04-1] Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 (owner: 10Eileen) [02:05:11] (03CR) 10Ejegg: [C: 04-1] "This stops the single quotes causing problems, but it also breaks the check for first + last name. Maybe just replace the single quotes ar" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:05:51] eileen: I tried giving my T'Test user no last name and the first name still showed up in the email [02:08:06] hmm [02:08:30] I'll give it another go [02:09:02] that one was last in the chain - but I added more - but I think they can be rebased directly onto master [02:09:19] k, i'll rebase the easy ones [02:09:38] (03PS7) 10Ejegg: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 (owner: 10Eileen) [02:09:53] (03PS8) 10Ejegg: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 (owner: 10Eileen) [02:10:00] (03CR) 10Ejegg: [C: 03+2] Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 (owner: 10Eileen) [02:10:24] (03PS6) 10Ejegg: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:10:32] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:12:38] oops, the contactids check got added to the error message spacing patch instead of its parent [02:21:39] (03Merged) 10jenkins-bot: Fix upgrade comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747676 (owner: 10Eileen) [02:22:58] (03Merged) 10jenkins-bot: Check status when checking if job is empty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747679 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:30:14] (03PS9) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [02:30:16] (03PS8) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [02:30:18] (03PS6) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [02:30:20] (03PS3) 10Eileen: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 [02:30:26] just another rebase :-) [02:31:29] (03PS9) 10Eileen: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) [02:31:31] (03PS7) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [02:31:33] (03PS4) 10Eileen: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 [02:31:35] (03PS10) 10Eileen: Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) [02:41:33] (03CR) 10jerkins-bot: [V: 04-1] Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:41:42] (03CR) 10Ejegg: [C: 03+2] Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:43:51] (03CR) 10jerkins-bot: [V: 04-1] Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [02:44:15] (03CR) 10jerkins-bot: [V: 04-1] Handle quotes in tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747638 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [02:44:19] (03CR) 10jerkins-bot: [V: 04-1] Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 (owner: 10Eileen) [02:45:59] (03PS8) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [02:47:21] (03PS9) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [02:47:23] (03PS5) 10Eileen: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 [02:52:36] (03Merged) 10jenkins-bot: Clean up MakeJob [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747673 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [03:11:58] (03PS19) 10Ejegg: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [03:12:00] (03PS1) 10Ejegg: Fixes for Resolve tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 [03:13:28] (03CR) 10jerkins-bot: [V: 04-1] Fixes for Resolve tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 (owner: 10Ejegg) [03:14:17] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 (owner: 10Ejegg) [03:30:12] (03PS2) 10Ejegg: Fixes for Resolve tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 [03:30:34] ejegg: I'm heading out for the day now - but this is the only significant one left https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/747984 & then I'm gonna look at the escaping one again [03:36:17] yep, the one-by-one patch looks pretty good to me [03:36:24] I just want to step through it locally [03:36:43] and i want to gety a donor match test written [03:41:33] (03CR) 10jerkins-bot: [V: 04-1] Fixes for Resolve tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 (owner: 10Ejegg) [03:48:59] (03PS3) 10Ejegg: Fixes for Resolve tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 [04:24:57] (03PS6) 10Ejegg: Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) [04:37:20] (03PS7) 10Ejegg: Add donor matching to pending txn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/739669 (https://phabricator.wikimedia.org/T291226) [04:48:57] (03CR) 10Ejegg: [C: 04-1] "Whew, what a long strange trip it's been! The loop exit condition probably needs a fix, the $this->failed just looks funny now, and there'" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [04:53:50] (03CR) 10Ejegg: [C: 04-1] Switch up flow - render, email & save per row (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [04:57:54] (03PS10) 10Eileen: Switch up flow - render, email & save per row [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 [04:59:59] (03CR) 10Eileen: Switch up flow - render, email & save per row (033 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747984 (owner: 10Eileen) [07:46:26] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: move donation,donate, donations (otrs, wikimania) exim aliases from SRE to ITS - https://phabricator.wikimedia.org/T297915 (10akosiaris) p:05Triage→03Medium [07:47:22] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: move donation,donate, donations (otrs, wikimania) exim aliases from SRE to ITS - https://phabricator.wikimedia.org/T297915 (10akosiaris) 05Open→03Stalled Thanks for creating this followup ticket. Stalling until early Janua... [12:52:27] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10akosiaris) >>! In T297307#7576437, @Dzahn wrote: >>>! In T297307#7574634, @akosiaris wrote: >> I am inclined to resolve this task, but I... [14:39:52] (03CR) 10Jgleeson: [C: 04-1] "Thanks Dami and Ejegg for the work on this. Looking good so far! I just had a question about newer score data and a test name that I added" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [14:40:06] (03CR) 10Jgleeson: Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [14:40:32] (03CR) 10Jgleeson: [C: 04-1] Pending resolver: fraud db integration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/743467 (https://phabricator.wikimedia.org/T291223) (owner: 10Damilare Adedoyin) [14:41:25] (03CR) 10Jgleeson: [C: 03+2] "Thanks for spotting this and fixing it!!! much appreciated." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747992 (owner: 10Ejegg) [15:59:36] 10Fundraising-Backlog: Add "one-time" to header on One-time Payments Wiki - https://phabricator.wikimedia.org/T269897 (10HNordeenWMF) hi @DStrine as we come into endowment time for banners: might this be a possibility? Or is it too risky to change on payments during the campaign. [16:38:09] fr-tech I've gotta pop our for a couple of hours so I won't make standup, sorry! My update today so far is no blockers and I've mostly been looking 600=>800 review around some failmail diggig [16:39:03] back later! [16:50:34] hey jgleeson|away! I'm also kinda logistically challenged today (though probably will make Standup), just hope we can sync up on your -1 CR on this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/743467 before u head out? thx! [16:56:59] 10Fundraising-Backlog: Add "one-time" to header on One-time Payments Wiki - https://phabricator.wikimedia.org/T269897 (10DStrine) I don't think this is likely to get out before the Christmas break more due to payments priorities for Q3 than anything else. But sometimes people are looking to shift hours on holida... [18:47:02] eyener2-0: fix your client please and thank you [19:33:26] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: move donation,donate, donations (otrs, wikimania) exim aliases from SRE to ITS - https://phabricator.wikimedia.org/T297915 (10Dzahn) [19:33:50] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: Forwards from VRT not making it to donate@ - https://phabricator.wikimedia.org/T297307 (10Dzahn) Ok, thanks! Done. I merged the tickets into one.