[00:21:57] (03PS1) 10Jgleeson: Covert UTC dates to timestamps in PaymentsFraudDatabase db fetch method. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748843 [00:22:03] looking jgleeson [00:22:18] thanks [00:24:16] that should fix it for us for now, but maybe we should update storeMessage as well [00:25:12] just going to fix that linebreak in the commit message [00:25:24] (03PS2) 10Ejegg: Covert UTC dates to timestamps in PaymentsFraudDatabase db fetch method. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748843 (owner: 10Jgleeson) [00:26:09] commit msg length paranoia [00:26:18] ejegg: is storeMessage new ? [00:26:27] I didn't realise it was [00:26:32] (03CR) 10Ejegg: [C: 03+2] "Looks good! Later let's update storeMessage to reformat the other way (and do the rest of the things that antiFraudQueueConsumer does)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748843 (owner: 10Jgleeson) [00:26:51] jgleeson: storeMessage is only ever used in tests so far [00:26:59] ah I see [00:27:01] (03Merged) 10jenkins-bot: Covert UTC dates to timestamps in PaymentsFraudDatabase db fetch method. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748843 (owner: 10Jgleeson) [00:27:05] but it's a good candidate to replace a bunch of drupal code in the future [00:27:25] k, will tag another patch version [00:27:29] thanks! [00:27:37] thank you for the late night fix! [00:27:48] oh man, it's after midnight for you [00:27:49] almost at the finish [00:28:00] * jgleeson hopes [00:29:18] wat [00:29:25] - wikimedia/donation-interface v2.5.7 requires wikimedia/smash-pig ^0.7 -> found wikimedia/smash-pig[v0.7.0, ..., v0.7.8.1] but it conflicts with your root composer.json require (0.7.8.2) [00:29:39] so it lets you do one patch release but not two? [00:29:39] huh [00:30:14] oh wait, that update didn't take on the packagist side yet [00:30:59] hah, after packagist.org gets the update, composer no longer complains about a version conflict [00:31:04] that seems... spooky [00:31:18] yeah I'm surprised at that [00:31:33] (03PS1) 10Ejegg: Update SmashPig to v0.7.8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748844 [00:31:37] (03CR) 10Ejegg: [C: 03+2] Update SmashPig to v0.7.8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748844 (owner: 10Ejegg) [00:32:12] (03PS1) 10Ejegg: Update SmashPig to v0.7.8.2 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/748845 [00:32:15] (03CR) 10Ejegg: [C: 03+2] Update SmashPig to v0.7.8.2 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/748845 (owner: 10Ejegg) [00:32:20] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update SmashPig to v0.7.8.2 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/748845 (owner: 10Ejegg) [00:32:40] I wonder what the pending queue is looking like [00:32:58] heh, shall we run a regular orphan slayer first? [00:33:22] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/748846 [00:33:25] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/748846 (owner: 10Ejegg) [00:33:35] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update SmashPig to v0.7.8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748844 (owner: 10Ejegg) [00:33:43] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/748846 (owner: 10Ejegg) [00:34:17] k, forced a couple of those thru, about to redeploy [00:34:45] only 99 [00:34:47] not too bad [00:35:14] !log updated fundraising CiviCRM from 2826afc3 to e1ffa75a [00:35:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:35:22] k, let's try running some more [00:35:29] !!! [00:36:41] k, just got another completed, let's see if this one was actually completed here in the resolver [00:36:48] txn id 115259681.1 [00:36:57] just saw that one [00:37:03] in the p-c logs [00:37:13] nice :) [00:37:52] hmm, but this one also has the TY sent more than a half hour ago [00:38:02] like 90 minutes [00:38:09] ok, so not newly captured [00:38:44] 115259626.1 complete too [00:39:31] ...and also had ty sent a while back [00:39:47] Why the heck were these still in the pending table??? [00:39:47] how does that happen? [00:40:09] oh, we're querying already closed trxns [00:40:12] the donations QC seriously should be deleting these [00:40:32] can we cross reference those ids with the dqc logs [00:41:38] hmm I don't see 115259626.1 in dqc logs [00:41:58] yeah, those logs are looking a bit funny [00:42:01] or any other logs for that matter [00:42:25] oh, the logs on ../remote have rolled over the day since these went into civi [00:42:39] so you have to zgrep through yesterday's files [00:44:56] got it [00:45:13] 115260733.1 also came through the pending resolver, also has ty sent a while ago [00:45:14] /srv/archive/civi1001/process-control/20211220/donations_queue_consume_sleepy-20211220-230202.log.civi1001.bz2 hits: 3 [00:45:32] ahh right, the other qc run [00:46:43] grr [00:46:53] i know i've seen this work locally [00:47:16] right, even when AndyRussG was screensharing the other day, we saw the pending message disappear after the donations qc [00:47:41] the code looks solid, just depends on the order_id and gateway [00:48:18] ejegg: jgleeson available to help out if needed btw [00:48:50] (just back at the keyboard from a much-needed nap and then walking the dog) [00:48:52] yeah I'm pretty sure qdc does it's thing with pending msgs [00:48:54] jgleeson: it's super late for u! [00:49:12] jgleeson: i just did a non-slow-start and it resolved 131, [00:49:32] nice! [00:49:34] hmm, we really do need to get some linebreaks in those civi logs [00:49:55] ah, let me check to make sure it stopped when it got the the half-hour-old mark [00:51:12] trust me AndyRussG ... we don't do this often :) [00:52:00] hmm, it stopped at 1640042831, more than an hour and 20 minutes old [00:52:16] ohhh, it's still using the timeLimit 25 [00:52:19] meaning 25 seconds [00:52:28] ah yeah that needs to be 1500 [00:53:32] eileen: Should those Civi::log lines need explicit \n linebreaks at the end of them? [00:53:46] I'll update that p-c job [00:54:14] eileen: in the stdout output they seem to be all on one lonnnnng line [00:54:23] which makes grepping problematic [00:55:04] hmm - probably we can fix in monolog - where are they coming from? / outputting to [00:55:37] pushed [00:56:12] eileen: coming from the new pending transaction resolver [00:56:22] outputting to stdout and to process-conrol logs [00:56:45] also it would be nice to get the output as it's written [00:56:56] rather than just dumping it all at the end of the API call [00:57:03] ok - I'll take a look once I've wrapped this up [00:57:04] but I guess that might be trickier [00:57:25] jgleeson: maybe we just turn the old job back on and finish this off tomorrow? [00:58:05] what's outstanding, the logs? [00:58:19] that timeLimit update is pushed to localsettings [00:58:23] yep, maybe just the logs [00:58:40] the logs aren't urgent are they? [00:58:40] thanks for pushing that! [00:59:17] eileen: I'm trying to verify the output and I'm not sure how I'm going to find the txns that actually get resolved by the new process without being able to grep the logs [00:59:26] so we can definitely keep running the old job [00:59:28] mm [01:00:06] well, maybe I can do some grep -o stuff [01:00:27] ejegg: also you could just add the line break to the civi::log for now - even if we hope we can remove in a bit [01:02:29] I'mma try just adding a \n to the LineFormatter in MonologManagfer::addStdOutLogger [01:03:09] cool [01:05:27] ejegg: checkout that payments initial failmail [01:05:33] we might have missed something else [01:05:49] oops [01:06:09] ok, let's definitely turn the old job back on for now [01:06:13] yeah I agree [01:06:23] it was a good first test [01:06:27] yep yep [01:06:38] thanks jgleeson ! [01:07:58] I'll pick what you don't get to tomorrow. have a good one fr-tech [01:08:52] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Donations QC seems to leave some pending rows it shouldn't - https://phabricator.wikimedia.org/T298067 (10Ejegg) [01:14:23] well, the good news is that it really did resolve that pending txn and send it to Civi [01:17:13] i turned the old job back on [01:18:46] ok cool [01:22:05] ejegg|food: I've just updated the EOY jobs (obviously still disabled) [01:41:11] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 4 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10Eileenmcnaughton) Moving this to review as I have 1) u... [01:42:06] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Tech talk on EOY receipt email - https://phabricator.wikimedia.org/T291572 (10Eileenmcnaughton) I think we covered this.... [02:17:52] whoa I just had a freak out about emails leaking on EOY - but it really was it merging same-email contacts [02:34:22] but there IS a bug - 2 separate activities rather than 1 activity linked to 2 contacts [02:35:32] actually that might be unchanged but wrong (IMHO) [02:47:21] hmmm [03:01:21] (03PS1) 10Eileen: EOY Email - create 1 activity per email. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748888 (https://phabricator.wikimedia.org/T297159) [03:12:30] (03CR) 10jerkins-bot: [V: 04-1] EOY Email - create 1 activity per email. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748888 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [03:26:15] (03CR) 10AndyRussG: Stop processing when PaymentActionNotInitiated (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747648 (https://phabricator.wikimedia.org/T205566) (owner: 10Ejegg) [03:32:55] (03PS1) 10Ejegg: Add newlines for StdOut logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748889 [03:37:14] (03PS2) 10Ejegg: Stop processing when PaymentActionNotInitiated [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747648 (https://phabricator.wikimedia.org/T205566) [03:37:28] AndyRussG: added that comment ^^^ [03:37:38] ejegg: cool thx! [03:38:17] lmk if priorities of stuff to review/work on have changed following deploy/rollback? [03:38:59] well, I just need to fix one thing with the payments-init message [03:39:15] (and add it to the test) [03:40:10] then that'd be nice to get review on! [03:54:26] ejegg: oki sure yee I'm around [04:03:47] (03PS1) 10Ejegg: Fix queue messages for pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 [04:03:55] AndyRussG: ^^^ is the queue fix [04:04:14] oki [04:14:30] (03CR) 10jerkins-bot: [V: 04-1] Fix queue messages for pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (owner: 10Ejegg) [04:19:24] oops, missed that test [04:21:03] (03PS2) 10Ejegg: Fix queue messages for pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 [04:36:27] ejegg: is there a Phab bug for that? Doesn't look like T298067 [04:36:27] T298067: Donations QC seems to leave some pending rows it shouldn't - https://phabricator.wikimedia.org/T298067 [04:36:46] AndyRussG: nope, just something we found when testing after deploy [04:38:21] ejegg: it's what required the rollback? should I look at back(sc)roll? [04:38:47] we didn't roll back a deploy, we just turned the old job back on [04:39:13] but yeah, the missing payments-init key means we couldn't go to the new job [04:39:31] also I want to fix the log formatting: https://gerrit.wikimedia.org/r/748889 [04:40:57] oki [04:41:31] right I see it's what was mentioned in ur e-mail reply to the failmail [04:42:35] ejegg feel like it's worth either make a new task and tag that or, perhaps quicker, just add a bug tag from whatever Phab this would be a follow-on to? [04:44:05] I'll tag the initial resolver task [04:45:11] (03PS3) 10Ejegg: Fix queue messages for pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (https://phabricator.wikimedia.org/T291223) [04:48:38] thx!! [04:54:42] (03CR) 10Ejegg: [C: 03+2] "This does the trick! And for most of our donors I'm guessing the apostrophes are in last names, so there will be no change at all in the r" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/748834 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [04:55:22] (03PS7) 10Ejegg: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 (owner: 10Eileen) [04:55:30] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 (owner: 10Eileen) [04:57:54] ok, I'm going to head to bed [04:59:11] ejegg|away: cya! [05:05:58] (03Merged) 10jenkins-bot: Handle single quote in name [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/748834 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [05:07:24] (03Merged) 10jenkins-bot: Fix error message spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/747988 (owner: 10Eileen) [05:46:10] (03PS1) 10Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748894 [05:46:24] (03CR) 10Eileen: [C: 03+2] CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748894 (owner: 10Eileen) [05:46:58] (03PS3) 10Eileen: Add unit test for single quote in name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748833 (https://phabricator.wikimedia.org/T297159) [05:47:00] (03PS2) 10Eileen: EOY Email - create 1 activity per email. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748888 (https://phabricator.wikimedia.org/T297159) [05:53:52] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/748945 (owner: 10L10n-bot) [05:58:11] (03Merged) 10jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748894 (owner: 10Eileen) [05:59:02] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748833 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [06:34:23] (03CR) 10AndyRussG: [C: 03+2] "Yaaa lgtm!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748889 (owner: 10Ejegg) [06:45:22] (03CR) 10AndyRussG: [C: 03+2] "Cool!! Smoke tested consuming the generated message in payments-init, works great! Thanks for this!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [06:45:54] (03Merged) 10jenkins-bot: Add newlines for StdOut logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748889 (owner: 10Ejegg) [06:50:41] (03CR) 10AndyRussG: [C: 03+2] Fix queue messages for pending resolver (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [06:56:42] (03Merged) 10jenkins-bot: Fix queue messages for pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [15:02:45] (03PS1) 10Jgleeson: Fix test for paymentsInit message check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749188 (https://phabricator.wikimedia.org/T291223) [15:14:22] (03CR) 10Jgleeson: "Thanks for finding that missing 'server' key! I feel like it would be better to change this patch slightly and modify the payments-init me" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [15:14:24] (03CR) 10jerkins-bot: [V: 04-1] Fix test for paymentsInit message check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749188 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [15:19:00] (03CR) 10Jgleeson: Fix queue messages for pending resolver (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748891 (https://phabricator.wikimedia.org/T291223) (owner: 10Ejegg) [15:31:51] Happy solstice :) [15:32:11] :) [15:32:35] how's it goin greg-g ? [15:44:48] hi fr-tech jgleeson greg-g :) [15:44:53] thanks greg-g, same! [15:47:48] howdy AndyRussG! [15:49:11] jgleeson: hi :) really sorry if I was too quick on the +2 with that queue messages for pending resolver patch, I should have waited for you to give feedback...! I can look at possible follow-ons any time [15:52:02] hey AndyRussG no worries. ejegg|away's change highlghted that the original test wasn't working as expected so it was a good catch [15:52:39] I don't like using fancy php comparison fns in test assertions typically [15:52:54] they can't be trusted [15:53:02] ahh hehe never trust a test you haven't seen fail ;p [15:53:12] so I've heard anyway [15:53:49] yeah so I think the existing test still made sure we had at least the 18 or so properties defined as expected but it ignored any new ones! which isn't great [15:54:27] ah right [15:55:18] I'm not sure why we're using both 'source_host' and 'server' on queue messages since they hold the same value. I'm guessing the 'server' key predates the source_* fields [15:56:56] it's great that we're gonna get all this work out before the break [15:57:26] yeah agreed :) [16:37:37] Hi fr-tech [16:52:50] hey cstone :) [17:12:24] jgleeson: it's going well. Still on break. :) [17:13:00] I had a message composed but forgot to hit enter yesterday after waving of something like "glad to hear the good news from last week and hope ya'll have a decent week" [17:20:16] ah sorry greg-g I wasn't aware you were on holiday or I wouldn't have pinged! :) [17:20:31] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10jgleeson) Thanks for digging in here and I'm glad they were useful! WRT to the points on the diagram: >>! In T295926... [17:23:17] enjoy your break! [17:26:04] jgleeson: no, no worries, I can handle it :) [17:26:07] thanks! [17:52:51] (03CR) 10Ejegg: "OK AndyRussG, I've added a comment explaining that conditional" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747648 (https://phabricator.wikimedia.org/T205566) (owner: 10Ejegg) [17:54:53] fr-tech there's a fundraising-dev patch here to use the latest images from dev-images: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/742581 [17:55:18] That includes the change we need to get SmashPig IPN listener working via the proxy [17:58:03] ejegg: have the images been pushed to the registry? [17:58:29] yes AndyRussG [18:05:18] oops, sorry, there is one missing AndyRussG [18:05:28] I'll ask releng to push it [18:08:57] ejegg: ah cool thx! [18:10:25] btw, looks like you can query with cURL [18:10:32] curl https://docker-registry.wikimedia.org/v2/dev/fundraising-smashpig-buster-php73-apache2/tags/list [18:10:37] {"name":"dev/fundraising-smashpig-buster-php73-apache2","tags":["0.0.1-1-s1","0.0.1-1-s2","0.0.1-1","latest"]} [18:11:04] (03PS2) 10Jgleeson: Add 'server' key to payments-init message test and fix array_diff_key usage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749188 (https://phabricator.wikimedia.org/T291223) [18:11:18] looking jgleeson [18:11:27] thanks ejegg [18:12:00] just a heads up, when I run the unit tests now I see "civicrm.wmf.WARNING: CVV score mismatch for order_id order-1778913714. Front end score 80.0, pending resolver score 50. Please check that cvv_map settings are consistent" being written to stdout in the middle of phpunit output [18:12:46] hehe, i guess that's working! [18:13:09] though it would be prettier to leave that consistent [18:13:18] or do something to redirect the logs during tests [18:13:24] like with do with donationinterface tests [18:16:51] jgleeson: let's keep checking for the keys of the donations queue message somewhere! [18:17:22] looks like your patch deletes that check and doesn't move it anywhere [18:17:35] (lines 175-192) [18:18:21] oh rly! sorry I thought that was duplicated [18:18:25] let me add that back [18:20:09] (03PS3) 10Jgleeson: Add 'server' key to payments-init message test and fix array_diff_key usage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749188 (https://phabricator.wikimedia.org/T291223) [18:21:09] good call checking for those keys. I guess we were a little too relaxed about the contents of the donation message [18:21:27] but then decided to check the payments-init ... [18:21:58] yeah, I just noticed the extra gateway_session_id that shouldn't actually get sent to the donations queue and decided to add that test [18:22:34] later we can try making a more fleshed out pending message with all the utm_ bells and whistles and add those to the message [18:23:16] but I was thinking it might be nice for some SmashPig test class to have functions to verify well-formedness for various types of queue messages [18:23:21] including date formats, etc [18:23:40] so we could use those functions in tests all through the stack [18:24:33] yeah good idea [18:25:48] this also got me thinking about how our current tests don't really give us coverage of the ancillary processes triggered on the back of the pending trxn resolver running [18:26:18] which is why we ran into the afqc and pqc failures [18:27:15] maybe we should try to write tests for other areas that use data from new processes as part of the overall all testing effort [18:28:03] so many tests so little time [18:29:04] other teams at the foundation have test engineers right? [18:31:31] I've worked on teams with them before although they didn't tend to write unit tests, that was still an engineering task. That role was more about writing acceptance tests and was closer to a technical business analyst [18:31:53] not sure how we do things at wmf though! [18:32:44] cstone: was your interviewing partner a test engineer? [18:32:54] yep [18:33:49] he worked with two teams [18:33:50] works [18:33:52] did he mention the types of tests he was responsible for in his day to day? [18:34:02] i think all JS stuff and iOS app maybe [18:34:08] ah ok [18:36:12] (03CR) 10Ejegg: [C: 03+2] Add 'server' key to payments-init message test and fix array_diff_key usage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749188 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [18:36:13] good that we have them tho! [18:36:20] thanks ejegg ! [18:36:30] looks good jgleeson! Do you want to prep the deploy when that merges? [18:36:43] sure. brb [18:36:48] I think there's a civicrm submodule update too, for one last EOY patch from eileen [18:42:56] back [18:43:06] mr fox had eaten all the vegetables ! [18:43:22] according to Tilly [18:44:44] https://en.wikipedia.org/wiki/Peter_Rabbit [18:48:19] (03Merged) 10jenkins-bot: Add 'server' key to payments-init message test and fix array_diff_key usage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749188 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [18:57:18] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749253 [19:02:14] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749253 (owner: 10Jgleeson) [19:11:20] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749253 (owner: 10Jgleeson) [19:15:28] AndyRussG: dancy just published that missing smashpig image [19:18:14] ejegg: ah fantastic thx! [19:18:30] also btw thx for adding the comment on the paypal di-as-a-lib fix... just smoke testing now [19:23:44] ok fr-tech the fixes for the 600=>800 and process-control config to switch off the existing orphan rectifier have just been deployed [19:23:58] I'm gonna run `run-job -j ingenico_pending_resolver --slow-start` now to test one out [19:24:03] nice jgleeson [19:26:06] first 5 'pending' lol [19:26:07] (03PS2) 10Wfan: Add more Euro countries to adyen cc amex and mc [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/748573 (https://phabricator.wikimedia.org/T293292) [19:26:27] congrats on your first patch WFan woot woot ! [19:26:29] well at least those log lines look better! newlines at the end of each instead of one looooooooong line [19:27:20] we got a complete! [19:27:24] nice [19:27:31] 115453252.1 [19:27:38] I'm gonna check the queues [19:27:39] so let's see if it's one of those that should have been deleted [19:27:46] ah yeah [19:27:51] grr [19:28:00] at this point I think we can run a non-slow-start [19:28:24] @_@ [19:28:41] ok here goes [19:29:31] 144 resolved! [19:29:35] cool cool [19:29:45] those log lines look better [19:31:02] 115458470.1 seems to be new! [19:31:08] yay [19:31:15] 17 completed out of that bunch [19:33:38] ejegg jgleeson what is the consumer that will call the DI function where the changes to paypal processResponse() for this change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/747648/ ? is it the old orphan rectifier? [19:34:23] AndyRussG: it's the old orphan slayer [19:34:34] lemme see [19:38:11] yeah I think all batch processor calls come in via the slayer/rectifier right? [19:38:37] so how is that run specifically? [19:38:37] haha Thanks jgleeson :) [19:38:42] AndyRussG: might be worth running the old orphan slayer tests and dropping in a break point there to see the call stack that gets you there [19:38:45] drush orphan-slayer paypal_ec [19:39:04] ejegg: he'll need pending rows for that I think [19:39:04] ah cool thx! [19:39:12] yes I just made a pending row [19:39:15] ah cool! [19:39:35] jgleeson: yep, for this case it's the easiest kind of pending row, that where the donor hasn't done anything at the paypal side [19:40:07] AndyRussG: the only trick here is that you need the pending rows at least 30 minutes old [19:40:20] 'filas pendientes reposadas' [19:40:45] añejas [19:40:49] and the date you edit isn't the date on the pending row, it's the date timestamp in the message field [19:41:12] right, i guess not so painful if you have a db GUI [19:41:32] trixy [19:41:52] hmm I'd hacked the new code locally so $minimumAge = 0 [19:42:02] ah nice [19:42:03] I wonder where I could do that in the old [19:42:04] ha even better [19:42:29] AndyRussG: oh hey, there's a --time (or -time?) option to the drush command [19:42:42] so you can set that to 1 [19:43:08] ah oki [19:43:12] function orphan_slayer_process_orphans($gateway, $time = 30) [19:43:17] in orphan_slayer.module [19:44:08] yep, that creates the batch-mode adapter and calls ->rectify [19:44:16] Hmm I got an error now, it says, "OutOfRangeException: No adapter configured for paypal_ec in /srv/civi-sites/wmff/vendor/wikimedia/donation-interface/DonationInterface.class.php:107 " [19:44:28] ahh, yeah, we need more settings [19:44:45] where do the DI settings under civi live? [19:45:08] $wgDonationInterfaceAdapters['paypal_ec'] = 'PaypalExpressAdapter' [19:45:28] good question AndyRussG - do you see any $wg settings in any of those civi files? [19:46:57] jgleeson: the donation record for cid 29546503 looks just fine [19:47:14] AndyRussG: try config/civicrm/settings.d/settings.php [19:47:17] * Note: You'll need to include a bunch of exciting MediaWiki globals in your [19:47:19] * Drupal settings.local.php, including default values that would normally be [19:47:21] * read from extension.json [19:47:28] i think that's where you need to add mwGlobals for crm [19:47:33] what do you think, time to set the schedule for that new pending resolver job? [19:47:35] when testing actual functionality [19:47:49] ejegg: I just ran it again and it processed 61 records [19:47:51] comment in orphan_slayer.drush.inc [19:48:54] sounds good ejegg. copy the existing job schedule? [19:51:32] AndyRussG: that file should get included when things run. However to set mwGlobals when running unit tests we need to update another file I think [19:51:56] thx!! hmmm I just added a file under the dir u suggested jgleeson [19:52:18] jgleeson: yep, existing job schedule sounds good [19:52:44] config/civicrm/settings.d/10-donation-interface.php [19:52:57] $wgDonationInterfaceAdapters['paypal_ec'] = 'PaypalExpressAdapter'; [19:53:02] looks good [19:53:05] however still getting the same error [19:53:14] oh hmm [19:53:20] hmmm maybe drush cc and such? [19:53:35] could try [19:54:49] noup [19:55:02] I guess I should ask eileen in a bit :) [19:56:35] ejegg: that schedule line is pushed to p-c [19:56:50] wanna take a peek ? [19:57:02] woohoo [19:57:07] will do in a sec [19:57:14] skynet activated [19:57:22] the job is self-aware! [19:57:58] AndyRussG: try adding something in settings.php maybe exit() [19:58:05] just to see if that one is loaded in [19:58:24] config/civicrm/settings.d/settings.php * [20:08:05] jgleeson: want to do the honors of moving the tickets over to done? [20:08:21] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10DStrine) 05Open→03Resolved [20:09:21] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T297336 (10XenoRyet) [20:09:44] 10Fundraising-Backlog: Investigate why orphan-slayer job is running for hours - https://phabricator.wikimedia.org/T239756 (10DStrine) [20:09:46] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10FR-Paypal: Delete PayPal pending messages more aggressively - https://phabricator.wikimedia.org/T297246 (10DStrine) 05Open→03Resolved [20:09:54] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline: Transactions at status 600 - https://phabricator.wikimedia.org/T296956 (10DStrine) 05Open→03Resolved [20:10:41] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10fundraising sprint Wireless Zipline: Tech talk on EOY receipt email - https://phabricator.wikimedia.org/T291572 (10DStrine) 05Open→03Resolved [20:11:01] will do ejegg [20:11:35] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fr-donorservices, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): applepay donations TY email doesn’t have the donor's name - https://phabricator.wikimedia.org/T296881 (10DStrine) 05Open→03Resolved [20:13:00] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 6 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) 05Open→03Re... [20:13:16] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 6 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) [20:13:26] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 7 others: Add PendingTransaction::resolve API call that replicates Ingenico orphan rectifier - https://phabricator.wikimedia.org/T291223 (10DStrine... [20:13:34] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 6 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) [20:13:52] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 6 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) [20:13:54] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 5 others: Add existing donor matching to PendingTransaction::resolve - https://phabricator.wikimedia.org/T291226 (10DStrine) 05Open→03Resolved [20:13:56] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 7 others: Enhance Pending Transaction Resolver to use all available fraud filter scores - https://phabricator.wikimedia.org/T296555 (10DStrine) 05... [20:14:11] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 6 others: Epic: Automatically send status 800 on prior donors stopped at 600 - https://phabricator.wikimedia.org/T276183 (10DStrine) [20:14:14] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 5 others: Update PaymentsInitQueueConsumer to leave FAILED/REJECTED pending rows for Ingenico - https://phabricator.wikimedia.org/T291228 (10DStrine... [20:16:13] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 5 others: Add existing donor matching to PendingTransaction::resolve - https://phabricator.wikimedia.org/T291226 (10DStrine) [20:17:09] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Wireless Zipline, 10fr-donorservices: Recurring "Cancel" button reposition request - https://phabricator.wikimedia.org/T291133 (10DStrine) 05Open→03Resolved [20:17:40] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10MW-1.38-notes (1.38.0-wmf.13; 2021-12-13): Post-payment Monthly Convert *Yes* button text overflows container on some devices - https://phabricator.wikimedia.org/T297012 (10DStrine) 05Open→03Resol... [20:20:39] jgleeson: that schedule line for pending resolver looks good [20:21:18] i'm on frpm, i'll rsync [20:24:18] interesting new behavior i just saw when placing an apple pay order for food. i was given a 'contact' bubble where i could then go in and update the name/email/phone number to be used with the transaction. [20:24:32] don't know if we are using that for our donations or if we want to look into it. [20:34:48] thanks ejegg [21:11:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Y 2021: Donations QC seems to leave some pending rows it shouldn't - https://phabricator.wikimedia.org/T298067 (10DStrine) [21:11:13] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Y 2021, 10fr-donorservices: Civi is no longer displaying the recurring amount in the same format - correctly. - https://phabricator.wikimedia.org/T296663 (10DStrine) [21:11:15] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Y 2021: Documentation: Create a place for text source for UML diagrams, and put existing diagrams there - https://phabricator.wikimedia.org/T296344 (10DStrine) [21:11:17] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, and 5 others: Switch eoy email over fully to the new method - https://phabricator.wikimedia.org/T297159 (10DStrine) [21:11:19] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Y 2021, 10Patch-For-Review: Adyen forms for Euro Bundle - https://phabricator.wikimedia.org/T293292 (10DStrine) [21:11:21] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Y 2021, 10fr-donorservices: Add a second layer of confirmation to the batch merge deduper button - https://phabricator.wikimedia.org/T296042 (10DStrine) [21:11:23] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Y 2021, and 2 others: Adyen payments-init messages getting NULL final_status - https://phabricator.wikimedia.org/T296266 (10DStrine) [21:11:27] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Y 2021: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10DStrine) [21:11:29] 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Question about blocked contacts in Civi and how they sync to Acoustic - https://phabricator.wikimedia.org/T293587 (10DStrine) [21:11:31] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Y 2021: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10DStrine) [21:11:33] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Y 2021, 10FR-LATAM: Adding PIX as a payment type for Brazil - https://phabricator.wikimedia.org/T280303 (10DStrine) [21:11:35] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Y 2021, 10fundraising-tech-ops: Document Ingenico integration - https://phabricator.wikimedia.org/T291874 (10DStrine) [21:11:37] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 10 others: update the docs on the civi-acoustic import and export scripts - https://phabricator.wikimedia.org/T286934 (10DStrine) [21:11:39] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising Sprint Visual C Saw, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 10 others: Search kit links not loading when sharing out to Engage - https://phabricator.wikimedia.org/T279686 (10DStrine) [21:11:41] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Y 2021, 10FR-India, 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28): re-enable AMEX cards in India - https://phabricator.wikimedia.org/T258509 (10DStrine) [21:11:43] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Y 2021, 10FR-PayPal-ExpressCheckout, 10MediaWiki-extensions-DonationInterface: Payments-wiki should send payments-init message on failed PayPal EC - https://phabricator.wikimedia.org/T249276 (10DStrine) [21:11:47] 10Fundraising Sprint Vestigial tails shoot from the hip, 10Fundraising Sprint Window dressing is mostly olive oil, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, and 5 others: Switch PE and UY to dlocal for processing - https://phabricator.wikimedia.org/T208963 (10DStrine) [21:11:53] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Y 2021, 10Patch-For-Review: Paypal Orphan Slayer Missing PayerID - https://phabricator.wikimedia.org/T205566 (10DStrine) [21:11:57] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Corrugated super slide, 10Fundraising Sprint Downed power line jump rope, and 33 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10DStrine) [21:45:44] ses language code has 'yeeti' all over the place, looks like it means something like reset or delete [21:48:01] what sprint name did we settle on fr-tech? [21:48:14] yeet-coaster [21:48:18] ha! [21:48:20] nice [21:51:14] just had a look over the pending trxn logs. Looks like it's processing ok and no failmail so far... [21:52:20] have a good one fr-tech. catch you tomorrow o/ [22:01:25] great! [22:02:50] (03PS4) 10Ejegg: Add unit test for single quote in name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748833 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:02:55] (03CR) 10Ejegg: [C: 03+2] Add unit test for single quote in name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748833 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:15:40] (03Merged) 10jenkins-bot: Add unit test for single quote in name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748833 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:18:38] https://commons.wikimedia.org/wiki/File:Yeeting_boy.svg [22:18:46] https://en.wikibooks.org/wiki/Wikijunior:Yeet [22:19:16] dstrine: I petition to update the sprint image [22:24:25] (03PS3) 10Ejegg: EOY Email - create 1 activity per email. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748888 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:24:33] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748888 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:27:55] (03PS2) 10Ejegg: Shift to ip-allowlist from ip-whitelist [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748806 (https://phabricator.wikimedia.org/T279576) (owner: 10Dwisehaupt) [22:28:02] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748806 (https://phabricator.wikimedia.org/T279576) (owner: 10Dwisehaupt) [22:28:44] (03Merged) 10jenkins-bot: Shift to ip-allowlist from ip-whitelist [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/748806 (https://phabricator.wikimedia.org/T279576) (owner: 10Dwisehaupt) [22:36:22] (03Merged) 10jenkins-bot: EOY Email - create 1 activity per email. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/748888 (https://phabricator.wikimedia.org/T297159) (owner: 10Eileen) [22:38:58] (03CR) 10Ejegg: [C: 03+2] "Thanks! Hopefully soon we can remove these testing adapters entirely." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746797 (owner: 10Thiemo Kreuz (WMDE)) [22:39:21] (03PS2) 10Ejegg: Remove dead code from TestingGenericAdapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746797 (owner: 10Thiemo Kreuz (WMDE)) [22:43:43] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749275 [22:43:57] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749275 (owner: 10Eileen) [22:45:13] (03PS2) 10Ejegg: Fix a series of easy to fix PHPCS violations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746796 (owner: 10Thiemo Kreuz (WMDE)) [22:47:22] (03CR) 10jerkins-bot: [V: 04-1] Fix a series of easy to fix PHPCS violations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746796 (owner: 10Thiemo Kreuz (WMDE)) [22:53:06] !log civicrm rev:aa90dd3a conf:449c8de8 [22:53:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:55:34] (03PS3) 10Ejegg: Fix a series of easy to fix PHPCS violations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746796 (owner: 10Thiemo Kreuz (WMDE)) [22:56:25] (03CR) 10Ejegg: [C: 03+2] "Thanks for the fixes and syntax modernization!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746796 (owner: 10Thiemo Kreuz (WMDE)) [23:04:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unnecessary deduple conflicts on language - https://phabricator.wikimedia.org/T298169 (10Eileenmcnaughton) [23:12:16] (03Merged) 10jenkins-bot: Remove dead code from TestingGenericAdapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746797 (owner: 10Thiemo Kreuz (WMDE)) [23:12:20] (03Merged) 10jenkins-bot: Fix a series of easy to fix PHPCS violations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/746796 (owner: 10Thiemo Kreuz (WMDE)) [23:57:24] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10AnnWF) Cccccbbhkvlj this is the public side of the key, thanks :)