[00:34:29] (03PS2) 10Ejegg: Delete cruft from oldest orphan rectifiers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747201 [00:35:49] (03PS8) 10Ejegg: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) [00:36:37] (03Abandoned) 10Ejegg: Fix exception setting client-side validation rules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/730878 (owner: 10Ejegg) [05:58:49] (03CR) 10AndyRussG: [C: 03+2] "Works great! SP endpoints work out-of-the-box! Thanks!!! :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/742581 (owner: 10Ejegg) [05:58:53] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Update docker images to latest [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/742581 (owner: 10Ejegg) [08:31:24] (03PS1) 10Thiemo Kreuz (WMDE): Enable and partially fix some more PHPCS sniffs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749502 [09:51:13] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/748945 (owner: 10L10n-bot) [15:15:25] (03Abandoned) 10Jgleeson: Updated Ingenico getHostedPaymentStatus response to now return an instance of PaymentDetailResponse. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732788 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [15:25:09] (03Abandoned) 10Jgleeson: WIP: Update $result handling for Ingenico getHostedPaymentStatus call as this now returns an instance of PaymentDetailResponse. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732790 (https://phabricator.wikimedia.org/T291223) (owner: 10Jgleeson) [15:25:19] (03Abandoned) 10Jgleeson: WIP: Fix the test failues due to getHostedPaymentStatus updates [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732791 (owner: 10Jgleeson) [15:40:08] (03CR) 10Jgleeson: [C: 03+2] "This looks great! thanks for adding these rules." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749502 (owner: 10Thiemo Kreuz (WMDE)) [15:46:22] (03CR) 10Jgleeson: [C: 03+2] "Thanks! I remember seeing the old job in the process-control files a while back but having just checked I can see you also removed that in" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747201 (owner: 10Ejegg) [15:51:13] (03PS2) 10Jgleeson: Enable and partially fix some more PHPCS sniffs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749502 (owner: 10Thiemo Kreuz (WMDE)) [15:51:28] (03CR) 10Jgleeson: [C: 03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747201 (owner: 10Ejegg) [15:52:12] oops looks I +2'd a volunteer patch which made changes to another patch I +2'd that remove the files the changes were made on! CI fun [15:58:15] (03CR) 10Jgleeson: [C: 03+2] "rebased over Ib51a3c4a61217af4c08257aa5fe6b62fdbe5a8f2 which deletes some of the files that were cleaned up." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749502 (owner: 10Thiemo Kreuz (WMDE)) [16:09:27] (03Merged) 10jenkins-bot: Delete cruft from oldest orphan rectifiers [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747201 (owner: 10Ejegg) [16:14:20] (03Merged) 10jenkins-bot: Enable and partially fix some more PHPCS sniffs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749502 (owner: 10Thiemo Kreuz (WMDE)) [16:58:26] (03CR) 10Jgleeson: "Thanks so much for this! I'm not sure if this file is actually referred to concerning displaying submethods on the form if that's why you'" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/748573 (https://phabricator.wikimedia.org/T293292) (owner: 10Wfan) [16:59:01] ejegg|away: your thoughts on that would appreciated! ^^^ [16:59:51] would be* [17:00:45] hey jgleeson thanks for the code review on that [17:01:01] we were just doing it for history basically (and good first easy patch) [17:48:27] cstone: this navy assault is crazy lol [17:48:51] "the smoke grenades fit perfectly in the cup holders" [17:51:09] i couldnt find the whole clip its like "does a horse head fit in the trunk?" yes [17:51:10] The fiesta passed basic training cstone :) [17:52:46] back later fr-tech [18:21:09] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10AnnWF) ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDEjLOetxcruVmEu1kwyYDdacFw+h+Js1CpKWenpeAxI9m1mgg6WmKq4fBDUjeIiJV1/MLMYNbIoW1a5UyO1ZSS2TK1x9kQsmmLgF6qjVzWEdV8XEqkYi19wKX5kFyeHlEVNw6UrSyAuFUWDSj/gnwDAfOVn... [18:31:33] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) [18:33:33] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) Yubikey public key added to puppet. SSH public key added to puppet. mariadb grant portions added to make_grants scripts. Keys pushed out. Grants applied. .my.cnf file created. mariadb acc... [18:50:05] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) [18:50:33] 10fundraising-tech-ops: Fundraising access request for Wenjun Fan - https://phabricator.wikimedia.org/T297750 (10Dwisehaupt) 05Open→03Resolved Verified login and access is working. [20:04:15] (03PS1) 10Cstone: WIP: Light verison for docker-compose and setup.sh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/749572 [20:14:15] (03Abandoned) 10Cstone: WIP: Adding new Adyen countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/747897 (https://phabricator.wikimedia.org/T293292) (owner: 10Cstone) [21:36:28] (03PS1) 10Jgleeson: Fix pending db fixture to satisfy required fields when building donations queue message so that rectify() works as expected. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749581 [21:37:25] nice catch jgleeson [21:39:53] thanks ejegg. I thought that test would help me confirm that 'utm_medium=endowment' was being lost between the pending and the donation message during the orpha- slayer run but no such luck. The utm_medium property is still at the end there so I'm scratching my head a little at the ct_id I was looking at regarding eyener's issue [21:40:41] ah, I need to read backscroll [21:40:53] over in the other channel [21:40:58] which I won't type here [21:41:00] again.. [22:09:49] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Yeet-coaster, 10fr-donorservices: Civi is no longer displaying the recurring amount in the same format - correctly. - https://phabricator.wikimedia.org/T296663 (10Eileenmcnaughton... [22:18:25] (03PS1) 10Ejegg: Reformat orphan_slayer files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749585 [22:18:27] (03PS1) 10Ejegg: Add batch and time_limit options to orphan slayer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749586 [22:19:04] AndyRussG: ^^ are one more thing we can do to fix the paypal orphan slayer running too long [22:19:37] eyener has just found a bug that it turns out is being caused by that orphan slayer lagginess [22:19:47] or rather, by it running so long that the queue connection dies [22:21:02] so if we can just run it with the time_limit and restart it after half an hour, we should keep those queue and db connections fresh [22:21:29] might be easy for you to review if you're running that script already [22:39:11] oops, that === was too strict for the options that came across as strings [22:45:00] ack XenoRyet i got caught up in ^^^ bug and spaced on our meeting [22:52:48] (03PS2) 10Ejegg: Add batch and time_limit options to orphan slayer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749586 (https://phabricator.wikimedia.org/T239756) [22:53:16] cstone: if you have a sec, want to check out ^^^ ? [22:55:45] sure ejegg im at sandwhich shop with just my mac if it just needs another pair of eyeballs (dont have a working dev setup right now) [22:55:52] but ill be home in like ~20 mins [23:03:32] ah cool cstone whenever's convenient [23:19:54] ok im back the sun went behind the mountains and it dropped like 20 degrees and I didn't have a coat haha [23:45:14] ejegg: ah cool thx! [23:45:29] logistical question, do you want to try to get any of that out before the break? [23:45:48] AndyRussG: the time limit, yes [23:46:16] it's so trivial, and is specifically causing endowment donations to be mis-tagged [23:46:26] ejegg: oki [23:46:53] ejegg: I'm right now cooking and then have a bunch of non-work but I can be back at the keyboard in about 2.5 hrs... would that still work? [23:46:57] k [23:47:00] oki thx! [23:49:39] so let's see, we should really stop processing when we lose the queue connection [23:50:02] it may not make sense to try to do that with the old code, but we can try to make sure the new code treats that as fatal [23:51:02] oh hmm, the new code seems like it'll quit after any old problem [23:51:36] so I guess we might want to make it more fault tolerant at some point [23:51:43] but for now we should be fine