[00:00:13] 10Fundraising-Backlog, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10Ejegg) [00:00:31] eyener: want to paste the query for the apple pay ones on that ticket? ^^^ [00:12:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Yeet-coaster: Donations QC seems to leave some pending rows it shouldn't - https://phabricator.wikimedia.org/T298067 (10Ejegg) Possibility: fast card entry & unlucky timing, the donations QC is picking it up before the pending QC [00:45:57] hey ejegg trying to test and looks good so far but to actually deal with an orphan I'm getting No adapter configured for paypal_ec in [error] [00:45:58] /srv/civi-sites/wmff/vendor/wikimedia/donation-interface/DonationInterface.class.php:107 [00:45:58] is that what AndyRussG was fixing last night? [00:46:04] ah yeah [00:46:31] ah yeah sorry for not putting up a patch yet cstone ahhh non-work [00:46:46] no worries I think i remember where it was overwritten [00:46:52] lemme see, you could either edit the 60-donationinterface file in src/civicrm-buildkit/app/config/wmff/drupal.settings.d/post.d/60-donationinterface.php [00:47:12] or add a 70-blah.php file in the other drupal.settings.d folder [00:47:15] thanks! [00:47:46] you can also try setting donationinterface values in a 61-donationinterface.php you can put in config/civicrm/drupal-settings.d [00:47:56] sorry we're just gonna eat here :) [00:48:21] no rush AndyRussG enjoy your dinner [00:49:20] would it be paypalAdapter and paypalOrphanAdapter? [00:50:18] paypalexpressadapter maybe [00:55:51] cstone: yep sorry, PaypalExpressAdapter [01:10:51] ejegg: this may just be me not understanding how this works but how can $slain get incremented if $orphan is limited to 1 [01:11:21] oh wait, am I doing something dumb there? Probably... [01:12:25] when stepping through when it grabs it from the pending table theres a limit 1 [01:12:46] cstone: ah yeah, but then it gets another orphan down on line 25 [01:12:56] just pulling them from the db one at a time [01:13:03] oh yep missed that [01:13:04] thanks [01:13:17] ty for looking at the code! [01:17:50] (03PS1) 10Ejegg: Base queue consumer: little fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749600 [01:28:08] WD orphan slayer: Slayed 2 orphans in 14 seconds [01:28:12] looks good ejegg ! [01:28:28] WFan: is helping me with time math [01:28:31] my greatest weakness [01:29:37] (03CR) 10Cstone: [C: 03+2] "Looks good! Tested with with a 10 second time limit and it just ran the one in that time also tested with a 1000 second time limit and it " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749586 (https://phabricator.wikimedia.org/T239756) (owner: 10Ejegg) [01:31:17] whoops missed the parent [01:31:50] (03CR) 10Cstone: [C: 03+2] Reformat orphan_slayer files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749585 (owner: 10Ejegg) [01:32:13] thanks! [01:37:12] (03PS1) 10Ejegg: Base QC: option to wait when queue is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749601 (https://phabricator.wikimedia.org/T298067) [01:41:45] (03PS1) 10Ejegg: ConsumePendingQueue: add wait-for-messages option [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749602 (https://phabricator.wikimedia.org/T298067) [01:42:11] (03CR) 10jerkins-bot: [V: 04-1] ConsumePendingQueue: add wait-for-messages option [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749602 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [01:42:58] (03Merged) 10jenkins-bot: Reformat orphan_slayer files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749585 (owner: 10Ejegg) [01:43:00] (03Merged) 10jenkins-bot: Add batch and time_limit options to orphan slayer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749586 (https://phabricator.wikimedia.org/T239756) (owner: 10Ejegg) [01:43:49] (03PS2) 10Ejegg: ConsumePendingQueue: add wait-for-messages option [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749602 (https://phabricator.wikimedia.org/T298067) [01:55:01] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Yeet-coaster, 10Patch-For-Review: Donations QC seems to leave some pending rows it shouldn't - https://phabricator.wikimedia.org/T298067 (10Ejegg) The unlucky timing theory seems to be true: all of those were pulled in by the dona... [01:55:31] so there's my retroactive justification for the last 3 patches ^^^ [01:57:53] k, i'm going to deploy that orphan slayer update and see if I can trick the current run into stopping [01:59:49] waaat - deploy branch has a conflict on the OrphanSlayer - looks like it never even had the ->cancel logic merged somehow! [02:00:19] Well, it was only going to be called in pretty impossible circumstances, so I'm going ahead and overwriting with the current state of master branch [02:01:41] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749603 [02:02:51] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749603 (owner: 10Ejegg) [02:10:09] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/749603 (owner: 10Ejegg) [02:11:59] !log updated fundraising CiviCRM from aa90dd3a to 47dd67f2 [02:12:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:16:13] ok, I updated the process-control yaml to add that time_limit option [02:17:07] I was considering a couple of db updates to the pending table to make the current job stop [02:18:06] temporarily setting the gateway field to something odd where gateway='paypal_ec' [02:18:19] but that seems like it could cause other problems [02:19:03] so I guess we just wait for this run to finish when the db connection dies [02:38:38] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster: Investigate why orphan-slayer job is running for hours - https://phabricator.wikimedia.org/T239756 (10Ejegg) [02:39:43] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10Ejegg) [02:44:22] ejegg cstone finally back at the computer [02:44:37] is there still CR? [02:48:47] AndyRussG: the patch you've been looking at can still help! [02:49:19] and there are a few new ones for a different aspect of the problem: https://phabricator.wikimedia.org/T298067 [02:50:56] ejegg: cool thx! [02:51:10] AndyRussG: so I want the pending queue consumer to basically run continuously like the donations queue consumer [02:51:24] to make it more likely that the messages will be consumed in order [02:52:12] the donations one runs more or less continuously this time of year because it takes more time with the messages [02:52:33] so for the pending one, I added an option to sleep instead of quit when it gets to the end of a queue [02:55:17] oh hmmm interesting [02:55:41] and then wake up after some time to check for more message? [02:55:51] yep, it just sleeps for a second [02:59:24] hehe a short nap [03:01:27] ejegg: what's the urgency on this one? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/749581 [03:02:28] looks like that's just a test fix AndyRussG [03:06:55] oh hmm, passing a bool as a parameter is interesting [03:07:05] I may need to fix the last of those three patches [03:07:28] oh oops I didn't see it was just a test hting [03:08:29] looks like eileen got all her stuff merged too! [03:08:39] AndyRussG: yep I did [03:08:43] yay! [03:09:23] I've just been poking around on the recurring currency phab - but got frustrated setting up test data so have been trying to add that to the sample data [03:10:15] ah cool [03:30:17] (03PS1) 10Ejegg: Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) [03:31:19] AndyRussG: ok, with ^^^ you can test the new behavior by running php Maintenance/ConsumePendingMessages.php -w --time-limit=60 [03:31:34] no need to put a value for -w after that final patch [03:32:43] ejegg: ah cool... should I look at those 4 patches at once, or one-by-one? [03:33:01] they're pretty tiny, all at once is probably not overwhelming [03:33:15] the first is just cleaning up some stuff I noticed, before adding new stuff [03:34:25] So at the end if you run that command I just pasted, you can then hit the front end and start sending pending messages (hitting the paypal form is the quickest as it sends one immediately on redirect) [03:34:46] and the consumer should pick those up and output the gateway + order ID within a couple seconds [03:34:56] k, I'mma head to bed... [03:36:19] ejegg: oki thanks much! [03:36:29] que descanses [07:58:50] 10Fundraising-Backlog: Remove Endowment from Financial Type Field in Civi - https://phabricator.wikimedia.org/T298202 (10Peachey88) [11:57:23] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: GlobalCollect_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [12:02:25] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [12:05:00] 10Fundraising-Backlog, 10MediaWiki-Interface, 10MediaWiki-Page-editing, 10MediaWiki-extensions-CentralNotice, and 3 others: Content jumps after JavaScript is loaded - https://phabricator.wikimedia.org/T138177 (10thiemowmde) [14:50:33] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10EYener) Here is a query to show the donations which have come in through utm_mediums of 'endowment' but have a financial type of 9 (cash):... [15:53:14] (03CR) 10Jgleeson: [C: 03+2] "These look good and easy to +2. Thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749600 (owner: 10Ejegg) [15:53:45] (03Merged) 10jenkins-bot: Base queue consumer: little fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749600 (owner: 10Ejegg) [16:02:43] (03CR) 10Jgleeson: [C: 03+2] "Thanks for this, hopefully it'll speed things up!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749601 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:03:13] (03Merged) 10jenkins-bot: Base QC: option to wait when queue is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749601 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:06:04] (03CR) 10Jgleeson: [C: 03+2] "LGTM! This has got me think about adding some stats output for the pending QC now." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749602 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:06:33] (03Merged) 10jenkins-bot: ConsumePendingQueue: add wait-for-messages option [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749602 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:15:03] thanks for all the cr, jgleeson ! [16:16:50] that last patch just makes the command-line option nicer: https://gerrit.wikimedia.org/r/749606 [16:17:14] so you can run it with -w instead of needing -w=1 [16:18:56] (03CR) 10Jgleeson: [C: 04-1] "Thanks for this. The change makes sense and works well. However, there's something dirty about needing to pass a string e.g. 'Boolean' to " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:19:11] hi fr-tech ejegg jgleeson [16:19:15] hi AndyRussG [16:19:16] np ejegg. I just reviewed that one [16:19:20] :) [16:19:25] lemme know what you think [16:19:28] hi AndyRussG :) [16:19:33] +fr-tech [16:20:01] ejegg I did indeed try to posh ahead with review yesterday evening but my brain just completely noped out [16:20:21] jgleeson: how about I create a new method addFlag() [16:20:28] or addBooleanOption [16:20:29] ooo nice [16:20:30] ? [16:20:34] yeah that would work [16:20:38] and just proxy on [16:20:39] apologies, and thanks so much for getting to it jgleeson :) :) [16:20:43] will do! [16:21:11] also, hi jgleeson, AndyRussG and the rest of fr-tech! [16:21:44] ejegg: did you see my comment about the wait qc behaviour being hard to test? [16:21:54] via unit test [16:22:37] jgleeson: oh yeah, sleeping in unit tests is bad form [16:22:49] ejegg: was cstone able to get the orphan slayer for paypal running under Docker? I added all the vars from config-private to where Civi can get them, but still erroring out [16:23:04] AndyRussG: i think so [16:23:08] cURL transaction to Paypal Express Checkout failed: (3) . cURL verbose logging: * Expire in 0 ms for 6 [16:23:23] AndyRussG: did you add in some private config? [16:23:28] getting 3 of those, only when there's a row in the pending table [16:23:29] it'll at least need the url [16:23:56] yeah added those [16:23:59] but to actually query the transactions it'll need the same account info as payments-wiki [16:24:18] $wgPaypalExpressGatewayURL, $wgPaypalExpressGatewayTestingURL, $wgPaypalExpressGatewaySignatureURL, $wgPaypalExpressGatewayAccountInfo [16:24:44] hmm, i'll take a look after I finish this smashpig maintenance thing [16:25:03] ejegg: oki thx! yeah i can continue to dig in, just wondering if it was already resolved [16:25:53] around all this work I'm seeing more and more an opportunity to add some stats collection code to the pending trxn resolver. i wonder if we make a case for that in the new year [16:26:17] sounds like a good idea jgleeson :) [16:26:34] whats the plan in the new AndyRussG are we gonna go straight into refactoring? [16:27:07] did we actually get the green light on that [16:27:12] jgleeson: I think we gotta write up and all agree on a reasonably complete proposal [16:27:20] ah I see [16:27:26] we're still lobbying [16:27:29] :) [16:27:57] :) [16:28:00] yeah but I kinda feel it's in the air, and I'm hoping it won't be an immediate no... but yeah my sense is the ball is in our court [16:28:55] I think we'll have space after break to make a cogent proposal and see where it goes? [16:29:01] I should read Refactoring [16:29:15] sounds good [16:29:19] :) :) [16:29:27] the book also sounds good. I haven't read any of it yet [16:30:03] yeah me neither [16:30:16] new years resolution and all!!! [16:30:18] :) [16:30:41] Hi fr-tech AndyRussG I was able to run it but I just added the two adapters directly to the buildkit file. I did get a contact info error but it wasn't preventing the slayer from running [16:32:07] cstone: ah cool thx! so you didn't get the curl transaction error like I got above? Did you add any creds from config-private? [16:32:20] also hi! :) [16:32:26] (03PS2) 10Ejegg: Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) [16:32:42] jgleeson: ok, ^^^ uses the new addFlag() method [16:32:52] for -w and also for -h [16:32:53] (03CR) 10jerkins-bot: [V: 04-1] Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:32:58] oops [16:33:08] i should really lint before review [16:33:33] ooh Default of null should be declared in @param [16:33:41] really? [16:34:07] I guess I could default to 'String' [16:34:13] and then we'd know that key is set [16:34:28] AndyRussG: I didn't get a curl error and just added the PayPal express and orphan adapters [16:34:37] code looks good ejegg just gonna test [16:36:14] hmm funny [16:38:37] ejegg: just thinking about this. are we gonna leave the pending qc running indefinitely ? [16:38:53] jgleeson: I figure run it on 10 minute cycles [16:39:12] so as not to hit connection problems [16:40:02] so the timelimit has to be 0 in the code I think for it to run. Is p-c gonna stop it? [16:40:36] jgleeson: ohhh, i meant for it to go the other way - it should need a timeLimit > 0 for waiting [16:40:40] so it stops itself [16:40:48] looking at that validation again [16:41:03] actually sorry I might be wrong [16:41:08] I'm looking at the exception condition [16:41:15] lemme also remind myself [16:41:29] ok, so in the constructor I throw an error if wait is true but there is no message or time limit [16:41:37] ah I see [16:41:53] yeah so that STOPS that indefinite scenario [16:41:55] good good [16:41:56] right [16:41:57] thanks [16:42:49] where to curl_init and curl_exec get the URL from? [16:43:25] @param string|null $type When not given, defaults to string [16:43:28] ejegg: ^ [16:43:37] (03PS3) 10Ejegg: Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) [16:43:52] ahh right, phpDoc doesn't use ?string yet [16:43:53] ah you've already done it [16:44:01] (03CR) 10jerkins-bot: [V: 04-1] Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:44:42] missing a space after 'Boolean' param also [16:44:45] $this->addOption( $name, $description, false, $alias, 'Boolean' ); <-- [16:45:04] I fixed that in PS3 [16:45:09] I just ran `composer fix` and those were the two updates [16:45:11] ah cool [16:45:28] ok I found it [16:45:37] (03PS4) 10Ejegg: Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) [16:45:44] what was the issue AndyRussG ? [16:46:22] ok jgleeson, PS4 uses the correct string|null in the phpdoc [16:46:22] (03CR) 10Jgleeson: [C: 03+2] "Works great! thanks for this" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:46:26] thank you! [16:46:52] (03Merged) 10jenkins-bot: Allow flag-type options for Maintenance scripts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/749606 (https://phabricator.wikimedia.org/T298067) (owner: 10Ejegg) [16:48:04] dwisehaupt: hi! I'm hoping to do a SmashPig deploy shortly. It'll include your change from ip-whitelist to ip-allowlist, which you indicated needs a corresponding change in puppet. [16:48:12] when would be convenient to push that out? [16:48:51] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-India, 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28): re-enable AMEX cards in India - https://phabricator.wikimedia.org/T258509 (10jgleeson) a:03jgleeson [16:49:10] or if you'd like, I can just cherry-pick the other changes (adding a --wait-for-messages option to the pending QC) and leave the config name change till after the break [16:49:49] any time would be good. the update to the template is to fix a commented out default value. [16:49:58] so i can push it whenever you are ready. [16:50:32] ejegg: any chance you have the atropay URL you used when testing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/472503 to hand? [16:50:39] to history* [16:52:45] hmm I see one on our quick links page actually [16:52:52] but that doesn't show me any submethods [16:53:13] ejegg: i have the puppet change ready now so i can push it up and roll it at your convenience. [16:53:18] thanks dwisehaupt [16:54:46] jgleeson: https://mediawiki.d/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=en&language=en¤cy=UYU&amount=100&country=UY&ffname=astropay [16:54:54] oops, but fixing that domain name [16:55:30] i got one ejegg [16:55:38] the one in quick links works I just had to change from cash to cc [16:55:48] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/749755 [16:55:50] quick links on the Main page [16:55:52] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/749755 (owner: 10Ejegg) [16:56:00] ah cool jgleeson [16:56:18] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/749755 (owner: 10Ejegg) [16:56:33] (03CR) 10Jgleeson: [C: 03+2] "Working for me! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) (owner: 10Ejegg) [16:56:37] ok dwisehaupt, i'm ready to deploy [16:57:46] dwisehaupt: I just did the fundraising_code_update for SmashPig so it's all ready to go [16:58:02] AndyRussG: where in the flow are you getting the curl error? [16:58:12] dwisehaupt: shall we synchronize the button push in the standup video call? [16:58:52] (03Merged) 10jenkins-bot: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) (owner: 10Ejegg) [16:58:58] thanks jgleeson ! [17:00:23] (03PS1) 10Jgleeson: Re-enable Amex for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749757 (https://phabricator.wikimedia.org/T258509) [17:01:13] sure [17:01:59] AndyRussG: I am getting the curl error sorry!!!! [17:04:28] !log updated standalone SmashPig deploy from 5a7d0c2c to 96c7b03e [17:04:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:08:49] fr-tech that continuous run for the pending QC is looking good so far [18:09:02] interestingly almost all of the pending messages are from paypal for some reason [18:09:46] hmm, there are a few repeated order IDs [18:12:25] (03PS2) 10Ejegg: Fix pending db fixture to satisfy required fields when building donations queue message so that rectify() works as expected. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749581 (owner: 10Jgleeson) [18:12:40] (03CR) 10Ejegg: [C: 03+2] "Thanks, it's good to have these fields!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749581 (owner: 10Jgleeson) [18:13:58] oh jeez, the paypal orphan slayer run from Dec 19th is still active [18:14:36] fr-tech I'm tempted to do that pending-row-juggling to make it stop, as it's still zombie-ing along with a dead queue connection [18:23:47] (03Merged) 10jenkins-bot: Fix pending db fixture to satisfy required fields when building donations queue message so that rectify() works as expected. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/749581 (owner: 10Jgleeson) [18:31:01] sounds good ejegg [18:34:59] (03PS2) 10Jgleeson: Re-enable Amex for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749757 (https://phabricator.wikimedia.org/T258509) [18:36:56] ejegg: check out the rector factoring suggestion for our base consumer call back https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/749600/1#message-a5a00eed501594c416f269dbb5d5b5bb4b8d24c6 [18:37:37] feels like a worthwhile refactor for readability [18:37:50] ok if push that up as a patch? [18:38:06] Rector Refactoring suggestion* [18:41:14] (03CR) 10Jgleeson: "to test this I used the following URL on fundraising-dev:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749757 (https://phabricator.wikimedia.org/T258509) (owner: 10Jgleeson) [18:41:58] jgleeson: hmm, seems like an unnecessary stack level, but I guess maybe more readable [18:43:10] hmm [18:43:34] you don't like wrapping it with the anon fn ? [18:44:10] it kinda makes more sense to me to pass a call back as an anon fn vs an array [18:44:11] fr-tech do other folks think that would be more readable? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/749600/1#message-a5a00eed501594c416f269dbb5d5b5bb4b8d24c6 [18:46:27] Jeff_Green / dwisehaupt could one of you please kill a drush process? It's been running for days and seems to have a dead queue connection [18:46:40] sure [18:46:43] sure. [18:46:44] on civi1001 , process # 13762 [18:46:47] oh. you go Jeff_Green [18:47:10] thanks! [18:47:36] I was scheming how to fulfill the loop condition to make it stop but it would take some gnarly data juggling [18:47:43] ha [18:47:59] for context, we deployed a new version of the code which actually has a time limit condition last night [18:48:07] it did seem to be looping actively, according to strace [18:48:09] cool [18:48:13] but the existing code still hasn't stopped running [18:48:23] killed [18:48:28] yeah, it's resolving pending paypal messages, but then it can't actually drop them on the donations queue [18:48:31] thanks! [18:48:45] let's see if the parent processes exited too [18:48:57] yep! [18:49:08] cool cool, now the one with the proper exit condition can run instead [19:00:02] ejegg: im watching the log are most of these that are attempting supposed to be ending up as a failure (I dont know the normal state) [19:00:34] for the paypal orphans [19:01:19] fr-tech I'm calling it a day. Have a great break and I hope you get some well deserved down time! All the best from us and see y'all in 2022! [19:01:30] have a good end of year jgleeson ! [19:01:32] jgleeson: all the best to u and your family! [19:01:42] You too jgleeson, have a good break [19:01:42] * jgleeson waves [19:14:37] cstone: yep, most of the pending messages would be expected to fail - the 'good' flow has them come back to the result switcher and get the payment finished at payments wiki [19:14:46] ok cool! [19:26:59] ejegg: it stopped! [19:43:17] :) [19:46:56] ok, so there are a total of 25 apple pay contributions mistagged as not endowment [19:47:30] still happening, it looks like [19:47:56] so let's see how these got to Civi [19:49:41] hmm, message straight from payments... [19:51:16] interesting, there are utm_medium = donatewiki_page [19:51:23] *this one is [19:55:45] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10Ejegg) Looking in the payments logs for the Apple Pay ones, I see utm_medium=donatewiki_page . Trying to understand how the contribution_tr... [19:58:33] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10Ejegg) They have different utm_source and utm_campaign than the results of that query, too. Utm_campaign is mostly donate_now_btn and utm_s... [20:06:48] fr-tech trying to test the new adyen countries and they break on live but not local with Configuration key 'payment-provider//class' does not exist. [20:07:14] I haven't figured out where its getting it yet but is that from the yaml file somehow? [20:07:37] that error generally means payment_method is blank [20:09:02] I'm trying with this link https://payments.wikimedia.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&ffname=adyen&payment_method=cc&recurring=&uselang=en&language=en¤cy=MYR&amount=4.15&country=MY&utm_source=internal_test [20:09:32] cstone that link loads fine for me [20:09:40] yeah it loads fine but when I tried to donate [20:09:44] ahh i see [20:09:46] I'm getting that error [20:09:53] but not on local [20:10:32] I can hunt more just wasn't sure if we had seen it before [20:11:32] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10Ejegg) Looking in the contribution tracking QC logs I do see the values that end up in the contribution_tracking table at timestamps around... [20:11:51] hmm, I wonder if the logs show anything more [20:12:18] yeah I tried looking but SmashPig\Core\ConfigurationKeyException from line 134 of /srv/www/org/wikimedia/payments/ve [20:12:18] ndor/wikimedia/smash-pig/Core/Configuration.php: Configuration key 'payment-provider//class' does not exist. [20:12:56] i was looking in payments.error [20:16:17] 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10FR-Smashpig: Endowment donations not being tagged as endowment - https://phabricator.wikimedia.org/T298219 (10Ejegg) So... maybe the utm* values should be 'stickier', i.e. never overwrite with newer values while a donor's payments-wiki session is st... [20:16:24] 116009405.1 is a test one [20:16:31] looking cstone [20:16:54] whoops this one 116008253.1 [20:17:41] Filtered" "reject" [20:17:57] ahh, this is the no-payment-method-on-fail-page error [20:18:08] that dami was trying to fix [20:18:10] ooh like that one jack and dami were looking at [20:18:36] so yeah, we should still fix that :) [20:20:02] hmm there is a different error page on that ticket than the one I see [20:21:04] oh maybe that is the dev one [20:21:47] yeah okay [20:24:29] AndyRussG: any luck getting the connection to PayPal to work under the orphan slayer? [20:27:04] ejegg: i was just one config var away [20:27:10] :) [20:28:41] debugging in, with all the config-private stuff, it seemed to be trying to get the live URL (which was not set) instead of the test one, because some test var was not set [20:28:50] ah yeah [20:28:56] gnarly stuff [20:29:36] Not at the computer just now cause I had to transport a teenager, but I'll be back there in about 1 hr! [20:30:12] ehhh heh could be worse, definitely feels solvable [20:31:45] cool cool, I think that patch can still be helpful [20:32:30] somehow we're still getting 'Failure queueing final status message' errors in the orphan slayer [20:35:31] ok, one happened after 17 minutes and the other after 20 minutes without other queue activity [20:35:40] So maybe the QueueWrapper should handle reconnection [20:35:42] ? [20:36:57] anyway, a patch which reduces the time spent on non-viable donations will reduce those delays [20:51:19] Hmm, but also we could run the orphan slayer on a shorter cycle [20:51:39] heading out for a bit before the sun goes down, back soon [21:07:12] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10Patch-For-Review: Adyen forms for Euro Bundle - https://phabricator.wikimedia.org/T293292 (10Cstone) Here are the links: AUSTRIA (deAT): https://payments.wikimedia.org/index.php?title=Special:AdyenCheck... [21:12:59] 10Fundraising Sprint Visual C Saw, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10Patch-For-Review: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10Cstone) I ran into this today testing on production when I forgot to add the utm... [21:21:31] 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10Patch-For-Review: Adyen forms for Euro Bundle - https://phabricator.wikimedia.org/T293292 (10EMartin) Thank you for the Christmas gift, FRTech/Christine!! Evelyn Martin (She/Her) Sr. Manager Donation Pr... [23:04:59] (03CR) 10Ejegg: [C: 03+2] Re-enable Amex for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749757 (https://phabricator.wikimedia.org/T258509) (owner: 10Jgleeson) [23:07:27] (03CR) 10Ejegg: [C: 03+2] Fix hard tab in YAML [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/591631 (owner: 10Awight) [23:07:29] (03Merged) 10jenkins-bot: Re-enable Amex for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/749757 (https://phabricator.wikimedia.org/T258509) (owner: 10Jgleeson) [23:08:00] (03Merged) 10jenkins-bot: Fix hard tab in YAML [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/591631 (owner: 10Awight) [23:09:41] AndyRussG: want to talk through that PaymentActionNotInitiated patch live? [23:10:14] ejegg: hi! I was about to ping, just got back from a long time in traffic [23:10:24] oh man, sounds unfun [23:10:49] is there a lot of last minute christmas traffic in MX too? [23:11:01] it's the very best traffic of the whole year [23:11:02] I was just at the grocery store and it was really crowded, even before 5 pm [23:11:22] if you'd like to do a call I can, though, give me maybe 5 min? [23:11:33] sure, let me know when you;re ready [23:11:38] k thx! [23:20:39] ejegg: oki anytime is good :) [23:20:58] cool, see you in the daily autopsy vidcall for today? [23:21:04] yyeee