[03:04:46] (03CR) 10AndyRussG: "Hi! Thanks so much for this!! See inline comment for one very small suggestion. ;)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) (owner: 10Wfan) [06:06:27] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/756273 (owner: 10L10n-bot) [06:52:52] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/756273 (owner: 10L10n-bot) [07:31:34] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756465 (owner: 10L10n-bot) [07:34:14] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756465 (owner: 10L10n-bot) [11:43:44] (03PS1) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [11:46:01] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [11:48:22] (03PS2) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [11:50:21] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [11:54:23] (03PS3) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [13:24:53] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Do not re-render Adyen card fields under MC modal - https://phabricator.wikimedia.org/T299005 (10Damilare) a:03Damilare [13:28:04] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Implement RecurringConversion in Adyen Checkout adapter - https://phabricator.wikimedia.org/T299002 (10Damilare) a:03Damilare [14:32:16] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11514 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [14:37:16] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 6021238 Threads: 18 Questions: 614581487 Slow queries: 3334 Opens: 3155809194 Flush tables: 1 Open tables: 200 Queries per second avg: 102.068 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [16:25:19] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Wireless Zipline, 10fundraising sprint Yeet-coaster: Orphan Slayer deep dive documentation - https://phabricator.wikimedia.org/T295926 (10jgleeson) thanks @AndyRussG :))) [16:29:05] 10Fundraising-Backlog, 10SRE, 10SRE-Access-Requests, 10observability, 10serviceops-radar: Fundraising-Tech engineers unable to ACK icinga alerts on fr-tech host groups - https://phabricator.wikimedia.org/T298649 (10Volans) @jgleeson @Ejegg is there anything else to do here or we can consider this done fo... [16:30:40] ejegg|away: wanna try your new ACKing powers when your about? Jeff_Green are we able to trigger an alert like last time on the fly? [16:31:04] jgleeson: yup [16:31:09] awesome [16:31:30] the ops folks are following up. I think if the configuration used for ejegg|away works they can just apply that to us all [16:31:55] what kind of alert do we want to trigger? [16:34:14] Jeff_Green: anything you think we should be able to ACK thats easy enough to trigger. ejegg can then try it and we can confirm all is good. Let wait until he pops up [16:34:23] ok [16:39:05] 10Fundraising-Backlog, 10SRE, 10SRE-Access-Requests, 10observability, 10serviceops-radar: Fundraising-Tech engineers unable to ACK icinga alerts on fr-tech host groups - https://phabricator.wikimedia.org/T298649 (10jgleeson) hey @Volans, thanks for the reminder. Let's hold out until @ejegg has had a chan... [16:52:44] damilare|brb: looks like we've got access to dlocal's test env so I've asked if they can also add support for south african bank code you added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/753695/ so we can push that one along [16:55:45] jgleeson: saw your email, thanks [17:55:22] hi fr-tech! [17:55:41] heyy ejegg how are u feeling? [17:55:43] hey ejegg, good to have you back [17:55:44] Jeff_Green: I'm ready to try acking something whenever you get a chance to trigger an alert [17:55:52] AndyRussG: much better, thank you! [17:55:58] ejegg: ok, looking [17:55:58] ah great to hear! [17:55:58] thanks damilare! [17:56:18] Some antibiotics and generic benedryl were the magic bullet [17:56:28] got the diagnosis of tonsillitis [17:56:44] so I've been thinking more about the form chooser [17:57:00] welcome back ejegg [17:57:03] ohhh aww glad that's helping [17:57:16] and I wonder if we can use the adapter config without instantiating the adapters [17:57:38] hehe fun sequence of messages, "tonsillitis... so, form chooser" [17:57:40] so I think maybe we should do a quick refactor first so that each adaptor takes the $config array as a constructor argument [17:58:57] Helps de-bloat the adapter, removes a bit of logic in the constructor, and might even make tests saner [17:59:02] thanks jgleeson [17:59:57] so then the Form Chooser, when it wants to check for supported countries and currencies, only has to get the configuration for each adapter [18:00:21] ok we should see an alert for frdb1004 check_recurring_gc_schedule_sanity before too long . . . [18:00:50] (I want to avoid instantiating the adapters in the form chooser precisely because the constructor is so heavy, doing some fraud filtering and logging, etc) [18:00:55] thanks Jeff_Green [18:03:31] PROBLEM - check_recurring_gc_schedule_sanity on frdb1004 is CRITICAL: CRITICAL https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_recurring_gc_schedule_sanity [18:04:08] So the only issue I can think of with the form chooser using the config directly, is that some adapter might need to override the default logic for getCurrencies [18:04:12] ooh, there's the alert [18:04:56] ACKNOWLEDGEMENT - check_recurring_gc_schedule_sanity on frdb1004 is CRITICAL: CRITICAL Elliott Eggleston Acking test alert https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_recurring_gc_schedule_sanity [18:05:08] Thanks Jeff_Green, that worked. I'll comment on the access ticket [18:11:12] 10Fundraising-Backlog, 10SRE, 10SRE-Access-Requests, 10observability, 10serviceops-radar: Fundraising-Tech engineers unable to ACK icinga alerts on fr-tech host groups - https://phabricator.wikimedia.org/T298649 (10Ejegg) Thanks @Volans! I was out sick last week, but today I was able to ack a test alert... [18:30:36] ejegg: ok great [18:33:26] RECOVERY - check_recurring_gc_schedule_sanity on frdb1004 is OK: OK recurring_gc_schedule_sanity=0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_recurring_gc_schedule_sanity [18:34:30] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dadedoyin - https://phabricator.wikimedia.org/T299937 (10Dwisehaupt) [18:35:31] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for nisrael - https://phabricator.wikimedia.org/T299938 (10Dwisehaupt) [18:36:18] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sguseman - https://phabricator.wikimedia.org/T299939 (10Dwisehaupt) [18:36:54] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dmorgan - https://phabricator.wikimedia.org/T299940 (10Dwisehaupt) [18:37:36] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rkumar - https://phabricator.wikimedia.org/T299941 (10Dwisehaupt) [18:38:17] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jkim - https://phabricator.wikimedia.org/T299942 (10Dwisehaupt) [18:39:01] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jrobell - https://phabricator.wikimedia.org/T299943 (10Dwisehaupt) [18:39:35] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rstearns - https://phabricator.wikimedia.org/T299945 (10Dwisehaupt) [18:40:05] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgreen - https://phabricator.wikimedia.org/T299946 (10Dwisehaupt) [18:40:34] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for pcoombe - https://phabricator.wikimedia.org/T299948 (10Dwisehaupt) [18:41:08] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sinaba - https://phabricator.wikimedia.org/T299949 (10Dwisehaupt) [18:41:46] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jadams - https://phabricator.wikimedia.org/T299950 (10Dwisehaupt) [18:42:52] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jjameshill - https://phabricator.wikimedia.org/T299952 (10Dwisehaupt) [18:49:05] (03PS5) 10Wfan: Add customized translation fields for Adyen credit card forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) [18:55:42] hmm, the config is a little annoying because of the multiple base directories [18:58:01] I think we should probably remove Adyen hosted + PayPal classic and move the config dirs to config/ to match SmashPig [18:58:16] then loading them should be simpler outside of an instance [19:07:22] sounds good ejegg [19:12:24] I'm curious about the use case you have in mind to use the config without an instance of a gateway adapter [19:27:05] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Princess Mongodb, 10Fundraising-Backlog, 10Fr-planning-ahead: Email preference center: Implement polished UI - https://phabricator.wikimedia.org/T290986 (10AndyRussG) Hi! Just some initial questions: - In the mockup and the images, we se... [19:32:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sguseman - https://phabricator.wikimedia.org/T299939 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [19:44:05] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Princess Mongodb, 10Fundraising-Backlog, 10Fr-planning-ahead: Email preference center: Implement polished UI - https://phabricator.wikimedia.org/T290986 (10DStrine) Some comments in line >>! In T290986#7646329, @AndyRussG wrote: > Hi! J... [19:45:17] 10Fundraising Sprint Princess Mongodb, 10Fundraising-Backlog, 10Fr-planning-ahead: Email preference center: make the email address editable - https://phabricator.wikimedia.org/T299962 (10DStrine) [19:45:57] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Princess Mongodb, 10Fundraising-Backlog, 10Fr-planning-ahead: Email preference center: Implement polished UI - https://phabricator.wikimedia.org/T290986 (10DStrine) editing the email address is now a separate task: T299962 [20:12:34] (03PS1) 10Ejegg: Remove Adyen HPP implementation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756673 (https://phabricator.wikimedia.org/T291797) [20:14:34] ahh, that's not quite complete ^^^ [20:15:04] (03CR) 10jerkins-bot: [V: 04-1] Remove Adyen HPP implementation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756673 (https://phabricator.wikimedia.org/T291797) (owner: 10Ejegg) [20:25:47] (03PS2) 10Ejegg: Remove Adyen HPP implementation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756673 (https://phabricator.wikimedia.org/T291797) [20:28:27] (03CR) 10jerkins-bot: [V: 04-1] Remove Adyen HPP implementation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756673 (https://phabricator.wikimedia.org/T291797) (owner: 10Ejegg) [20:28:47] 10Fundraising-Backlog, 10fundraising-tech-ops: python3 module for frdb1003 - https://phabricator.wikimedia.org/T299861 (10Jgreen) @Eyener you need this on fran1001 correct--for the cube scripts? Re. python version, we have Debian's stock 3.7.3 release installed. /usr/bin/python3 is a symlink to the 3.7.3 binar... [20:30:00] 10Fundraising-Backlog, 10fundraising-tech-ops: python3 module for frdb1003 - https://phabricator.wikimedia.org/T299861 (10Jgreen) python3-abba 1.0.0-1 is built and in the local deb repository, still have the puppet portion left to do [20:34:59] (03PS3) 10Ejegg: Remove Adyen HPP implementation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756673 (https://phabricator.wikimedia.org/T291797) [20:40:49] 10Fundraising-Backlog, 10FR-Adyen: Properly handle pending-poke with Adyen Checkout - https://phabricator.wikimedia.org/T299690 (10DStrine) [20:46:25] 10Fundraising-Backlog, 10fundraising-tech-ops: python3 module for frdb1003 - https://phabricator.wikimedia.org/T299861 (10EYener) Hey @Jgreen yes this will need to be on fran1001 - correct. Thanks for the note on python3 - we will keep using that path! [20:46:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Payments report: search donations by IP address - https://phabricator.wikimedia.org/T299679 (10DStrine) this should do it: https://civicrm.wikimedia.org/civicrm/report/wmffraud/fredge let's talk about how to use this in the next meeting. [20:50:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: How to Identify RML contacts in civi - https://phabricator.wikimedia.org/T299697 (10DStrine) These are all in a group: "silverpop imports' [20:55:54] jgleeson: oops, sorry, just saw your question about the use case - it would be for the form chooser. I want to get the lists of countries and currencies from the configs without instantiating a whole adapter [20:56:06] since instantiating the adapter is such a heavy process right now [20:56:21] also, it seems proper that we should pass the config into the constructor [20:58:33] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: DonationInterface: Remove Adyen hosted payment pages integration - https://phabricator.wikimedia.org/T291797 (10DStrine) [21:03:15] 10Fundraising-Backlog, 10SRE, 10SRE-Access-Requests, 10observability, 10serviceops-radar: Fundraising-Tech engineers unable to ACK icinga alerts on fr-tech host groups - https://phabricator.wikimedia.org/T298649 (10jgleeson) Great. @Volans42 are you able to demote my account to the level of @Ejegg's and... [21:07:50] 10Fundraising-Backlog, 10fundraising-tech-ops: python3-abba module for frdb1003 - https://phabricator.wikimedia.org/T299861 (10Jgreen) [21:08:10] 10Fundraising-Backlog, 10fundraising-tech-ops: python3-abba module for fundraising analytics server role - https://phabricator.wikimedia.org/T299861 (10Jgreen) [21:36:46] 10Fundraising-Backlog, 10fundraising-tech-ops: python3-abba module for fundraising analytics server role - https://phabricator.wikimedia.org/T299861 (10Jgreen) 05Open→03Resolved Done! [21:36:48] 10Fundraising-Backlog, 10fundraising-tech-ops: python3 modules for frdb1003 - https://phabricator.wikimedia.org/T247981 (10Jgreen) [21:39:42] ah gotcha ejegg. sounds good! [21:52:16] girc [21:52:25] oops [21:58:42] have a good rest of your day fr-tech. bye for now o/ [21:58:58] later! [22:00:13] fr-tech I'mma do this brainless Adyen MC task if no-one's doing it yet: T299009 [22:00:14] T299009: Create monthlyConvert variant yaml files for Adyen - https://phabricator.wikimedia.org/T299009 [22:03:33] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Create monthlyConvert variant yaml files for Adyen - https://phabricator.wikimedia.org/T299009 (10Ejegg) a:03Ejegg [22:08:56] (03PS1) 10Ejegg: Adyen monthly convert: add yaml files for variants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756706 (https://phabricator.wikimedia.org/T299009) [22:13:22] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Do not re-render Adyen card fields under MC modal - https://phabricator.wikimedia.org/T299005 (10Ejegg) Looking at this with a fresh mind, I feel like it ma... [22:32:07] (03PS1) 10Ejegg: Add Abitab cash xfer for Uruguay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756711 (https://phabricator.wikimedia.org/T208963) [22:37:27] (03CR) 10Cstone: [C: 03+2] "These look good, thanks for rearranging!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) (owner: 10Wfan) [22:57:15] (03PS6) 10Wfan: Add customized translation fields for Adyen credit card forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) [23:00:11] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) (owner: 10Wfan) [23:05:17] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10Patch-For-Review: Adyen forms for Big Bundle - https://phabricator.wikimedia.org/T293292 (10EMartin) Hi - further to the error I reported above where I... [23:05:48] fr-tech dstrine I feel we may want to look at this one at the same time as the e-mail pref ctr styling task currently in the sprint: https://phabricator.wikimedia.org/T278174 [23:06:30] how we deal with that flash of quickly hidden Mediawiki stuff might impact how we do the other styling, no? [23:08:06] also the flash is pretty ugly..... [23:11:32] (03CR) 10Cstone: [C: 03+2] "Try two 😊 Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) (owner: 10Wfan) [23:13:55] (03Merged) 10jenkins-bot: Add customized translation fields for Adyen credit card forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756052 (https://phabricator.wikimedia.org/T299788) (owner: 10Wfan) [23:30:04] AndyRussG: definitely looks worth fixing! [23:42:00] ejegg: cool thx! [23:42:40] hmmm Doggo wants to be walked............ [23:54:04] (03PS1) 10Ejegg: Add test links for Peru and Uruguay [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/756727 (https://phabricator.wikimedia.org/T208963)