[00:06:36] (03PS2) 10Ejegg: Add Abitab cash xfer for Uruguay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756711 (https://phabricator.wikimedia.org/T208963) [00:06:38] (03PS1) 10Ejegg: Add three bank methods for Peru [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756731 (https://phabricator.wikimedia.org/T208963) [00:14:07] (03PS1) 10Wfan: test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756736 [00:16:41] (03Abandoned) 10Wfan: test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756736 (owner: 10Wfan) [00:17:55] Looks like that worked ^ [00:21:57] yep [00:23:32] oh I mean Tyler helped me with the Gerrit wired issue. [00:28:16] ah cool glad to hear that :) [00:37:25] eileen: I see there's a bit of unreviewed civi patches building up btw [00:37:39] I'm about if CR would be helpful [00:37:48] AndyRussG: that would be great [00:38:02] eileen: ahh cool :) which one should I start with? [00:38:47] maybe this one? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/755522 [00:39:19] AndyRussG: yep - so cstone confirmed that script isn't used anymore [00:40:24] ah fantastic [00:41:45] AndyRussG: we used to use foundationwiki as the CMS [00:42:10] and ppl had to edit the TY email in wikitext but with twig tokens [00:42:24] and then we had to maintain regexes to fix all the horribleness [00:42:59] hmmmm [00:43:01] oki [00:45:10] regexes against horibleness [00:47:20] eileen ejegg should this line and subsequent ones not be updated, too, then? https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/126629a6da784af2020b784f9dbb77564f57a025/drupal/sites/all/modules/thank_you/thank_you.info#10 [00:47:39] also eileen ejegg so other parts of that module _are_ still used, correct?ยก [00:47:47] AndyRussG: yep, looks right [00:47:49] AndyRussG: YES - well spotted - I will remove that [00:48:12] ah okok thx [00:49:28] (03PS3) 10Eileen: Remove unused script to render thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755522 (https://phabricator.wikimedia.org/T299455) [00:49:31] AndyRussG: ^^ [00:53:42] (03CR) 10AndyRussG: [C: 03+2] "LGTM! Thx much!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755522 (https://phabricator.wikimedia.org/T299455) (owner: 10Eileen) [00:54:28] eileen ahhh I almost forgot I have to do the CentralNotice deploy before 2:00 am UTC to put accumulated updates on the main cluster deploy train [00:54:34] it shouldn't take too long tho [01:15:47] (03Merged) 10jenkins-bot: Remove unused script to render thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755522 (https://phabricator.wikimedia.org/T299455) (owner: 10Eileen) [01:43:38] (03PS4) 10Eileen: Update naming convention on template files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755524 (https://phabricator.wikimedia.org/T299455) [01:43:40] (03PS1) 10Eileen: Remove 'orphan' subjects [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/756742 [01:44:13] (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/756744 [01:44:56] (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/756744 (owner: 10AndyRussG) [01:49:13] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/756744 (owner: 10AndyRussG) [01:51:21] awwww https://poorlydrawnlines.com/comic/new-phone-2/ [01:54:13] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Fix JQMigrate warnings on payments forms - https://phabricator.wikimedia.org/T299985 (10Ejegg) [01:55:38] (03CR) 10jerkins-bot: [V: 04-1] Remove 'orphan' subjects [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/756742 (owner: 10Eileen) [01:55:58] (03CR) 10jerkins-bot: [V: 04-1] Update naming convention on template files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755524 (https://phabricator.wikimedia.org/T299455) (owner: 10Eileen) [02:14:24] https://poorlydrawnlines.com/comic/wont-sit/ [02:27:10] eileen: I see some more that are failing CI, but this one seems to be doing okok https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/755520 [02:27:47] as is this one: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/755503 [02:32:21] eileen: for the one that moves a test, I actually see a lot of differences with the original test file removed and the new one added [02:33:43] AndyRussG: yeah - there are quite a few changes - the test infrastructure is different and I did clean up - but the same things are tested [02:34:22] oki... what about maybe adding a couple lines in the commit message to explain that? [02:35:03] also is that the most prioritized one to dig into, or should I look at something else instead? [02:36:20] AndyRussG: I think they are kinda equal priority [02:36:35] oki thx [02:37:35] (03PS2) 10Eileen: Move thank you test from the module to the extension. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755520 (https://phabricator.wikimedia.org/T299455) [02:37:40] I updated the commit [02:43:25] AndyRussG: argh - I think I know what I did when I rebased that commit - [02:46:50] eileen: thx for that! hmmm I don't see anything wrong with the commit? [02:48:16] sorry the one that started failing [02:48:30] ahh right [02:48:41] what's WMF_UNSUB_SALT? [02:48:53] (just curious, I guess not important) [02:51:28] I can't remember [02:51:41] I think just to salt a hash for unsubscribes [02:51:45] awww oki [02:51:49] no worries [02:55:44] hmmm also curious why config vars are used in the test? is that what variable_get('thank_you_civimail_rate', 1.0) is fetching? [02:57:28] I'm actually not quite sure.... I think it's the idea that we create civimails but only for some letters - which gives us some extra tracking but also has performance costs - 1.0 is a 100% ratio [03:01:13] oki [03:01:44] I mean on principle I kinda would rather not have tests that depend on config, but rather always do the same thing no matter what [03:02:05] but again it's not really important, I see the old and new tests both do it [03:02:25] and I'm quite likely missing something here of course [03:02:49] AndyRussG: yeah I haven't dug into that one yet - I think it basically means 'turn on using civimail & test that' [03:03:06] & I think what we do is run that setting at different ratios on live - traffic dependent [03:03:36] but it has to be 100% in a test since if we set it to .9 tests would pass 90% of the time :-) [03:06:12] I think the test fails are because I somehow went back to an older version of the patch :-( [03:08:27] (03PS5) 10Eileen: Update naming convention on template files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755524 (https://phabricator.wikimedia.org/T299455) [03:09:26] (03PS2) 10Eileen: Remove 'orphan' subjects [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/756742 [03:11:16] hmmm [03:11:43] right so in that test we're somehow checking what the variable is set to, and then 1.0 is just the default value we get if it's unset, no? [03:12:45] AndyRussG: oh yeah that is pretty dumb [03:13:17] awww I mean it's ok really [03:13:49] maybe keep some notes somewhere in case we want to further refactor the test one day, I guess? [03:13:55] AndyRussG: so it is storing the old value (default 1) and then re-setting it afterwards to whatever it was (unless it was unset) [03:14:57] eileen: ahhh I see got it [03:15:05] k thx for the exaplanation! [03:15:05] but AndyRussG that variables will get migrated to Civicrm Settings in the next few months as we migrate off drupal [03:15:14] right [03:15:19] because variable_get is a drupal thing [03:16:21] yee right [03:19:59] "smurfalicious" lol [03:22:43] :-) [03:23:00] AndyRussG: unfortunately that does require adding the word to my spell checker [03:33:02] eh spellchecker's fault for not having it already [03:42:15] (03CR) 10AndyRussG: [C: 03+2] "Coooool thx for this!!!! :) :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755520 (https://phabricator.wikimedia.org/T299455) (owner: 10Eileen) [03:42:29] thanks AndyRussG & yeah spell check was remiss [03:48:44] thank u! [03:54:09] (03Merged) 10jenkins-bot: Move thank you test from the module to the extension. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755520 (https://phabricator.wikimedia.org/T299455) (owner: 10Eileen) [03:54:44] eileen https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/755503 looks very safe, and sane... only question I can think to ask is if it's been smoke tested? [03:55:13] AndyRussG: yep - it's just something that got forgot [03:55:23] oki cool! [03:56:12] (03CR) 10AndyRussG: [C: 03+2] "nice catch!!! :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755503 (https://phabricator.wikimedia.org/T299011) (owner: 10Eileen) [03:56:57] K I think that's all my brain can do for today..... [03:57:14] thx much for the help with CR and apologies for the silly questions... [04:01:54] thanks Andy! [04:04:32] same :) [04:07:00] (03Merged) 10jenkins-bot: Add year filter into update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755503 (https://phabricator.wikimedia.org/T299011) (owner: 10Eileen) [05:02:44] (03CR) 10Cstone: "Look's really good just a couple little things." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/755523 (https://phabricator.wikimedia.org/T293292) (owner: 10Wfan) [05:27:22] (03PS3) 10Wfan: Add extra translation for adyen check out form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/755523 (https://phabricator.wikimedia.org/T293292) [05:33:52] (03PS4) 10Wfan: Add extra translation for adyen check out form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/755523 (https://phabricator.wikimedia.org/T293292) [05:59:51] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/756788 (owner: 10L10n-bot) [07:46:24] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/DonationInterface] (REL1_36) - 10https://gerrit.wikimedia.org/r/756788 (owner: 10L10n-bot) [09:04:11] 10Fundraising-Backlog, 10SRE, 10SRE-Access-Requests, 10observability, 10serviceops-radar: Fundraising-Tech engineers unable to ACK icinga alerts on fr-tech host groups - https://phabricator.wikimedia.org/T298649 (10Volans) a:05cmooneyโ†’03jhathaway Thanks for checking @Ejegg. @jgleeson sure, we can do... [15:36:55] (03PS4) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [15:39:31] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [16:13:36] hey damilare, have you done much with TypeScript? [16:13:57] yes I have [16:18:38] great damilare. I'm going through the Adyen Checkout SDK which is written in TS trying to figure out the best way to trigger the applepay payment on load. I'm down to my last option and not confident this is gonna work. It would be good to get a second opinion and talk over the code if you have some time today around your current priorities [16:20:52] Hey fr-tech, because it never ends, Dylan is home with COVID-like symptoms. I'm going to take her to get tested, and I'll be out for however long that takes. [16:21:04] jgleeson, I'll probably miss our check-in this morning. [16:21:14] Maybe the later meetings too, depending on how things go. [16:21:51] XenoRyet: hope she feels better soon! [16:23:42] sure jgleeson: would love to [16:23:59] np XenoRyet. hope it's just a cold! [16:24:19] thanks damilare! lemme know when it good for you [16:24:22] XenoRyet: take your time, hope Dylan gets well soon. [16:24:48] We could discuss now if that's fine [16:26:40] great damilare. wanna use our call from yesterday? [16:34:55] hi damilare jgleeson XenoRyet fr-tech :) [16:36:09] hi AndyRussG [16:36:12] L:) [16:36:20] :) [16:47:29] Hi fr-tech [16:47:50] :) [17:06:13] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for pcoombe - https://phabricator.wikimedia.org/T299948 (10Dwisehaupt) SSL cert renewed and sent via email. Password sent via SMS. [17:07:25] hi cstone! [17:38:23] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for pcoombe - https://phabricator.wikimedia.org/T299948 (10Dwisehaupt) 05Openโ†’03Resolved Verified cert is working. [17:44:03] hi AndyRussG cstone fr-tech [17:44:17] :) [17:45:03] dstrine: hi! how's it going? ahhh how would you feel about bringing T278174 into the sprint, as a quick and needed-anyway prerequisite to T290986? [17:45:03] T278174: Fix flash of Mediawiki UI elements on Special:EmailPreferences - https://phabricator.wikimedia.org/T278174 [17:45:04] T290986: Email preference center: Implement polished UI - https://phabricator.wikimedia.org/T290986 [17:45:37] I mean prerequisite in that for coding it makes sense to fix the flash first, since that could determine how we approach the rest of the styling [17:45:42] fr-tech ^ ? [18:01:20] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10fr-email-preference-center: Fix flash of Mediawiki UI elements on Special:EmailPreferences - https://phabricator.wikimedia.org/T278174 (10DStrine) [18:01:43] AndyRussG: I pulled it in^^ [18:02:23] (03PS5) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [18:02:28] dstrine: great thanks! [18:05:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [18:41:23] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for nisrael - https://phabricator.wikimedia.org/T299938 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [18:46:56] (03CR) 10Ejegg: "Thanks! Some suggestions inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [18:51:52] ejegg: thanks for the comments, would update those soon [19:03:55] (03CR) 10Damilare Adedoyin: "Thanks Elliot" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [19:04:30] fr-tech: I'm back now, turned out the testing site I went to only had PCR tests, so those results won't be back for a few days, but I was able to find some at-home rapid tests on the way home, and that came out negative. [19:04:35] So looks like just a normal cold. [19:05:50] good to hear XenoRyet [19:09:16] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10fr-email-preference-center: Fix flash of Mediawiki UI elements on Special:EmailPreferences - https://phabricator.wikimedia.org/T278174 (10AndyRussG) a:03AndyRussG [19:09:36] XenoRyet: ah cool! [19:13:12] fr-tech something or other about how styles are injected seems to cause a flash of hidden Mediawiki elements on the e-mail preferences pages but not on the payments forms [19:14:07] if anyone has any guesses as to the cause of the difference, pls lmk... I was guessing something about how the RL modules are added, but it looks like it's all the same at this point [19:23:10] AndyRussG: both are hiding it in stylesheets loaded via load.php, right? [19:23:30] could your payments form css just be better cached? [19:26:48] that's correct... and nope definitely not a local caching issue [19:27:53] ejegg try this: load each with (or without) debug=true, network browser tools tab open, cache disabled, and network throttled heavily by the browser [19:28:02] So for payments forms, is the hide css coming in the same resourceloader request as the skin css? [19:28:19] ahh, but debug=true is not the way users experience the page [19:28:23] no flash as it loads on a payments form, yes flash as it loads on e-mail pref ctr [19:28:28] yeah also same without debug=true [19:29:05] here's a test URL for fundraising-dev: https://localhost:9002/index.php/Special:EmailPreferences/emailPreferences?contact_hash=4175270008&contact_id=185 [19:29:19] (check our local civicrm_contacts table for a valid contact_id and hash) [19:29:26] k, I'll look after this meeting I have [19:30:05] ejegg: thx! also no worries, I was just wondering if anyone just already knew the answer :) [19:42:08] (03CR) 10Damilare Adedoyin: "Hi Elliot, once again thanks for reviewing this. Just realised some of my responses weren't saved earlier." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [19:47:33] ejegg: found it... it's a slightly different RL call, addModuleStyles(), that does it :) [19:49:21] aha! [19:49:22] that plus the RL module has to be styles-only [19:51:27] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Remove PayPal classic integration from DonationInterface - https://phabricator.wikimedia.org/T300068 (10Ejegg) [19:53:21] (03Abandoned) 10Cstone: WIP: Add custom languages for Adyen credit card forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/754058 (https://phabricator.wikimedia.org/T293292) (owner: 10Cstone) [20:05:58] (03PS5) 10Wfan: Add extra translation for adyen check out form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/755523 (https://phabricator.wikimedia.org/T293292) [20:10:03] (03PS1) 10AndyRussG: Separate RL style module to hide MW elements, fix loading on Special:EmailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/757084 (https://phabricator.wikimedia.org/T278174) [20:25:51] (03CR) 10Cstone: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/755523 (https://phabricator.wikimedia.org/T293292) (owner: 10Wfan) [20:36:46] (03Merged) 10jenkins-bot: Add extra translation for adyen check out form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/755523 (https://phabricator.wikimedia.org/T293292) (owner: 10Wfan) [20:36:59] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10Patch-For-Review: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10DStrine) @EMartin we are still waiting on setting up... [20:37:47] 10Fundraising-Backlog, 10FR-Adyen: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 (10DStrine) [20:38:02] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising sprint Yeet-coaster, 10Patch-For-Review: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10EMartin) Ah. OK. I saw them respond so let me get... [20:41:05] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Do not re-render Adyen card fields under MC modal - https://phabricator.wikimedia.org/T299005 (10DStrine) 05Openโ†’03Invalid [20:41:09] 10Fundraising-Backlog, 10FR-Adyen: EPIC: Monthly convert for Adyen - https://phabricator.wikimedia.org/T290338 (10DStrine) [20:42:46] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Yeet-coaster, and 4 others: implement Italy email the old school way ... this one last time - https://phabricator.wikimedia.org/T298908 (10DStrine) @CDenes_WMF I will close this by... [20:51:30] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Adyen: dedupe support for apple pay weird names - https://phabricator.wikimedia.org/T298547 (10Eileenmcnaughton) This is the function where we would add support for a more flexible match - in WMFCo... [20:52:36] (03CR) 10Ejegg: "Thanks, Wenjun! Some suggestions inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756677 (https://phabricator.wikimedia.org/T299001) (owner: 10Wfan) [20:57:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [21:02:13] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [21:13:33] (03PS6) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [21:15:27] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [21:18:43] 10Fundraising-Backlog, 10FR-Adyen: Optimization of Apple Pay Flow - https://phabricator.wikimedia.org/T295092 (10jgleeson) I looked into this and it doesn't look straightforward. I spent longer than the hour allocated trying to work around Apple Pay's requirement for the user to psychically "click" the Apple... [21:57:09] (03PS7) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [21:59:14] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [22:01:26] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Adyen: dedupe support for apple pay weird names - https://phabricator.wikimedia.org/T298547 (10jgleeson) a:03jgleeson [22:02:47] (03PS8) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [22:05:59] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [22:11:56] (03PS9) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [22:15:10] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [22:19:19] (03PS10) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [22:22:02] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [22:23:19] (03PS11) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [22:25:37] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [22:30:14] (03PS12) 10Damilare Adedoyin: WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) [22:32:56] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow rendering MC modal outside of ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756545 (https://phabricator.wikimedia.org/T299100) (owner: 10Damilare Adedoyin) [22:34:10] (03PS9) 10Wfan: WIP: Tokenize the adyen monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756677 (https://phabricator.wikimedia.org/T299001) [22:48:00] (03PS10) 10Wfan: WIP: Tokenize the adyen monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/756677 (https://phabricator.wikimedia.org/T299001) [23:05:03] (03PS6) 10Eileen: Update naming convention on template files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/755524 (https://phabricator.wikimedia.org/T299455) [23:05:05] (03PS3) 10Eileen: Remove 'orphan' subjects [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/756742 [23:05:07] (03PS1) 10Eileen: Move all thank you templates to wmf-civicrm extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757113 (https://phabricator.wikimedia.org/T299455) [23:07:42] (03PS4) 10Eileen: Remove 'orphan' subjects [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/756742 [23:07:44] (03PS2) 10Eileen: Move all thank you templates to wmf-civicrm extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757113 (https://phabricator.wikimedia.org/T299455) [23:08:47] (03PS2) 10Ejegg: Separate RL style module to hide MW elements, fix loading on Special:EmailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/757084 (https://phabricator.wikimedia.org/T278174) (owner: 10AndyRussG) [23:09:20] (03CR) 10Ejegg: [C: 03+2] "Thanks! Looks like we can use this to de-duplicate a couple rules in gateway.css. I'll put up a followup patch for that." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/757084 (https://phabricator.wikimedia.org/T278174) (owner: 10AndyRussG) [23:14:44] (03PS1) 10Ejegg: Dedupe some CSS rules to hide MW interface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/757114 [23:16:13] (03PS1) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/757115 [23:17:54] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/757115 (owner: 10Wfan) [23:19:28] (03PS1) 10Ejegg: Replace deprecated ApiBase constants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/757116 [23:19:41] (03CR) 10Wfan: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/757115 (owner: 10Wfan) [23:24:03] (03CR) 10jerkins-bot: [V: 04-1] Move all thank you templates to wmf-civicrm extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757113 (https://phabricator.wikimedia.org/T299455) (owner: 10Eileen) [23:30:21] (03PS3) 10Eileen: Move all thank you templates to wmf-civicrm extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757113 (https://phabricator.wikimedia.org/T299455) [23:39:27] ejegg: I'm just looking at the class 'ICiviMailBulkStore' & I think it was probably a good idea someone had a long time ago that never really got used? [23:44:37] eileen: good question, lemme refresh my memory [23:45:57] sure don't see it used anywhere in the current codebase [23:48:41] eileen: aha, it was an early attempt at Silverpop sync [23:49:59] ejegg: ok - I'll rip it out & turn the other back into just a class (no interfaced needed since we didn't go further down that path) [23:50:04] https://phabricator.wikimedia.org/rWFCGfd78777e7fc3edb41baa74fbc179a713152c1a38 [23:50:27] eileen: you can rip out the whole BulkStore, implementation too [23:54:15] hmm, maybe we can add api4 stubs for the mail jobs tables and rip out the rest of those classes too [23:54:47] (03PS1) 10Eileen: Remove CiviMailBulk code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757118 (https://phabricator.wikimedia.org/T299455) [23:55:05] ejegg: yeah I suspect so ^^ removes the bulk class [23:55:30] thanks! Happy to sign the death certificate [23:55:49] looks like the indentation got a lil janky on the fn comments in CiviMailingRecord there [23:55:53] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/757118/1/drupal/sites/all/modules/wmf_communication/CiviMail/CiviMailingRecord.php [23:57:42] ejegg: that spacing actually looks OK in the UI - I think there must be some tabs in there (which there shouldn't be) [23:58:25] oh yeah, it's all mediawiki style in that folder