[00:00:33] 10Fundraising-Backlog, 10FR-Amazon, 10MediaWiki-extensions-DonationInterface: Amazon Pay should send full name to Civi - https://phabricator.wikimedia.org/T300691 (10Ejegg) [00:12:43] 10Fundraising Sprint Princess Mongodb, 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Email preference center: create new mail type "Email Preference Country" - https://phabricator.wikimedia.org/T280674 (10AnnWF) a:03AnnWF [01:25:18] (03PS1) 10Eileen: Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758991 [01:26:30] (03PS1) 10Eileen: Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758992 [01:31:10] thanks eileen ! [01:34:36] (03CR) 10jerkins-bot: [V: 04-1] Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758991 (owner: 10Eileen) [01:36:00] (03PS2) 10Ejegg: Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758991 (owner: 10Eileen) [01:36:03] (03PS3) 10Eileen: Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758991 [01:36:05] (03PS2) 10Eileen: Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758992 [01:36:07] (03PS13) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 [01:36:30] (03CR) 10Ejegg: [C: 03+2] Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758991 (owner: 10Eileen) [01:36:38] lol duelling rebases [01:36:43] ejegg: opps [01:36:47] (03CR) 10Ejegg: [C: 03+2] Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758992 (owner: 10Eileen) [01:36:59] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Drupal upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758991 (owner: 10Eileen) [01:37:19] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758992 (owner: 10Eileen) [01:37:19] I have a feeling we have to force through the verify - something about our weird namespaces [01:37:34] yah, just force-submitted [01:37:49] I can do the deploy [01:38:26] oh actually, do you feel comfortable reviewing this test fix/ smashpig upgrade patch? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/758573 [01:38:55] I want to get that out before Evelyn tests all the new DLocal payment methods [01:39:04] it includes some new updates to the decoder ring [01:39:34] but also includes a refactor to the PaymentProcessorResponse base class that means I had to add all those ->setSuccessful calls in the test setup [01:42:15] if it looks weird, nbd, I'll just deploy the already-merged stuff [01:43:47] (03PS14) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 [01:46:07] ejegg: OK - I can accept that as not being totally scary test changes :-) & smashpig stuff already reviewed [01:46:12] (03CR) 10Eileen: [C: 03+2] Update SmashPig and fix tests to match [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758573 (owner: 10Ejegg) [01:46:16] thanks! [01:46:23] I'll prep that deploy now [01:48:31] (03PS1) 10Ejegg: Update drush and smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/758994 [01:48:34] (03CR) 10Ejegg: [C: 03+2] Update drush and smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/758994 (owner: 10Ejegg) [01:49:26] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758995 [01:49:30] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758995 (owner: 10Ejegg) [01:51:32] oh shoot, we don't have a drush script to add missing payment instruments? [01:51:40] I guess I need another wmf_civicrm.install fn then [01:53:53] (03PS1) 10Ejegg: Add missing payment instruments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758996 [01:54:18] eileen: any chance you want to help me sneak one more patch into this deploy? ^^^^ [01:54:35] (03PS15) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 [01:55:39] (03CR) 10Eileen: [C: 03+2] Add missing payment instruments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758996 (owner: 10Ejegg) [01:55:43] thanks! [01:56:04] ejegg: ok - those need moving over to being 'managed' but I see the others aren't yet - prob some complexity [01:56:21] yep, that sounds about right [01:57:11] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758997 [01:57:56] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update drush and smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/758994 (owner: 10Ejegg) [02:14:47] hmm, I might force-merge that last one too [02:14:53] 18 minutes in the zuul queue [02:14:56] (03CR) 10Ejegg: [V: 03+2] Add missing payment instruments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758996 (owner: 10Ejegg) [02:15:05] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758997 (owner: 10Ejegg) [02:15:46] yeah zuul - take that [02:16:20] oops, I meant to snag the change-id from the old footer but ended up with two merge patches [02:16:25] abandoning one [02:16:30] (03Abandoned) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758995 (owner: 10Ejegg) [02:16:37] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758997 (owner: 10Ejegg) [02:18:46] (03CR) 10Eileen: Add isLowConfidenceNameSource flag to WMFConact::save() API Action (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758897 (https://phabricator.wikimedia.org/T298547) (owner: 10Jgleeson) [02:19:53] (03CR) 10Eileen: "Hmm looking at the test fails on the other you might need to cast to bool" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758897 (https://phabricator.wikimedia.org/T298547) (owner: 10Jgleeson) [02:19:55] !log updated CiviCRM from 0513f1b7 to 3d379e25 [02:19:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:21:34] (03CR) 10Eileen: Add isLowConfidenceNameSource flag to WMFConact::save() API Action (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758897 (https://phabricator.wikimedia.org/T298547) (owner: 10Jgleeson) [02:22:32] oh shoot, missing module warnings for wmf_eoy_receipt on prod [02:24:53] (03CR) 10Eileen: WIP: Add isLowConfidenceNameSource check to getExistingContactID lookup (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758954 (https://phabricator.wikimedia.org/T298547) (owner: 10Jgleeson) [02:25:13] (03CR) 10Ejegg: Add isLowConfidenceNameSource flag to WMFConact::save() API Action (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758897 (https://phabricator.wikimedia.org/T298547) (owner: 10Jgleeson) [02:25:37] ejegg: ug - those are a pain - can we revert the extension to exist & then uninstall & re-remove? [02:26:17] i think so - let's see if that's back before the civi version upgrade [02:27:06] eileen ejegg hi, finally back at the keyboard [02:27:09] ejegg: can you merge this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/758959 - I can see someone spending time if that comment isn't there [02:27:26] (03PS2) 10Ejegg: Add code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758959 (owner: 10Eileen) [02:27:31] (03CR) 10Ejegg: [C: 03+2] Add code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758959 (owner: 10Eileen) [02:27:32] hey AndyRussG I found a few things that I fixed in the meantime [02:27:36] hi AndyRussG [02:27:55] heyy :) [02:28:42] ah cool... so suggestions for anything I should start looking at? also not wishing to overlap with or interrupt whatever ejegg you're looking at? [02:29:13] AndyRussG: do you want to hangout ? [02:29:15] eileen darn, it IS a while before the last civicrm upgrade [02:29:27] we could do the rollback, but we'd want to stop queues [02:29:35] this is the patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/757286 [02:29:37] eileen: sure gimme 2 min then pls [02:29:40] ejegg - that's odd [02:30:00] The EOY removal was on Dec 13th [02:30:09] and we did a Civi upgrade on Jan 10th [02:31:10] I can also try just deleting the relevant row from drupal.system [02:31:30] but that doesn't always work for me locally [02:32:13] eileen K all set anytime [02:32:45] ejegg will you be joining the civi evening party? [02:32:51] not right now [02:32:57] aww oki [02:33:00] (03PS1) 10Eileen: Revert "Finally fully remove the drupal module" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758999 [02:33:10] ejegg: I think we can just revert that for now [02:33:12] ^^ [02:33:18] & then disable & re-apply [02:33:24] it has no real code in it [02:33:37] ahh [02:33:45] https://meet.google.com/pau-rggj-byc?authuser=0&hs=122 [02:34:06] sure, I thought you meant roll back the whole codebase using the frpm deploy tools [02:34:18] but yeah, this works too [02:34:31] ejegg: no that would be a bit much! [02:34:40] heck, if we're mickey mousing it this way, might as well just do the revert against deploy [02:34:48] ejegg: sure [02:34:58] fr-tech btw anyone else wishing to look at civi stuff is welcome also of course ^ [02:35:03] I could swear I disabled that extension but ..... [02:36:31] (03PS1) 10Ejegg: Revert "Finally fully remove the drupal module" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/759000 [02:36:46] (03Abandoned) 10Ejegg: Revert "Finally fully remove the drupal module" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758999 (owner: 10Eileen) [02:36:59] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Revert "Finally fully remove the drupal module" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/759000 (owner: 10Ejegg) [02:38:19] huh, wmf_eoy_receipt is already disabled [02:38:32] right, disable then... uninstall? [02:39:34] ok, uninstalled it bia the UI [02:40:03] oh hah, recurring globalcollect module was on that uninstall list too [02:40:09] ok, should be good and gone [02:40:20] will re-delete on deploy [02:40:26] (03Merged) 10jenkins-bot: Add code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758959 (owner: 10Eileen) [02:40:47] (03PS1) 10Ejegg: Revert "Revert "Finally fully remove the drupal module"" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758914 [02:41:04] ejegg: how sore is your brain right now? [02:44:22] hah, not too bad [02:46:25] (03CR) 10Ejegg: [C: 03+2] Revert "Revert "Finally fully remove the drupal module"" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758914 (owner: 10Ejegg) [02:49:18] wat, wmf_test_settings module? [02:49:42] that's been disabled on prod for a long time apparently [02:50:15] ohhh kayyy, it's a module with 1 form, to set the wmf_test_settings_email variable? [02:50:20] k, that can definitely go [02:51:04] uninstalled on prod [02:53:07] (03PS1) 10Ejegg: Remove tiny crufty drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759001 [02:59:29] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, and 3 others: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10Ejegg) OK @EMartin this is really ready to test now.... [03:02:20] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations, 10Patch-For-Review: Monthly convert amounts should be set in config - https://phabricator.wikimedia.org/T283834 (10Ejegg) p:05Triage→03Low a:03Ejegg [03:04:08] (03PS16) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 [03:04:10] (03PS1) 10Eileen: Add rt div for hebrew [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759002 [03:15:04] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Revert "Revert "Finally fully remove the drupal module"" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/758914 (owner: 10Ejegg) [03:21:34] (03PS1) 10Ejegg: Uncomment PE + UY form settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759003 [03:22:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [03:22:41] (03PS1) 10Ejegg: Add validation pattern for ZA National ID [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759004 [03:27:12] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [03:31:21] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Expand list of supported submethods for 3d Secure - https://phabricator.wikimedia.org/T300188 (10EMartin) Here's the list of cards which support 3DS through Adyen: {F34940225} [03:31:43] (03PS1) 10Eileen: Add full stop [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759006 [04:14:29] AndyRussG: I'm back if you have any questions [04:15:56] eileen: ah cool thx [04:16:34] (03CR) 10Eileen: [C: 03+2] "Another one bites the dust!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759001 (owner: 10Ejegg) [04:17:04] I have just been doing a bit of housework heheh... I think I understand how to dig in a bit more tho, so I could do so now and I'll let you know if I have questions shortly? [04:23:22] eileen: ^ [04:25:30] AndyRussG: great - I might go & get 30 -40 mins of movement & then check in [04:25:48] ok sounds gret [04:25:51] *great [04:28:01] (03Merged) 10jenkins-bot: Remove tiny crufty drupal module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759001 (owner: 10Ejegg) [04:40:57] eileen: can we add a bug tag to the smarty patch? [04:42:29] Andy yep - are you ok with me squishing the other 2 patches into that 1 to keep it simple [04:44:34] (03PS17) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [04:44:59] eileen sure if that works for you? I guess fixing the missing "." is conceptually kinda separate but if it's easiest for you to roll it in, I think that's okok [04:45:08] really not important [04:49:42] eileen: where would be the first place you'd suggest to put a breakpoint for debugging through this? [04:49:47] AndyRussG: yeah - I can just see this could wind up getting complicated since I think there are likely to be multiple changes [04:49:56] okok sure [04:50:07] ah also btw if you were having breakpoint issues you may want to check out your xdebug logs [04:50:19] thank_you_send_mail [04:50:50] okok thx! [04:50:54] that function is changed to use the new render method [04:51:44] k [04:52:07] Note that civi deals with language (e.g en_US) & mediawiki with 'locale' eg 'en' - or sometimes 'en-US' - where you see 'language' it will be the civi variant - but the difference is artifical because locale is also a valid name for the 'en_US" version [04:52:33] right I was about to ask about the locale vs language stuff [05:09:32] eileen: is the change on line 431 of ty.module, "'stock_value' => $mailingData['stock_value'] ? : NULL" related to the templating change? [05:09:49] just asking 'cause if it is, maybe other fields might need the same change? [05:17:10] or maybe it's unrelated? would we be getting a runtime error there anyway if that were undefined? [06:31:30] AndyRussG: it's because I hit enotices in the tests :-) obviously in some flows it isn't defined [06:32:59] I think smarty is more intolerant to notices maybe [06:34:55] ah okok thx! [12:54:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can't view the stock information for stock gifts - https://phabricator.wikimedia.org/T300732 (10RLewis) [14:23:08] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgreen - https://phabricator.wikimedia.org/T299946 (10Jgreen) 05Open→03Resolved [15:22:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [15:27:11] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [15:35:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Engage civi user getting error and strange formatting on records - https://phabricator.wikimedia.org/T300387 (10MDemosWMF) Just heard from the user that all is back to normal in civi this morning. Not sure what... [15:38:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Engage civi user getting error and strange formatting on records - https://phabricator.wikimedia.org/T300387 (10DStrine) @MDemosWMF ok thanks. We were a little confused by the screen shot in #2. we couldn't tell... [15:59:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Engage civi user getting error and strange formatting on records - https://phabricator.wikimedia.org/T300387 (10MDemosWMF) Thanks! Sounds good. She was just saying the formatting was different than her normal la... [16:38:03] (03PS3) 10Jgleeson: Add isLowConfidenceNameSource check to getExistingContactID lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758954 (https://phabricator.wikimedia.org/T298547) [16:49:39] (03CR) 10jerkins-bot: [V: 04-1] Add isLowConfidenceNameSource check to getExistingContactID lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/758954 (https://phabricator.wikimedia.org/T298547) (owner: 10Jgleeson) [17:21:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can't view the stock information for stock gifts - https://phabricator.wikimedia.org/T300732 (10DStrine) a:05DStrine→03None [17:23:05] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add unit tests for Google Pay - https://phabricator.wikimedia.org/T300689 (10DStrine) [17:23:21] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Document Google Pay - https://phabricator.wikimedia.org/T300688 (10DStrine) [17:23:36] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add recurring for Google Pay - https://phabricator.wikimedia.org/T300687 (10DStrine) [17:23:45] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add Google Pay JS to Donation Interface - https://phabricator.wikimedia.org/T300686 (10DStrine) [17:23:57] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add Google Pay Provider and Api calls to SmashPig - https://phabricator.wikimedia.org/T300685 (10DStrine) [17:32:12] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Automatically populate created date on relationships - https://phabricator.wikimedia.org/T294487 (10Ejegg) [17:34:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Engage civi user getting error and strange formatting on records - https://phabricator.wikimedia.org/T300387 (10DStrine) p:05Triage→03Low [17:34:52] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings: Pending transaction resolver losing recurring tokens - https://phabricator.wikimedia.org/T300281 (10DStrine) p:05Triage→03Medium [17:34:59] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings: turn on matching gifts as default - https://phabricator.wikimedia.org/T300086 (10DStrine) p:05Triage→03High [17:35:07] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10FR-Adyen, 10FR-Gpay-Integration: Investigate gpay implementation - https://phabricator.wikimedia.org/T299591 (10DStrine) p:05Triage→03Medium [17:35:18] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10FR-Adyen: payments fr-tech-dev server should serve something when ports are not forwarded - https://phabricator.wikimedia.org/T296860 (10DStrine) p:05Triage→03Medium [17:35:25] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10fr-email-preference-center, 10MW-1.38-notes (1.38.0-wmf.20; 2022-01-31): Fix flash of Mediawiki UI elements on Special:EmailPreferences - https://phabricator.wikimedia.org/T278174 (10DStrine... [17:35:39] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings, 10FR-Email: Link mailing data to contacts imported from RML - https://phabricator.wikimedia.org/T222854 (10DStrine) p:05Triage→03Medium [17:36:00] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10fr-email-preference-center, 10MW-1.38-notes (1.38.0-wmf.20; 2022-01-31): Fix flash of Mediawiki UI elements on Special:EmailPreferences - https://phabricator.wikimedia.org/T278174 (10DStrine... [17:51:40] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jmando - https://phabricator.wikimedia.org/T300762 (10Dwisehaupt) [17:52:14] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for mdemos - https://phabricator.wikimedia.org/T300763 (10Dwisehaupt) [17:52:45] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for aparker - https://phabricator.wikimedia.org/T300764 (10Dwisehaupt) [17:53:15] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewilson - https://phabricator.wikimedia.org/T300765 (10Dwisehaupt) [17:53:41] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lpapadimitriou - https://phabricator.wikimedia.org/T300766 (10Dwisehaupt) [17:54:29] 10Fundraising-Backlog, 10Analytics-Radar, 10Product-Analytics, 10Wikipedia-iOS-App-Backlog, and 2 others: Understand impact of Apple's Relay Service - https://phabricator.wikimedia.org/T289795 (10nettrom_WMF) 05Open→03Resolved We've complete the analyses in the subtasks and continued to monitor views f... [17:54:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for spatton - https://phabricator.wikimedia.org/T300767 (10Dwisehaupt) [17:54:50] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for khancock - https://phabricator.wikimedia.org/T300768 (10Dwisehaupt) [20:00:54] (03PS1) 10Ejegg: Set success status on top-level Ingenico error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/759304 [20:01:05] cstone: ^^^ should fix it, I think [20:01:28] the rest of the code paths look like they all set successful to either true or false [20:01:37] ah okay [20:17:16] hmm my docker civi has decided to not exist [20:20:06] (03CR) 10Cstone: [C: 03+2] "Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/759304 (owner: 10Ejegg) [20:20:35] (03Merged) 10jenkins-bot: Set success status on top-level Ingenico error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/759304 (owner: 10Ejegg) [20:23:21] thanks cstone! [20:23:33] I'll push another minor point release [20:24:06] thanks ejegg I can reset the recurring after that (it got stuck at processing) [20:26:01] oh cool, thanks for that! [20:34:51] (03PS1) 10Ejegg: Update SmashPig for recurring charge fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759328 [20:34:54] (03CR) 10Ejegg: [C: 03+2] Update SmashPig for recurring charge fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759328 (owner: 10Ejegg) [20:36:06] (03PS1) 10Ejegg: Update SmashPig for recurring charge fix [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/759329 [20:36:11] (03CR) 10Ejegg: [C: 03+2] Update SmashPig for recurring charge fix [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/759329 (owner: 10Ejegg) [20:38:01] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/759330 [20:38:09] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/759330 (owner: 10Ejegg) [20:38:23] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update SmashPig for recurring charge fix [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/759329 (owner: 10Ejegg) [20:42:57] oh wow the charge job is still running [20:43:01] still 3 out of 13k isnt the worst [20:43:40] ooh, we might have to adjust that schedule sooner rather than later, huh? [20:43:58] yeah the first and last days of the month are recurring heavy [20:44:06] there will def be an issue the end of this month [20:44:37] hah, right, Feb 28 it'll just run nonstop all day [20:44:51] yeah [20:45:35] (03Merged) 10jenkins-bot: Update SmashPig for recurring charge fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759328 (owner: 10Ejegg) [20:51:46] damilare: I realised earier there might be an even easier way to intercept the Relationship create params in civicrm. So instead of extending and changing the method in an extension, you might be able to attach your code to an existing/new hook called when the create relationship behaviour is called [20:53:49] which phab are you looking at? [20:54:13] I see - will add notes [20:54:25] https://phabricator.wikimedia.org/T294487 [20:54:49] thanks eileen [20:56:34] jgleeson: we talked over that one, and it looks like eileen already made a pull request for that change upstream [20:57:42] oh cool was that on tech-talk? I'll check out the recording if so [20:58:05] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Automatically populate created date on relationships - https://phabricator.wikimedia.org/T294487 (10Eileenmcnaughton) I have done some work upstream to get 2 ne... [20:58:20] jgleeson: not sure when we discussed - I just added a link to the upstream issue [20:58:22] jgleeson: no, we just stayed on after standup today [20:58:50] actually in our video call we were discussing how Dami could do the upstream core change himself [20:58:50] ah ok [20:59:07] I can see the way eileen tackled it is very different to what I thought was the way to go [20:59:11] but then when he went to make the edits he found Eileen already had a pull request in [20:59:28] much less work! [21:00:01] jgleeson: yeah, the original request was one of those things where the user asks for one thing but the best thing for them is something different [21:00:20] i.e not misusing 'start date' which has its own meaning [21:01:05] lol - yeah I did kinda re-interpret what they wanted :-) [21:21:24] fr-tech I'm gonna finish a bit earlier tonight and make it up tomorrow. I decided to go the gym this evening to break up the day and then do my last hour or so afterwards which turned out to be a bad idea as I'm falling asleep typing. [21:21:40] have a good one [21:23:22] hmm, that merge to deploy didn't actually finish? [21:23:58] oh drat, I didn't have the latest? [21:25:52] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/759330 [21:26:19] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/759330 (owner: 10Ejegg) [21:36:17] !log updated CiviCRM from 2bd5fb5e to 7dcdc017 [21:36:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:36:28] ok cstone that fix is out [21:36:36] thanks ejegg ! [21:52:58] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewilson - https://phabricator.wikimedia.org/T300765 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [21:56:37] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for cstone - https://phabricator.wikimedia.org/T300554 (10Dwisehaupt) Certificate renewed and files place on frpm1001. cstone informed of where to collect them for install. [22:07:26] 10Fundraising Sprint Princess Mongodb, 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Email preference center: create new address type "Email Preference Country" - https://phabricator.wikimedia.org/T280674 (10Ejegg) [22:11:27] (03PS18) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [22:16:32] (03PS1) 10Eileen: Remove CiviMailStore interface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759347 [22:17:31] ejegg: I'm having namespace pain since that drupal upgrade - not sure if it's cached somewhere but stuff in wmf_communication seems to be playing silly buggers. I might just move the classes outa there though since that namespacing has always been fraught eg ^^ [22:18:08] weird [22:19:02] yeah - maybe I could just re-build - but then again it has to change at somepoint. We have that drupal hack but I did keep it.... [22:19:14] maybe my registry rebuild in between the 2 patches [22:20:24] if I move the wmf civimail classes to an extension - I'm dithering about which one - wmf_civicrm is a bit of a catchall, wmf_thankyou is the thank you mail outgoings or the 3rd option is a specific but narrow extension. I'm not leaning towards 3 [22:20:49] in 1 there is a namespace Civi\WMFHelpers [22:21:06] so it could be Civi\WMFHelpers\CiviMail [22:21:07] eileen: ah, so there's still no easy replacement of what they're doing with API3/4 calls? [22:21:55] erm definite maybe - I haven't figured out how much magic is in there [22:21:59] It's basically just saving new records to the civicrm_mailing_* tables, right? [22:22:22] oh, looks like one VERP convenience method [22:22:51] if not, Civi\WMFHelpers\CiviMail seems fine to me [22:25:25] ejegg: yeah I think I'll move then upgrading is optional [22:34:07] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings: Pending transaction resolver losing recurring tokens - https://phabricator.wikimedia.org/T300281 (10Ejegg) a:03Ejegg [22:35:41] (03PS1) 10Eileen: Remove addActivity function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759349 [22:35:55] ejegg: well there is one I CAN replace with an api call ^^ [22:39:35] oh cool [22:43:56] this is where it is confusing - https://github.com/civicrm/civicrm-core/pull/22624 I think the BAO would do 'what we want' with the right params (mostly) but kinda need to discuss those with Tim & Coleman [22:51:01] (03PS19) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [22:52:09] dang I though gerrit might display as a table :-( https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/757286/18 [23:06:54] (03PS1) 10Ejegg: Pending txn resolver: send recurring tokens to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759360 (https://phabricator.wikimedia.org/T300281) [23:07:16] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings, 10Patch-For-Review: Move transactional email code to start using email template UI - https://phabricator.wikimedia.org/T299455 (10Eileenmcnaughton) This maps... [23:10:40] (03CR) 10Ejegg: "Might be worth moving the function comments over?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759347 (owner: 10Eileen) [23:13:37] (03PS2) 10Eileen: Remove CiviMailStore interface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759347 [23:14:02] (03CR) 10Eileen: "Yep true ejegg - I put them back except addActivity because I have a commit to remove that fn" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759347 (owner: 10Eileen) [23:16:21] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings: turn on optional employer field by default - https://phabricator.wikimedia.org/T300086 (10Ejegg) [23:16:43] thanks eileen [23:18:06] (03CR) 10jerkins-bot: [V: 04-1] Pending txn resolver: send recurring tokens to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759360 (https://phabricator.wikimedia.org/T300281) (owner: 10Ejegg) [23:23:31] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings: turn on optional employer field by default - https://phabricator.wikimedia.org/T300086 (10Ejegg) @NNichols Looks like the variants made the employer field appear as an optional field on all the English-speaking countries (US, CA, GB, IE, AU, NZ).... [23:25:37] (03PS20) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [23:33:07] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759347 (owner: 10Eileen) [23:35:44] (03PS21) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [23:36:27] (03CR) 10Ejegg: "Thanks for the cleanup! One question, one additional property we can remove" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759349 (owner: 10Eileen) [23:44:34] (03Merged) 10jenkins-bot: Remove CiviMailStore interface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759347 (owner: 10Eileen) [23:45:50] (03PS22) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [23:46:31] (03PS23) 10Eileen: Switch over to smarty [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/757286 (https://phabricator.wikimedia.org/T299455) [23:53:19] (03PS2) 10Eileen: Remove addActivity function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759349 [23:55:45] ejegg: I fixed that one up - now I'm just trying to decide if I munged the smarty one in some way.... [23:59:04] ok nope looks like the stuff I pushed up was right