[00:00:58] thanks so much wfan eileen ejegg! :) [00:02:44] 10Fundraising Sprint Princess Mongodb, 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 5 others: Email preference center: create new address type "Email Preference Country" - https://phabricator.wikimedia.org/T280674 (10AnnWF) This ticket ma... [00:04:51] Thanks Andy, Elieen and Elliott :P [00:05:12] :) [00:05:56] :) [00:12:34] 10Fundraising-Backlog: Ingenico/Worldline certificate notice potentially requiring Action - https://phabricator.wikimedia.org/T300940 (10EMartin) [00:37:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: minFraud_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:42:11] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [01:31:07] AndyRussG: OK, I got a bit written at https://wikitech.wikimedia.org/wiki/Fundraising/Fundraising-dev [01:35:22] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10FR-Adyen: payments fr-tech-dev server should serve something when ports are not forwarded - https://phabricator.wikimedia.org/T296860 (10Ejegg) This is working for the Apple Pay files, and documented at https://wikitech.wikimedia.org/wiki/Fun... [01:55:18] ooh, this looks promising for serving a main page when no dev machine is connected: https://stackoverflow.com/questions/13380439/fallback-for-an-nginx-upstream-proxy [02:17:15] woot! [02:17:29] look ma, no forwarding: https://paymentstest5.wmcloud.org/ [02:17:44] Well, no CSS or JS either, but it's a page [02:19:52] ok, now how to make nginx share that config for all sites [02:21:02] ejegg: wow very classy eh [02:21:04] congrats! [02:21:09] :) thanks! [02:21:54] any suggestions taken for improvement (as long as I can do it all in one page, no other files) [02:22:21] I guess we could try to put trombone cat in a data: blob, but... [02:22:35] hehe thank u! wow thanks for all the doc too :) [02:22:41] YW! [02:23:17] so it was simpler than the config on the stackoverflow Q [02:23:40] I just made that a custom 502 page [02:23:49] oh bother, the HTTP status is still probably 502 [02:24:08] Amazon probably won't like that [02:24:20] ok, let's see if we can tell nginx to fib on that status code [02:24:34] oooh yep [02:24:48] error_page 502 =200 /error-502.html [02:46:07] ok, that's enabled for all the test domains [03:05:32] just catching up on ^^ - yeah the requirements are confusing & probably the most important thing we need to know is how it will be used from acoustic - as 'the' country for segmentation etc or just something nice to know for ? [03:26:39] (03PS1) 10Ejegg: Fix &debugMonthlyConvert flag [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759638 [03:29:16] (03CR) 10Ejegg: "Oops, it looks like adyen.js is wrong here - we're calling it 'diners' in Ingenico, AstroPay, and in Civi" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759365 (https://phabricator.wikimedia.org/T300188) (owner: 10Ejegg) [03:31:58] (03PS1) 10Ejegg: Fix Diners Club code from Adyen checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759639 [03:34:00] (03PS1) 10Ejegg: Fix Diners Club code for Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/759640 [03:34:32] (03PS3) 10Ejegg: Expand list of cards supporting 3ds [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759365 (https://phabricator.wikimedia.org/T300188) [03:35:43] (03CR) 10Ejegg: "Good catch on that mismatch, jgleeson! I've restored it to 'diners' here, and added I50004031064711c808b1bbbae909c76bef2cf8e6 and I2c2432d" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759365 (https://phabricator.wikimedia.org/T300188) (owner: 10Ejegg) [03:47:15] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings, 10FR-Adyen: payments fr-tech-dev server should serve something when ports are not forwarded - https://phabricator.wikimedia.org/T296860 (10Ejegg) OK, we now also have a slightly prettier default page when no-one's connected. It's just a custom... [12:59:47] 10Fundraising-Backlog, 10fundraising Sprint Black Hole Fillings: turn on optional employer field by default - https://phabricator.wikimedia.org/T300086 (10Damilare) a:03Damilare [13:02:10] (03PS1) 10Damilare Adedoyin: Turn on optional employer field by default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759700 (https://phabricator.wikimedia.org/T300086) [13:08:52] (03PS2) 10Damilare Adedoyin: Turn on optional employer field by default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759700 (https://phabricator.wikimedia.org/T300086) [14:16:55] fr-tech it looks like we might have an issue with one of the thank you mail email templates eileen deployed that night [14:17:25] we've had 194 failmails since last night [14:18:08] this one /wmf-civicrm/msg_templates/thank_you/thank_you.zh.html. [14:18:12] let's take alook [14:27:04] it looks like there's some twig syntax in the the template that is causing a problem [14:30:23] there's also twig errors being thrown which is confusing me as I thought'd we'd switched to smarty [14:30:51] AndyRussG: are you around by chance, do you know if eileen intended to have some templates using twig and some using smarty [14:31:16] I might roll that code back until we know more [14:47:33] ok it looks like we can fix it easy enough but as no one is around to review I'll revert that deploy and fix it afterwards [14:48:04] oops that'll have to come after I pick up Oscar. back soon! [15:00:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lpapadimitriou - https://phabricator.wikimedia.org/T300766 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [15:41:09] hi jgleeson, are you available for a short call to discuss the current civi deploy [15:42:18] damilare: it's rolled back I just sent an email out [15:43:03] ohh ok, cool [15:43:35] would review the fix patch once you push it [15:49:09] sounds good! [15:59:56] Hey fr-tech. I'm going to try to hit the pharmacy right when it opens to pick up a prescription for Cat, so I'll miss standup. [16:00:22] My update is that I'm just going to try to use silent Friday to catch up on email and everything I missed while I was out. [16:02:54] cool XenoRyet. hope she feels better soon [16:03:08] Thanks, me too [16:42:24] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759365 (https://phabricator.wikimedia.org/T300188) (owner: 10Ejegg) [16:42:36] (03CR) 10Jgleeson: [C: 03+2] Fix Diners Club code from Adyen checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759639 (owner: 10Ejegg) [16:42:53] (03CR) 10Jgleeson: [C: 03+2] Fix Diners Club code for Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/759640 (owner: 10Ejegg) [16:43:47] (03Merged) 10jenkins-bot: Fix Diners Club code for Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/759640 (owner: 10Ejegg) [16:48:20] (03CR) 10Zfilipin: [C: 03+2] selenium: Refactor WebdriverIO tests from sync to async mode [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/757680 (https://phabricator.wikimedia.org/T300212) (owner: 10Osamaahmed17) [16:57:56] (03Merged) 10jenkins-bot: Expand list of cards supporting 3ds [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759365 (https://phabricator.wikimedia.org/T300188) (owner: 10Ejegg) [16:57:59] (03Merged) 10jenkins-bot: Fix Diners Club code from Adyen checkout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/759639 (owner: 10Ejegg) [16:59:53] (03Merged) 10jenkins-bot: selenium: Refactor WebdriverIO tests from sync to async mode [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/757680 (https://phabricator.wikimedia.org/T300212) (owner: 10Osamaahmed17) [17:00:18] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for cvirtue - https://phabricator.wikimedia.org/T300092 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [17:12:15] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 13 others: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Esanders) It would've been nice to use the same function signature as OOUI,... [17:28:55] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jsimmons - https://phabricator.wikimedia.org/T300910 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [19:17:05] 10Fundraising-Backlog: Thank you mailer template failmail - https://phabricator.wikimedia.org/T300999 (10jgleeson) [19:18:34] (03PS1) 10Jgleeson: Remove leftover Twig syntax from the ZH and MK templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759764 (https://phabricator.wikimedia.org/T300999) [19:19:24] fr-tech do I need to get added to a list to be able to send test thank you emails from staging? [19:19:35] in relation to that patch just pushed [19:20:58] (03PS2) 10Jgleeson: Remove leftover Twig syntax from the ZH and MK templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759764 (https://phabricator.wikimedia.org/T300999) [19:22:02] Hmm I am not sure for how the new system works but you need to be on the list for ones sent from the old email test sending page jgleeson [19:22:58] jgleeson: your wm.o address should already be present. so anything you generate to be sent to that should be delivered. [19:26:50] thanks cstone and dwisehaupt [19:26:55] I'll try it out [19:31:08] 10Fundraising-Backlog, 10Patch-For-Review: Thank you mailer template failmail - https://phabricator.wikimedia.org/T300999 (10jgleeson) [19:31:36] 10Fundraising-Backlog, 10Patch-For-Review: Thank you mailer template failmail - https://phabricator.wikimedia.org/T300999 (10jgleeson) [20:02:44] hmm dwisehaupt is it easy enough to switch back to my backup yubikey? my usb c one has stopped working :/ [20:03:22] yeah. i think it's in the file. let me check real quick. [20:03:27] thanks [20:03:46] tried it on my phone also and it's lifeless :( [20:03:51] old one works [20:04:01] yeah. let me swap them. [20:06:01] ok. i have swapped them. it should catch on the next puppet run in a few minutes. [20:06:11] i can force that run if you need access now. [20:06:32] I can wait a min [20:13:24] I'll try now [20:13:47] argh it looks like I'm blocked out dwisehaupt [20:13:53] I did try earlier but it didn't like it [20:15:41] ha. [20:24:48] 10Fundraising-Backlog, 10Patch-For-Review: Thank you mailer template failmail - https://phabricator.wikimedia.org/T300999 (10jgleeson) On staging when attempting to send a test thank you email using the current code we get the failmail error {F34942548} [20:26:41] 10Fundraising-Backlog, 10Patch-For-Review: Thank you mailer template failmail - https://phabricator.wikimedia.org/T300999 (10jgleeson) After checking out https://gerrit.wikimedia.org/r/759764 and trying again with ZH and MK as the language code, it works as expected. {F34942550} [20:27:20] (03PS3) 10Jgleeson: Remove leftover Twig syntax from the ZH and MK templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/759764 (https://phabricator.wikimedia.org/T300999) [20:29:10] fr-tech I've just tested that fix for the smarty patches that eileen deployed tonight on staging and it's working as expected.it's an easy +2 if anyone wants to take a look [20:29:13] ^^^ [20:29:23] s/tonight/last night/ [20:39:58] have a good weekend fr-tech [21:07:13] 10Fundraising-Backlog: Exploration: moving to credit card network vs proprietary tokens - https://phabricator.wikimedia.org/T301008 (10EMartin) [21:21:22] 10Fundraising-Backlog: Single click checkout - https://phabricator.wikimedia.org/T301009 (10EMartin)