[00:01:43] (03PS6) 10Ejegg: Email Preference Email Edit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/762494 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [00:02:06] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks great and works fine locally." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/762494 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [00:04:46] (03Merged) 10jenkins-bot: Email Preference Email Edit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/762494 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [00:05:32] Ejegg: Thanks! Still in the middle of the new docker container build process, will start working on the countries and language tickets :) [00:10:15] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/762501/ also this is the civi part to make email editable [00:13:39] (03CR) 10Ejegg: "This is working great! Just a couple comments on the tests inline. Let's try to keep the tests focused on just validating our own code and" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [00:15:46] Ha, yes, because my ui is not working, so I was using the unittest to test the function, I will remove them now :) Thanks [00:22:21] (03PS1) 10Ejegg: Email Prefs center - use expiring checksum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/763623 (https://phabricator.wikimedia.org/T301289) [00:30:24] (03PS6) 10Wfan: Email Preference Email Edit (civi part) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) [00:30:38] (03CR) 10jerkins-bot: [V: 04-1] Email Preference Email Edit (civi part) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [00:34:07] (03PS1) 10Ejegg: WIP Civiproxy.getpreferences uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763625 (https://phabricator.wikimedia.org/T301289) [00:34:09] (03PS1) 10Ejegg: WIP Preferences.create uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763626 (https://phabricator.wikimedia.org/T301289) [00:34:57] wfan I found that I had to disable debugging to make the build process finish [00:35:06] maybe that would make things faster for you too [00:35:44] Quick question, should I rebase my https://gerrit.wikimedia.org/r/762501 to master [00:35:57] or on the most recent civi commit # ? [00:36:54] I generally always rebase onto master [00:42:44] (03PS1) 10Ejegg: Update CiviProxy config for expiring checksum [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/763627 (https://phabricator.wikimedia.org/T301289) [00:45:12] (03CR) 10jerkins-bot: [V: 04-1] WIP Civiproxy.getpreferences uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763625 (https://phabricator.wikimedia.org/T301289) (owner: 10Ejegg) [00:45:42] (03CR) 10jerkins-bot: [V: 04-1] WIP Preferences.create uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763626 (https://phabricator.wikimedia.org/T301289) (owner: 10Ejegg) [00:46:18] (03PS2) 10Ejegg: Email Prefs center - use expiring checksum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/763623 (https://phabricator.wikimedia.org/T301289) [00:54:30] (03PS7) 10Wfan: Email Preference Email Edit (civi part) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) [01:06:24] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10fr-email-preference-center: Email preference center's language list (from mediaWiki and filter by json file) has different format than civi accepted now - https://phabricator.wikimedia.org/T301911 (10Ejegg) [01:12:27] wfan I'm trying to rebase your patch manually because it had merge conflicts that gerrit couldn't solve [01:13:00] ? [01:13:12] I removed the civicrm file, which happend before, I guess now is ok? [01:13:53] wfan no, it's because you changed the parent patch a lot between the version you based this patch on, and the version that actually got merged [01:14:13] So the parent patch was adding the country edit as well as the new address type [01:14:23] and that's the version you based the current patch on [01:14:35] then you changed the parent patch to only add the new address type [01:14:40] and that's the version that was merged [01:15:31] So if you look at the difference between the current patch and master [01:15:53] you see both the country edit and the email edit being added [01:16:09] I can upload the manually-rebased version if you like [01:16:36] Oh I see, so you just pull the master and solve conf then rebase to master, right? [01:16:56] yeah, I'm trying to rebase your current patch onto current paster [01:16:58] *master [01:17:27] So if you want to put the country stuff back in as its own patch, I might be able to figure out a good trick for that [01:18:56] Gotcha, or I could just checkout a new branch from master, then commit again [01:19:03] (03PS8) 10Ejegg: Email Preference Email Edit (civi part) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [01:19:05] (03PS1) 10Ejegg: Make country editable in email preferences [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763631 (https://phabricator.wikimedia.org/T280674) [01:19:43] OK, ^^^ PS1 there is the old version of your parent patch, rebased onto master [01:20:07] So the old version had BOTH the create changes and the new type [01:20:37] but the rebased version has just the create changes [01:20:51] and now your new patch rebased cleanly over it! [01:22:02] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763631 (https://phabricator.wikimedia.org/T280674) (owner: 10Ejegg) [01:22:04] Oh I see, you created my old change as a new branch, then the new one can sit above that change [01:22:12] yep yep! [01:22:47] (03CR) 10Ejegg: [C: 03+2] "Looking good, thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [01:23:10] OK, now I'll get to updating the tests in my own two WIP patches [01:23:17] 👍🏻Thanks haha! [01:24:18] yeah, I see you have two patches sit above that one, that's a good approach! [01:32:03] (03PS3) 10Ejegg: Add email pref center link to contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763386 (https://phabricator.wikimedia.org/T301289) [01:32:05] (03PS2) 10Ejegg: Civiproxy.getpreferences uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763625 (https://phabricator.wikimedia.org/T301289) [01:32:07] (03PS2) 10Ejegg: Preferences.create uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763626 (https://phabricator.wikimedia.org/T301289) [01:32:34] Civiproxy is finally working with the brand new container! [01:32:35] yeah [01:32:51] (03Merged) 10jenkins-bot: Make country editable in email preferences [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763631 (https://phabricator.wikimedia.org/T280674) (owner: 10Ejegg) [01:33:45] (03Merged) 10jenkins-bot: Email Preference Email Edit (civi part) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/762501 (https://phabricator.wikimedia.org/T299962) (owner: 10Wfan) [01:34:05] nice wfan, glad to hear it! [01:34:31] so I found that when I have debugging on with autostart=yes it was making civiproxy hang in the background [01:34:58] i need to figure out how to make that stop happening so I can debug on E-P-C pages that make civiproxy calls [01:36:18] Ha, I will use my air to test that! Thanks [01:43:47] (03CR) 10jerkins-bot: [V: 04-1] Preferences.create uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763626 (https://phabricator.wikimedia.org/T301289) (owner: 10Ejegg) [01:51:48] (03PS3) 10Ejegg: Preferences.create uses expiring checksum [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763626 (https://phabricator.wikimedia.org/T301289) [01:59:23] ok, that checksum roundtrip seems to be working on my machine [01:59:50] have a good friday and a good weekend, fr-tech [02:01:36] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Princess Mongodb, 10Fundraising-Backlog, and 4 others: Email preference center: Implement polished UI - https://phabricator.wikimedia.org/T290986 (10Ejegg) a:03AndyRussG [02:28:06] (03PS1) 10Ejegg: Small cleanups to email prefs API calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763636 [16:58:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Request to make $1k donation bot for END gifts only - https://phabricator.wikimedia.org/T301982 (10DStrine) a:05DStrine→03None [17:02:56] 10Fundraising-Backlog: Notice on Adyen Certificates - https://phabricator.wikimedia.org/T302006 (10DStrine) 05Open→03Resolved a:03DStrine Thanks for this. Luckily we don't have to do anything for this. [17:10:41] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10FR-Email: wle_001 variant for e-mail opt-in is broken - https://phabricator.wikimedia.org/T277196 (10DStrine) [18:15:05] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lschreibstein - https://phabricator.wikimedia.org/T301191 (10Dwisehaupt) Certificate created and sent via email. Password sent via SMS. [18:20:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Ingenico, 10FR-Sweden, 10Recurring-Donations: Sweden MonthlyConvert_Thank_You Email - https://phabricator.wikimedia.org/T301284 (10DStrine) [18:37:42] (03CR) 10Wfan: [C: 03+2] Small cleanups to email prefs API calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763636 (owner: 10Ejegg) [18:38:59] (03CR) 10Wfan: [C: 03+2] "Looks good, except one thing, so we will not use the queue consume in the future?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/763636 (owner: 10Ejegg) [22:54:14] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, 10SRE, 10Znuny: move donation,donate, donations (otrs, wikimania) exim aliases from SRE to ITS - https://phabricator.wikimedia.org/T297915 (10bcampbell) Hey @Dzahn I heard back from Advancement and they'd like to hold off on adjusting their Ze... [23:12:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 5 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [23:17:10] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages