[01:13:03] 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10Ejegg) [01:13:34] 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10Ejegg) p:05Triage→03Unbreak! [02:07:54] AndyRussG: got a potential fix written, asking for review in #wikimedia-dev [02:22:14] legoktm is suggesting a straight up revert for now [02:27:56] (03PS2) 10Wfan: WIP: Update lang for civi from media wiki [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/765328 (https://phabricator.wikimedia.org/T301911) [02:29:20] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, 10Patch-For-Review: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10Ejegg) [03:44:43] (03PS2) 10Wfan: Email preference center's language list filter with civi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765324 (https://phabricator.wikimedia.org/T301911) [03:46:44] (03CR) 10jerkins-bot: [V: 04-1] Email preference center's language list filter with civi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765324 (https://phabricator.wikimedia.org/T301911) (owner: 10Wfan) [03:49:15] (03PS3) 10Wfan: Email preference center's language list filter with civi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765324 (https://phabricator.wikimedia.org/T301911) [03:50:02] (03PS3) 10Wfan: Clear unused code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/765328 (https://phabricator.wikimedia.org/T301911) [07:02:25] AndyRussG: There's a deploy in an hour if you're free to test [07:02:50] I can try and see if they are willing to start earlier with your patch if needed though [07:03:54] RhinosF1: wow thanks... well I was planning on going to sleep and trying to see if it could get deployed tomorrow (it's 1 am here)... There are no Fundraising banner campaigns or tests active at the present time [07:04:40] AndyRussG: you were top of my email! Do you have an easy way to test it? [07:05:01] RhinosF1: heh thanks! yes in fact [07:05:18] AndyRussG: i can probably test for you then [07:05:49] RhinosF1: wow that'd be absolutely fantastic, thanks so much [07:05:58] so currently this link does not show a banner: https://en.wikipedia.org/wiki/Wikipedia?banner=B2122_0119_enWW_dsk_p1_lg_template&country=US [07:06:26] and in the JS console, you get this error: Uncaught SyntaxError: unterminated regular expression literal [07:06:46] after the fix is deployed, that error should go away and the FR banner should display [07:06:53] actually one sec let me get a better link [07:09:41] RhinosF1: this link is better: https://en.wikipedia.org/wiki/Wikipedia?banner=B2122_0131_itIT_dsk_p2_sm_twin1&force=1&country=US [07:10:01] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10RhinosF1) a:03RhinosF1 Stealing to help get depl... [07:10:16] same thing, it should show a banner instead of a JS console error after the fix [07:10:47] AndyRussG: perfect, it'll be deployed at some point in next 2 hours [07:11:26] RhinosF1: fantastic thanks so much!!! [07:12:02] RhinosF1: I'll leave IRC alerts on on my phone. If you happen to have some issue, don't hesitate to ping (preferably repeatedly) [07:12:05] thanks again!!! :) [07:18:04] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761486 [07:18:26] (oops unintentional message ^) [08:54:00] AndyRussG: not working [08:54:07] i'm getting Uncaught RangeError: Incorrect locale information provided [08:55:11] oh dear [08:55:49] and no banner shown? [08:57:33] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10RhinosF1) Deployment tests failed: ` load.php?la... [08:57:45] AndyRussG: I posted the error at ^ [08:57:59] * RhinosF1 is off to have breakfast [08:58:02] no banner, no [09:00:55] RhinosF1: ok I see. Thanks so so much for deploying and then reverting the revert [09:02:31] No problem [09:02:43] we'll try picking up pieces tomorrow [09:02:43] You should thank the backport team more though [09:03:48] Yeee ok for will do [09:04:06] * for sure [09:04:35] Please give me a shout if you need anything else [09:04:46] Might be best to PM as I don't always check this channel [09:08:49] RhinosF1: thx so so much for now heading back to sleep heheh [14:49:21] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10FR-Email: Updating List of Database ids for Forget Me requests - https://phabricator.wikimedia.org/T302286 (10KHaggard) Thanks @Eileenmcnaughton . Just a quick update from my side: Acoustic kept blocking me from deleting database id 11851009... [15:30:35] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10AndyRussG) Thanks so much @Urbanecm @RhinosF1 @Amm... [15:30:55] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10AndyRussG) [15:31:35] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10RhinosF1) a:05RhinosF1→03None [15:33:45] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10AndyRussG) [16:05:53] c [16:18:24] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint Black Hole Fillings: Move attempt to guess contact's country & language from silverpop to impo... - https://phabricator.wikimedia.org/T298400 [17:03:30] jgleeson|dinner: AndyRussG: around for standup? [17:05:09] dwisehaupt: huh? [17:06:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: failed recurring email should send user directly to recurring area of ways to give - https://phabricator.wikimedia.org/T302445 (10TomaszGorski) Hello David and Sandra, 1. In Standard and English(United States) versions, the URL is this one https://donate... [18:17:16] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10FR-Email, 10Patch-For-Review: Email Pref. Ctr.: Copy translations from wikimediafoundation.org and put links in qqq.json - https://phabricator.wikimedia.org/T301815 (10AndyRussG) [18:23:26] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10FR-Email, 10Patch-For-Review: Email Pref. Ctr.: Copy translations from wikimediafoundation.org and put links in qqq.json - https://phabricator.wikimedia.org/T301815 (10AnnWF) a:03AnnWF [19:07:25] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: Epic: fundraising database scalability - https://phabricator.wikimedia.org/T241083 (10Jgreen) [19:08:25] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: Epic: fundraising database scalability - https://phabricator.wikimedia.org/T241083 (10Jgreen) [19:30:36] 10Fundraising-Backlog, 10FR-Civi-Prospect: Adding a new field in civi - https://phabricator.wikimedia.org/T302524 (10NNichols) [19:38:59] 10Fundraising-Backlog, 10FR-Civi-Prospect: Adding a new field in civi - https://phabricator.wikimedia.org/T302524 (10NNichols) [20:26:57] (03PS1) 10Wfan: Update translation from wikimediafoundation.org [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765592 (https://phabricator.wikimedia.org/T301815) [20:51:37] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10matmarex) (This is my proposed fix for later, we j... [20:52:26] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10RhinosF1) @matmarex: see above. A revert didn't work. [20:53:55] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10matmarex) Well, feel free to review and merge and... [20:56:40] AndyRussG: hey, the last standard deployment on the week is in about 5 minutes. [20:57:18] MatmaRex is happy to try and help if you are happy for a take 2 [20:58:04] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765592 (https://phabricator.wikimedia.org/T301815) (owner: 10Wfan) [21:29:40] hey, is this for fr-tech as well? did you guys know this: https://phabricator.wikimedia.org/source/frig/ [21:29:47] Fund Raising Intuit Git [21:30:14] I am currently wondering about this repository and whether I can disable updates to it via ssh. [21:30:26] or maybe you want to copy it somewhere [21:31:08] mutante: that's looks old and unused to me [21:31:10] mutante: never heard of it but I can check... first glance looks like old cruft [21:32:42] the only part that really matters to me right now is .. I want to disable the ability to push to it via ssh [21:32:47] and going through the few special cases [21:33:01] but if you know it is pointless.. then I just hit "deactivate" [21:33:13] and even that is not really deleted [21:33:40] mutante: kill it with fire [21:33:54] (block push access) [21:34:16] ok, thank you. first step removing http:// and ssh:// URIs [21:34:20] then deactivating the whole thing [21:34:42] Jeff_Green: have you ever heard of that project Casey worked on ? [21:34:50] Fund Raising Intuit Git [21:36:02] usage: frig.py [-h] [-m MERGE] [-d DEPLOY] [-r REMOTE] {prep,bump} [target] [21:36:21] jgleeson: it does not ring a bell [21:36:27] it looks like it may have been used in the code update / rsync blaster space if anything [21:36:29] deactivated publishing / pushing etc. but it's still possible to revert that. [21:36:36] where did you find it? [21:36:42] mutante: found it [21:36:54] oh now I see backscroll! [21:36:57] Jeff_Green: I am going through all repos still hosted on Phabricator directly that are active [21:37:15] we want to stop using Phab for repos ideally [21:37:23] since we have gitlab, gerrit, github, etc [21:37:26] mutante: gotcha [21:37:51] lemme take a look at frig, I'm sure we don't use it in SRE land but I don't know what it is [21:37:54] first step is to shutdown git-ssh.wikimeedia.org [21:38:01] that means no more pushing via ssh to phab [21:38:08] but then you can STILl push via https [21:38:37] and if you guys want repos on gitlab.wikimedia.org you can ping for help, btw [21:38:55] we can also import from any other git [21:38:57] mutante: I don't think anyone is using it [21:39:01] ok [21:39:19] it's deactivate now and that is good enough for me, no need to delete it [21:39:25] great, thx [21:39:27] thanks all [21:40:15] np [22:04:50] see you tomorrow fr-tech o/ [22:32:13] PROBLEM - check_load on frdb2003 is CRITICAL: CRITICAL - load average: 84.78, 61.49, 32.14 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_load [22:32:46] ^^^ this alert is my doing, expected [22:34:58] ACKNOWLEDGEMENT - check_load on frdb2003 is CRITICAL: CRITICAL - load average: 84.78, 61.49, 32.14 Jeff_Green stress-testing how mariadb tuned https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_load [22:56:37] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CentralNotice, and 3 others: Recent message fallback change breaks fundraising banners - https://phabricator.wikimedia.org/T302469 (10matmarex) The revert was deployed for real in http... [23:12:09] RECOVERY - check_load on frdb2003 is OK: OK - load average: 0.02, 0.21, 7.48 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_load [23:39:46] (03CR) 10Cstone: [C: 03+2] "Looks good, tested with making a ja.json and they all displayed correctly" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765592 (https://phabricator.wikimedia.org/T301815) (owner: 10Wfan) [23:43:16] (03CR) 10Wfan: [C: 03+2] E-mail Preferences Center header, footer and styling (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/758283 (https://phabricator.wikimedia.org/T290986) (owner: 10AndyRussG) [23:45:49] (03Merged) 10jenkins-bot: E-mail Preferences Center header, footer and styling [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/758283 (https://phabricator.wikimedia.org/T290986) (owner: 10AndyRussG) [23:45:52] (03Merged) 10jenkins-bot: Update translation from wikimediafoundation.org [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/765592 (https://phabricator.wikimedia.org/T301815) (owner: 10Wfan)