[01:53:55] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10Ejegg) [02:14:36] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Paypal: Dust off braintree docs and break down tasks - https://phabricator.wikimedia.org/T291573 (10Ejegg) > Evelyn's questions/topics >* can we implement... [03:15:22] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Whoa staging - my head hurts - https://phabricator.wikimedia.org/T303492 (10Eileenmcnaughton) [03:32:27] ok eileen now I'm curious about staging :) [03:32:40] I'mma just poke around, sounds like I can't mess it up much further [03:33:57] huh, .gitmodules deleted, that'll cause problems [03:34:03] fatal: Unable to create '/srv/org.wikimedia.civicrm/.git/index.lock': Permission denied [03:36:27] looks like the .git directory is all eileen:www-data so I guess I can't really do anything either [05:37:50] howdy. [05:38:07] i'm back, i'll adjust the perms on that dir and reapply the acl. [05:54:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Whoa staging - my head hurts - https://phabricator.wikimedia.org/T303492 (10Dwisehaupt) I have noticed a few things. As mentioned by @Ejegg in irc, some of the directories in the .git dir were set as eileen:www-data without group... [06:05:10] ok. i need to get these kids and myself to bed so we can get up and do it all again. [07:03:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Whoa staging - my head hurts - https://phabricator.wikimedia.org/T303492 (10Eileenmcnaughton) OK - site is just about back..... I just need to figure out if I lost any settings [11:33:51] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) > | **Schema** | **Migrate or Decom?** | **Owners?** | **c... [11:42:17] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [12:06:09] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [14:05:39] damilare: fancy merging https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/769497/ to deployment ? [14:05:56] we could roll the dice again :) [14:06:23] hi fr-tech! [14:07:31] cool, yes sure jgleeson [14:10:47] (03PS1) 10Damilare Adedoyin: Fix civicrm contact preferred languages [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769701 (https://phabricator.wikimedia.org/T279389) [14:14:33] (03CR) 10Damilare Adedoyin: [C: 03+2] Fix civicrm contact preferred languages [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769701 (https://phabricator.wikimedia.org/T279389) (owner: 10Damilare Adedoyin) [14:36:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Whoa staging - my head hurts - https://phabricator.wikimedia.org/T303492 (10Jgreen) I see why the recursive setfacl was necessary to set the default for existing subdirs. But I don't see how that relates to the git issue? Yesterd... [14:39:38] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [14:39:56] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769707 [14:40:21] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769707 (owner: 10Damilare Adedoyin) [14:40:48] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [15:08:10] (03Abandoned) 10Damilare Adedoyin: Fix civicrm contact preferred languages [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769701 (https://phabricator.wikimedia.org/T279389) (owner: 10Damilare Adedoyin) [15:08:17] (03Abandoned) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769707 (owner: 10Damilare Adedoyin) [15:18:50] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769713 [15:21:35] (03PS2) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769713 [16:24:23] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10bd808) >>! In T282131#7766753, @phuedx wrote: >> | **Schema** | **... [16:46:47] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769713 (owner: 10Damilare Adedoyin) [16:52:17] (03CR) 10Jgleeson: "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/769713 (owner: 10Damilare Adedoyin) [16:57:17] !log civicrm change revision from 9b5aafbc to 4cb2bdbc [16:57:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:58:51] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration, 10MediaWiki-extensions-DonationInterface: DonationInterface forms should accept full_name - https://phabricator.wikimedia.org/T300684 (10jgleeson) a:03jgleeson [17:04:04] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration, 10MediaWiki-extensions-DonationInterface: DonationInterface forms should accept full_name - https://phabricator.wikimedia.org/T300684 (10jgleeson) a:05jgleeson→03AnnWF [17:15:33] (03CR) 10Ejegg: "How about just setting $data['employer_visible'] = false here in EndowmentHooks::onAlterPaymentFormData?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/769526 (https://phabricator.wikimedia.org/T302451) (owner: 10Jgleeson) [18:39:17] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 3 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [18:40:32] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 3 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [19:13:14] (03PS3) 10Jgleeson: Don't collect employer info for endowment donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/769526 (https://phabricator.wikimedia.org/T302451) [19:18:51] (03CR) 10Jgleeson: Don't collect employer info for endowment donations (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/769526 (https://phabricator.wikimedia.org/T302451) (owner: 10Jgleeson) [19:24:17] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/769526 (https://phabricator.wikimedia.org/T302451) (owner: 10Jgleeson) [19:25:03] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Add Google Pay Link [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/768754 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [19:26:07] (03Merged) 10jenkins-bot: Don't collect employer info for endowment donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/769526 (https://phabricator.wikimedia.org/T302451) (owner: 10Jgleeson) [19:42:42] 10Fundraising-Analysis, 10Product-Analytics: [REQUEST] Android and iOS user distribution in India vs. US - https://phabricator.wikimedia.org/T303552 (10SNowick_WMF) 05Open→03In progress [19:43:06] 10Fundraising-Analysis, 10Product-Analytics: [REQUEST] Android and iOS user distribution in India vs. US - https://phabricator.wikimedia.org/T303552 (10SNowick_WMF) [20:12:07] 10Fundraising-Analysis, 10Product-Analytics: [REQUEST] Android and iOS user distribution in India vs. US - https://phabricator.wikimedia.org/T303552 (10SNowick_WMF) Hi @spatton I was able to pull preliminary data for Android (for US and India) form the Android Play Store. I included data definitions in the she... [20:41:53] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/769778 [20:43:26] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/769778 (owner: 10Cstone) [20:45:57] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Whoa staging - my head hurts - https://phabricator.wikimedia.org/T303492 (10Eileenmcnaughton) @Jeff_G - it is pseudocode - I figured I should't put the actual path in phab [20:52:13] (03CR) 10Ejegg: [C: 03+2] "Looks good! We might need to support GetDetails for 3D Secure later but let's go with this for now." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/768753 (https://phabricator.wikimedia.org/T300685) (owner: 10Wfan) [20:52:48] (03Merged) 10jenkins-bot: Add Google Pay Provider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/768753 (https://phabricator.wikimedia.org/T300685) (owner: 10Wfan) [20:53:45] Thanks, I saw your email, will follow up this 3ds :) [20:55:25] wfan: I just sent an email to adyen support asking how to test it [20:55:28] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/769778 (owner: 10Cstone) [20:55:35] so let's just keep going with the current patch for now [20:55:57] oh, do you want to tag another minor version of the SmashPig library ? [20:56:47] I think the current version smashpig is ok, and then once the 3ds is ready we can have another ticket for it? [20:57:53] (03PS1) 10Cstone: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/769781 [20:58:09] wfan I mean just add the tag so we can pull the GooglePayPaymentProvider in under vendor for DonationInterface/mediawiki [20:58:26] we usually don't make a ticket for these point releases [21:00:06] Oh I see, the packagist tag, right [21:00:39] yep! [21:01:25] Ok on it need to check my note first 😂 [21:06:39] (03CR) 10Cstone: [C: 03+2] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/769781 (owner: 10Cstone) [21:08:23] v0.7.9.4 is the new tag for smashpig at packagist [21:14:45] (03Merged) 10jenkins-bot: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/769781 (owner: 10Cstone) [21:18:49] !log update Donation Interface revision changed from ca37a93e to 5db12b21 [21:18:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:22:08] * [new tag] v0.7.9.4 -> v0.7.9.4 is what I got after my new tag push, but from the packagist I see this version is there for 3 days, should I do a new tag and push again? ejegg: [21:23:00] wfan: looking [21:24:20] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10Jgreen) This may be better done within the payments application, but here's a first try at a proxy-based approach using nginx maps: `map $a... [21:25:13] wfan wow that's strange, I don't see the 0.7.9.4 tag on the master branch [21:25:39] https://packagist.org/packages/wikimedia/smash-pig#v0.7.9.4 [21:25:55] yeah, that's a bit worrying! Is somebody trying to trojan it? [21:27:09] Oh I see maybe because I was not in my master branch sorry, let me do that again sorry [21:27:26] so did that tag git pushed to github and not to gerrit? [21:27:33] *get pushed [21:27:50] It was at the old gerrit branch I was have [21:28:02] googlePay/provider [21:28:35] ooh weird, https://github.com/wikimedia/wikimedia-fundraising-SmashPig/tree/v0.7.9.4 says "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository." [21:28:55] OK, I think we have to skip that tag and add v0.7.9.5 to the current state of master [21:29:02] then push that tag to gerrit, not to github [21:29:28] what do you see when you type 'git remote -v' in your smashpig checkout [21:30:19] just updated the v0.7.9.5 [21:30:21] (03PS5) 10Eileen: Stock civicrm 5.48-alpha [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/762972 (https://phabricator.wikimedia.org/T303363) [21:30:23] (03PS3) 10Eileen: Remove slow check from the upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769106 (https://phabricator.wikimedia.org/T303363) [21:30:25] (03PS6) 10Eileen: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/763346 (https://phabricator.wikimedia.org/T303363) [21:30:27] (03PS4) 10Eileen: Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/763403 (https://phabricator.wikimedia.org/T303363) [21:30:29] (03PS2) 10Eileen: Add created & modified dates to relationhsip view [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769145 (https://phabricator.wikimedia.org/T294487) [21:30:31] (03PS2) 10Eileen: SearchKit - Allow searching by range [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769531 [21:30:33] (03PS2) 10Eileen: Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769532 [21:30:53] https://www.irccloud.com/pastebin/wqLeKWwU/ [21:31:59] oh ok, that seems right wfan [21:34:40] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10FR-Adyen, and 2 others: Enable Monthy Convert for Bundle Countries and Sweden - https://phabricator.wikimedia.org/T300920 (10Cstone) [21:34:51] Yeah I thought I was checkin the master branch, then realized that I am not, sorry 😅 That's might be why it's 3 days old [21:35:49] ok wfan, now I see it. Looks good! [21:36:07] Thanks! [21:36:37] Do you want to add a little update to the smash-pig version in extension.json for your DonationInterface patch? [21:36:47] err, i mean in composer.json [21:37:06] Oh I see, ok [21:42:34] (03CR) 10jerkins-bot: [V: 04-1] Stock civicrm 5.48-alpha [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/762972 (https://phabricator.wikimedia.org/T303363) (owner: 10Eileen) [21:43:25] (03CR) 10jerkins-bot: [V: 04-1] Remove slow check from the upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769106 (https://phabricator.wikimedia.org/T303363) (owner: 10Eileen) [21:44:22] (03CR) 10jerkins-bot: [V: 04-1] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/763346 (https://phabricator.wikimedia.org/T303363) (owner: 10Eileen) [21:49:18] (03PS8) 10Wfan: Add google pay js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/768752 (https://phabricator.wikimedia.org/T300686) [21:52:57] Tag version updated to 0.7.9.5 :) for the js patch~ [21:53:17] thanks wfan! [21:54:39] Update the document now, forgot to mention the composer.json update previously, Thanks! [21:55:39] eileen: oh odd, I get "Table 'civicrm.a' doesn't exist" just trying to navegate to the main CiviCRM page with the new code, not even trying to do the upgrade [21:56:06] hmm - I ran the upgrade via drush - & also the extension upgrade via drush [21:56:29] stack trace runs through API4SelectQuery again [21:56:48] can you access the upgrade page? civicrm/upgrade [21:57:29] I can access it and click the button, that should get me to my breakpoint at the first API4 call in the upgrade [22:05:09] looks like $tableName = CoreUtil::getTableName($this->getEntity()); is setting $tableName to null in Api4SelectQuery constructor [22:05:28] and then the next line sends just ' a' to the 'from' bit of the sql query constructor [22:05:40] what gets it to this point? [22:05:42] $this->query = \CRM_Utils_SQL_Select::from($tableName . ' ' . self::MAIN_TABLE_ALIAS); [22:05:54] ie do you have a backtrace [22:06:03] eileen: on the main page, it's the Dashboard Api4SelectQuery [22:06:17] on the upgrade, it's a civicrm_api4 call trying to get an OptionValue [22:06:54] ejegg: hmm - can you make sure you have the latest patch in case it does fix that? [22:06:58] for the main page it's specifically this bit to get the dashlets: [22:07:00] DashboardContact::get(FALSE)->selectRowCount()->addWhere('contact_id', '=', $cid)->execute()->count() [22:07:10] I just pulled down the new version of your patch chain eileen [22:07:20] yeah - I think it's OK for the dashboard to fail until the upgrade has run [22:07:49] Is there a backtrace in configAnd Log [22:07:50] hmm, but the upgrade doesn't run because the OptionValue API4 select fails the same way [22:08:02] I can paste the backtrace from the upgrade screen if you like [22:08:52] https://phabricator.wikimedia.org/P22358 [22:09:45] I checked that option_group_id 19 and it's the advanced_search_options group, i.e. the first entry in the $managed array [22:10:00] so the upgrade seems to be failing on the first API4 select as well [22:10:04] back in a sec [22:10:24] 10Fundraising-Backlog, 10fr-donorservices: Ingenico audit wobble: May 2021 refunds for recurrings not in Civi - https://phabricator.wikimedia.org/T284171 (10Cstone) [22:10:26] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog: Transaction canceled in Ingenico but not in Civi - https://phabricator.wikimedia.org/T301480 (10Cstone) [22:25:39] eileen: looks like the array of entities in ActionObjectProvider doesn't have table_name set under any of the entities I'm checking [22:26:14] lemme try to rebuild the metadata cache to see how that gets created [22:27:13] shoot, gotta head out for a neighborhood meeting [22:27:24] will hop back on this as soon as that's done [22:44:35] 10Fundraising-Backlog, 10fr-donorservices: Unusual amount of recurring CIDs "on hold" in Civi - https://phabricator.wikimedia.org/T303565 (10SHust) [22:45:26] 10Fundraising-Backlog, 10fr-donorservices: Unusual amount of recurring CIDs "on hold" in Civi - https://phabricator.wikimedia.org/T303565 (10SHust)