[05:48:29] (03CR) 10AndyRussG: Support full_name for all messages, not just ChecksFile (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/769098 (https://phabricator.wikimedia.org/T300690) (owner: 10Ejegg) [07:16:57] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770355 (owner: 10L10n-bot) [07:33:59] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770355 (owner: 10L10n-bot) [08:43:00] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Organize meeting around CRM system - https://phabricator.wikimedia.org/T272267 (10Aklapper) @Jenny_Brandt_WMSE: Hi, the `Due Date` set for this open task passed a while ago. Could you please either update or reset the Due Date (by... [09:00:02] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Organize meeting around CRM system - https://phabricator.wikimedia.org/T272267 (10Jenny_Brandt_WMSE) [11:37:13] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Request to make $1k donation bot for END gifts only - https://phabricator.wikimedia.org/T301982 (10RLewis) @Ejegg thank you so much, I tested this and it works. I was getting myself confused on how to... [11:41:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you letter not showing in the Activity field for Endowment Donation - https://phabricator.wikimedia.org/T239745 (10RLewis) 05Open→03Declined [15:04:20] (03PS1) 10Wfan: Add full_name to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770521 (https://phabricator.wikimedia.org/T300684) [15:06:27] (03CR) 10jerkins-bot: [V: 04-1] Add full_name to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770521 (https://phabricator.wikimedia.org/T300684) (owner: 10Wfan) [15:50:15] hey damilare just got back. any luck, also do you wanna jump back on the call? [15:55:06] hey jgleeson, sure [15:55:18] I'm on the call from earlier [15:57:01] coming! [16:04:29] fr-tech does anyone know what eileen is referring to when she says 'omnihell' ? [16:09:17] a term of endearment for omnimail? [16:09:29] or omnipay? [16:10:57] oh wow it was that annoying she named some of the domain model after it lol [16:11:17] seems to be related to the web scraper part of our silverpop integration [16:11:35] wrapped up in the omnimail extension [16:45:44] 10Fundraising-Backlog, 10fr-donorservices: Unusual amount of recurring CIDs "on hold" in Civi - https://phabricator.wikimedia.org/T303565 (10DStrine) 05Open→03Resolved a:03DStrine This is normal. There are a few reasons they may be on hold. This should not stop them from receiving transactional emails fr... [16:46:05] (03PS1) 10Jgleeson: Switch over substr to mb_substr to handle multibyte email subjects. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770553 (https://phabricator.wikimedia.org/T303732) [16:46:09] hi fr-tech [16:46:43] jgleeson: ah yeah, the screen-scraping stuff is the hellish part of that extension [16:52:52] (03CR) 10Ejegg: "The change to omnimail looks good! Looks like the phpunit bootstrap change got committed by mistake though?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770553 (https://phabricator.wikimedia.org/T303732) (owner: 10Jgleeson) [16:53:34] thanks for diving into that omnimail stuff jgleeson ! [16:55:51] oh good spot ejegg I thought I'd omitted that change in git add -p [16:55:54] I'll remove it [16:56:03] hi ejegg btw [16:56:15] and fr-tech [16:56:37] hi hi! [16:57:12] hi fr-tech [16:58:21] (03PS2) 10Jgleeson: Switch over substr to mb_substr to handle multibyte email subjects. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770553 (https://phabricator.wikimedia.org/T303732) [16:59:36] (03CR) 10Damilare Adedoyin: [C: 03+2] "Looks good to me." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770553 (https://phabricator.wikimedia.org/T303732) (owner: 10Jgleeson) [17:00:05] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770553 (https://phabricator.wikimedia.org/T303732) (owner: 10Jgleeson) [17:00:22] hiii fr-tech jgleeson cstone ejegg damilare dwisehaupt wfan :) [17:00:55] (03PS6) 10Ejegg: Support full_name for all messages, not just ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/769098 (https://phabricator.wikimedia.org/T300690) [17:01:10] Hey Andy:) [17:01:25] hii Andy fr-tech [17:01:36] hi AndyRussG cstone! [17:01:59] :) :) :) [17:12:56] (03Merged) 10jenkins-bot: Switch over substr to mb_substr to handle multibyte email subjects. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770553 (https://phabricator.wikimedia.org/T303732) (owner: 10Jgleeson) [17:19:19] 10Fundraising-Backlog, 10fr-donorservices: Unusual amount of recurring CIDs "on hold" in Civi - https://phabricator.wikimedia.org/T303565 (10krobinson) Follow up question to confirm behaviours @dstrine / @Eileenmcnaughton or others on fr-tech. I understand that they will get the receipt anyway, just to confi... [17:23:56] 10Fundraising-Backlog, 10fr-donorservices: Unusual amount of recurring CIDs "on hold" in Civi - https://phabricator.wikimedia.org/T303565 (10DStrine) Recurring restart (also called failed recurring) would still go out. I'd have to check on the eoy email. There are some people who get on hold status if we got... [17:32:08] (03CR) 10Ejegg: "Thanks, this looks like a good start." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770521 (https://phabricator.wikimedia.org/T300684) (owner: 10Wfan) [17:32:23] AndyRussG: thanks for the CR on the full_name in the queue consumer. I added that comment you suggested in PS6: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/769098 [17:32:31] gonna grab some lunch, back soon [17:32:43] thx ejegg|food, buen provecho [17:53:10] (03PS1) 10Ejegg: Add jcb_applepay to Adyen ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/770562 [18:05:23] fr-tech that trivial patch will stop the adyen audit failmail ^^^ [18:05:47] thanks to wfan for getting the error message from the logs [18:22:29] (03PS1) 10Wfan: add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770568 (https://phabricator.wikimedia.org/T300686) [18:25:55] (03CR) 10AndyRussG: [C: 03+2] "coool thx!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/770562 (owner: 10Ejegg) [18:26:29] (03Merged) 10jenkins-bot: Add jcb_applepay to Adyen ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/770562 (owner: 10Ejegg) [18:34:14] (03PS2) 10Ejegg: Remove drupal OAuth and dependencies [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/769821 (https://phabricator.wikimedia.org/T298973) [18:36:07] dstrine ejegg just reviewing https://phabricator.wikimedia.org/T291573 ... so I see in the description it says, "Create a list of major tasks or phases here or in a doc." In this comment there's a list of interaction steps that the integration will carry out https://phabricator.wikimedia.org/T291573#7745061 [18:37:24] is that sufficient for the purposes of this task? it sounded like the ask was for phases in the development work, rather than phases in how the integration will work internally? [18:37:26] AndyRussG: ah yeah, i just wrote that on phab to clarify it for myself [18:37:47] I've since created a bunch of tasks that should include all of those steps plus seceral others [18:38:02] https://phabricator.wikimedia.org/project/profile/5754/ [18:38:17] ejegg: ahh got it, thanks! [18:39:04] or a better task list: https://phabricator.wikimedia.org/search/query/nrQkZid.C6lA/ [18:39:33] wow oki cool that's quite specific [18:41:26] 10Fundraising-Backlog, 10FR-Braintree-Integration: Set up official WMF Braintree account - https://phabricator.wikimedia.org/T303456 (10Ejegg) @Dstrine, @EMartin I think this is more of a business-side task than a task for FR-tech. Probably @EMartin can get started on this before we do any tech work. [18:43:13] (03PS1) 10Ejegg: Update Smash-Pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770571 [18:43:15] (03CR) 10Ejegg: [C: 03+2] Update Smash-Pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770571 (owner: 10Ejegg) [18:44:50] fr-tech I'm going to do a quick CRM deploy when ^^^ merges, unless there are any objections. Will get the fixes out for both the Adyen audit failmail and the Silverpop mailing fetch failmail [18:46:03] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/770572 [18:46:40] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/770572 (owner: 10Ejegg) [18:50:53] 10Fundraising-Backlog, 10FR-Braintree-Integration: Set up official WMF Braintree account - https://phabricator.wikimedia.org/T303456 (10EMartin) @DStrine @Ejegg Hi both, I am in the process of completing the contract with Braintree and simultaneous to that, Braintree/Paypal would like to have a technical cal... [18:55:32] (03Merged) 10jenkins-bot: Update Smash-Pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770571 (owner: 10Ejegg) [18:58:01] thanks ejegg [18:58:37] 10Fundraising-Backlog, 10FR-Braintree-Integration: Set up official WMF Braintree account - https://phabricator.wikimedia.org/T303456 (10DStrine) yeah we might need to discuss this in relation to micorpricing T238576 [19:03:35] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Paypal: Dust off braintree docs and break down tasks - https://phabricator.wikimedia.org/T291573 (10AndyRussG) "review +2" on this task! Thanks for all th... [19:03:55] oki ejegg dstrine I'm moving that task into "Done" ^ [19:11:22] 10Fundraising Sprint Princess Mongodb, 10Fundraising-Backlog, 10FR-dlocal: Dlocal cancel buttons don't go back to the payments wiki form - https://phabricator.wikimedia.org/T229336 (10EMartin) 05Open→03Resolved a:03EMartin [19:12:04] 10Fundraising Sprint Trojan Horse Wisperer, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10fr-donorservices: Duplicate donations caused by PayPal's “Final Approval” messaging - https://phabricator.wikimedia.org/T235220 (10EMartin) 05Open→03Resolved a:03EMartin [19:17:25] (03PS1) 10Ejegg: Update smash-pig library [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/770576 [19:17:29] (03CR) 10Ejegg: [C: 03+2] Update smash-pig library [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/770576 (owner: 10Ejegg) [19:17:37] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update smash-pig library [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/770576 (owner: 10Ejegg) [19:18:17] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/770572 [19:18:37] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/770572 (owner: 10Ejegg) [19:19:08] thanks AndyRussG! [19:19:20] ty [19:20:28] ejegg: AndyRussG I quickly scanned through that task and the Braintree docs and noticed the bit about 'Single-use payment methods expire in 3 hours' which got me thinking about the orphan rectifier stuff. I think the old orphan rectifier is still handling the paypal orphans right, Should we add a task for adding Braintree to the pending transaction resolver also? [19:21:24] ohhh sounds like a good idea jgleeson [19:21:36] yeah the docs do say 3 hours [19:22:15] !log updated civicrm from 252269c8 to 52c45874 [19:22:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:22:20] jgleeson: yep, good call! [19:25:41] Is the idea for is to do a hard switch over Braintree and retire the existing Paypal integration? If so we could then probably retire the orphan rectifier along with the process-control jobs. [19:25:55] lemme try that first bit again [19:26:13] IF the idea IS to do....* [19:26:34] ~_~ [19:31:32] my trainwreck of a question there reminded me of the the elegant way to check a types in Ruby. thing.is_a?(type) [19:35:30] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Whoa staging - my head hurts - https://phabricator.wikimedia.org/T303492 (10DStrine) 05Open→03Resolved [19:48:16] jgleeson: yep, once braintree is working we would disable the paypal_ec integration [19:49:02] We should also look into whether they can migrate existing recurring over to tokenized braintree recurring on the new account(s) [19:57:14] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10Fr-drupal-upgrade-2021, 10Patch-For-Review: disable civicrm oauth extension and remove module from crm/drupal repository - https://phabricator.wikimedia.org/T298973 (10jgleeson) drush dis libraries oauth_common services [20:02:43] (03CR) 10Ejegg: [C: 04-1] "Thanks for breaking this out from the full_name patch. We'll want to use mapAdyenSubmethod here to get our own codes for the submethods." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770568 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [20:03:43] 10Fundraising Sprint Cheese String Theory, 10Fundraising-Backlog, 10donate.wikimedia.org, 10Wikimedia-production-error: PHP Warning: geoip_country_code_by_name(): Required database not available at /usr/share/GeoIP/GeoIP.dat. - https://phabricator.wikimedia.org/T301485 (10DStrine) [20:05:02] (03Restored) 10Ejegg: Stop falling back to server-side GeoIP lookup [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/769817 (https://phabricator.wikimedia.org/T301485) (owner: 10Ejegg) [20:06:57] (03PS2) 10Ejegg: Stop falling back to server-side GeoIP lookup [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/769817 (https://phabricator.wikimedia.org/T301485) [20:08:48] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, and 2 others: Automatically populate created date on relationships - https://phabricator.wikimedia.org/T294487 (10Eileenmcnaughton) Relation... [20:09:35] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: PHP Warning: geoip_country_code_by_name(): Required database not available at /usr/share/GeoIP/GeoIP.dat. - https://phabricator.wikimedia.org/T301485 (1... [21:10:15] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10Fr-drupal-upgrade-2021, 10Patch-For-Review: disable civicrm oauth extension and remove module from crm/drupal repository - https://phabricator.wikimedia.org/T298973 (10jgleeson) After running the above I see the `drush pml` diff a... [21:13:51] (03CR) 10Jgleeson: [C: 03+2] "Some good cruft removal here! Thanks." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/769821 (https://phabricator.wikimedia.org/T298973) (owner: 10Ejegg) [21:20:43] (03PS4) 10Eileen: SearchKit - Allow searching by range [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769531 [21:26:03] (03Merged) 10jenkins-bot: Remove drupal OAuth and dependencies [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/769821 (https://phabricator.wikimedia.org/T298973) (owner: 10Ejegg) [21:32:05] (03PS5) 10Eileen: SearchKit - Allow searching by range [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769531 [21:32:07] (03PS4) 10Eileen: Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769532 [22:40:08] ugh, fr-tech i juat installed a bios update and it wiped out grub again [22:40:36] on chat via phone but it'll be a little bit to restore that [22:42:38] awww [22:48:33] ugh. [22:49:04] i'm on network 4 for the day. [22:50:00] this one has more packet loss (10% vs 8%) but at least the ping times are in the 30ms vs 1sec [22:54:12] of course as i type that. it got worse. [23:08:38] whew, back on the compy. I at least remembered what phrases to google to get the instructions [23:12:22] i'm disabling those soon-to-be-deleted modules on prod & staging CiviCRM just so they don't get stuck in limbo when that patch deploys [23:12:55] done [23:13:51] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising-Backlog, 10Fr-drupal-upgrade-2021: disable civicrm oauth extension and remove module from crm/drupal repository - https://phabricator.wikimedia.org/T298973 (10Ejegg) These are disabled on production and staging. OK to deploy the code removal w... [23:23:11] (03PS2) 10Wfan: add the payment submethod for google pay based on the document https://developers.google.com/pay/api/web/reference/request-objects#CardParameters we supported ["AMEX", "DISCOVER", "INTERAC", "JCB", "MASTERCARD", "MIR", "VISA"] as default while our smashpig support mastercard as mc and not mir and interac yet, so limit the supported card type and map the card type to the one smashpig suppoted [extensions/Dona [23:23:12] (https://phabricator.wikimedia.org/T300686) [23:24:35] (03PS3) 10Wfan: add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770568 (https://phabricator.wikimedia.org/T300686)