[01:42:34] (03PS1) 10Dylsss: Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 [01:44:24] (03CR) 10jerkins-bot: [V: 04-1] Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [01:59:52] (03PS2) 10Dylsss: Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 [02:01:26] (03CR) 10jerkins-bot: [V: 04-1] Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [02:10:29] (03Abandoned) 10Dylsss: Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [07:40:14] (03PS1) 10Func: Replace deprecated loadData() method of HTMLForm [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/772320 [07:42:23] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated loadData() method of HTMLForm [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/772320 (owner: 10Func) [07:52:32] (03PS2) 10Func: Replace deprecated loadData() method of HTMLForm [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/772320 [11:31:14] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 3 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [11:35:12] 10Fundraising-Backlog, 10Data-Engineering, 10Data-Engineering-Kanban, 10Event-Platform, and 3 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [16:15:21] (03CR) 10Wfan: [C: 03+2] Add gift source example code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/770660 (https://phabricator.wikimedia.org/T302448) (owner: 10Eileen) [16:16:12] (03CR) 10Wfan: [C: 03+2] "Tested with send email and check the mail with the mailCatcher, looks good~" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770663 (https://phabricator.wikimedia.org/T302448) (owner: 10Eileen) [16:30:42] (03Merged) 10jenkins-bot: Add gift source example code [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/770660 (https://phabricator.wikimedia.org/T302448) (owner: 10Eileen) [16:35:53] (03Merged) 10jenkins-bot: Update original endowment letter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/770663 (https://phabricator.wikimedia.org/T302448) (owner: 10Eileen) [17:52:44] 10Fundraising-Backlog: create a default gateway status page - https://phabricator.wikimedia.org/T304345 (10DStrine) [17:54:17] (03CR) 10Ejegg: [C: 03+1] "All looks good (and works locally) for the main full_name change! The unrelated gross/amount rounding for the MC message should probably u" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770521 (https://phabricator.wikimedia.org/T300684) (owner: 10Wfan) [17:55:25] 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Automated QCD Civi Gift Receipts - https://phabricator.wikimedia.org/T302448 (10AnnWF) The way to test this: pull all the pr to local env, and run `drush @wmff cvapi sy... [17:59:43] 10Fundraising-Backlog: Separate fraud rules by country - https://phabricator.wikimedia.org/T304347 (10DStrine) [18:03:24] (03Abandoned) 10AndyRussG: [DO NOT MERGE] Stub for partial mustache template in Email Pref. Ctr. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/764625 (https://phabricator.wikimedia.org/T277196) (owner: 10AndyRussG) [18:04:53] (03CR) 10Ejegg: "This looks pretty good! I like that you're getting the supported card network from the server-side config. Maybe we could add the optional" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [18:05:58] (03PS5) 10Wfan: Add full_name to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/770521 (https://phabricator.wikimedia.org/T300684) [18:06:39] ah I was just reviewing that and had similar thoughts to ejegg so I'll leave that one. thanks for the updates wfan :) [18:07:36] 😃 Thanks Jack and Elliott [18:10:56] wfan: not sure if you wanted a new commit for other reasons but in case you lost your earlier work and that's why you abandoned, you can always checkout your patches e.g. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/770568 and add to that commit with git commit --amend [18:13:01] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10FR-Ingenico, 10FR-Italy: Transactions in Italy campaign stopped at 600 - https://phabricator.wikimedia.org/T303994 (10jgleeson) a:03jgleeson [18:16:54] jgleeson: Thanks Jack, because when I add the depend-on: xxxx , two commit number is popping up, then I delete the previous commit number, which is the abandoned one, will keep the first commit number next time :) [18:20:31] I see [18:21:51] I've definitely done that too :) [18:39:28] (03PS1) 10Ejegg: Stop exporting voter_party [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/772459 (https://phabricator.wikimedia.org/T304088) [18:40:24] ejegg: do pending db tbl messages get pruned after a period? [18:40:31] I feel like that's a thing [19:04:26] (03PS1) 10Ejegg: WIP remove voter_party [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772465 (https://phabricator.wikimedia.org/T304088) [19:05:00] jgleeson: yep! [19:05:37] We have a job that runs the DeleteExpiredPendingMessages smashpig maintenance script [19:06:15] it runs a separate command for each gateway so it can pass different expiry times to each [19:07:18] e.g. a few hours for the PayPal messages which have the short-lived session ID [19:07:46] vs a month for dlocal messages that may clear up whenever someone does their shopping [19:07:55] (03PS4) 10Wfan: add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) [19:09:53] (03CR) 10jerkins-bot: [V: 04-1] add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [19:13:44] (03PS5) 10Ejegg: add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [19:14:02] (03CR) 10Ejegg: [C: 03+2] "Looks good! Thanks for finding this extra information." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [19:15:24] (03PS1) 10Jgleeson: Use array_key_exists() for checking cvv exists instead of empty() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772488 (https://phabricator.wikimedia.org/T303994) [19:15:37] (03CR) 10jerkins-bot: [V: 04-1] add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [19:16:01] oops, should have waited for the V+2! [19:16:03] cool thanks ejegg [19:16:07] let's see what that's about [19:16:28] ah, spacey-parens [19:16:36] wfan those should be simple to fix [19:16:53] and I'll reapply the +2 [19:17:31] (03PS6) 10Wfan: add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) [19:19:37] (03CR) 10jerkins-bot: [V: 04-1] add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) (owner: 10Wfan) [19:20:51] (03PS7) 10Wfan: add the payment submethod for google pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/771940 (https://phabricator.wikimedia.org/T300686) [19:22:56] 😅 Thanks [19:30:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect: New custom field - Prospect Insight - https://phabricator.wikimedia.org/T304268 (10DStrine) [19:31:00] 10Fundraising-Backlog, 10FR-dlocal: Gpay for South Africa and India through Dlocal - https://phabricator.wikimedia.org/T304026 (10DStrine) [19:32:08] 10Fundraising-Backlog: Sweden currently processing through Ingenico instead of Adyen - https://phabricator.wikimedia.org/T304161 (10DStrine) 05Open→03Resolved a:03DStrine Adyen is back on as the default for sweden but MC is not enabled. [19:47:00] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Remove voter party field from acoustic export - https://phabricator.wikimedia.org/T304357 (10Eileenmcnaughton) [19:47:59] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Remove voter party from logging triggers - https://phabricator.wikimedia.org/T304358 (10Eileenmcnaughton) [19:48:31] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Voter party field - once removed the logging field needs to be dropped - https://phabricator.wikimedia.org/T304359 (10Eileenmcnaughton) [19:48:58] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Voter party field - do we need to drop from backups or can it age out? - https://phabricator.wikimedia.org/T304360 (10Eileenmcnaughton) [19:49:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Voter party field - do we need to drop from backups or can it age out? - https://phabricator.wikimedia.org/T304360 (10Eileenmcnaughton) [19:55:58] 10Fundraising-Backlog, 10FR-Adyen: Changes to Adyen API calls - https://phabricator.wikimedia.org/T304115 (10DStrine) [20:03:15] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog: Set valid Callback URL on DLocal Sandbox - https://phabricator.wikimedia.org/T303974 (10DStrine) [20:14:07] (03Abandoned) 10Eileen: Add getoption to the civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/764903 (owner: 10Eileen) [20:14:53] (03PS2) 10Ejegg: Stop exporting voter_party [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/772459 (https://phabricator.wikimedia.org/T304088) [20:20:39] (03CR) 10Damilare Adedoyin: [C: 03+2] Use array_key_exists() for checking cvv exists instead of empty() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772488 (https://phabricator.wikimedia.org/T303994) (owner: 10Jgleeson) [20:32:38] (03Merged) 10jenkins-bot: Use array_key_exists() for checking cvv exists instead of empty() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772488 (https://phabricator.wikimedia.org/T303994) (owner: 10Jgleeson) [20:33:05] 10Fundraising-Backlog, 10FR-Adyen: Changes to Adyen API calls - https://phabricator.wikimedia.org/T304115 (10Ejegg) Looks like we should map a few of these new 905_x codes in the Adyen error normalizer [20:37:08] 10Fundraising-Backlog, 10FR-Adyen: Changes to Adyen API calls - https://phabricator.wikimedia.org/T304115 (10Dwisehaupt) [20:39:22] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect: New custom field - Prospect Insight - https://phabricator.wikimedia.org/T304268 (10Dwisehaupt) [20:45:58] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal: PIX workflow in Dlocal/Brazil - https://phabricator.wikimedia.org/T304014 (10Dwisehaupt) [20:56:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10Dwisehaupt) [20:58:54] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add GPay to Adyen Audit Processor list - https://phabricator.wikimedia.org/T303624 (10Dwisehaupt) [21:00:43] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add GPay to CivICRM - https://phabricator.wikimedia.org/T303623 (10Dwisehaupt) [21:14:35] 10Fundraising-Backlog, 10FR-dlocal: Gpay for South Africa and India through Dlocal - https://phabricator.wikimedia.org/T304026 (10EMartin) @DStrine Further to this request, I have learned that Adyen can support Gpay for South Africa but cross border only. Adyen cannot support us at all in India for Gpay. T... [21:24:07] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog: Document all Translations needed for Post-payment MC - https://phabricator.wikimedia.org/T303865 (10Cstone) @HNordeenWMF I updated our monthly convert documentation to have links to the current english strings and their descriptions: https://wikitech.wiki... [21:50:23] (03CR) 10Wfan: [C: 03+2] Stop falling back to server-side GeoIP lookup [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/769817 (https://phabricator.wikimedia.org/T301485) (owner: 10Ejegg) [21:54:05] (03PS1) 10Eileen: Security update to 5.48rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/772513 (https://phabricator.wikimedia.org/T303883) [21:54:07] (03PS1) 10Eileen: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/772514 (https://phabricator.wikimedia.org/T303883) [21:54:11] (03PS1) 10Eileen: Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/772515 (https://phabricator.wikimedia.org/T303883) [21:58:34] (03Merged) 10jenkins-bot: Stop falling back to server-side GeoIP lookup [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/769817 (https://phabricator.wikimedia.org/T301485) (owner: 10Ejegg) [22:01:51] (03PS6) 10Eileen: SearchKit ports of merged work [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769531 [22:02:05] wfan: is there a conversation I missed? [22:04:09] (03PS5) 10Eileen: Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769532 [22:04:33] Nope I was try to ask you about the phone number is missing ticket, but I now got something else to do :) will see if I am done with the other ticket and the phone number ticket is not been claimed by others or you :) [22:06:48] (03CR) 10jerkins-bot: [V: 04-1] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/772514 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [22:06:50] (03CR) 10jerkins-bot: [V: 04-1] Security update to 5.48rc [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/772513 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [22:08:05] wfan: cool :-) - if you want to look we can hang out - [22:09:16] Sure, or maybe we can hangout now? 😂 [22:09:55] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Port Core-team work to prod - https://phabricator.wikimedia.org/T304376 (10Eileenmcnaughton) [22:12:19] (03PS7) 10Eileen: SearchKit ports of merged work [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769531 (https://phabricator.wikimedia.org/T304376) [22:12:21] (03PS6) 10Eileen: Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/769532 (https://phabricator.wikimedia.org/T304376) [22:12:23] (03PS1) 10Eileen: Backport afform patches [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/772518 (https://phabricator.wikimedia.org/T304376) [22:12:47] wfan: ok - use this morning's meeting link? AndyRussG not sure if you want to join [22:13:09] tomorrow's morning meeting? [22:13:56] Oh today's refine meeting! [22:46:46] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog: Phone number not populating in Civi from import files - https://phabricator.wikimedia.org/T303886 (10AnnWF) a:03AnnWF [22:47:04] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog: Phone number not populating in Civi from import files - https://phabricator.wikimedia.org/T303886 (10AnnWF) 05Open→03In progress [22:49:42] (03CR) 10Eileen: [C: 03+2] "There is a misplaced space here - but I'm just gonna ignore it ...." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/772459 (https://phabricator.wikimedia.org/T304088) (owner: 10Ejegg) [22:51:13] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops, 10Patch-For-Review: Remove voter party field from acoustic export - https://phabricator.wikimedia.org/T304357 (10Eileenmcnaughton) @Ejegg @KHaggard it looks like the voter party field is the ver... [22:51:24] (03Merged) 10jenkins-bot: Stop exporting voter_party [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/772459 (https://phabricator.wikimedia.org/T304088) (owner: 10Ejegg) [22:54:35] (03PS1) 10Eileen: Submodule CiviCRM update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772520 [22:55:09] (03CR) 10Eileen: [C: 03+2] Submodule CiviCRM update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772520 (owner: 10Eileen) [23:07:06] (03Merged) 10jenkins-bot: Submodule CiviCRM update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772520 (owner: 10Eileen) [23:11:17] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Remove voter party field from acoustic export - https://phabricator.wikimedia.org/T304357 (10KHaggard) Thanks @Eileenmcnaughton - I still rely on the nightly imports to "unmap" a field, but it's t... [23:23:28] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/772522 [23:23:41] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/772522 (owner: 10Eileen) [23:27:07] thanks for the CR eileen ! [23:27:29] sorry for that introduced typo [23:40:08] ejegg: lol yeah I didn't think it was worth worrying about [23:41:08] XenoRyet: his highness is Still positive - we suggested he come & go down to the house but wear a mask - - he says 'I'm fine up here' (subtext = playing games & being waited on....) [23:42:07] are you verifying his tests or is he going to drag it out as long as feasible? :) [23:42:50] Heh, expected result then ;-) [23:43:17] (03CR) 10Ejegg: "Ooh, good catch! Thanks jgleeson and damilare." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772488 (https://phabricator.wikimedia.org/T303994) (owner: 10Jgleeson) [23:43:22] dwisehaupt: lol - probably bought sample positives on ebay [23:49:19] we think we might starve him out .... [23:51:57] (03PS1) 10Ejegg: Update guzzlehttp/psr7 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772526 [23:52:46] !log civicrm revision changed from 52c45874 to 30c55f51 [23:52:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:53:30] (03PS1) 10Ejegg: Update guzzlehttp/psr7 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/772527 [23:57:11] 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Added a new Gift Source - Retirement Fund - Annual Fund Specified - https://phabricator.wikimedia.org/T303275 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton