[00:01:55] dwisehaupt: ok - still processing them through - but in about 20 mins should be gtg I think [00:02:19] ok cool. i'll get the kids and dog situated then. [00:04:12] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775407 [00:04:30] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775407 (owner: 10Eileen) [00:13:42] !log revision changed from 951ffb1d to 4bb3ec09 [00:13:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:26:56] (03PS2) 10Ejegg: Remove voter_party custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774530 (https://phabricator.wikimedia.org/T304359) [00:27:18] ok eileen ^^^ there's the stripped-down version that just stops creating the field on new installs [00:31:17] (03PS1) 10Eileen: Updated triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775408 [00:31:38] (03CR) 10Eileen: [C: 03+2] Remove voter_party custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774530 (https://phabricator.wikimedia.org/T304359) (owner: 10Ejegg) [00:33:42] thanks [00:33:52] looking at that triggers patch [00:34:16] (03PS1) 10Eileen: Update prospect triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775409 [00:34:26] ejegg: I'm retrying - there is waay to much noise [00:34:40] gonna break into the 3 tables I expect to change & check the rest after [00:35:16] (03PS1) 10Eileen: Add triggers for new group table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775410 [00:36:29] eileen: weird, looks like that first version of the patch just had the triggers twice? [00:37:17] yeah - they seem to have been generated that way - even the updated one for prospect has a duplicate delete [00:37:35] I'll dump that out [00:38:50] (03PS2) 10Eileen: Update prospect triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775409 [00:39:35] (03PS2) 10Eileen: Add triggers for new group table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775410 [00:40:43] ejegg: ok - those 2 patches should work for the update & then I can dig into why it was too hard [00:41:22] oh maybe because I generated the triggers slightly differently - ie I just accepted that when the field was added they were regenerated & used that output - will try again after [00:42:42] (03CR) 10Ejegg: [C: 03+2] Update prospect triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775409 (owner: 10Eileen) [00:43:50] (03Merged) 10jenkins-bot: Remove voter_party custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774530 (https://phabricator.wikimedia.org/T304359) (owner: 10Ejegg) [00:49:56] (03CR) 10Ejegg: [C: 03+2] Add triggers for new group table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775410 (owner: 10Eileen) [00:53:52] (03PS1) 10Eileen: Updated prospect only triggers file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775412 [00:55:14] (03Merged) 10jenkins-bot: Update prospect triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775409 (owner: 10Eileen) [00:56:34] (03PS2) 10Eileen: Updated prospect only triggers file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775412 [00:57:34] ejegg: I thought it might be useful to update the file of triggers for that table only also - although I think it's adding to rather than easing the confusion now I look at the diff [01:01:12] (03PS3) 10Eileen: Updated prospect only triggers file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775412 [01:01:31] eileen: oh right, I had only fixed that standalone file earlier when removing voter_party [01:01:38] so yah, I was a bit confused [01:01:41] ok updated again - I was thinking dwisehaupt could run that one first & then back them up & try the big file [01:02:05] I'm just worried about recovery if there is an issue with the big file - since I had to do more wrangling than I wanted to [01:02:21] gotcha [01:02:55] (03CR) 10Ejegg: [C: 03+2] Updated prospect only triggers file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775412 (owner: 10Eileen) [01:03:58] (03Merged) 10jenkins-bot: Add triggers for new group table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775410 (owner: 10Eileen) [01:14:48] (03Merged) 10jenkins-bot: Updated prospect only triggers file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775412 (owner: 10Eileen) [01:20:29] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775415 [01:20:40] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775415 (owner: 10Eileen) [01:29:28] (03PS8) 10Eileen: Add Omnigroup.create api to create group at Acoustic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772968 (https://phabricator.wikimedia.org/T304473) [01:29:31] (03PS8) 10Eileen: Store remote group ID to the custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774582 (https://phabricator.wikimedia.org/T304475) [01:29:33] (03PS7) 10Eileen: Add groups to Acoustic data fetch output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774587 (https://phabricator.wikimedia.org/T304475) [01:29:35] (03PS7) 10Eileen: Add api to create contacts at Acoustic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774590 (https://phabricator.wikimedia.org/T304473) [01:29:37] (03PS7) 10Eileen: Add Omnimail push action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774591 (https://phabricator.wikimedia.org/T305006) [01:37:37] (03Abandoned) 10Eileen: Updated triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775408 (owner: 10Eileen) [01:38:16] !log revision changed from 4bb3ec09 to a9c323af [01:38:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:27:15] PROBLEM - check_mysql on frdb1002 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [02:32:15] PROBLEM - check_mysql on frdb1002 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [02:35:33] ACKNOWLEDGEMENT - check_mysql on frdb1002 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Dwisehaupt known db work for triggers. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [03:01:18] (03PS1) 10Ejegg: Fix missing quote in triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775418 [03:02:35] (03CR) 10Eileen: [C: 03+2] Fix missing quote in triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775418 (owner: 10Ejegg) [03:02:46] (03CR) 10Eileen: [V: 03+2 C: 03+2] Fix missing quote in triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775418 (owner: 10Ejegg) [03:03:42] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775419 [03:03:54] (03CR) 10Eileen: [V: 03+2 C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775419 (owner: 10Eileen) [03:04:53] !log civicrm revision changed from a9c323af to a6f49bb3 [03:04:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:10:31] (03PS1) 10Eileen: Re-update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775420 [03:11:51] (03CR) 10Ejegg: [C: 03+2] Re-update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775420 (owner: 10Eileen) [03:13:00] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Re-update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775420 (owner: 10Eileen) [03:13:53] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775421 [03:14:04] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/775421 (owner: 10Ejegg) [03:15:17] !log civicrm revision changed from a6f49bb3 to 84c737b6 [03:15:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:26:13] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Voter party field - once removed the logging field needs to be dropped - https://phabricator.wikimedia.org/T304359 (10Ejegg) Dallas has dropped this column from... [03:27:18] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 127342 Threads: 11 Questions: 4742668 Slow queries: 47 Opens: 17965533 Flush tables: 1 Open tables: 200 Queries per second avg: 37.243 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [04:00:18] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect: Three new custom fields on the prospect tab - https://phabricator.wikimedia.org/T304479 (10Eileenmcnaughton) As promised I've updated https://wikitech.wikimedia.org/wiki/Fundraising#Custom_fields wi... [04:05:22] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect: Three new custom fields on the prospect tab - https://phabricator.wikimedia.org/T304479 (10Eileenmcnaughton) I learnt something- you can output in php from api explorer - {F35031193} [04:11:10] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect, 10Patch-For-Review: New custom field - Prospect Insight - https://phabricator.wikimedia.org/T304268 (10Eileenmcnaughton) The trigger portion of this is done [04:39:04] (03PS1) 10Eileen: Fix trigger generation to get rid of trailing spaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775446 [05:05:49] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, and 4 others: Create custom field data structure to store the acoustic reference - https://phabricator.wikimedia.org/T304475 (10Eileenmcnaughton) 0... [05:05:52] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, and 4 others: Add api to add contact to a group in acoustic - https://phabricator.wikimedia.org/T304473 (10Eileenmcnaughton) [05:06:19] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Remove voter party from logging triggers - https://phabricator.wikimedia.org/T304358 (10Eileenmcnaughton) 05Openβ†’03Resolved [05:06:34] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Voter party field - once removed the logging field needs to be dropped - https://phabricator.wikimedia.org/T304359 (10Eileenmcnaughton) 05Openβ†’03Resolved [05:13:26] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/775537 (owner: 10L10n-bot) [05:16:38] (03CR) 10Eileen: "I didn't get as far as testing this but I looked through all the code and it all looks right so just adding a +1 to indicate I have taken " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775013 (https://phabricator.wikimedia.org/T304909) (owner: 10Ejegg) [07:30:57] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/775537 (owner: 10L10n-bot) [09:21:44] (03PS1) 10Damilare Adedoyin: Add 3 new custom fields on the prospect tab on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775809 (https://phabricator.wikimedia.org/T304479) [09:41:54] (03PS2) 10Damilare Adedoyin: Add 3 new custom fields on the prospect tab on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775809 (https://phabricator.wikimedia.org/T304479) [09:43:48] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775399 (https://phabricator.wikimedia.org/T304268) (owner: 10Eileen) [09:56:49] (03CR) 10Damilare Adedoyin: [C: 03+2] Add Prospect Insight custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775399 (https://phabricator.wikimedia.org/T304268) (owner: 10Eileen) [09:57:54] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect, 10Patch-For-Review: Three new custom fields on the prospect tab - https://phabricator.wikimedia.org/T304479 (10Damilare) Thanks @Eileenmcnaughton the this and documentation on WikiTech was really... [09:58:55] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog: Brief Civi Deadlock 3/30/22 - https://phabricator.wikimedia.org/T305089 (10RLewis) @Eileenmcnaughton - I using an export mapping that was already saved but added a few additional fields from the prospect tab, unless I somehow selected all fields but that... [10:09:54] (03Merged) 10jenkins-bot: Add Prospect Insight custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775399 (https://phabricator.wikimedia.org/T304268) (owner: 10Eileen) [13:24:24] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal: PIX workflow in Dlocal/Brazil - https://phabricator.wikimedia.org/T304014 (10Pcoombe) @EMartin Yes, the donor would select PIX on either donatewiki or in the banners, and then get this form on payments. Do you have anyone who could test this locally? [14:01:11] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Adyen: Changes to Adyen API calls - https://phabricator.wikimedia.org/T304115 (10Damilare) a:03Damilare [14:28:58] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog: Refactor ConfigurationReader - https://phabricator.wikimedia.org/T305152 (10jgleeson) [14:31:48] I really like Pistachio nuts but they don't half make one hell of a mess! [14:34:13] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog: Refactor ConfigurationReader - https://phabricator.wikimedia.org/T305152 (10jgleeson) [14:38:18] (03PS1) 10Damilare Adedoyin: Changes to Adyen API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/775874 (https://phabricator.wikimedia.org/T304115) [15:46:54] Hi all. I am looking to use the drupal.exchange_rates table for currency conversion. However, I noticed that there are many entries for each currency? https://usercontent.irccloud-cdn.com/file/ScSHA6n6/Screen%20Shot%202022-03-30%20at%203.28.51%20PM.png [15:47:15] Do those update columns correspond to datetime or any other way to identify which entry is most recent? [15:47:15] The entry in media wiki (https://www.mediawiki.org/wiki/Fundraising_tech/Database_schema#drupal.exchange_rates) says "Current and historical foreign exchange rates." [15:50:23] looking josephmando [15:50:32] Thank you! [15:57:29] 10Fundraising-Backlog, 10FR-Email: Acoustic import jobs failed - missing files from FTP - https://phabricator.wikimedia.org/T305170 (10KHaggard) [15:57:38] 10Fundraising-Backlog, 10FR-Email: Acoustic import jobs failed - missing files from FTP - https://phabricator.wikimedia.org/T305170 (10KHaggard) p:05Triageβ†’03High [15:57:40] yeah josephmando it looks like we update those rates nightly and the 'local_update' field is a timestamp set at the time we write the data to the db so you could order by that field to get the latest [15:59:21] Gotcha, I will use the local_update field to order it. Do we know what format that is? It looks like unix time stamp? [15:59:52] yeah it's a unix timestamp so 'ORDER BY local_update DESC' should be good! [16:01:26] Awesome! That worked. Thank you! This is going to be so helpful! https://usercontent.irccloud-cdn.com/file/dUaoVD57/Screen%20Shot%202022-03-31%20at%2011.00.58%20AM.png [16:02:01] no problem! :) [16:05:51] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Email: Acoustic import jobs failed - missing files from FTP - https://phabricator.wikimedia.org/T305170 (10DStrine) [16:18:47] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Email: Acoustic import jobs failed - missing files from FTP - https://phabricator.wikimedia.org/T305170 (10Ejegg) Oh shoot @KHaggard we had the jobs off for some maintenance last night and it looks like that was right when the export was scheduled... [16:57:10] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Email: Acoustic import jobs failed - missing files from FTP - https://phabricator.wikimedia.org/T305170 (10KHaggard) Thanks @Ejegg ! I'll manually run the jobs after I get out of next meeting :) [17:05:38] https://imgur.com/1YuasTA civi build failed again here is the screen shot [17:05:55] AndyRussG: [17:10:02] ah thx wfan, looking [17:10:40] to do this, did you remove everything in fundraising-dev? or just wmff? [17:11:20] just thinking you might still have some old source code under src/civicrm-buildkit, depending on how you did it? [17:12:15] looks like a compile error for some composer dependency? [17:13:36] I hit yes for remove and reinstall for all the questions setup script asked me for, but I will try to build a brand new docker πŸ˜‚ [17:13:59] wfan: I would first just try updating civibuildkit code? [17:14:35] oh ok [17:14:56] under src/civicrm-buildkit [17:15:11] already up to date [17:15:12] and make sure setup.sh runs the steps for composer and npm install for that repo [17:15:20] ok [17:16:18] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal: PIX workflow in Dlocal/Brazil - https://phabricator.wikimedia.org/T304014 (10EMartin) @Pcoombe yes, we have someone. I'll see if they will do this for us. [17:19:54] wfan: I wonder if it's not also something to do with the Mac? or this is on Linux? [17:23:23] this is on mac [18:04:49] oh huh, composer compile step? [18:05:18] so what is Civi trying to get compiled [18:11:54] looks like scss files being compiled to css in the greenwich skin [18:12:09] do we use that? [18:13:11] wfan you might be able to get past that just by deleting the civicrm/composer-compile-plugin line in civicrm/composer.json [18:14:40] ah. I will try this too, thanks [18:16:47] oh shoot, it might really mess up your css though - looks like that greenwich extension whose css is being compiled by that broken step is responsible for providing bootstrap3 to the rest of Civi [18:19:27] so 'composer compile' does work for me on linux inside the crm/civicrm directory [18:22:02] yeah, I will try to setup with my ubuntu too, just need to have the ssh setup for my yubikey and gerrit [18:27:02] I'm on ubuntu wfan and managed to reinstall civicrm yesterday without any issues. hope it works for ya! [18:27:42] πŸ‘thanks! [18:31:01] Hi wfan, I also reinstalled civicrm on my mac yesterday and it completed. [18:35:52] Yeah I will try both envπŸ˜‚ [18:44:46] (03PS2) 10Damilare Adedoyin: Changes to Adyen API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/775874 (https://phabricator.wikimedia.org/T304115) [18:58:50] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Email: Acoustic import jobs failed - missing files from FTP - https://phabricator.wikimedia.org/T305170 (10KHaggard) 05Openβ†’03Resolved a:03KHaggard Jobs ran and look good! Thanks for the help @Ejegg ! Resolving ticket now :) [20:10:42] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Dwisehaupt) [20:10:57] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Dwisehaupt) 05Openβ†’03Resolved a:03Dwisehaupt [20:50:48] (03PS3) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [20:52:47] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10Patch-For-Review: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10jgleeson) @EMartin would we ever need to keep these settings private? [20:53:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [20:56:55] (03PS4) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [20:57:17] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog: Brief Civi Deadlock 3/30/22 - https://phabricator.wikimedia.org/T305089 (10Eileenmcnaughton) @RLewis I think the issue might be the selected fields rather than the number of rows - maybe try cutting back - especially things like groups, notes, tags if you... [20:58:48] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [21:02:00] (03CR) 10Eileen: "Looks good Damilare - it needs a rebase now the other is merged - I couldn't do it within gerrit so I guess it needs to be done manually " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775809 (https://phabricator.wikimedia.org/T304479) (owner: 10Damilare Adedoyin) [21:04:20] (03PS5) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [21:06:14] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [21:12:24] well that sucks. phpcs giving different results across local and CI [21:12:47] different rulesets? [21:14:33] I was under the impression they would both be looking at phpcs.xml on the fundraising/REL1_35 branch [21:14:37] but I guess not [21:15:44] the differences are related to PHP 7.4 return type declarations so feels like it might be a version thingy [21:16:08] (03PS6) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [21:17:48] ah so the rule that was tripped is PSR12.Functions.ReturnTypeDeclaration.SpaceBeforeColon [21:18:12] but I don't see that in fundraising/REL1_35 phpcs.xml [21:19:52] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10Patch-For-Review: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10EMartin) @jgleeson Hi Jack. No. I don't think this is proprietary in any way as a system... [21:20:04] oh I wonder if my mediawiki-codesniffer package is out of date [21:21:49] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10Patch-For-Review: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10jgleeson) thanks @EMartin [21:27:06] yah so it looks like CI is installing mediawiki/mediawiki-codesniffer (v38.0.0) [21:27:58] donation interface is using v38.0.0 [21:28:06] but payments is using v34.0.0 [21:28:24] I'm guess composer merge picks the lowest common denominator? [21:30:06] looks like jenkins is happy. bye for now [22:27:41] (03PS1) 10Ejegg: Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/776002 [22:45:53] (03CR) 10Ejegg: [C: 03+2] Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/776002 (owner: 10Ejegg) [22:54:52] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/776002 (owner: 10Ejegg) [23:11:35] !log updated payments-wiki from 47d9bd27 to 6f888c28 [23:11:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:48:56] 10Fundraising-Backlog, 10FR-Adyen, 10FR-WMF-Audit, 10Recurring-Donations: Adyen audit parser: fix recurring as much as possible - https://phabricator.wikimedia.org/T297856 (10Cstone) The fix to find Ingenico recurring installments also fixed the Adyen ones https://gerrit.wikimedia.org/r/c/wikimedia/fundrai...