[07:39:55] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/776777 (owner: 10L10n-bot) [07:44:30] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/776777 (owner: 10L10n-bot) [09:39:45] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog: Brief Civi Deadlock 3/30/22 - https://phabricator.wikimedia.org/T305089 (10RLewis) @Eileenmcnaughton - thanks that's good to know and will do. [12:35:13] (03PS4) 10Damilare Adedoyin: Add 3 new custom fields on the prospect tab on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775809 (https://phabricator.wikimedia.org/T304479) [12:36:46] (03CR) 10Damilare Adedoyin: "All fixed switched to keying by name for consistency. Thanks Eileen." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775809 (https://phabricator.wikimedia.org/T304479) (owner: 10Damilare Adedoyin) [16:27:11] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add recurring for Google Pay - https://phabricator.wikimedia.org/T300687 (10AnnWF) No code change for this ticket since it’s been covered by https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/768753/2/... [17:33:32] AndyRussG: I found an event that's thrown when the resolve function fails, for that Civi / Acoustic data patch [17:33:35] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/776057 [17:34:06] So when the resolve function fails, the controller is never instantiated and the model is not rendered [17:34:21] I guess the idea is that things from resolve are completely necessary to the view [17:34:33] ejegg: ah cool! yeah I was looking at that one last night, didn't get that far tho before my brain died (many crazy non-work stuffs) [17:34:46] and then rather than wire error handling / display into all of your different views, you can have one central error handler [17:35:00] I think at the level you wire it in, you can still get access to the router [17:35:10] so if you wanted to you could redirect to a general error page [17:35:19] but for this patch I just tossed up an alert [17:35:36] ejegg: hmm so with not much change it could be an error page rather than an alert box? [17:36:02] Well, we'd have to see how to pass the error message into the error page [17:36:10] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal: PIX workflow in Dlocal/Brazil - https://phabricator.wikimedia.org/T304014 (10DStrine) Let me know if this works and I'll resolve this task. As for now it's on the back burner for fr-tech. [17:36:25] I didn't want to just put it on the route and have the error page blindly render the error from the URL [17:36:47] If we didn't care about the specific error message, we could do that [17:37:12] we would need at the least an error template in angualr [17:37:31] and a controller if we wanted to do anything non-static [17:37:58] so it wouldn't exactly be not much change, but it might be a fun learning experience [17:38:08] want to try making another patch to go from alert to page? [17:40:40] ejegg: I'm happy to but I'm also worried about fun rabbit-hole outrunning actual priorities heheh [17:41:22] ok ok, maybe the alert is good enough for now [17:41:35] cool... yeah let's keep it at an alert box for today and run the idea by eileen later? I'd be surprised if she doesn't already has a plan for something like this [18:08:49] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal: PIX workflow in Dlocal/Brazil - https://phabricator.wikimedia.org/T304014 (10EMartin) @RKumar_WMF Rakhi is getting this tested. Stand by. [18:20:30] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Gpay-Integration: Add recurring for Google Pay - https://phabricator.wikimedia.org/T300687 (10Cstone) I tested this too, looks good! Made the token correctly in adyen and charged it fine [19:47:52] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022? - https://phabricator.wikimedia.org/T305405 (10spatton) [19:54:38] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Editing system workflow messages should clear cached values - https://phabricator.wikimedia.org/T305103 (10Dwisehaupt) [19:55:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Let's do a global update on our composer packages (crm repo) - https://phabricator.wikimedia.org/T304451 (10Dwisehaupt) [19:57:07] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Zeitgeistbusters, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Clean up install script from wmf_civicrm & move relevant parts to the extension - https://phabricator.wikimedia.org/T270680 (10Dwisehaupt) [20:02:36] 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising Sprint Interstitial ads halfway down the coaster hill, 10Fundraising Sprint Ketchup Flume Ride, and 4 others: Convert large donation module to an extension - https://phabricator.wikimedia.org/T270667 (10... [20:04:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Figure out how we will migrate users - https://phabricator.wikimedia.org/T276271 (10Dwisehaupt) [20:07:30] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Figure out how we will migrate users - https://phabricator.wikimedia.org/T276271 (10Dwisehaupt) [20:07:41] (03CR) 10Eileen: [C: 03+2] Add 3 new custom fields on the prospect tab on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775809 (https://phabricator.wikimedia.org/T304479) (owner: 10Damilare Adedoyin) [20:11:16] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Test d9 install on staging - https://phabricator.wikimedia.org/T276273 (10Dwisehaupt) [20:18:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Spike - do practice d9 installs locally to get our heads around it - https://phabricator.wikimedia.org/T276395 (10Dwisehaupt) [20:20:41] 10Fundraising-Backlog, 10Fr-drupal-upgrade-2021: Add year option to wmf-eoy-send-letters drush command - https://phabricator.wikimedia.org/T271585 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton https://wikitech.wikimedia.org/wiki/Fundraising/Internal_Endpoints/End_of_year_emails#Send [20:24:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_communication into an extenstion = probably wmf-thankyou - https://phabricator.wikimedia.org/T270682 (10Dwisehaupt) [20:27:28] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Try to remove wmf_common_date_unix_to_civicrm - https://phabricator.wikimedia.org/T270753 (10Dwisehaupt) [20:29:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10Dwisehaupt) [20:33:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10Dwisehaupt) [20:37:17] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Prospect: Three new custom fields on the prospect tab - https://phabricator.wikimedia.org/T304479 (10Eileenmcnaughton) I moved this straight to resolved since there is no real need for deployment [20:38:54] ejegg: I just noticed this in the sprint - but I think it was maye resolved last sprint? https://phabricator.wikimedia.org/T304088 [20:49:23] eileen: yep, all but the backups [20:50:11] I think we were going to talk to security about maybe encrypting those for us so we can't just restore them? [20:50:26] maybe past a certain date? [21:25:23] (03PS7) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [21:27:42] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [21:48:32] ejegg: it was decided that backups didn't need to be done. trying to find the documentation on it. [21:48:39] ok, cool [21:48:52] then I guess we CAN close that ticket [21:49:10] T304360 [21:49:10] T304360: Voter party field - do we need to drop from backups or can it age out? - https://phabricator.wikimedia.org/T304360 [21:49:22] so yeah. we can close it. [21:49:23] ok, great [21:51:42] (03PS2) 10Ejegg: Fix trigger generation to get rid of trailing spaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775446 (owner: 10Eileen) [21:51:59] (03CR) 10Ejegg: [C: 03+2] "Regenerated triggers look fine and work locally" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775446 (owner: 10Eileen) [22:05:33] (03Merged) 10jenkins-bot: Fix trigger generation to get rid of trailing spaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775446 (owner: 10Eileen) [22:30:16] ejegg: just looking at your thank you - do we have any hesitation committing Maryana's email into our code? I guess the spammers already have it [22:31:51] eileen: no, no hesitation [22:31:57] ok cool [22:36:13] ejegg: also - I'm tempted to add a menu item in to mailcatcher on dev builds - but it gets a lot more complicated if I don't hard code the port - which I *think* is a feature you use (changing ports around) [22:39:42] we might have the mailcatcher port hardcoded - lemme see [22:40:29] ah no, it's variable [22:40:44] so we just need to provide the variable to the civicrm container [22:41:04] FR_DOCKER_MAILCATCHER_PORT [22:41:28] hmm, does that need an image rebuild? [22:41:47] or just a change to the container? [22:41:52] setup.sh [22:43:03] ah no, docker-compose.yml [22:53:21] (03PS4) 10Eileen: Move thank you from name/address to Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775013 (https://phabricator.wikimedia.org/T304909) (owner: 10Ejegg) [22:55:18] (03CR) 10Eileen: "I just fixed one use statement to have correct capitalisation - so far have tested endowment & EOY - will see if I can test the other 2 bu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775013 (https://phabricator.wikimedia.org/T304909) (owner: 10Ejegg) [22:55:44] ejegg: to add a link in the menu I would do it in Civi [22:56:00] I can always just do the easy thing & we can make it cleverer later if we want [23:10:05] (03CR) 10Eileen: [C: 03+1] "ejegg I'm +2 on this including the minor change I made - if you want to check that & then +2 it it can be merged" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775013 (https://phabricator.wikimedia.org/T304909) (owner: 10Ejegg) [23:15:41] (03PS1) 10Eileen: Add dev environment link to MailCatcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/777026 [23:15:49] ejegg: ^^ was what I was thinking about re link [23:21:19] sorry eileen, was afk helping with a bedtime routine [23:21:23] looking [23:21:29] and thanks for the fix [23:21:39] ejegg: no worries - you can also +2 your own one now [23:28:34] (03CR) 10Ejegg: [C: 03+2] "Thanks for the fix!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775013 (https://phabricator.wikimedia.org/T304909) (owner: 10Ejegg) [23:33:57] oh hmm, mailcatcher shows the verp address in the from field [23:34:25] but if you look at the source it's got the configured from email in the From: and the Reply-To: headers [23:34:34] is that a bug in mailcatcher? [23:37:03] ejegg: yeah it took me a bit to realise it was there [23:37:12] not sure if it is a bug or a feature... [23:37:57] heh, ideally it would display more like other clients, no? [23:38:13] i.e. gmail shows the configured From: address and hides the reply-to [23:39:29] ejegg: yep [23:39:40] but that looks like a rabbit hole [23:41:09] heh, especially since mailcatcher is a Ruby app [23:41:10] (03Merged) 10jenkins-bot: Move thank you from name/address to Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/775013 (https://phabricator.wikimedia.org/T304909) (owner: 10Ejegg) [23:41:19] * ejegg pulls head back up out of hole [23:41:50] (03CR) 10Ejegg: [C: 03+2] "Well that's handy!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/777026 (owner: 10Eileen) [23:42:01] :-) [23:42:50] AndyRussG: were you planning on reviewing those other Acoustic api? If so am happy to jump on a call any time. I'm just gonna update the wiki page [23:43:16] eileen: hiii! [23:43:21] eileen: I'm about to +2 that Omnigroup.create call [23:43:22] hey [23:43:28] ejegg: cool - one down! [23:45:11] eileen ejegg I did look at some, as I could... as mentioned in the meeting I've been going a bit crazy with non-work stuff of late... eileen what about a call later this evening (your afternoon), and we can go over whatever others haven't gotten to by then? [23:45:48] AndyRussG: ok sure - it might be that ejegg is already looking anyway :-) [23:46:04] unrelated https://www.youtube.com/watch?v=02AEB75W5Sg - the ad has our new Art centre in it [23:46:58] eileen: right so whatever he hasn't gotten to later perhaps? [23:47:10] (if there's any left that is :) ) [23:47:32] (03PS1) 10Ejegg: Fix the 'All' jackpot thank-you test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/777032 [23:47:40] I'm thinking in about 2.5 or 3 hrs or so [23:48:25] (if that works for u ofc) [23:51:18] (03CR) 10Eileen: [C: 03+2] "It's better than before I guess - but it's actually important that we get rid of this form as it is testing the file version of the templa" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/777032 (owner: 10Ejegg) [23:51:21] ah ejegg eileen there was one tiny comment I had on that first patch [23:51:53] AndyRussG: I don't see it - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/772968 [23:51:58] (03CR) 10AndyRussG: Add Omnigroup.create api to create group at Acoustic (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772968 (https://phabricator.wikimedia.org/T304473) (owner: 10Eileen) [23:52:09] oh - 'Show all entries' [23:52:25] eileen: nooo it was only in draft form... just submitted a second ago ;p [23:52:33] ok [23:52:40] thx, back later! [23:53:34] AndyRussG: yeah - that makes sense - I'll make that change at the top of the chain though rather than rebase [23:53:36] (03Merged) 10jenkins-bot: Add dev environment link to MailCatcher [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/777026 (owner: 10Eileen) [23:55:46] (03PS1) 10Eileen: Move variable declaration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/777033 [23:56:20] (03CR) 10Eileen: Add Omnigroup.create api to create group at Acoustic (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/772968 (https://phabricator.wikimedia.org/T304473) (owner: 10Eileen)