[00:55:35] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Puppet failures on CentralNotice staging VM - https://phabricator.wikimedia.org/T305602 (10Ejegg) [00:58:41] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10Ejegg) [05:09:52] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/778001 (owner: 10L10n-bot) [05:50:19] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/777570 (owner: 10L10n-bot) [05:52:11] (03CR) 10AndyRussG: [C: 03+2] "Fantastic, thanks so much!!!!!! :) :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774590 (https://phabricator.wikimedia.org/T304473) (owner: 10Eileen) [05:55:36] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/778001 (owner: 10L10n-bot) [06:04:49] (03Merged) 10jenkins-bot: Add api to create contacts at Acoustic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774590 (https://phabricator.wikimedia.org/T304473) (owner: 10Eileen) [07:08:25] (03PS2) 10Russ Rogovetz: Replace getNativeData to getText for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/777815 (https://phabricator.wikimedia.org/T283668) [11:22:18] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal: PIX workflow in Dlocal/Brazil - https://phabricator.wikimedia.org/T304014 (10RKumar_WMF) PIX retested successfully. No issues were reported. CID: 54914490. Ty. [13:24:12] PROBLEM - Host frbast1001 is DOWN: PING CRITICAL - Packet loss = 100% [13:26:08] RECOVERY - Host frbast1001 is UP: PING OK - Packet loss = 0%, RTA = 0.32 ms [14:15:44] (03CR) 10Roman Stolar: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/777815 (https://phabricator.wikimedia.org/T283668) (owner: 10Russ Rogovetz) [16:01:33] fr-tech are we moving our standup after all-staff mtg? [16:02:07] i believe so. i'm still catching up on the all-staff at 1.5x. [16:02:13] im ok with that [16:02:25] ok [16:05:44] the one bad part of watching live, you can't watch at 1.5x :) [16:07:33] i'm not sure what happens when i catch up. perhaps i will see the future. [16:08:26] it just goes to 1x as you'd expect, I've done that a few times in the past with school/kid duties making me late :) [16:08:44] ah this is why no one is on the call [16:09:32] bummer. i thought i might have a chance at time travel. [16:09:56] sorry [16:10:26] I joined just as the presentation fisnished [16:10:33] guess I'll catch the recording [16:10:45] fr-tech jgleeson and I were the only ones in the standup meeting just now. I moved it to half past the hour. [16:10:54] oh shoot it's over now? [16:11:00] no, one more preso [16:11:02] its still going [16:11:23] yeah [16:11:48] meetingathon [16:12:10] jgleeson: ^^^ that's my life lol [16:12:47] haha [16:19:29] let's not start comparing calendars [16:24:59] greg-g: it's cute when ICs complain about being in too many meetings. ;) [16:25:45] ha. i just caught up to live as the meeting finished. perfect timing. [16:27:02] I at least have a partial understanding of the directors and above. Some of my weeks are similar. [16:27:07] bd808: <3 [16:27:46] whew, got my lappy plugged in right before the battery was about to die [16:27:59] will definitely set up hibernation on the next one [16:36:34] enable that swap, yo [16:37:26] yep yep, I had tons of stuff on a full-disk encrypted partition on the current lappy before I learned how to do encrypted hibernation... [16:37:36] much easier to set it up that way from the start [16:39:08] yeah, I just use a swapfile (not partition) to make it easier to manage, eg: https://devconnected.com/how-to-add-swap-space-on-debian-10-buster/#Add_Swap_Space_with_a_swap_file [16:50:31] oho, and the bootloader can restore the RAM from a file? I thought hibernation needed a partition [16:51:17] apparently so... https://askubuntu.com/questions/888998/hibernate-to-swapfile-on-encrypted-volume [16:51:40] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising Sprint e^🥧👀=yum, and 5 others: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10Pcoombe) 05Resolved→03Open Can we get this added t... [16:58:19] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising Sprint e^🥧👀=yum, and 5 others: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10DStrine) Hey @Pcoombe we ran into some form chooser ch... [17:03:00] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising Sprint e^🥧👀=yum, and 5 others: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10Pcoombe) No, the banner code is designed around using... [17:06:13] ok fr-tech this is something to work through https://phabricator.wikimedia.org/T293508 [17:06:37] we can't have dlocal be default but it needs to be available for the banner team to run a 1 hour test [17:11:27] I know we're about to start the form chooser work next sprint but they need to be able to set up the SA test within the next few days for it to run on the 26th. So this needs to get figured out before any of the form chooser stuff would realistically get done. [17:12:14] And it will be somewhat painful for them to move the test. I'd rather not ask them to do that [17:13:38] dstrine it's probably OK for it to be default for an hour, no? [17:14:12] ah ok yeah if we coordinate with the banner team right at the moment they want to run the tests [17:14:34] someone would have to be online with the banner team to do this live with them [17:18:39] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising Sprint e^🥧👀=yum, and 5 others: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10DStrine) @Ejegg is suggesting that fr-tech can turn it... [18:18:29] We could really use it available outside of the test window, for us to proof the entire flow internally [18:20:12] dstrine / pcoombe I'm going to try a slight change to that commented out bit - we should be able to make it available without making it default [18:20:31] I would really like to start writing the unit tests on the form chooser that will give us more predictability around that [18:52:03] (03PS1) 10Ejegg: Uncomment DLocal ZA form with weight 0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/778334 (https://phabricator.wikimedia.org/T293508) [18:53:53] (03CR) 10Ejegg: "links for local verification:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/778334 (https://phabricator.wikimedia.org/T293508) (owner: 10Ejegg) [18:53:57] 10Wikimedia-Fundraising, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Is DonationInterface still needed on the main cluster? - https://phabricator.wikimedia.org/T236001 (10Krinkle) [18:53:58] https://localhost:9001/index.php?title=Special:GatewayForfr-tech ^^^ [18:54:06] derp [18:54:41] fr-tech this should work for the ZA tests: https://gerrit.wikimedia.org/r/778334 Links for local testing are included in a comment on the patch [19:25:23] (03PS1) 10Ejegg: Stock CiviCRM 5.48.0 [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778336 [19:25:25] (03PS1) 10Ejegg: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778337 (https://phabricator.wikimedia.org/T303883) [19:25:27] (03PS1) 10Ejegg: Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778338 (https://phabricator.wikimedia.org/T303883) [19:25:29] (03PS1) 10Ejegg: SearchKit ports of merged work [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778339 (https://phabricator.wikimedia.org/T304376) [19:25:31] (03PS1) 10Ejegg: Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778340 (https://phabricator.wikimedia.org/T304376) [19:25:33] (03PS1) 10Ejegg: Backport afform patches [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778341 (https://phabricator.wikimedia.org/T304376) [19:25:35] (03PS1) 10Ejegg: Guzzle psr update [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778342 [19:25:37] (03PS1) 10Ejegg: Fix label [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778343 (https://phabricator.wikimedia.org/T304665) [19:25:39] (03PS1) 10Ejegg: Add created & modified dates to relationhsip view [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778344 (https://phabricator.wikimedia.org/T294487) [19:25:58] fr-tech does someone want to help me sanity check those? [19:26:19] there's the base upgrade then the collection of patches we put on top of the last upgrade [19:26:26] I can ejegg [19:26:49] So if you check out the end of the chain, then diff it against origin/master it should show just the 'real' changes [19:27:00] not the patch removal/restoration noise [19:27:35] cool will try it out [19:27:46] A lot of the diff I'm seeing is related to that event timezone revert which happened between the 5.48 rc and the 5.48 release [19:29:00] (03CR) 10jerkins-bot: [V: 04-1] Guzzle psr update [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778342 (owner: 10Ejegg) [19:29:04] (03CR) 10jerkins-bot: [V: 04-1] Fix label [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778343 (https://phabricator.wikimedia.org/T304665) (owner: 10Ejegg) [19:29:22] (03CR) 10jerkins-bot: [V: 04-1] Add created & modified dates to relationhsip view [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778344 (https://phabricator.wikimedia.org/T294487) (owner: 10Ejegg) [19:29:29] So those V-1s are expected - some tests rely on all the patches being reapplied [19:29:48] as long as they pass on the end of the chain we should be OK to force the earlier patches through [19:30:51] weird [19:30:59] when I checkout that patch wit git review [19:31:04] it doesn't show your changes [19:31:22] jack@jack-ThinkPad:~/fundraising-dev/src/civi-sites/wmff/civicrm$ gr -d 778344 [19:31:24] Downloading refs/changes/44/778344/1 from gerrit [19:31:26] Branch review/unknown/778344 already exists - reusing [19:31:26] hrm? lemme look at gerrit [19:31:28] Switched to branch "review/unknown/778344" [19:31:51] git log shows: [19:31:54] commit 35fc472fb9fc5fab716ead1c2f4890fb2aa37023 (HEAD -> review/unknown/778344) [19:31:56] Author: Eileen McNaughton [19:31:58] Date: Wed Mar 9 09:45:03 2022 +1300 [19:32:00] Add created & modified dates to relationhsip view [19:32:02] [19:32:04] Bug: T294487 [19:32:04] T294487: Automatically populate created date on relationships - https://phabricator.wikimedia.org/T294487 [19:32:06] Change-Id: I2f2ee2a941a2dd0004681af51b0fc182c8c96501 [19:32:08] which is not your commit [19:32:14] oh weird [19:32:28] in gerrit the chain looks OK [19:32:28] review/unknown/ also looks unusual [19:33:44] I'll pull it down the other way [19:34:26] oh dang, looks like my merge conflict resolution on a vendor / composer update didn't work right [19:34:41] tests are failing with Error: Class 'ComposerAutoloaderInitb59f00d19ce944fce5ab065a94c51420' not found in require_once() [19:34:58] might have to manually run composer update [19:35:10] ok something fishy is going on. it's still showing the wrong cmt message when I pull it down the other way [19:35:23] git fetch https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm/civicrm refs/changes/44/778344/1 && git checkout -b change-778344 FETCH_HEAD [19:35:42] is that the right patch? [19:35:56] it should be, but I'm about to re-do the last three in any case [19:36:17] lemme see if I can fix this composer thing, then let's try the checkout again [19:37:30] fr-tech: today's music/mix recommendation is In Search Of Sunrise 4: Latin American CD 2 Continuous Mix - https://www.youtube.com/watch?v=edYzd_vZzyk [19:38:25] Latin America* even [19:39:11] ok, maybe I can just get rid of that patch? [19:40:18] I'm still wondering why I couldn't see it but yeah maybe I'll have better luck with the next one [19:40:22] (03CR) 10jerkins-bot: [V: 04-1] Stock CiviCRM 5.48.0 [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778336 (owner: 10Ejegg) [19:40:38] fr-tech is anyone around to double check the unusual behaviour I'm seeing? [19:41:17] (03PS2) 10Ejegg: Fix label [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778343 (https://phabricator.wikimedia.org/T304665) [19:41:19] (03PS2) 10Ejegg: Add created & modified dates to relationhsip view [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778344 (https://phabricator.wikimedia.org/T294487) [19:41:41] ok, I'll try pulling down from gerrit in the other dir I have on my machine [19:41:43] just run `git-review -d 778344` on your local wmff/civicrm checkout and if you DON'T see an ejegg commit when you run `git log -1` it's not just me [19:42:06] (03Abandoned) 10Ejegg: Guzzle psr update [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778342 (owner: 10Ejegg) [19:42:31] I'm in the throes of kid pick-up but can look in 40 min jgleeson [19:42:39] (03CR) 10jerkins-bot: [V: 04-1] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778337 (https://phabricator.wikimedia.org/T303883) (owner: 10Ejegg) [19:43:09] jgleeson: ok, I get Switched to branch "review/unknown/778344" too [19:43:12] let me see [19:43:21] np AndyRussG thanks! [19:43:25] ah ok ejegg [19:43:39] jgleeson: but 'git log' does seem to have the right chain for me [19:43:45] oh rly [19:43:48] mine errored but i dont think i have git review set up correctly [19:43:56] and your in wmff/civicrm/ ejegg ? [19:43:57] do you want to try again with the rebased last couple of patches? [19:44:03] jgleeson: yep, exactly [19:44:07] ah jeez [19:44:14] ok lemme try again [19:44:16] I had done the initial upgrade over in my non-docker checkout [19:44:36] so my wmff docker checkout ought to be in the same state as all of yorus [19:44:59] cstone: this will do the same thing just in longer form [19:45:02] git fetch https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm/civicrm refs/changes/44/778344/1 && git checkout -b change-778344 FETCH_HEAD [19:45:12] whoops i just did the /2 [19:45:25] cstone: no, that's good [19:45:34] the /1 has a bad composer update under it [19:46:34] i guess for testing what jgleeson was seeing? [19:46:39] so once you get it checked out, you can 'git diff 07ace7b34c7caab355253cf10b656f484e615c0e' to see all the differences from the currently merged version [19:47:15] argh still broke for me even with PS2 [19:47:33] jgleeson: want to do a scree share? [19:48:32] https://phabricator.wikimedia.org/P24271 [19:48:46] I just pasted that to share. can do share also in 1 sec. brb [19:48:54] scree share is trading various sharp rocks /rock joke [19:49:15] jgleeson ok that makes sense [19:49:36] cstone haha i was just thinking of that but I assumed nobody else would know the word [19:50:00] i guess i didn't know it meant they were sharp [19:50:14] i guess they dont have to be sharp but [19:50:21] havent been eroded as much as other rocks [19:50:42] ok back [19:50:53] jgleeson: that paste actually looks right [19:51:33] oh man [19:51:37] we're back up to 7 patches to cherry-pick after each upgrade [19:51:45] I'm looking for YOUR name [19:51:49] sorry my bad [19:51:56] :) [19:51:59] panic over [19:52:14] ok now that I know git still works [19:52:18] what do you need me to do [19:52:20] lol [19:53:11] just take a look at 'git diff 07ace7b34c7caab355253cf10b656f484e615c0e' [19:53:12] reading backscroll [19:53:15] ah ok [19:53:44] I guess to see if there are any other things from the currently-merged-version that are being lost [19:53:47] ok lots of stuff there [19:54:01] yeah, I thought it would be really small b/c we were already on 5.48 beta1 [19:54:17] git diff 07ace7b34c7caab355253cf10b656f484e615c0e --name-only [19:54:19] help [19:54:21] but the beta2 release reverted a pretty big patch about event timezones [19:54:21] s [19:54:51] OK, the vendor changes are mostly for the current security release [19:54:53] --name-only needs a --show-delete-added add-on [19:55:03] + - [19:55:35] and the info.xml ones are just a version stamp update [19:55:49] there's some other option, like --stat? [19:56:07] yeah, --stat shows the size of the change for each file [19:56:33] oh nice [19:56:35] so all the 2 +- ones with names like *info* can be assumed to be version stamp changes [19:57:08] wow where have you been all my life --stat [19:57:26] :) [19:57:55] sql/civicrm_generated.mysql [19:58:09] looks like it contains a lot of changes [19:58:36] jgleeson another thing going on here is that CiviGrant has just been removed from core and changed to an extension, so I see a couple of changes related to that (though it was mostly completed by beta1) [19:58:47] looking at that sql jgleeson [19:59:01] looks like test data [20:00:12] ok, yep, seems safe to ignore [20:00:22] I guess I can try doing a local upgrade [20:00:28] then a local rebuild [20:00:34] to make sure those paths both work [20:00:51] paths? [20:01:20] i mean to make sure upgrading works as well as fresh-installing [20:01:56] gotcha [20:03:15] I scan over a few files that looked interesting outside of the vendor changes and everything looked good to me [20:03:22] great! [20:03:30] I can also try an upgrade locally if that helps [20:03:48] sure, that'd be nice [20:03:53] I guess I should do it on staging too [20:04:49] guh, i got almost to the end of the local upgrade (had finished all the timezone stuff) and then Error 1: Maximum execution time of 30 seconds exceeded in /srv/civi-sites/wmff/civicrm/vendor/pear/db/DB/mysqli.php, line 462 [20:05:09] so why does our docker environment enforce 30 second execution times? [20:05:15] Production sure doesn't [20:05:28] and it's no fun to end up with a half-upgraded db [20:06:06] ok https://wmff.localhost:32353/civicrm/upgrade/ now shoes me Your database has already been upgraded to CiviCRM 5.48.0 [20:06:14] so I guess it actually updated what it needed to [20:06:23] will try to edit an event just to make sure [20:07:27] ok, that still works [20:07:52] will try the rebuild to make sure that test data still populates right [20:08:34] ok I haven't run the civi up yet I just finished the drupal [20:08:38] hello from new laptop [20:08:39] lemme change the time limit [20:08:46] woohoo cstone [20:08:46] hello new laptop cstone ! [20:15:07] this is strange [20:15:14] the max_execution_time on my civicrm container is 0 [20:15:23] and no where in the code sets it to 30 [20:18:01] drush @wmff ev "print ini_get('max_execution_time');" [20:18:09] 0 [20:18:17] even confirmed via drush so not sure what's happening [20:19:11] ok I'll run the update [20:21:10] it worked for me [20:21:33] did you try it on your non-docker stack ejegg maybe? [20:21:47] jgleeson: not yet, will do [20:22:21] oh poop, my latest change to the buildkit STILL isn't quite right [20:22:39] it makes the build fail when the prometheus dir already exists [20:22:58] hmm I see it [20:23:00] [Error: Update log tables] [20:23:02] Error 1: Maximum execution time of 30 seconds exceeded in /srv/civi-sites/wmff/civicrm/packages/DB/DataObject.php, line 578 [20:23:08] oh but that was via the web U [20:23:10] I [20:23:13] for the extension updates [20:23:23] grrr I think that defaults to 30 [20:23:35] huh, could that max execution time be from the database container? [20:24:28] docker@civicrm:/etc/php/7.3$ grep -r max_exe . [20:24:30] ./cli/php.ini:max_execution_time = 30 [20:24:32] ./apache2/php.ini:max_execution_time = 30 [20:24:37] php is doing it to us [20:24:49] even though when you run the cli it says 0 [20:25:53] we can mount in changes to that file or we could just update it at the image level which would be neater [20:26:43] oh i see [20:26:53] yeah I think if we update that at the base image we'll fix that for them all [20:34:15] we could also fix it with ini_set in the civi settings, no? [20:35:50] oh yeah we could do it there too I was just thinking of something invisible [20:36:07] but yeah that works also and makes it more obvious where it is [20:36:39] I just updated my execution time in the config and reloaded apache but I'm not getting offered to upgrade the extensions anymore [20:37:04] huh, i guess maybe the SQL updates all completed after PHP gave up? [20:37:41] yeah I guess the log tables updates are last? [20:37:55] sounds right [20:38:47] I'm getting some notices which are presumably down to my dev ini [20:38:49] Notice: Undefined index: email_greeting_display in include() (line 53 of /srv/civi-sites/wmff/drupal/sites/default/files/civicrm/templates_c/en_US/%%77/77A/77AF58B9%%CommunicationPreferences.tpl.php). [20:39:15] or could that be cache related [20:40:39] fr-tech until my latest civibuild patch gets merged in github, you may need to manually delete the drupal/sites/default/files/prometheus directory to be able to re-run setup.sh [20:40:43] sorry! [20:40:54] jgleeson: maybe cache related I guess [20:41:08] also maybe just a template referring to somethign the code forgot to set [20:42:51] ok well it's only a notice i guess [20:52:49] hmm I tried drush cc all and drush cvapi system.flush and I still see the notices about missing params in templates [20:52:59] other than that everything looks good ejegg [20:53:52] also ejegg I'm out of time today and I won't see you tomorrow or next week as I'm on vacation but if you get around to reviewing the config reader stuff while I'm away feel free to take the wheel and implement any changes you'd like to see or feedback from others [20:54:16] ok, thanks jgleeson [20:54:20] have a good vacation! [20:55:19] hmm I'll try. it's a week in a caravan with the kids. Small confined living spaces and loud energetic kids... [20:56:05] there's a fairground on site though so that'll be fun! thanks [21:00:16] ok, I'll try the upgrade on staging [21:16:39] [Error: Upgrade org.wikimedia.omnimail to revision 1005] [21:16:40] DB Error: already exists [21:17:30] hmm, case type names invalid [21:18:27] seems like a thing they just started caring about? [21:19:00] OK, I think we can safely do the upgrade though [21:19:42] dwisehaupt / Jeff_Green there's a civi security upgrade that I'd like to get out [21:19:55] ejegg: ok [21:20:25] it also includes a patch to remove some just-added columns to the event table (reverting buggy timezone handling) [21:20:35] so I guess we'll need to re-do triggers [21:21:26] I just tried it on staging and it seems fine [21:21:44] alright [21:21:59] Locally it's fine on new install + on upgrade too [21:22:25] just going to merge the patches in gerrit [21:22:58] dwisehaupt: will you be around to help with the trigger updates in a bit? I know it's almost end-of-day for Jeff_Green [21:23:40] ejegg: yeah. i'm around. [21:24:00] awesome, thx! [21:24:00] i can get the prep work ready for triggers. [21:24:31] super! [21:25:11] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Stock CiviCRM 5.48.0 [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778336 (owner: 10Ejegg) [21:25:25] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778337 (https://phabricator.wikimedia.org/T303883) (owner: 10Ejegg) [21:25:33] (03CR) 10Ejegg: [C: 03+2] Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778338 (https://phabricator.wikimedia.org/T303883) (owner: 10Ejegg) [21:25:36] (03CR) 10Ejegg: [C: 03+2] SearchKit ports of merged work [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778339 (https://phabricator.wikimedia.org/T304376) (owner: 10Ejegg) [21:25:41] (03CR) 10Ejegg: [C: 03+2] Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778340 (https://phabricator.wikimedia.org/T304376) (owner: 10Ejegg) [21:25:45] (03CR) 10Ejegg: [C: 03+2] Backport afform patches [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778341 (https://phabricator.wikimedia.org/T304376) (owner: 10Ejegg) [21:25:48] (03CR) 10Ejegg: [C: 03+2] Fix label [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778343 (https://phabricator.wikimedia.org/T304665) (owner: 10Ejegg) [21:25:51] (03CR) 10Ejegg: [C: 03+2] Add created & modified dates to relationhsip view [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778344 (https://phabricator.wikimedia.org/T294487) (owner: 10Ejegg) [21:26:52] (03PS1) 10Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/778355 [21:26:54] (03CR) 10Ejegg: [C: 03+2] Update CiviCRM submodule [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/778355 (owner: 10Ejegg) [21:31:29] have a good one fr-tech. bye for now [21:32:54] ejegg: do you think we need to stop the queues for this trigger update? [21:37:47] sure, let's do that [21:39:34] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/778358 [21:39:36] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/778358 (owner: 10Ejegg) [21:41:22] ok. i'll go ahead and do that now. [21:42:41] oops, i just did the disable patch [21:42:58] hmm, think i'll speed up those patch merges too [21:43:38] np [21:44:35] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778338 (https://phabricator.wikimedia.org/T303883) (owner: 10Ejegg) [21:44:42] (03CR) 10Ejegg: [V: 03+2 C: 03+2] SearchKit ports of merged work [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778339 (https://phabricator.wikimedia.org/T304376) (owner: 10Ejegg) [21:44:50] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Afform - Refactor toward multiple search displays on an afform [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778340 (https://phabricator.wikimedia.org/T304376) (owner: 10Ejegg) [21:44:57] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Backport afform patches [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778341 (https://phabricator.wikimedia.org/T304376) (owner: 10Ejegg) [21:45:03] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Fix label [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778343 (https://phabricator.wikimedia.org/T304665) (owner: 10Ejegg) [21:45:11] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Add created & modified dates to relationhsip view [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/778344 (https://phabricator.wikimedia.org/T294487) (owner: 10Ejegg) [21:46:10] !log disabled fundraising scheduled jobs for CiviCRM upgrade [21:46:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:49:25] ok dwisehaupt the jobs are stopped [21:49:36] and I'm ready to push out the code and run the db update [21:50:14] remind me - what's the rollback path in case something fails and we have a half-updated schema? [21:50:39] do we temporarily stop replication to some copy now? [21:51:17] yeah. i will stop replication now. [21:51:29] cool cool [21:51:30] thanks! [21:51:46] and the way we capture triggers now should allow us to back them up if need be. [21:52:10] great [21:52:15] s/back them up/roll them back/ [21:54:14] ok, code is rolled out. ready for me to do the db updates dwisehaupt ? [21:54:34] let me pull the triggers real quick [21:55:08] ok. go for it. [21:55:38] running... [21:56:12] unfortunately I forgot the -v -v so I have no idea which step it's on [21:56:50] ok, that completed successfully! [21:57:05] now an extension db update [21:57:33] all set [21:57:34] ok. did a diff on the scripts dir and there are no changes. so in theory we shouldn't need to do any trigger updates. [21:58:16] dwisehaupt: oh, let me see if the events triggers are still using the deleted columns [21:58:41] right, we basically don't use events [21:59:23] but in any case, I can't save. I think we do need to dump triggers [21:59:34] will do the enable/disable logging thing to regenerate them [21:59:37] and check in the new file [21:59:54] ok. let me know when you want me to run the script. [22:02:22] ok, it should be the CiviCRM.trigger624f5f31bb33915A97702126718965e4a41105a08d6202e60.sql file in the drupal/sites/default/files/civicrm/ConfigAndLo directory [22:02:35] I'll copy that locally and check it in over the scripts/triggers file [22:03:06] coolthanks. since we usually pull the scripts dir and run what is there. [22:04:50] hmm, diff is a bit noisy due to WS [22:05:02] right, diff -w is better [22:05:45] (03PS1) 10Ejegg: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/778359 [22:05:50] (03CR) 10Ejegg: [C: 03+2] Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/778359 (owner: 10Ejegg) [22:06:24] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/778360 [22:06:27] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/778360 (owner: 10Ejegg) [22:06:34] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/778359 (owner: 10Ejegg) [22:06:41] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/778360 (owner: 10Ejegg) [22:08:10] !log updated fundraising CiviCRM from 7b7b284d to a90a6709 [22:08:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:08:31] ok dwisehaupt the new triggers file is up on prod in drupal/sites/all/modules/wmf_civicrm/scripts/triggers.mysql [22:10:08] ok. pulling it now. [22:10:54] ok. running the triggers [22:11:47] thanks! [22:12:45] ok. i think it looks good. [22:14:06] yeah. matches what we have in the diff. [22:15:06] just let me know when you are happy and ready for me to reenable replication. [22:15:52] saving events works again [22:15:58] looks good to me! [22:16:37] ok cool. you care clear to restart the jobs. i'll restart replication. [22:18:53] !log restarted fundraising scheduled jobs [22:18:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:20:15] thanks! [22:21:01] I'mma be afk for a little bit but near the compy in case anything happens [22:22:06] coolio.