[00:11:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10DStrine) [00:11:41] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Adding a new field to the Endowment Benefactor Page listing - https://phabricator.wikimedia.org/T305486 (10DStrine) [00:11:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Added new fields to the Benefactor Page Listing section in Civi - https://phabricator.wikimedia.org/T305485 (10DStrine) [05:13:03] (03CR) 10AndyRussG: "Coool, thanks for this!!! Hmm just a few comment inline..." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/774591 (https://phabricator.wikimedia.org/T305006) (owner: 10Eileen) [05:29:57] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/778789 (owner: 10L10n-bot) [07:02:36] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/778789 (owner: 10L10n-bot) [12:37:01] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Fibonachos, 10Fundraising Sprint Xenomorph Petting Zoo, 10Fundraising Sprint e^🥧👀=yum, and 6 others: Enable South Africa through Dlocal - https://phabricator.wikimedia.org/T293508 (10Pcoombe) 05Open→03Resolved Thanks @Ejegg! Was alre... [17:34:20] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Natalie Ngu - https://phabricator.wikimedia.org/T305588 (10Dwisehaupt) Sent follow on docs for setting up ssh client config, connecting, and testing for ssh and mysql. [18:31:28] (03PS1) 10Ejegg: Rate-limit failmail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/779090 [18:31:56] (03CR) 10jerkins-bot: [V: 04-1] Rate-limit failmail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/779090 (owner: 10Ejegg) [18:37:03] (03PS2) 10Ejegg: Rate-limit failmail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/779090 [18:59:33] (03PS3) 10Ejegg: Rate-limit failmail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/779090 [19:00:35] fr-tech do you think ^^^ is enough for the paypal use case, or would it be worth a bit more complexity to track the count of skipped mails? [19:13:00] ejegg: question from when we were looking at logs, in the smashpig listener theres a lot of Starting processing for request, configuration view: 'globalcollect', action: 'listener' is that actually doing anything? [19:14:05] cstone: good question, I guess we are getting some kind of IPN from Ingenico [19:14:12] it happens a lot [19:14:18] and we just dont do anything [19:14:46] So let's see what actions we have in the 'GlobalCollect' payment processor [19:17:25] oh huh, not much [19:18:45] so yeah, that seems like something we could get rid of [19:18:58] just would make the listener logs a lot cleaner [19:19:17] I guess we would have to unsubscribe from IPNs somewhere [19:57:48] 10Fundraising Sprint Fibonachos, 10Fundraising-Backlog, 10Patch-For-Review: Increase failure tolerance for Paypal IPN API endpoint - https://phabricator.wikimedia.org/T305553 (10DStrine) [19:59:21] 10Fundraising-Backlog: Remove unneeded payments-listener-smashpig log content - https://phabricator.wikimedia.org/T305881 (10Cstone) [19:59:48] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10DStrine) [20:02:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-donorservices: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10DStrine) [20:21:09] 10Fundraising-Backlog: Don't send already refunded donations to the refund queue - https://phabricator.wikimedia.org/T305887 (10Cstone) [20:23:46] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fr-donorservices: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10Dwisehaupt) [20:24:36] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10Dwisehaupt) [20:27:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Added new fields to the Benefactor Page Listing section in Civi - https://phabricator.wikimedia.org/T305485 (10Dwisehaupt) [20:28:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Adding a new field to the Endowment Benefactor Page listing - https://phabricator.wikimedia.org/T305486 (10Dwisehaupt) [20:31:38] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10Dwisehaupt) [20:32:55] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Unit tests for Form Chooser - https://phabricator.wikimedia.org/T302891 (10Dwisehaupt) [20:36:18] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Simplify FormChooser::buildPaymentsFormURL - https://phabricator.wikimedia.org/T302944 (10Dwisehaupt) [20:40:42] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Clean up remaing ffname use - https://phabricator.wikimedia.org/T302939 (10Dwisehaupt) [20:41:40] (03PS4) 10Ejegg: Rate-limit failmail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/779090 (https://phabricator.wikimedia.org/T305553) [20:41:56] fr-tech that's the minimum rate limiter I was thinking of ^^^ [20:42:13] err, rather, minimum-featured maximum rate limiter [20:42:40] we could add more things like keeping a count of skipped mails [20:43:08] bah i forgot the reason I started log diving was looking into that adyen audit parser failmail, have you seen it do Predis\Connection\ConnectionException: Error while reading line from the server. [20:43:08] before ejegg [20:43:48] cstone: ah dang, that means it's holding on to a redis connection and not sending anything for a looooong time [20:44:08] so then something at the network or driver layer closes it and we don't have logic to re-open it [20:44:15] I think we have a ticket for that [20:44:26] yeah we do and I just commented on it [20:44:29] for other part [20:44:42] https://phabricator.wikimedia.org/T297856t this right? [20:45:12] https://phabricator.wikimedia.org/T266591 [20:45:40] ooh okay no [20:45:55] but adyen is breaking it this time [20:45:56] cstone ohh that 'fix recurring as much as possible' has Adyen in the title too [20:46:33] So we should probably implement that queue reconnection either way down in the php-queue library [20:46:42] or maybe in the SmashPig QueueWrapper [20:47:30] but that problem you found with the audit processor sending Ingenico refunds to the queue for donations that were already refunded in Civi sounds like it's worth a new ticket [20:47:39] I did make a new one for that [20:51:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Ingenico audit backfill fails sending messages to Redis - https://phabricator.wikimedia.org/T266591 (10Cstone) Adyen audit parser is now also erroring with this: /var/log/process-control/adyen_audit_parser/adyen_audit_parser-20220411-201701.log 2022-04-1... [20:51:27] oh nice [20:52:05] it looks like the adyen one has failed since apirl 7 [20:52:55] oh hey, we tried to solve it this way in the old globalcollect audit logic: https://phabricator.wikimedia.org/rWFCG349b521163a80e0371dbc73db917681e2403793f [21:45:58] ahh, that patch in review for the failmail limiter assumes there's a cache object that stores things across requests for SmashPig [21:46:22] and I just realized we only have that for when we're using SmashPig under MediaWiki :( [21:46:38] We could just pull in this library and get one that uses redis directly: https://github.com/php-cache/predis-adapter [22:01:29] or we could do a simple version of our own [22:06:46] ok, so let's see, best way to pull in a library just for the IPN deployment? [22:07:42] composer.local.json seems to be used for mediawiki, but I guess that's merged using the composer-merge-plugin [22:08:10] basically trying not to add requirements to the base composer.json for SmashPig [22:09:17] We could add requirements to composer.json just in deployment branch, but that could get ugly [22:10:43] hmm, what about the 'recommends' section? [22:12:02] err, that's 'suggest' [22:22:02] huh, I guess the 'right' way to do this would be to have a different repo for the deployed SmashPig IPN listener [22:22:45] that pulls in SmashPig as a dependency and also any cache adapters we want to use [22:24:25] fr-tech any opinions on that? [22:25:11] So the options are: 1) add a requirement to composer.json that's not really required for using it as a library [22:26:23] or 2) create a separate project & repo for the deployed IPN listener (e.g. fundraising-code-update smashpig-ipn-listener) that has its own composer.json pulling in smash-pig-the-library plus the cache adapter we want to use in the IPN listener [22:37:31] bah, even pulling in that one there's no simple way to instantiate it in our config [22:37:59] needs a predis client constructed, then fed to its own constructor [22:38:13] OK, lemme make a quick-n-dirty version [22:48:32] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Natalie Ngu - https://phabricator.wikimedia.org/T305588 (10Dwisehaupt) [22:50:02] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Natalie Ngu - https://phabricator.wikimedia.org/T305588 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Verified in logs that nngu successfully logged in. [23:04:16] ejegg: from your commend the first option is not ideal, so we should probably go with the second option and sorry I am not very familiar with this IPN listener :) willing to test your pr