[00:58:34] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10Eileenmcnaughton) [01:26:10] (03PS1) 10Cstone: WIP: Skip looking in the logs for missing recurring donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784797 [01:38:53] (03CR) 10jerkins-bot: [V: 04-1] WIP: Skip looking in the logs for missing recurring donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784797 (owner: 10Cstone) [05:20:41] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/784911 (owner: 10L10n-bot) [06:13:50] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785077 (owner: 10L10n-bot) [06:24:24] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785077 (owner: 10L10n-bot) [07:31:37] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/784911 (owner: 10L10n-bot) [13:22:21] 10Fundraising-Backlog, 10fundraising-tech-ops: SSL cert - can't get into Civi - https://phabricator.wikimedia.org/T306483 (10Jgreen) 05Openβ†’03Resolved [14:24:47] howdy fr-tech! [14:42:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10fr-donorservices: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10SHust) Adding the rest of the DR agents CIDs that can’t access the "acoustic data"... [15:02:27] Jeff_Green: did we have any comms blips around 9PM UTC yesterday? Looks like civi1001 ran into an error when trying to read from frqueue1003. [15:05:47] hmm. there were no alerts, looking at graphs... [15:06:11] is there a more exact time to work with? [15:07:13] 2022-04-20 20:55:31,956 ERROR Predis\Connection\ConnectionException: Error while reading line from [error] [15:07:15] 2022-04-20 20:55:31,956 ERROR the server. [tcp://frqueue1003.frack.eqiad.wmnet:6379] in [15:07:17] Jeff_Green: ^ [15:07:25] thx [15:07:41] jgleeson: is that the adyen adult [15:07:50] yep yep cstone [15:08:00] It's been failing for like two weeks there's a ticket [15:08:24] Its timing out cause there's so many recurrings it can't find in the logs [15:09:09] I looked over some of the previous ones and saw there was a few different reasons that job fails but the log for this one has a redis error. did the ones you looked at also have the same thing cstone ? [15:09:31] Yeah they all have the timeout error [15:09:40] Er oh I see hmm [15:09:50] Is it the same error as on the phab? [15:10:03] lemme find the ticket [15:11:08] Elliott had looked and old old audit code had restarted the connection but I was looking at it from the infinite log hunting angle [15:12:36] I don't see anything obvious in the metrics, redis shows fairly consistent activity through that window and I don't see any big jump or dip. [15:17:06] sorry lag of getting to computer but this is the ticket https://phabricator.wikimedia.org/T306194 [15:19:24] hey all. I'm popping into the standup but it was also in conflict with the salon so I moved it later [15:19:30] 10Fundraising-Backlog: Adyen audit parser finding lots of missed transactions - https://phabricator.wikimedia.org/T306631 (10jgleeson) [15:19:38] jgleeson: is that a process_control log? I don't see that message anywhere in syslog [15:19:51] yeah Jeff_Green [15:20:08] thanks cstone sorry I was trying to wrap up something else but will check out the ticket now [15:20:17] jgleeson: kthx [15:20:38] yep that is the same error cstone [15:20:58] is the thinking that something is timing out on the redis connection side of things? [15:21:22] do you see the related ticket its looking forever through the logs for recurrings that arent there [15:22:25] let me see if i can find the old code elliott linked [15:23:09] hmm [15:23:15] ok I can see that now [15:23:26] I'm curious about the stack trace in your ticket [15:23:41] 2022-04-15 20:55:27,409 ERROR SmashPig\Core\DataStores\QueueWrapper::push('donations', Array) [15:23:56] which is after 2022-04-15 20:55:27,409 ERROR BaseAuditProcessor->log_hunt_and_send(Array) [15:29:47] jgleeson: I pasted what we had talked about this before here https://etherpad.wikimedia.org/p/oldchatsadyenaudit [15:30:50] so I think it opens the connection, takes forever log hunting, then when it goes to send it to the queue its been closed and error [15:31:35] also fr-tech there is advancement salon at same time as standup do we want to move standup after? [15:31:43] dstrine: already did it [15:31:45] oh haha [15:31:47] im behind! [15:32:28] ah ok that explanation makes sense cstone, thanks for the info [15:33:56] ill update the ticket but i guess two issues, the fact that the timeout can happen in general and that its looking in logs for recurrings that don't exist [15:34:32] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10Cstone) Some chatting on this here: https://etherpad.wikimedia.org/p/oldchatsadyenaudit [15:41:28] cstone / jgleeson this seems like a very long shot, but systemd-timedated ran right around that time, it completed at 2022-04-20T20:55:39.183596 [15:43:11] the clocks should not be drifting far b/c it runs every 5 min [15:43:49] Jeff_Green: it looks like ejegg and cstone figured out how the connection failure happened on a previous instance of the same problem. looks like it timed out due to the processor audit parser job opening a queue connection, then looking for non-existent log lines that ran on for a long time, and then finally trying to use the connection from step 1 which had timed out by then [15:44:10] not a comms issue [15:44:14] thanks for digging though [15:44:24] ah that makes sense, cool [15:44:53] dstrine: [15:45:05] aren't you OOO [15:45:48] * jgleeson realises 'yes' could mean multiple things [15:47:45] thanks for looking into it jgleeson Jeff_Green [15:48:46] jgleeson: I'm making a short visit [15:49:35] this is what I was trying to link yesterday jgleeson warning picture of a snake if people don't want to see that https://www.inaturalist.org/observations/81612410 [15:59:27] wow you're really close there cstone [15:59:31] nice work! [15:59:35] and what a great snake [16:00:00] haha it was very chill for a snake I actually picked it up and moved it away from people then put it there [16:00:28] and it was a wild snake? [16:00:41] yeah [16:00:48] wow, that's pretty brave ha [16:34:28] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10Ejegg) [16:40:59] ejegg: have folks been doing that? [16:51:12] jgleeson: a few [16:51:29] I think it'll get more frequent if we start using Adyen in the US though [16:51:43] since we've mostly only used the employer field with Ingenico [16:54:32] and that form disables the contact info before it shows the card field [16:55:41] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10Ejegg) Context: it's only happened a few times. but I think it'll get more frequent if we start using Adyen in the US. We've mostly only used the em... [16:58:32] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10RKumar_WMF) Credit Card: https://payments.wikimedia.org/index.php?title=Special:AstropayGateway&appeal=JimmyQuote&payment_method=cc&recurring=&uselang=es&language=es¤cy=PEN&amou... [17:08:29] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10Ejegg) Weren't banners going to send the language code as es-419? That should get the right TY email. We don't currently have any logic to map a list of countries to es-419 in payment... [17:10:44] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10DStrine) p:05Mediumβ†’03High [17:10:54] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^πŸ₯§πŸ‘€=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Refactor ConfigurationReader - https://phabricator.wikimedia.org/T305152 (10DStrine) p:05Mediumβ†’03High [17:21:21] 10Fundraising-Backlog, 10fundraising-tech-ops: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [19:47:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10KHaggard) Hi @Eileenmcnaughton, that makes senes to me, though I'm unaware if there are any important reasons to not change the disallow list. @... [19:51:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10bsisolak) No real person should have that as their email address, I would leave it and opt the user out. [20:26:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10Eileenmcnaughton) Hmm - we did get a significant donation from that not-real-person.... [20:26:34] say the name and she appears... [20:26:40] just not on IRC [20:28:06] * jgleeson sends telepathic message to Eileen to log on to IRC /o\ [20:32:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10Eileenmcnaughton) I just checked - here are a couple more donors with that start https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid... [20:47:15] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10Fr-drupal-upgrade-2021, 10Patch-For-Review: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10JSimmons) @Eileenmcnaughton @RLewis Trilogy is used for donations m... [20:59:35] (03PS1) 10Cstone: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) [20:59:54] bah spaces [21:00:34] (03PS2) 10Cstone: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) [21:09:01] (03CR) 10Jgleeson: "Looks good to me! Wanna push up the private-config update and we can test it out?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) (owner: 10Cstone) [21:12:36] thanks jgleeson [21:13:29] i had one day of quiet here and today the curb sawing started haha [21:13:37] oh no! [21:14:26] have you ever tried out ANC headphones cstone ? [21:14:35] they work pretty well on planes [21:14:43] i have not [21:15:07] https://en.wikipedia.org/wiki/Active_noise_control [21:15:42] actually I think i did try them when the AC at old place was bothering me and i could still hear it :P but that was just one case [21:17:03] yeah they are not a 100% solution [21:17:10] I got a cheap pair similar to these [21:17:12] https://www.amazon.com/Infurture-Cancelling-Headphones-Bluetooth-Memory-Protein/dp/B08HDBZNZ9/ref=sr_1_12_sspa?crid=1JDSKPL2SB8JZ&keywords=anc%2Bheadphones&qid=1650575751&sprefix=anc%2Bheadphone%2Caps%2C253&sr=8-12-spons&spLa=ZW5jcnlwdGVkUXVhbGlmaWVyPUEyVkM0UjhBWkNVRlMwJmVuY3J5cHRlZElkPUEwNTQ2MzcyMk9IRUtZVFBYQk1IVyZlbmNyeXB0ZWRBZElkPUEwNTM5Nzc1T09LN1FLTkVYSVZZJndpZGdldE5hbWU9c3BfbXRmJmFjdGlvbj1 [21:17:14] jbGlja1JlZGlyZWN0JmRvTm90TG9nQ2xpY2s9dHJ1ZQ&th=1 [21:17:19] argh. tracking url spam [21:17:54] https://www.amazon.com/Infurture-Cancelling-Headphones-Bluetooth-Memory-Protein/dp/B08HDBZNZ9 [21:18:23] the brand I bought is no longer available as they were kicked off of Amazon for buying positive reviews [21:18:40] ironically the headphones are great so not sure why they needed that [21:19:15] jgleeson: I pushed up the localsettings [21:19:18] and thanks for all the links! [21:19:51] what is the brand you have? [21:20:36] TaoTronics, [21:20:38] https://www.androidpolice.com/2021/06/17/amazon-delists-ravpower-as-latest-target-in-its-crackdown-on-fake-reviews/ [21:21:41] maybe all their cheap headphone competitors were doign it even if they worked well [21:22:28] yeah probably [21:22:58] cstone: did you push it to config-private repo? [21:23:08] oh i pushed it to our localsettings haha [21:23:16] let me add it to config private [21:23:27] ah cool [21:23:27] wrong config [21:24:00] I see the last commit on config-private was wfan pushing up the failmail log stream stuff we were trying to get working the other week [21:24:20] that's half way to getting failmail working locally [21:25:19] I think the last bit might be configuring mailserver settings on the docker images [21:25:22] ok jgleeson now its actually there [21:25:28] cool. checking [21:32:39] 2022-04-21T21:30:32+00:00 39b7f915e832 SmashPig-Adyen: adyen::123:123.1 | (RawData) Launching REST capture request for J25FPRC9WTTFWR82 | {"amount":{"currency":"USD","value":1000},"merchantAccount":"WikimediaDonations"} | [21:32:41] 2022-04-21T21:30:32+00:00 39b7f915e832 SmashPig-Adyen: ad [21:32:54] looks good to me [21:33:44] the J25*** is the PSP reference [21:34:05] but the donation worked as expected for me with your patch and new config cstone [21:34:21] is 12345 the real id? or does that not matter [21:34:28] thats not the real id [21:34:35] i figured it iddnt matter cause testing worked without it at all haha [21:34:41] yeah I guess [21:35:49] i can put the real one there if you want I don't think its that secret [21:37:41] I guess that's fine for now [21:37:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10KHaggard) For cid=43560023, their email address prefix has a "5" next to "marketing" so it's not triggering the block. I'm pretty sure all "mark... [21:41:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10Eileenmcnaughton) @KHaggard - there are 218 contacts in this category - they all have donations - which I think reflects the way contacts enter... [21:42:24] (03CR) 10Jgleeson: [C: 03+1] "This works as expected for me, nice work! I see the values being pulled in and passed to the AdyenCheckout component create() call." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) (owner: 10Cstone) [21:46:06] hmm I just realised we do have the merchantAccount in the smashpig adyen config [21:46:19] not sure if that changes things [21:46:35] we could technically read that field from there? [21:49:18] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10Cstone) a:03Cstone [21:50:37] hmmm I guess it's a toss up between storing it in two places vs relying more on smashpig config for integration data [21:50:54] the latter probably [21:51:09] would we want to put the google id in there? [21:51:28] guess there is some apple stuff [21:52:23] yeah it might make more sense to store it over there [21:53:06] I'm dropping off now but I'd be interesting to hear ejegg's thoughts [21:53:18] interested even [21:53:33] catch you all tomorrow o/ [21:54:46] jgleeson|away: tomorrow is a holiday! [21:55:40] cstone yeah let's put it all in the SmashPig config [21:57:47] are we already pulling that in the JS somewhere [21:59:12] cstone its [21:59:16] 's selective [21:59:34] - only what we explicitly provide in that AdyenConfiguration var [22:00:24] yeah in getCheckoutConfiguration but I guess im missing the step of how that sees the yaml [22:00:31] from the provider? [22:00:34] ahh, let's see [22:01:12] so we have account_config - shoot, are we still setting that twice? [22:02:27] Oh yeah, we do set that in AdyenCheckoutGatewayAccountInfo [22:02:47] hmm, so I guess most of that makes sense to have in LocalSettings, since it's front-end-only [22:03:30] i.e. it might not make sense to have the CSS and JS paths in the SmashPig config [22:04:50] ok, I changed my mind, the Google Pay merchant ID is also only used in the front-end [22:06:10] hmm, but... for apple pay we left those things on the smashpig side [22:06:25] haha yeah the conundrum [22:06:32] right, because we were using them on the server side in calls that we send via SmashPig [22:08:16] cstone OK, so we still can't do it just the same way as we do with apple, because with apple we're providing the params as constructor args to the PaymentProvider class [22:08:38] and we don't want to add some wart to the GooglePayPaymentProvider just to provide the gpay params [22:09:18] so if we DID put them in the SmashPig config they would go under some completely different top-level key [22:11:01] OK, I'm leaning back towards keeping the GPay things that we only use on the client side to the LocalSettings AccountInfo array [22:11:48] cstone so the account name (the top-level key) can be accessed as $this->account_name [22:12:12] yeah i missed seeing that as it was the key [22:12:31] so that one can come from the yaml and the google merchant id we can add to localsettings? [22:12:32] that gets set in the parent adapter class's findAccount function [22:13:30] cstone the production config has $wgAdyenCheckoutGatewayAccountInfo = [ 'WikimediaDonations' => [ ...... ] ] [22:13:46] and that 'WikimediaDonations' gets stored in $this->account_name [22:13:52] oooh i see [22:13:53] ok [22:13:58] so I guess that one key is already stored in two places [22:14:24] ok well that second account name we def dont need [22:15:22] thats confusing too on our config its just named example and I would not have guessed wikimediadonations would have been there [22:15:42] ill change that to accountName [22:15:59] cool cool [22:16:07] or even merchantAccountName [22:16:25] yes even better haha [22:16:26] if you want to make super clear which level account it is [22:17:00] i am already confused with gatewayMerchantId and MerchantId :P [22:17:09] argh [22:17:33] right, they should name one of them googleMerchantId [22:17:33] coming from adyen not us [22:19:15] (03PS3) 10Cstone: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) [22:21:11] ok updated the config private too [22:21:16] thanks! [22:22:45] i updated localsettings too so the actual merchant ID is there [22:22:51] rockin! [22:24:08] (03CR) 10Ejegg: "Thanks! Just a couple places more we could add that GoogleMerchantID for completeness/documentation" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) (owner: 10Cstone) [22:25:05] ooh and that readme has another example lets change that [22:25:14] :) definitely [22:27:27] (03PS4) 10Cstone: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) [22:28:01] whopos failed at my own naming convention [22:28:30] (03PS5) 10Cstone: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) [22:29:07] now i want everything to match [22:30:06] :) do it [22:30:46] (03PS6) 10Cstone: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) [22:31:35] looking good! lemme just smoke test locally [23:27:34] (03CR) 10Ejegg: [C: 03+2] "Looks good. Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) (owner: 10Cstone) [23:29:03] thanks ejegg ! I'll deploy that on Monday [23:30:12] (03Merged) 10jenkins-bot: Add credentials for Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785196 (https://phabricator.wikimedia.org/T304991) (owner: 10Cstone) [23:33:24] sounds good cstone [23:33:42] I'mma just send up a quick patch to avoid the mw.config value being mutated [23:49:22] (03PS1) 10Ejegg: Adyen Checkout: copy config by value not by reference [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785239 [23:49:24] (03PS1) 10Ejegg: Adyen Checkout: reword comments, move config key [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785240 [23:49:30] gotta head out on another errand, sorry