[02:42:34] (03PS1) 10Wfan: conf [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785396 [02:42:36] (03PS1) 10Wfan: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 [02:43:06] (03CR) 10jerkins-bot: [V: 04-1] conf [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785396 (owner: 10Wfan) [02:43:14] (03CR) 10jerkins-bot: [V: 04-1] replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [02:44:45] (03PS2) 10Wfan: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 [02:51:27] (03CR) 10Wfan: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [05:43:06] (03PS3) 10Wfan: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 [05:44:12] (03Abandoned) 10Wfan: conf [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785396 (owner: 10Wfan) [15:57:44] (03PS1) 10Ejegg: Fix typo in next to last commit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785877 [16:10:18] 10Fundraising-Backlog, 10FR-Gpay-Integration, 10MediaWiki-extensions-DonationInterface: Handle donor-cancelled GPay login/card selection - https://phabricator.wikimedia.org/T306814 (10Ejegg) [16:10:54] (03CR) 10Ejegg: [C: 03+2] Fix typo in next to last commit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785877 (owner: 10Ejegg) [16:13:47] (03Merged) 10jenkins-bot: Fix typo in next to last commit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785877 (owner: 10Ejegg) [16:14:03] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) @Pcoombe Do you happen to have an older test banner for LATAM that this can be tested with? The local testers are having trouble getting the full experience here and payments... [16:34:05] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10Pcoombe) Yes, the banners will automatically change the uselang passed to paymentswiki from es to es-419 for the following countries: AR, CL, CO, MX, PE, UY, US. Also from pt to pt-br... [16:39:03] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) Thanks @Pcoombe !!! @RKumar_WMF can the local tester try again? [17:06:43] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/785892 [17:08:32] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Unit tests for Form Chooser - https://phabricator.wikimedia.org/T302891 (10AnnWF) a:03AnnWF [17:09:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Automatic de-duper shouldn't pick up contact till a minute or two after they're created - https://phabricator.wikimedia.org/T306822 (10Ejegg) [17:14:57] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/785892 (owner: 10Cstone) [17:26:22] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/785892 (owner: 10Cstone) [17:47:35] (03PS8) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [17:50:39] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [18:14:43] (03PS1) 10Cstone: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/785911 [18:30:06] (03CR) 10Cstone: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/785911 (owner: 10Cstone) [18:31:44] ejegg: my memory of our talk earlier in the month isn't great but I know ConfigReader factories came up. Was that to cover having GatewayConfigReaders (that know the gateway) vs general ConfigReaders for the form chooser stuff? I'm just adding that bit now and wanted to make sure [18:33:07] jgleeson: sorry, that was just to have a class outside of the gateway base class that would do the registration of all the directories [18:33:54] config readers would always be for a specific gateway identifier, we just want to be able to read the config without instantiating the gateway class [18:34:09] I'll add a ConfigReaderFactory and we can tweak it in review [18:34:23] I'm not quite sure what the other scenario looks like at this point [18:35:11] heck, we can probably just do it with a static method on the ConfigReader [18:35:30] like ::instance( $gatewayIdentifier ) [18:35:47] or ::instanceFor( $gatewayIdentifier ) [18:36:29] errr, i guess that's instanceFor( $gatewayIdentifier, $variant ) [18:37:41] instance makes me think of singleton [18:37:50] heck, we could even do that in a later patch - feel free to add the code to gateway base and we'll move it later [18:38:11] I'll add a ::create to it [18:38:16] and we can rejig if needed [18:38:38] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/785911 (owner: 10Cstone) [18:39:04] cccccchrbkbkefeikkugnjlenerrfdjchcthvtnirntf [18:39:07] whoops [18:39:14] whoops [18:39:15] haha [18:39:55] its not even the usb c type [18:40:11] it's either a cat walking across the keyboard or a yubikey slip [18:40:38] or rabbit [18:40:55] haha yes [18:40:56] theres two guinea pigs here too that could be to blame [18:41:07] just visiting? [18:41:18] they are fosters [18:47:51] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10DStrine) Just to cross link all tasks, this is the corresponding payments task https://app.asana.com/0/1200599190639529/1199928025421117/f From what... [18:47:56] !log payments-wiki revision changed from a3c69385 to 786dc94f [18:47:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:02:57] Thanks ejegg: to share the google console with me:) [19:03:56] this is the actual one this time (hopefully) [19:04:11] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10EMartin) yes, we have tested some time ago and feel comfortable for the external test. Please make it default for the test. [19:04:26] I see the merchant id start from BCR [19:04:36] Not the 808? [19:04:37] yeah and now a different ID [19:04:38] haha [19:04:45] haha soga [19:06:49] And why merchant ID changed? Will it change in the future or this BCR will be the final one used in private config [19:09:28] i think this is the right one and the other one is just some other ID [19:11:13] Ha I see the email that the new one is created by Elliott. We will then need to update the new merchant ID to private config, right? [19:16:22] yeah wfan I just updated that [19:16:53] yeah I see it :) [19:34:38] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10DStrine) We can't make it default for the test. @HNordeenWMF, @TSkaff and banner team can hard code it into banners for the 1 hour test. Once that is d... [19:37:51] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10EMartin) Great, we'll leave this with the Banner team to indicate making it the default post test. Is that who owns that part of the process? @TSkaff... [19:50:05] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10DStrine) p:05High→03Unbreak! [19:50:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Return of duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T306822 (10Ejegg) [19:50:16] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Refactor ConfigurationReader - https://phabricator.wikimedia.org/T305152 (10DStrine) p:05High→03Unbreak! [20:07:01] (03PS9) 10Jgleeson: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [20:09:02] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [20:19:35] fr-tech I just got back and joined the call from before [20:22:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: DAF change: soft credit to donors and link to DAF company - https://phabricator.wikimedia.org/T306226 (10DStrine) [20:24:57] ejegg: XenoRyet greg-g do yall wanna sit in on this one before I start? [20:25:07] I could record it also [20:25:25] Not unless you need my help for something [20:25:56] cool cool [20:26:11] I'm around though, so do ping if there is something I can do. [20:58:10] dstrine: XenoRyet chatted through the min donations stuff on the call (which is recorded against today's backlog refinement meeting) and ejegg has some ideas on how to simplify due to urgency which he's gonna try to push up a POC for if he has time and some notes. Hopefully be reviewable/testable tomorrow [20:58:30] 10-4, thanks for the update. [20:58:36] dstrine: ^ [21:17:49] 10fundraising-tech-ops, 10DC-Ops, 10ops-eqiad: Q3:(Need By: TBD) rack/setup/install frlog1002 - https://phabricator.wikimedia.org/T306839 (10RobH) [21:23:07] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10RobH) [21:23:26] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10RobH) [21:33:13] ok [21:34:17] 10fundraising-tech-ops: reimage fundraising monitoring (frmon) role servers to Bullseye - https://phabricator.wikimedia.org/T305968 (10Dwisehaupt) [21:42:12] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:(Need By: TBD) rack/setup/install frlog1002 - https://phabricator.wikimedia.org/T306839 (10RobH) [21:42:16] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:(Need By: TBD) rack/setup/install frlog1002 - https://phabricator.wikimedia.org/T306839 (10RobH) [21:49:23] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/785924 [21:49:49] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/785924 (owner: 10Eileen) [21:50:57] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10HNordeenWMF) I'm running into the problem that when I hardcode a Latin America banner for Astropay, it doesn't go to dLocal for Peru. https://es.wikipe... [21:50:58] wfan: you said something about the extension upgrade? I see your patch from last week isn't deployed so I just did a merge-to-deployment https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/785924 [21:52:22] !log civicrm revision 7de7ddd4 -> a841cf55 [21:52:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:54:22] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10DStrine) @Ejegg as well if that helps [22:09:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity: Added new fields to the Benefactor Page Listing section in Civi - https://phabricator.wikimedia.org/T305485 (10Eileenmcnaughton) @AnnWF - I just deployed this patch [22:10:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity: Adding a new field to the Endowment Benefactor Page listing - https://phabricator.wikimedia.org/T305486 (10Eileenmcnaughton) @AnnWF - I just deployed this patch & ran the upgrade - field seems to... [22:11:12] Thanks elieen: ~ [22:11:21] eileen: thanks! [22:33:56] (03PS1) 10Ejegg: Fix PE form settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785946 (https://phabricator.wikimedia.org/T303207) [22:36:33] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), 10Patch-For-Review: Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10Ejegg) Hi @HNordeenWMF, I just found the problem - the PE form definition was drafted a while ago when we were still using the ol... [22:53:51] (03CR) 10Eileen: "A couple of thoughts on the main query" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [22:57:11] 10fundraising-tech-ops: reimage fundraising monitoring (frmon) role servers to Bullseye - https://phabricator.wikimedia.org/T305968 (10Dwisehaupt) [23:18:59] (03PS1) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [23:20:34] (03PS1) 10Eileen: drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) [23:20:36] (03PS1) 10Eileen: Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) [23:20:38] (03PS1) 10Eileen: Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) [23:29:22] (03PS10) 10Ejegg: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [23:29:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10Fr-drupal-upgrade-2021, 10Patch-For-Review: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10Eileenmcnaughton) I've put up patches to remove - Paypal EFT - Coi... [23:30:17] huh, still getting a lot of phpunit errors locally - are other folks able to run the DonationInterface tests locally under docker? [23:31:06] (03CR) 10jerkins-bot: [V: 04-1] Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [23:31:34] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [23:33:35] (03CR) 10jerkins-bot: [V: 04-1] drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [23:35:24] (03CR) 10jerkins-bot: [V: 04-1] Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [23:35:26] (03CR) 10jerkins-bot: [V: 04-1] Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [23:37:41] ejegg: run the `./payments-phpunit.sh` rignt? Trying it now [23:37:59] wfan yep, even with --group=DonationInterface [23:38:10] to limit it to just the tests for our extension [23:38:15] rather than ALL the tests [23:39:02] Ok will try this one at other laptop 😂 [23:41:16] 'There were 8 errors: [23:41:16] 1) AmazonApiTest::testDoPaymentSuccess....' [23:41:26] this one without groupfilter [23:41:33] oh ok [23:41:37] not as many as I got [23:41:42] I wonder what my difference is [23:42:10] Oh I should restart the composer to get the most recent payments code [23:46:00] no, that's OK wfan [23:46:20] I was just wondering if everyone else was getting a 100% test pass rate in docker [23:46:54] STILL 8 [23:47:15] ok, good to know [23:47:22] (03PS11) 10Ejegg: WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [23:49:17] (03CR) 10jerkins-bot: [V: 04-1] WIP: Manage donation amounts by country. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [23:53:52] (03PS12) 10Ejegg: Manage donation amounts by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson)