[00:21:10] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, and 2 others: Syn group to Acoustic should remove any existing queues before creating a new one - https://phabricator.wikimedia.org/T306855 (10Eileenmcnaughton) [00:26:46] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, and 2 others: Civi Searchkit should allow user to export list to acoustic - https://phabricator.wikimedia.org/T301514 (10Eileenmcnaughton) @RLewis I have exp... [00:41:10] (03CR) 10Wfan: replace c0m to com and remove trailing number from email domain (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [01:25:31] (03PS1) 10Ejegg: Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) [01:28:53] (03CR) 10jerkins-bot: [V: 04-1] Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [01:31:10] (03PS1) 10Ejegg: Move Adyen Checkout to parent folder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785964 (https://phabricator.wikimedia.org/T302892) [01:37:08] (03PS2) 10Ejegg: Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) [01:52:26] (03PS1) 10Ejegg: Remove PayPal classic adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [01:53:35] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal classic adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [01:54:01] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Paypal, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Remove PayPal classic integration from DonationInterface - https://phabricator.wikimedia.org/T300068 (10Ejegg) [01:55:27] (03PS2) 10Ejegg: Remove PayPal classic adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [01:57:23] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal classic adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [02:05:08] (03PS3) 10Ejegg: Remove PayPal classic adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [02:07:04] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal classic adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [03:03:10] (03PS2) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [03:03:12] (03PS2) 10Eileen: drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) [03:03:14] (03PS1) 10Eileen: Cleanup in stripe teardown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785967 [03:04:46] (03PS2) 10Eileen: Cleanup in stripe teardown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785967 [03:09:17] (03PS3) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [03:09:19] (03PS3) 10Eileen: drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) [03:09:21] (03PS2) 10Eileen: Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) [03:09:23] (03PS2) 10Eileen: Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) [03:22:02] (03CR) 10jerkins-bot: [V: 04-1] Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [03:22:10] (03CR) 10jerkins-bot: [V: 04-1] Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [03:22:55] (03CR) 10jerkins-bot: [V: 04-1] drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [03:23:07] (03CR) 10jerkins-bot: [V: 04-1] Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [03:23:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Decide how to deal with acoustic-blocked prefixes - https://phabricator.wikimedia.org/T306582 (10Eileenmcnaughton) I finished uploading @rlewis's group of 1500 contacts and 4 were rejected by Acoustic because the local parts of their emails... [03:25:50] (03PS3) 10Eileen: Cleanup in stripe teardown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785967 [03:27:33] (03PS4) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [03:27:35] (03PS4) 10Eileen: drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) [03:39:25] (03CR) 10jerkins-bot: [V: 04-1] drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [03:39:28] (03CR) 10jerkins-bot: [V: 04-1] Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [04:10:30] (03CR) 10Eileen: replace c0m to com and remove trailing number from email domain (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [05:01:46] (03PS1) 10Eileen: Test cleanup - do hard delete, not delete to trash [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785976 [05:01:48] (03PS1) 10Eileen: Cleanup Testy McTester [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785977 [05:22:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [05:27:12] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [06:56:41] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/786198 (owner: 10L10n-bot) [07:05:13] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/786198 (owner: 10L10n-bot) [07:25:30] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Add CentralNotice keyboard shortcuts - https://phabricator.wikimedia.org/T132731 (10Aklapper) [07:27:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [07:32:12] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [07:40:58] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Patch-Needs-Improvement, 10Technical-Debt: Use CSS instead of obsolete HTML attributes on CentralNotice tables - https://phabricator.wikimedia.org/T108259 (10Aklapper) [15:45:51] (03PS13) 10Jgleeson: Manage donation amounts by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) [15:46:09] rebasing to reduce diff noise [16:07:47] (03CR) 10Jgleeson: [C: 03+1] "Thanks for the updates! Also, thanks for adding in the test changes. This is working for me in line with the requirements." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [16:17:10] (03PS4) 10Wfan: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 [16:29:21] (03PS5) 10Wfan: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 [16:44:21] (03PS2) 10Ejegg: Move Adyen Checkout to parent folder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785964 (https://phabricator.wikimedia.org/T302892) [16:44:24] (03PS4) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [16:46:35] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [17:13:10] 10fundraising-tech-ops: reimage fundraising monitoring (frmon) role servers to Bullseye - https://phabricator.wikimedia.org/T305968 (10Dwisehaupt) [17:33:25] 10fundraising-tech-ops: reimage fundraising monitoring (frmon) role servers to Bullseye - https://phabricator.wikimedia.org/T305968 (10Dwisehaupt) frmon2001 has been reimaged. Resetting the check boxes for frmon1001's rebuild. Things to note: * letsencrypt sync fails until it had a /etc/letsencrypt/live dir in... [17:33:34] (03CR) 10Jgleeson: [C: 03+2] Move Adyen Checkout to parent folder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785964 (https://phabricator.wikimedia.org/T302892) (owner: 10Ejegg) [17:34:09] (03PS3) 10Jgleeson: Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [17:45:42] jgleeson so I'd be happy to +2 that change now if you're ok with it [17:45:57] we can change the JS config var name in a follow-on patch [17:51:40] +2 your updates ejegg? or do you mean a related change [17:51:47] (03CR) 10Ejegg: [C: 03+1] "Looks good to me! This +1 is a +2 for the parts I didn't write..." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [17:52:45] I'm just wrapping up review on the follow-on patch 'Allow specifying min/max amount in any currency' [17:53:04] jgleeson so do you think that parent PS needs changes, or should we make the changes in following patches? [17:53:40] (03PS5) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [17:55:10] did you see the INR max one ejegg [17:55:22] i responded inline [17:55:26] ah lemme check [17:55:36] maybe we just take out the IN specific bit altogether for the defaults? [17:55:56] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [17:56:26] oh I see that's actually a USD amount [17:56:35] argh that confused me [17:57:01] ok fine I see now. that's clearer in the follow-on [17:58:06] sure ejegg let's do those smaller bits in follow on patches. [17:58:21] great! [17:58:44] (03CR) 10Ejegg: [C: 03+2] Manage donation amounts by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [17:58:52] I +2ed the Adyen one as it was an easy one but the paypal one has a bit more to it so I moved straight on to the currency one [17:59:02] one one one one [17:59:09] yeah, the paypal one is still failing tests unfortunately [18:02:26] should we rebase the currency one over master then one the others merge [18:02:38] that way we can get them out [18:02:47] I'm cllose to +2 on the currency one [18:03:06] s/then/when/ [18:03:27] sure thing [18:08:11] ejegg: I'm torn on this currency one [18:09:26] I'm trying to think of a way to remove the dependency on that static rates file [18:09:52] I think the frontend still relies on that [18:12:08] and the backend [18:12:30] (03Abandoned) 10Cstone: WIP: Skip looking in the logs for missing recurring donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784797 (owner: 10Cstone) [18:13:11] jgleeson: how can we remove that without specifying min/max in every single supported currency? [18:13:38] (03Merged) 10jenkins-bot: Manage donation amounts by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/773840 (https://phabricator.wikimedia.org/T261436) (owner: 10Jgleeson) [18:13:40] (03Merged) 10jenkins-bot: Move Adyen Checkout to parent folder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785964 (https://phabricator.wikimedia.org/T302892) (owner: 10Ejegg) [18:14:13] good point ejegg [18:15:16] actually do we need to do that [18:15:39] do for the currencies which have their own rules, do we care what the USD conversion is? [18:15:56] and for the ones that don't, we fall back to USD then [18:16:02] grr [18:16:07] s/do/so/ [18:17:33] I do think there is a risk relying on a to-USD conversation powered by a static file especially for the minimums [18:17:56] whereas if we just read straight from the native currency amounts when specified we remove that risk [18:18:28] albeit there's a bit more work unwinding the to-USD dependence in the validation [18:18:45] but that isn't need for now [18:18:47] needed [18:25:00] jgleeson: so partly I'm just loathe to touch that front-end validation because it needs to be completely rewritten [18:25:13] and we don't really have time to do that now [18:25:49] but we don't need this part out now [18:25:50] but sure, we could pass the configured currency code and the raw amounts to the front end [18:26:10] that's why I'm thinking more on this one [18:26:20] the one we just +2ed is fine for now [18:26:33] and avoid the conversion same as we're doing on the backend when the donation is in the configured currency [18:27:42] let's deploy what we have and I can leave comments on the follow-on patch for further consideration [18:28:09] ok, cool! [18:35:26] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10Cstone) Ok what I think is happening here is somewhere along the way, for only recurring payments, the Adyen Payment ID is being replaced by the Ady... [18:37:05] (03PS6) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [18:37:57] (03CR) 10Jgleeson: "Thanks for this. This works for me but I feel like with more time we could also remove the dependency on the static rates data when checki" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [18:40:04] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [18:44:24] grr [18:44:50] ok, i really want to update LightNCandy so the tests start working on my PHP8 [18:45:15] I guess or figure out how to get the tests to all pass on docker [18:45:41] probably settings related? [18:50:13] (03CR) 10Ejegg: Allow specifying min/max amount in any currency (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [18:50:19] replies inline ^^^ [18:50:47] though I am reworking it to provide the configured values verbatim to the front end [18:59:33] (03PS1) 10Cstone: Add payment_id to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) [19:00:42] (03CR) 10jerkins-bot: [V: 04-1] Add payment_id to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [19:05:08] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: MC bug related to bundle - https://phabricator.wikimedia.org/T305964 (10DStrine) [19:05:36] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Sweden: Turn on MC for Sweden as default. - https://phabricator.wikimedia.org/T305965 (10DStrine) 05Open→03Resolved [19:06:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity: Adding a new field to the Endowment Benefactor Page listing - https://phabricator.wikimedia.org/T305486 (10DStrine) 05Open→03Resolved [19:07:01] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity: Added new fields to the Benefactor Page Listing section in Civi - https://phabricator.wikimedia.org/T305485 (10DStrine) 05Open→03Resolved [19:08:52] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Transactions unscored for fraud in SE campaign - https://phabricator.wikimedia.org/T306058 (10DStrine) 05Open→03Resolved [19:27:42] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: (Need By: TBD) rack/setup/install frdb1005, frdev1003 - https://phabricator.wikimedia.org/T306935 (10RobH) [19:27:59] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: (Need By: TBD) rack/setup/install frdb1005, frdev1003 - https://phabricator.wikimedia.org/T306935 (10RobH) [19:59:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10DStrine) [20:01:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10DStrine) [20:04:07] 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10DStrine) p:05High→03Medium [20:05:38] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint H 2022 , 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Refactor ConfigurationReader - https://phabricator.wikimedia.org/T305152 (10DStrine) [20:05:43] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint H 2022 , 10Fundraising Sprint e^🥧👀=yum, and 3 others: Syn group to Acoustic should remove any existing queues before creating a new one - https://phabricator.wikimedia.org/T306855 (10DStrine) [20:05:45] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint H 2022 , 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, and 3 others: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10DStrine) [20:05:47] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10DStrine) [20:05:50] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Sprint Goal: small tasks then form chooser - https://phabricator.wikimedia.org/T305987 (10DStrine) [20:05:52] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, and 2 others: Enable Google Pay on Production - https://phabricator.wikimedia.org/T304991 (10DStrine) [20:05:55] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Paypal, and 2 others: Remove PayPal classic integration from DonationInterface - https://phabricator.wikimedia.org/T300068 (10DStrine) [20:05:57] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Increase failure tolerance for Paypal IPN API endpoint - https://phabricator.wikimedia.org/T305553 (10DStrine) [20:06:00] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10DStrine) [20:06:02] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10fr-donorservices: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10DStrine) [20:06:04] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10DStrine) [20:06:06] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint H 2022 , 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Set valid Callback URL on DLocal Sandbox - https://phabricator.wikimedia.org/T303974 (10DStrine) [20:06:11] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Create rules for gateway tiebreaking based on querystring - https://phabricator.wikimedia.org/T302935 (10DStrine) [20:06:14] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Add supported country lists to gateway config - https://phabricator.wikimedia.org/T302923 (10DStrine) [20:06:16] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10DStrine) [20:06:22] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Unit tests for Form Chooser - https://phabricator.wikimedia.org/T302891 (10DStrine) [20:06:28] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, and 2 others: Move PayPal and Adyen to folders based on gateway code - https://phabricator.wikimedia.org/T302892 (10DStrine) [20:06:32] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10Fr-drupal-upgrade-2021: Convert offline2civicrm to a drupal module - https://phabricator.wikimedia.org/T270669 (10DStrine) [20:06:36] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Docker: Add ability to create and see failmail in Docker - https://phabricator.wikimedia.org/T305977 (10DStrine) [20:06:40] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Cheese String Theory, and 41 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10DStrine) [20:06:44] 10Fundraising Sprint H 2022 , 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, and 2 others: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10DStrine) [20:42:47] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/786386 [20:46:30] (03PS1) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 [20:47:18] (03CR) 10jerkins-bot: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 (owner: 10Jgleeson) [20:48:40] ejegg: I was gonna push out the min donations stuff https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/786386/ [20:48:50] sound ok? [20:49:51] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Add mailto link on "your transaction could not be accepted" page that would include contribution tracking ID in the body or subject of email - https://phabricator.wikimedia.org/T85585 (10Aklapper) A #good_first_task is a self-contained, non-contr... [20:50:37] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/786386 (owner: 10Jgleeson) [20:50:44] sounds good jgleeson ! [20:51:11] So do you want to prep the settings on live to replicate what we've got now, and I'll take a look? [20:51:23] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/786386 (owner: 10Jgleeson) [20:51:33] I guess we'll need a new file in the local configuration directory for default and another one for adyen [20:51:45] err, i mean for astropay [20:51:55] since we are currently overriding that value for astropay [20:54:10] ejegg: do you mean removing the ceiling/floor mwgs ? [20:55:31] yep, and replacing them with new-style yaml configs [21:00:30] (03PS2) 10Cstone: Add payment_id to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) [21:01:16] (03CR) 10jerkins-bot: [V: 04-1] Add payment_id to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [21:02:00] ejegg: looks like we're only setting the ceiling in payments localsettings [21:02:07] (03PS3) 10Cstone: Add payment_id to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) [21:02:40] oh do you mean adding some config specifically astropay countries [21:02:53] jgleeson: i'm pretty sure astropay has a different ceiling and floor set there too [21:03:16] I see a Ceiling for all and one for astropay [21:03:43] oh huh, I wonder when we stopped giving them a special minimum [21:03:58] used to be around $1.50 to be close to 5 BRL [21:04:39] heh, Feb 25 2021 I deleted the -$wgAstroPayGatewayPriceFloor = 1.5; [21:04:52] just says 'No longer need to peg it to 5 BRL' [21:05:04] so ok, I guess we just set those maxima [21:06:08] for all countries we use astropay with? [21:06:44] I don't think we can [21:06:53] if I understand you correctly ejegg [21:07:12] I mean we could, but I'm not sure we want to [21:07:27] lemme check the form chooser settings [21:07:46] jgleeson: can't we just put the default: rule with max: 3000 in the donation_rules.yaml under the astropay local settings folder? [21:08:35] let's see, it would be under the di-config folder on frpm [21:09:15] oh I see what you mean [21:11:41] I've never seen the di config overridden [21:11:45] this is a first [21:12:24] (03PS1) 10Cstone: Add check for Adyen payment_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786390 (https://phabricator.wikimedia.org/T306194) [21:12:27] we're doing it to effectively disable GlobalCollect on prod until we can actually get around to disentangling it from Ingenico and getting it disabled for real [21:12:47] basically by saying 'no, GC, credit cards don't exist' [21:12:53] in the payment_methods file [21:13:21] I was pretty sure your configurationReader refactor preserved that functionality... [21:14:00] yeah it will allow overrides by that dir [21:14:12] yep yep, looks good [21:14:30] I guess I just thought it was a relic from a time long ago ha [21:14:50] heh, nope, it's the wave of the future! [21:15:02] groovy! [21:15:43] lemme just try that locally [21:26:25] (03CR) 10jerkins-bot: [V: 04-1] Add check for Adyen payment_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786390 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [21:26:36] yeah that works ejegg [21:27:02] tested it locally with /srv/di-config/astropay/donation_rules.yaml on the payments container [21:31:36] ejegg: I've pushed that update to localsettings [21:32:07] (03CR) 10Jgleeson: "recheck" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 (owner: 10Jgleeson) [21:34:45] (03PS2) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 [21:45:14] thanks jgleeson, looking [21:46:57] oh hmm, jgleeson, do we need to register yet another directory so we can get that max: 12000 in someplace? [21:47:32] because if we deploy as-is we'll push the max for all gateways besides astropay down to 10000 [21:48:34] so when I first looked at that I felt like the only way we could do it would be to add countries but now I'm thinking maybe it wont work that way either [21:49:39] ejegg: I'm out of time today so maybe we could figure it out and deploy tomorrow unless the solution jumps out at you tonight. The submodule update just passed Ci and is ready to go here https://gerrit.wikimedia.org/r/c/mediawiki/core/+/786387 [21:50:23] I think it's just one more registerDirectory line in the LocalConfigurationDirectory block [21:51:23] oh wait a minute ejegg [21:51:36] why don't we just set the default to 12000 in the base config file [21:52:37] ah that was why I left in the old mwglobals to use them as the fallback [21:52:55] nah, let's go all the way forward! [21:52:59] but yeah I think we can set the main config to 12k which will apply to them all [21:53:23] We should be able to override the defaults on a gateway-agnostic basis and also on a gateway-specific basis [21:54:13] yeah we can I think, the base config is the -agnostic [21:54:22] and then the di-config/ is the -specific [21:54:23] (03PS1) 10Ejegg: Register one more config dir [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/786399 [21:55:14] so the base config is the shipped defaults, which includes generic settings as well as gateway-specific settings [21:55:28] oh so you mean a donation_rules.yaml file in the root dir of the /srv/di-config/ [21:55:42] then the di-config is the deployed config, which shoudl be able to override both generic and specific [21:55:44] sorry I had no idea what you were talking about then [21:55:46] yep exactly that [21:56:09] tiredness [21:56:26] ok that's me. will pick up tomorrow. bye for now [21:56:30] ah yeah, it's 11 pm round your way - get some sleep! [21:57:28] (03CR) 10Jgleeson: [C: 03+2] "Looks good to me!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/786399 (owner: 10Ejegg) [21:57:38] thanks! [21:58:04] I'll share this new config stuff with the rest of fr-tech in the late-edition tech talk that's about to start [22:04:02] (03Merged) 10jenkins-bot: Register one more config dir [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/786399 (owner: 10Ejegg) [22:31:05] (03CR) 10Eileen: "I just discovered that" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [22:54:59] hopefully some easy-merge patches - just test cleanup https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/785967/3 [23:00:53] (03PS6) 10Wfan: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 [23:07:09] (03CR) 10Eileen: [C: 03+2] replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan) [23:19:46] (03Merged) 10jenkins-bot: replace c0m to com and remove trailing number from email domain [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785397 (owner: 10Wfan)