[00:43:18] (03PS2) 10Eileen: Cleanup Testy McTester [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785977 [00:43:20] (03PS1) 10Eileen: Improve cleanup in wmf-civicrm/tests/phpunit/api/v3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786434 [00:43:22] (03PS1) 10Eileen: Kill Bill [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786435 [00:45:27] (03CR) 10Ejegg: [C: 03+2] "Approve of the expanding definition of mice" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785967 (owner: 10Eileen) [00:45:31] (03PS4) 10Ejegg: Cleanup in stripe teardown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785967 (owner: 10Eileen) [00:46:00] (03PS1) 10Eileen: Kill Bill the sequel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786437 [00:46:26] (03PS2) 10Ejegg: Test cleanup - do hard delete, not delete to trash [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785976 (owner: 10Eileen) [00:46:31] (03CR) 10Ejegg: [C: 03+2] Test cleanup - do hard delete, not delete to trash [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785976 (owner: 10Eileen) [00:46:59] (03PS2) 10Ejegg: Improve cleanup in wmf-civicrm/tests/phpunit/api/v3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786434 (owner: 10Eileen) [00:47:26] (03CR) 10Ejegg: [C: 03+2] "I like an easily-understood mechanism" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786434 (owner: 10Eileen) [00:47:59] (03PS3) 10Ejegg: Cleanup Testy McTester [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785977 (owner: 10Eileen) [00:48:02] (03CR) 10Ejegg: [C: 03+2] Cleanup Testy McTester [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785977 (owner: 10Eileen) [00:54:04] (03PS3) 10Eileen: Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) [00:54:47] ejegg: look who the original author was on this file https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/785953 [00:55:29] oho! the legendary pgehres [00:55:55] I'll play a special song while I +2 the deletion [00:56:22] :-) [00:56:35] 10Fundraising-Backlog: Smashpig recurring job (for Adyen at least) is saving the capture ID as the gateway transaction ID instead of the authorise ID - https://phabricator.wikimedia.org/T306944 (10Cstone) [00:56:51] (03PS3) 10Eileen: Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) [00:57:08] This 30-year-old American brewpub, known for its German-style lagers, has definitely seen hoppier days. [00:57:10] looks like this one was too https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/785954/3/drupal/sites/all/modules/offline2civicrm/import_checks.drush.inc [00:57:14] lol [00:57:20] bah, clickpaste [00:57:24] (03CR) 10jerkins-bot: [V: 04-1] Kill Bill the sequel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786437 (owner: 10Eileen) [00:57:47] i wonder if it's possible to disable middle-click paste on a per-window basis [00:57:55] oh no - kill-bill the sequel flopped [00:58:21] (03PS5) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [00:59:35] (03PS5) 10Eileen: drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) [01:04:17] (03PS2) 10Ejegg: Kill Bill [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786435 (owner: 10Eileen) [01:04:25] (03CR) 10Ejegg: [C: 03+2] Kill Bill [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786435 (owner: 10Eileen) [01:05:13] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10Cstone) Ok created a new ticket from this one https://phabricator.wikimedia.org... [01:07:32] (03PS4) 10Ejegg: Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:07:39] (03CR) 10Ejegg: [C: 03+2] Remove import_chargebacks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785953 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:07:50] (03PS4) 10Cstone: Add modification_reference to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) [01:08:06] (03PS4) 10Ejegg: Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:08:15] (03CR) 10Ejegg: [C: 03+2] Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:08:54] (03PS5) 10Ejegg: Remove import_checks drush script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785954 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:09:51] (03PS2) 10Cstone: Add check for Adyen modification_reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786390 (https://phabricator.wikimedia.org/T306194) [01:09:58] (03PS2) 10Eileen: Kill Bill the sequel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786437 [01:11:06] (03CR) 10jerkins-bot: [V: 04-1] Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:17:05] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, and 2 others: Enable Google Pay on Production - https://phabricator.wikimedia.org/T304991 (10Cstone) I sent over the Business Console Merchant ID to A... [01:22:54] (03CR) 10jerkins-bot: [V: 04-1] Add check for Adyen modification_reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786390 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [02:09:30] (03PS2) 10Ejegg: Remove coinbase from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784772 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:09:50] (03CR) 10Ejegg: [C: 03+2] Remove coinbase from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784772 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:12:21] (03PS2) 10Ejegg: Remove Paypal EFT from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784773 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:12:25] (03CR) 10Ejegg: [C: 03+2] Remove Paypal EFT from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784773 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:29:00] (03Merged) 10jenkins-bot: Remove coinbase from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784772 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:29:02] (03Merged) 10jenkins-bot: Remove Paypal EFT from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/784773 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:39:38] (03PS6) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [02:40:47] (03PS6) 10Eileen: drush import_refunds script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785952 (https://phabricator.wikimedia.org/T286225) [02:41:39] (03PS7) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [02:43:10] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, and 2 others: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10Eileenmcnaughton) @Ejegg checked the offline2civicrm log... [02:44:31] (03PS1) 10Eileen: Remove WMF Org import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786440 (https://phabricator.wikimedia.org/T286225) [02:47:03] (03PS1) 10Eileen: Remove SquareFile import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786441 (https://phabricator.wikimedia.org/T286225) [02:50:54] (03PS1) 10Eileen: Remove CitiBank import (keep Citibank Individuals) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786443 (https://phabricator.wikimedia.org/T286225) [02:51:35] (03PS2) 10Eileen: Remove CitiBank import (keep Citibank Individuals) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786443 (https://phabricator.wikimedia.org/T286225) [02:52:15] (03PS2) 10Eileen: Remove SquareFile import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786441 (https://phabricator.wikimedia.org/T286225) [02:53:23] (03PS2) 10Eileen: Remove WMF Org import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786440 (https://phabricator.wikimedia.org/T286225) [02:53:25] (03CR) 10jerkins-bot: [V: 04-1] Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [02:55:25] (03PS3) 10Eileen: Remove CitiBank import (keep Citibank Individuals) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786443 (https://phabricator.wikimedia.org/T286225) [02:57:48] (03PS1) 10Eileen: Remove JP Morgan import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786444 (https://phabricator.wikimedia.org/T286225) [03:54:13] (03PS8) 10Eileen: Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) [04:06:44] (03CR) 10jerkins-bot: [V: 04-1] Remove make_recurring batch file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [05:21:13] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/786520 (owner: 10L10n-bot) [06:42:44] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/786520 (owner: 10L10n-bot) [07:09:51] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10RKumar_WMF) CID: 54914851 tried, the donation went to Ingenico instead of dLocal. Also the Thank You email sender is still Maryana. please see below: {F35069746} The link used was sa... [10:14:35] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10Pcoombe) Oh right, using dLocal is still waiting on {T303207} [13:19:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Return of duplicate active employer relationships crashing silverpop export - https://phabricator.wikimedia.org/T306822 (10jgleeson) We got another one of these today that tripped up the export job. contact_id 15741096 [14:52:08] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/786978 [14:58:03] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/786978 (owner: 10Jgleeson) [14:59:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/786978 (owner: 10Jgleeson) [15:02:37] (03PS3) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 [15:16:21] ejegg|away: I just pushed up the gateway default donation_rules.yaml to localsetting which along with the astropay one added yesterday should replicate what we had prior to the new config [15:18:40] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 (owner: 10Jgleeson) [15:19:02] and merged your path addition to deployment which is part of that release ^^ [15:19:39] in short, the min donations stuff is ready to go out! [15:19:59] fr-tech does anyone feel like oking the last two patches I pushed up to localsettings? [15:20:05] I can talk through them if needed [15:27:10] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/786387 (owner: 10Jgleeson) [15:28:15] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) @RKumar_WMF This task is just talking about the TY email language. Did the donor receive the esMX version? The email will still be signed by Jimmy but sent from Maryana unt... [15:35:47] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Docker: Add ability to create and see failmail in Docker - https://phabricator.wikimedia.org/T305977 (10jgleeson) a:03jgleeson [15:51:01] back later [16:01:35] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint e^🥧👀=yum, and 3 others: Syn group to Acoustic should remove any existing queues before creating a new on... - https://phabricator.wikimedia.org/T306855 [16:01:45] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10DStrine) p:05Triage→03Medium [16:01:55] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Paypal, and 2 others: Remove PayPal classic integration from DonationInterface - https://phabricator.wikimedia.org/T300068 (10DStrine) p:05Triage→03Medium [16:13:14] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10CDenes_WMF) Rakhi please feel free to share with me the tester's thank you email copy, and I can decipher it is esMX or esES. Thank you! [16:43:27] ok, those config files that jgleeson added look good on local [16:43:38] I'll push up a patch to fundraising-dev [16:44:18] (03PS1) 10Ejegg: Add donation_rules to match production [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787013 (https://phabricator.wikimedia.org/T261436) [17:22:40] thanks for that patch ejegg [17:29:52] ejegg: did you do the localsettings path bit somewhere else? I see it mentioned in the commit 787013 [17:30:04] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/787013 * [17:30:30] we could set that in LocalSettings.php in fundraising-dev [17:30:37] if we're not already [17:31:30] want me to add that? [17:40:08] oh oops, I thought I added that to the commit jgleeson [17:40:32] (03PS2) 10Ejegg: Add donation_rules to match production [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787013 (https://phabricator.wikimedia.org/T261436) [17:41:08] !log updated payments-wiki from 16c0c111 to 41e91033 [17:41:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:11:51] ah gotcha ejegg [19:11:55] lemme try that [19:25:21] php 8.1 introduced enums in php.. https://www.php.net/manual/en/language.enumerations.basics.php [19:25:39] feels like we could get some use out of those for payment status stuff [19:32:15] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "Works great for me. thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787013 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [19:59:41] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10Sharvaniharan) a:03Sharvaniharan [20:46:01] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10Sharvaniharan) Hi @spatton - Could we use the same image as we use on English wiki: https://upload.wi... [20:52:30] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, and 2 others: Enable Google Pay on Production - https://phabricator.wikimedia.org/T304991 (10Ejegg) I've uploaded the donation flow screenshots to the... [20:58:27] (03PS1) 10Ejegg: Use $wgLogos for payments rather than individual settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787071 [21:01:59] oh hmm, no more LogoOverride? [21:02:12] right, looks like we moved that to the onBeforePageDisplay hook [21:06:31] (03PS2) 10Ejegg: Use $wgLogos for payments rather than individual settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787071 [21:06:52] fr-tech anyone want to take a look at that fr-dev patch? ^^^ [21:07:15] I've got a matching localsettings patch to push out to paymentswiki on prod [21:07:22] just to clean up those logo settings [21:09:47] ejegg: cool! able to look at it in a 2-3 hours :) [21:10:01] (03PS3) 10Wfan: Use $wgLogos for payments rather than individual settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787071 (owner: 10Ejegg) [21:13:03] ejegg: this pr https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/777496/1 do you want to have the rfdqc or this is nothing todo with refund? [21:13:08] if so I can merge this one first [21:15:29] (03PS4) 10Wfan: Use $wgLogos for payments rather than individual settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787071 (owner: 10Ejegg) [21:17:19] looking [21:17:36] (03CR) 10Wfan: [V: 03+2 C: 03+2] "merge this to have the following localsetting patches merge, if rfdqc is needed can add later" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/777496 (owner: 10Ejegg) [21:18:20] nice convenience script ! [21:22:34] ejegg: i see the logo with your patch but I don't see endowments after adding '&utm_medium=endowment' [21:22:51] should that also work locally [21:23:42] ooh, it should - let me see what's up with that [21:23:51] maybe the hook needs to be attached in settings? [21:46:41] aha, yep [21:46:45] $wgHooks['BeforePageDisplay'][] = 'EndowmentHooks::onBeforePageDisplay'; [21:46:59] so let me add that to the localSettings in fr-dev [21:48:22] (03PS5) 10Ejegg: Use $wgLogos for payments rather than individual settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787071 [21:49:51] ok jgleeson with ^^^ it works for me [21:50:13] but... you may have to start a new session, as the utm_medium is stored in session [21:50:37] I tried in a private window with utm_medium=endowment on the URL and it gave me the different logo [21:51:09] the footer links should also be slightly altered for endowment donations [21:51:26] i.e. other ways to give goes to a wikimediaendowment.org URL [21:52:41] brb [22:04:09] working here ejegg [22:04:22] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "LGTM!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/787071 (owner: 10Ejegg) [22:23:49] thanks! [22:26:08] ok, looks good on production too