[02:57:33] (03PS7) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [02:59:54] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [03:09:44] (03PS8) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [03:11:24] (03PS9) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [03:11:29] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [03:13:38] (03CR) 10jerkins-bot: [V: 04-1] Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [03:15:27] (03PS10) 10Ejegg: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) [03:27:35] (03PS1) 10Ejegg: Move PayPal Express Checkout to paypal_ec_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787117 (https://phabricator.wikimedia.org/T302892) [03:41:18] (03PS2) 10Ejegg: Set adyen config on resultswitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779563 [05:28:21] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/787192 (owner: 10L10n-bot) [06:05:00] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/787192 (owner: 10L10n-bot) [09:22:45] 10Wikimedia-Fundraising-Banners: [Enhancement] India - Rearrange Visa payment logos to match other payment option button - https://phabricator.wikimedia.org/T259937 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Fixed since India has Amex enabled again [09:22:47] 10Wikimedia-Fundraising-Banners: QA 'Pretty' variant - https://phabricator.wikimedia.org/T259933 (10Pcoombe) [09:32:24] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10RKumar_WMF) @CDenes_WMF - sent over email the Thank you email from tester. [14:39:51] looks like gerrit got a facelift. I like it ! [14:41:45] (03PS1) 10Wfan: WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [14:43:52] (03CR) 10jerkins-bot: [V: 04-1] WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:15:48] (03PS2) 10Wfan: WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:16:08] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10CDenes_WMF) Thank you Rakhi. The Email sent is still in esES (not esMX). However, I went to production testmeister and sent myself a copy of esES and a copy of esMX and the esMX is u... [15:17:55] (03CR) 10jerkins-bot: [V: 04-1] WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:23:18] (03CR) 10Jgleeson: [C: 03+2] "Working here! Thanks." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [15:24:09] (03CR) 10Jgleeson: [C: 03+2] "Low hanging fruit if I've ever seen it! LGTM." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785946 (https://phabricator.wikimedia.org/T303207) (owner: 10Ejegg) [15:25:21] (03Merged) 10jenkins-bot: Remove PayPal legacy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785965 (https://phabricator.wikimedia.org/T300068) (owner: 10Ejegg) [15:26:16] (03Merged) 10jenkins-bot: Fix PE form settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785946 (https://phabricator.wikimedia.org/T303207) (owner: 10Ejegg) [15:29:28] (03CR) 10Jgleeson: [C: 03+2] "Thanks for the cleanup. Working for me!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787117 (https://phabricator.wikimedia.org/T302892) (owner: 10Ejegg) [15:31:43] (03Merged) 10jenkins-bot: Move PayPal Express Checkout to paypal_ec_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787117 (https://phabricator.wikimedia.org/T302892) (owner: 10Ejegg) [15:40:02] (03PS3) 10Wfan: WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:42:34] (03CR) 10jerkins-bot: [V: 04-1] WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:43:53] (03PS4) 10Wfan: WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:46:09] hi fr-tech, South Africa pre-test round two going live in 15 minutes! Same set-up as Tuesday, 16-19 UTC [15:46:42] (03CR) 10jerkins-bot: [V: 04-1] WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:51:14] (03CR) 10Jgleeson: "hmm I'm using 3dsecure and I'm not seeing this code being hit. how are you testing it?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779563 (owner: 10Ejegg) [16:06:32] (03PS5) 10Wfan: WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [16:08:29] (03CR) 10jerkins-bot: [V: 04-1] WIP: Still needs more test cases [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [16:14:54] thanks haley_ [16:15:41] thanks for all the CR, jgleeson ! [16:18:52] standup ejegg [16:19:25] we're all on* [16:22:38] oops! [16:38:21] I think I want to deploy that PayPal stuff now so any possible errors are easy to diagnose [16:41:11] ejegg: on this adyen one [16:41:23] I don't think the hook that we attach setClientVariables to is getting fired [16:41:33] did you see this working at your end? [16:42:18] looking at this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/779563 [16:44:24] jgleeson: ohhh, perhaps not [16:44:36] sorry, I need to smoke test that one more locally [16:48:46] no worries [16:49:44] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/787535 [16:49:48] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/787535 (owner: 10Ejegg) [16:52:51] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/787536 [16:53:22] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/787536 (owner: 10Ejegg) [17:04:26] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/787535 (owner: 10Ejegg) [17:24:11] fr-tech can anyone review the LocalSettings change (for payments-wiki) on the deploy server before I push it out? There was a fair amount to remove [17:36:43] I'm about to grab dinner. Anyone else fancy it? [17:38:54] -# FIXME: explain why [17:38:56] ha [17:40:54] hmm is the checkout config not piggy backing off the $wgAdyenGatewayCustomFiltersActionRanges [17:41:53] ejegg: does adyen checkout need it's own FiltersActionRanges [17:42:14] jgleeson: ah you're looking at ejegg localsettings settings? [17:42:21] *ejegg's [17:42:39] ah yeah AndyRussG no one pinged so i thought I'd do it before dropping off [17:42:52] wnna take over? [17:43:06] looks ok to me outside of that last question [17:43:28] back later! [17:47:41] jgleeson|dinner: nope, it doesn't [17:48:08] the custom FiltersActionRanges for the old flow was because we didn't do the final fraud filtering in the front end due to lack of AVS/CVV results [17:48:31] also AndyRussG ^ [17:49:02] the new flow does have those so we have the same action ranges and filter list as Ingenico [17:58:36] ok, I' [17:58:40] m going to deploy [18:00:26] ok thx ejegg jgleeson|dinner :) [18:06:09] ok, looks like that's still working [18:06:14] whew! [18:08:00] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), 10MW-1.39-notes (1.39.0-wmf.10; 2022-05-02): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10Ejegg) @HNordeenWMF we just deployed that typo fix. That PE banner you linked now successfully routes do... [18:23:06] thanks for the context! [18:23:10] glad it worked [18:31:19] 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), 10MW-1.39-notes (1.39.0-wmf.10; 2022-05-02): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10HNordeenWMF) great, thank you @Ejegg ! [20:44:21] 10Fundraising-Backlog, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10spatton) [20:47:39] 10Fundraising-Backlog, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10spatton) Hi @Sharvaniharan, thanks for your response! You caused me to realize th... [22:17:17] (03CR) 10Ejegg: [C: 03+2] "Nice to have for a cleanup! Maybe we can roll it back later when we start doing the right thing in the recurring charge job." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [22:17:48] (03Merged) 10jenkins-bot: Add modification_reference to the Adyen audit parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/786373 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [23:07:52] (03PS1) 10Ejegg: Update smash-pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787567 [23:07:56] (03CR) 10Ejegg: [C: 03+2] Update smash-pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787567 (owner: 10Ejegg) [23:08:48] wfan I'm planning to do a CRM deploy. [23:09:00] (03CR) 10jerkins-bot: [V: 04-1] Update smash-pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787567 (owner: 10Ejegg) [23:09:06] It looks like your email data fix would go out with it [23:09:11] Thanks! [23:09:23] do we need to stop the queues to run those? [23:09:57] that part I do not know, but this shouldn't take too long, so probably yes? [23:11:20] (03PS1) 10Ejegg: Clear up warning for end of heredoc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787568 [23:11:36] (03CR) 10Ejegg: [C: 03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787567 (owner: 10Ejegg) [23:12:12] (03CR) 10Ejegg: "Let's see if this can go in the Adyen class rather than the base" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786390 (https://phabricator.wikimedia.org/T306194) (owner: 10Cstone) [23:12:33] (03CR) 10jerkins-bot: [V: 04-1] Clear up warning for end of heredoc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787568 (owner: 10Ejegg) [23:12:39] (03CR) 10jerkins-bot: [V: 04-1] Update smash-pig library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787567 (owner: 10Ejegg) [23:16:55] huh, has there been an update to the CI infrastructure? [23:17:29] looks like maybe a new version of mariadb [23:17:59] First I see this: wo all-privilege accounts were created. [23:17:59] One is root@localhost, it has no password, but you need to [23:17:59] be system 'root' user to connect. Use, for example, sudo mysql [23:17:59] The second is nobody@localhost, it has no password either, but [23:18:01] you need to be the system 'nobody' user to connect. [23:18:07] then I see this: [23:18:12] ERROR 1698 (28000): Access denied for user 'root'@'localhost' [23:18:30] Do you mean we got a newer version mariadb on production site? btw I was try to test the heredoc, and when I run the sh file, 'BUILD_TAG environment variable was not set, exiting.' where build_tag should I have? [23:18:39] so that CI script is probably not running the difference [23:18:54] wfan ah, that script is only run in CI (that is, on Jenkins) [23:19:17] and Jenkins sets some environment variables including BUILD_TAG [23:19:23] ah, ok! [23:19:48] So the new mariadb version would be on the unit test docker images, not on production [23:20:06] and might be the reason that all the CRM tests are failing now [23:22:14] I remember couple days ago, eileen deployed the data patch for civi custom field with no error, what's the difference? [23:23:02] So maybe eileen do it directly through production? [23:24:42] (03PS2) 10Wfan: Clear up warning for end of heredoc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787568 (owner: 10Ejegg) [23:25:18] (03CR) 10Wfan: [V: 03+2 C: 03+2] "Not able to test it since it's cli cmd, but looks fine~" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787568 (owner: 10Ejegg) [23:25:43] wfan I think there may have been an update deployed to the CI infrastructure today [23:25:52] (03CR) 10jerkins-bot: [V: 04-1] Clear up warning for end of heredoc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787568 (owner: 10Ejegg) [23:26:01] let's see, we should be able to see that in one of their repos [23:26:49] maybe integration/config ? [23:27:22] https://gerrit.wikimedia.org/r/q/project:integration%252Fconfig [23:28:09] the heredoc also got 16:25:39 ERROR 1698 (28000): Access denied for user 'root'@'localhost' error from jenkins [23:28:34] yeah, it's happening for all the patches in that repo which is why I feel like it's a problem with the test environment [23:33:14] I see, then should we hold the deployment until the CI infrastructure be updated by someone to unblock the mariadb access issue? [23:36:28] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/785951 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [23:37:08] wfan if we can get a quick fix for CI today that would be best [23:37:21] otherwise we can force the patches to merge and go ahead with the deploy [23:42:16] oh I see, so we should irc the team that are working on the CI and then probably just force merge our patch to deploy, right~ Thanks for the explanation :) [23:48:56] yep, i'm waiting for a reply