[00:59:26] (03PS2) 10Ejegg: Speed up payments phpunit tests [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789306 (owner: 10Jgleeson) [00:59:32] (03CR) 10Ejegg: [V: 03+2] Speed up payments phpunit tests [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789306 (owner: 10Jgleeson) [01:03:20] (03PS5) 10Ejegg: Remove JP Morgan import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786444 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:03:32] (03CR) 10Ejegg: [C: 03+2] "Looks good to me!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786444 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:05:06] (03Abandoned) 10Ejegg: WIP form chooser test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779966 (owner: 10Ejegg) [01:17:54] (03Merged) 10jenkins-bot: Remove JP Morgan import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/786444 (https://phabricator.wikimedia.org/T286225) (owner: 10Eileen) [01:25:55] (03PS1) 10Ejegg: Remove dead code from FormChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789322 [01:27:05] cstone: did you want to check in a WIP version of the script to generate those test cases? [02:07:30] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Add flag for recurring to payment_methods.yaml entries - https://phabricator.wikimedia.org/T306151 (10Ejegg) a:03Ejegg [02:21:31] (03PS1) 10Ejegg: Add recurring flag for payment methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789323 (https://phabricator.wikimedia.org/T306151) [02:27:41] eileen fr-tech also available for moar review around nowish if that'd be helpful :) [02:28:07] thanks AndyRussG - I don't actually have anything at the moment (that's rare) [02:29:35] ah oki sounds good! thx! [02:29:46] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, and 2 others: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10Eileenmcnaughton) @KHaggard when... [02:29:53] AndyRussG: thanks! I've got a couple things up for review [02:30:13] form chooser preliminaries plus one thing towards running silverpop export on docker [02:31:12] I should head to bed now-ish, but I'd be happy to wake up to some comments on those! [02:31:32] These are a couple of the form chooser preliminaries: [02:31:37] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/788894 [02:31:43] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/788895 [02:31:50] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/789322 [02:31:58] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/789323 [02:32:33] Ah, and there's the min/max configurable currency one: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/785963 [02:32:54] This is the thing to get around that undefined LOGNAME when running python tools on docker: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/788896 [02:33:43] Thanks! [02:39:03] oki cool thank u ejegg :) [04:14:34] (03CR) 10AndyRussG: "Hi! Thanks for this! This actually breaks my current tunnel, for which the directives in .ssh/config are those indicated in README.md." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/771446 (owner: 10Jgleeson) [04:17:50] (03PS1) 10AndyRussG: Fix formatting in README.md [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789347 [06:27:27] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10Eileenmcnaughton) @nisrael sure - but I think you might not need us - you can remove the on hold from contact in bulk from search results (which is what we wou... [13:48:02] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) This bug is kind of growing beyond the original scope. I'm going to send an email on this. But we need to have clear steps to reproduce a bug and you need to show me the end... [14:03:12] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10CDenes_WMF) Thank you, David! Replies in-line: > But we need to have clear steps to reproduce a bug and you need to show me the end result you saw and what you expected to see.... [14:19:15] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) thanks @CDenes_WMF I recognise that @RKumar_WMF sent you the Spanish-SPAIN copy I just don't know how the tester got this email. [15:10:17] (03PS11) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:13:00] (03CR) 10jerkins-bot: [V: 04-1] Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:15:13] (03PS7) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [15:17:32] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [15:28:01] (03PS12) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:30:20] (03CR) 10jerkins-bot: [V: 04-1] Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:31:17] 10Fundraising-Backlog: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10CDenes_WMF) [15:33:32] (03PS13) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:37:29] (03CR) 10jerkins-bot: [V: 04-1] Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [15:38:58] (03PS14) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:39:17] (03PS15) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [15:42:31] (03PS8) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [15:45:06] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [15:49:19] (03CR) 10Damilare Adedoyin: WIP: Combined gateway countries and tests (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [16:25:38] (03CR) 10Ejegg: "This is great work! I'm seeing a lot of duplication, though. We could either have the generation script keep track of the cases it's alrea" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [16:26:25] Ok! Will do this, thanks 😊 [16:27:37] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10nisrael) Thanks Eileen for clarifying! And a heads up that Katie will be back in office next week. [17:06:18] 10Fundraising-Backlog, 10fundraising-tech-ops: Update iptables rules for gpc.matchinggifts.com - https://phabricator.wikimedia.org/T307728 (10Dwisehaupt) [17:36:40] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: DonationInterface: Remove unused code from old integrations - https://phabricator.wikimedia.org/T291785 (10Ejegg) [17:36:48] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Paypal, 10MediaWiki-extensions-DonationInterface: Remove PayPal classic integration from DonationInterface - https://phabricator.wikimedia.org/T300068 (10Ejegg) 05Open→03Res... [17:53:22] 10Fundraising-Backlog, 10fundraising-tech-ops: Update iptables rules for gpc.matchinggifts.com - https://phabricator.wikimedia.org/T307728 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt This rule has been updated to using an ipset. Config changes deployed and rules applied on all civicrm hosts. [18:33:08] 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10EMartin) [18:54:09] (03PS1) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) [18:56:48] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [19:01:45] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, and 2 others: Create rules for gateway tiebreaking based on querystring - https://phabricator.wikimedia.org/T302935 (10jgleeson) I've pushed up a WIP patch... [19:04:51] fr-tech, I've pushed up a working WIP patch with a test for the Formchooser tiebreaker task https://phabricator.wikimedia.org/T302935. I've added some notes on the ticket and comments on the patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/789675/. I'm gonna take my face off the ticket now and put it back in to the backlog so feel free to pick it up! [19:05:49] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, and 2 others: Create rules for gateway tiebreaking based on querystring - https://phabricator.wikimedia.org/T302935 (10jgleeson) a:05jgleeson→03None [19:06:06] (03PS2) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) [19:07:56] have a good rest of your week all! [19:07:58] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [19:17:46] (03PS3) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) [19:18:37] thanks jgleeson|away [19:19:42] (03PS4) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) [19:20:17] np. I realised I forgot to add a few test cases to make it more obvious how the rules work. really going now, bye! [19:21:38] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [19:55:56] 10Fundraising-Backlog: Verbiage on payment page re S.A. national ID requirement - https://phabricator.wikimedia.org/T307743 (10EMartin) [20:12:54] AndyRussG: Would you like to have a quick video chat for some context on the patches in review? [20:13:18] ejegg: thanks, sure! I can do so in 2-3 minutes :) [20:16:44] ejegg: https://meet.google.com/nsc-symi-ic [20:52:05] fr-tech also btw if anyone's interested in call [20:52:08] ^ [21:37:53] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) [21:53:11] (03CR) 10Ejegg: "I worry that if we base this on an accumulating score that it could end up difficult to predict." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [21:56:06] ejegg: I'm around. I was downstairs and had an idea about how to manage the tiebreaker scenario so thought I'd throw a quick implementation down before I forget over the weekend [21:56:19] you not feeling the score approach? [21:57:00] yeah, I think that still makes it harder to determine the impact [21:57:03] of a change [21:57:25] hmmm [21:57:33] with a strict 'first matching rule wins' flow, it seems easier to understand [21:58:19] so for instance if we can only ever process endowment donations through X gateway for contract reasons, it should be easy to put that rule at the top and not worry about it being overruled [21:58:27] so in my head I envisaged we'd have pretty broad rules which would generally result in low scores and then we'd have a small amount of targeted rules to bump up the score for some flows [21:59:31] I also imagined that'd we'd use tests to verify those small amounts of specific rules to make sure we get the processor we expect [21:59:41] Sure, we want to have the tests too [22:00:08] but I also want to be able to look at the rules and figure out at a glance what their impact is [22:00:33] and the top-down match/no-match is mentally easier for me than tallying up a bunch of scores [22:01:01] doesn't that take us more in the direction of the selection weight approach? [22:01:21] the scores feel like selection weight to me [22:01:53] so my understanding was that the more rules that apply, conditons are met, the more priority we give the processor [22:02:36] and as the rules are split across multiple instances it felt like counting them might help us [22:02:49] multiple instances? [22:03:11] multiple rules declarations [22:04:33] I feel like we'll have a lot less rules than the existing settings file as we're now setting rules across multiple gateways [22:04:46] so it might not be as hard to quickly see what goes where [22:05:04] Yes, we definitely will have a lot fewer rules [22:05:54] I think we will basically just need a couple of them for 'these countries should prefer adyen for cc' and 'these countries should prefer dlocal for all methods' [22:06:09] and the rest will be handled in the initial filtering [22:06:37] I don't see why we would need a score total [22:06:57] shouldn't just one rule matching be enough to decide & return? [22:07:53] you mean stop at the first condition we hit? [22:08:07] yes, exactly, the first rule where all conditions are met [22:08:20] what is endowment is adyen but FR is ingenico and it's a FR/Endowment [22:09:08] oh I see so you want to write out the complete set of conditions, an exact match [22:09:27] so the endowment rule comes first since that's contractually more important, and we steer the person to the endowment gateway [22:10:05] if adyen can't be used in FR at all, then we don't put FR in adyen's countries.yaml and it gets filtered out in the inital selection before we even look at tiebreaker rules [22:11:13] I'll tell you what, I'll finish this tiebreaker idea I had and push it up. feel free to add more review and submit an alternative approach and we can discuss more on Monday [22:11:27] in the meantime anyone else can also dip in until then [22:11:29] if FR => ingenico is just a preference, we can put that in a rule that comes lower down [22:11:30] hows that sound [22:11:34] ok, sounds good [22:11:43] cool col [22:31:51] (03PS5) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) [22:33:46] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [22:36:29] ok that works for now but it's still pretty heavily tilted towards using the scores to decide the tiebreaker so I'll check in on your notes when I get back. I'm not wedded to the scoring approach it's just the first idea that made sense so we can definitely rework that if needed. thanks for the feedback anyway! bye for now [22:43:00] (03PS6) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) [22:43:43] (03PS16) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [22:44:53] (03CR) 10jerkins-bot: [V: 04-1] WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [22:45:48] (03CR) 10jerkins-bot: [V: 04-1] Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [23:12:46] (03PS17) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [23:14:41] (03CR) 10jerkins-bot: [V: 04-1] Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [23:18:19] (03PS18) 10Wfan: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) [23:18:46] 10Fundraising-Backlog: New Adyen recurrings from the audit file are missing their recurring_token and creating Error: INVALID_MESSAGE Recurring donation, but no subscription ID failmail - https://phabricator.wikimedia.org/T307602 (10Cstone) [23:52:50] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) [23:54:40] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) Access request sent and approved. ` Date: Thu, 5 May 2022 15:23:36 From: Lisa Seitz Gruwell To: Dallas Wisehaupt Cc: Dylan Kozlowski, Maryum Styles, Jeff G...