[01:27:17] 10Fundraising-Backlog: Use specific currency for minimum donation amount - https://phabricator.wikimedia.org/T307880 (10AndyRussG) [01:27:32] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Use specific currency for minimum donation amount - https://phabricator.wikimedia.org/T307880 (10AndyRussG) [01:31:04] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, and 3 others: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10AndyRussG) Follow-on to specify currency for min am... [02:09:44] (03CR) 10AndyRussG: "Cool! Just one comment so far here..." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789730 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [02:13:52] (03CR) 10AndyRussG: "Hi! Thanks for this!!! BTW not yet done CR... just as a start here are a few notes inline... :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T261436) (owner: 10Ejegg) [05:54:24] (03CR) 10AndyRussG: "Thanks!!! Ahh just a couple inline suggestions for code readability... and also some mostly unrelated notes thrown in for good measure! :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [07:20:32] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10krobinson) Could we sit on this until the Civi fortnightly... [09:36:34] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10RKumar_WMF) Hi - I sent the below link to the tester to make a test donation. After completing the donation, the tester received the TY email that she sent to me and I forwarded the s... [10:47:55] 10Fundraising-Backlog, 10FR-Email: Confirmation needed for database update export job - https://phabricator.wikimedia.org/T307811 (10Eileenmcnaughton) @MNoorWMF - we will have to do a full database export when we deploy the fix for https://phabricator.wikimedia.org/T305483 - so if anything IS missed they will... [11:30:04] (03PS9) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [11:32:19] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [11:50:29] (03PS10) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [11:52:19] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [12:05:57] (03PS11) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [12:07:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [13:40:38] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/324066 (owner: 10Hashar) [13:40:45] (03CR) 10Hashar: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/324066 (owner: 10Hashar) [14:58:28] hi fr-tech! [14:58:31] thanks for the CR AndyRussG [14:58:37] will respond shortly [15:03:43] (03PS2) 10Ejegg: Update donation_rules with currency [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789730 (https://phabricator.wikimedia.org/T307880) [15:09:33] hey ejegg [15:12:38] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Stop logging queue message twice in queue consumers - https://phabricator.wikimedia.org/T307929 (10Ejegg) [15:17:51] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10Ejegg) @RKumar_WMF Thanks! I'm having trouble finding it in the logs - the only PE donation attempts I can find in May with that banner in the utm_source are incomplete, so wouldn't h... [15:17:59] 10Fundraising-Backlog, 10fundraising-tech-ops: Help me set up ssh access on a new machine - https://phabricator.wikimedia.org/T307930 (10spatton) [15:18:09] hi jgleesn ! You seem to be short an 'o' [15:18:35] oh yeah good spot ha [15:18:52] got all that earth sorted out? [15:22:21] hiii ejegg jgleeson damilare fr-tech :) [15:22:21] yep yep! got the first half of it done over thursday and friday and then the digger came saturday to clear out all the tree waste from the back of the garden. We tried doing it by hand but it was too much work for 2 people so I ended up hiring a mini digger (with drier to speed things up [15:22:43] I then spent the rest of the weekend rollin turf out which was fun [15:23:08] whew, sounds like a big job! [15:23:16] my knees didn't think it was fun [15:23:52] https://drive.google.com/file/d/1hlQo7ldQ1wm2V0hqSvuEP1Y2EyM8ht7p/view?usp=sharing [15:24:35] https://drive.google.com/file/d/1hp3Lw3C-RWSkKtpuB-3nyS_zYoOTTTha/view?usp=sharing [15:25:06] hi AndyRussG ! [15:25:51] I'm only half for now, gonna do the other half when I can get my buddy back to help with the soil :( [15:26:34] I've only done half* [15:26:50] (03PS3) 10Ejegg: Factory method for ConfigurationReader [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) [15:26:52] (03PS3) 10Ejegg: Remove unused getBasedir function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788895 (https://phabricator.wikimedia.org/T302892) [15:27:53] we had quite a bit of turf left over from the first half of the order so I spent the rest of weekend replacing the grass I had out front https://drive.google.com/file/d/1hmlslGJF90YPjSo5_lEsGr4rqHJkmkpK/view?usp=sharing [15:28:10] I was showing damilare earlier so pushed up some pics [15:28:52] that looks really good! [15:29:27] ah man I just realised I was meant to return a lawn roller that I hired and I've forgotten [15:29:48] it's only £3 a day so I'll ride it out and take it tomorrow [15:29:55] thanks! [15:30:07] (03CR) 10Ejegg: Factory method for ConfigurationReader (034 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [15:30:18] OK AndyRussG I made those changes you asked for ^^ [15:30:55] (03CR) 10Ejegg: "I updated the task tag, AndyRussG" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789730 (https://phabricator.wikimedia.org/T307880) (owner: 10Ejegg) [15:31:37] ah ejegg AndyRussG, when that ConfigReader was a WIP I planned to write some tests for both the register and unregister methods [15:31:59] I figured it would be a nice one to have to future use when designing it [15:32:52] didn't I add any tests to that [15:33:47] I guess not [15:35:13] also sorry for not reviewing that patch like I said I would [15:35:35] pretty glad I never now after AndyRussG added some good points [15:40:10] hi fr-tech [15:40:24] hey cstone !:) [15:41:55] your garden looks great jgleeson ! [15:43:41] thanks cstone ! it's getting there [15:45:20] (03PS8) 10Ejegg: Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) [15:46:05] (03CR) 10Ejegg: "Thanks for the CR AndyRussG. I made some changes and responded to your comment on the max donation message." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [15:50:20] Listening suggestion for today: Giorgio Moroder's 1983 'Metropolis' score - https://archive.org/details/Giorgio-moroder-metropolis-score [15:53:05] Then you can follow it up with some Janelle Monáe [15:53:42] or dig up the Alloy Orchestra's alternate score for the restored version of the movie [15:54:16] Sadly their website seems to have been snatched by a domainsquatter advertising an Indonesian casino [16:00:55] I'm currently listening to The Greatest Showman soundtrack. Guilty pleasure [16:02:49] ejegg: did you send in the Config param on the factory for testability ? [16:05:15] just reviewing that patch [16:13:06] I'll add a comment on the patch [16:18:49] (03CR) 10Jgleeson: [C: 03+1] "Working good for me. I just had a comment about passing the Config as an arg. Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [16:19:00] damilare: coming [16:31:53] 10Fundraising-Backlog, 10FR-Email: Confirmation needed for database update export job - https://phabricator.wikimedia.org/T307811 (10KHaggard) Thanks Moska for logging this! Hi @Eileenmcnaughton - we do have a small email send going out on Thursday this week, do you think we should run the full file + new cus... [16:43:30] jgleeson: yep, the Config param would be for testability [16:44:48] It looks like the pattern in mediawiki core is for the MediawikiServices calls to be nearer the root of the call stack, and for utility classes to just take constructor args for the specific things they need [16:47:00] (03CR) 10Jgleeson: [C: 03+1] Factory method for ConfigurationReader (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [16:47:33] ejegg: could we not inject a mock into the container prior to any test running [16:50:01] jgleeson: We certainly could, but do you think it's preferable to call MediaWikiServices instance to get the config from inside the ConfigurationReader? [17:00:22] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog: Set India's minimum donation amount to $.65 USD - https://phabricator.wikimedia.org/T307942 (10DStrine) p:05Triage→03High [17:10:27] (03PS12) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [17:10:31] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog: Set India's minimum donation amount to $.65 USD - https://phabricator.wikimedia.org/T307942 (10HNordeenWMF) Adding @Pcoombe as well. Once this change is made, we'll probably also want to update the banner hard minimum in the JS, https://meta.w... [17:12:29] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:14:24] wow did standup finish already [17:18:42] yup [17:19:44] (03PS13) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [17:22:06] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:26:29] (03PS14) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [17:26:37] ejegg: sorry been on a call so couldn't formulate a response worthy of writing until now. I like sending in dependencies but in this case I think to save the calling code needing to pull config we could shift that work to the factory and reduce the method args whilst still keeping the ability to mock the dependency in the service container. [17:27:09] that's guess also, I've not seen an example of that on our code to-daste [17:27:17] to-date [17:28:57] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:31:46] ah ejegg I just read your other bit about norms in mediawiki core [17:31:49] hmm [17:33:17] for instance, the Special page class has an instance var for a config [17:33:27] (03PS15) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [17:33:49] and when we need to read gateway yamls from the form chooser we can just pass that into the factory function [17:34:11] ejegg: I'm looking across core for instance of MediaWikiServices::getInstance() and I see the first few are calling it in methods using the result of the service call [17:35:01] I think we should probably make the gateway objects take an MW config in the constructor too, and give it an instance var to use to access the mg globals [17:35:41] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:36:53] https://github.com/wikimedia/mediawiki/blob/aa5a82d9d91efbc61c0e2b48b95a98e639b3d676/includes/actions/HistoryAction.php#L432 [17:37:53] (03PS16) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [17:37:58] i wonder why they wouldn't put that in the constructor - maybe there's a difficulty with how the action objects are created? [17:38:30] https://github.com/wikimedia/mediawiki/blob/aa5a82d9d91efbc61c0e2b48b95a98e639b3d676/includes/api/ApiQueryBase.php#L561 [17:38:52] sorry I know seems like confirmation bias [17:38:53] ha [17:39:03] cherry picking the ones I could make out quickly enough [17:39:16] https://www.mediawiki.org/wiki/Dependency_Injection#Quick_Start [17:39:24] > To acquire a reference to the service container, use MediaWikiServices::getInstance(). This should only be done in bootstrap code and static entry points. [17:39:39] > Accessing the service container say in application logic (as per the Service Locator pattern) or passing the service container as a parameter or keeping a reference to the service container in a member variable (as per the Context Object pattern) is strongly discouraged. [17:39:50] (03CR) 10jerkins-bot: [V: 04-1] WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:39:53] > in static entry points [17:40:05] yep, like the load.php code, I think [17:40:59] aren't we breaking that rule in both cases [17:41:04] your second paste [17:41:09] https://www.mediawiki.org/wiki/Dependency_Injection#Static_entry_points [17:41:34] the 'accessing in application logic' rule [17:41:47] jgleeson: right, we shouldn't have it in the gateway adapter class either [17:42:08] I can write another patch for the gateway adapter constructor to take a MW Config object [17:42:23] ah ok I see static entry points isn't static api methods [17:42:25] the MW config object is fine to pass around, not the MediawikiServices instance [17:45:13] 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10DStrine) @CDenes_WMF @HNordeenWMF @TSkaff Fr-tech will discuss this today. If we get the english version in before May 23rd this would need to be translated as well. [17:46:54] sounds good ejegg [17:47:38] gonna grab food [17:47:44] (03PS2) 10Ejegg: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) [17:51:18] (03PS3) 10Ejegg: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) [17:58:17] arr, looks like that'll be a bit trickier than I though - the dang adapter's getGlobal class is used statically a lot [17:58:38] so... we have to get rid of that [18:01:46] ok, 22 instances of ::getGlobal( [18:01:51] not TOO terrible [18:02:40] 6 are in non-static instance methods of the gateway class, so should be easy to fix [18:03:44] 7 more are in non-static instance methods of child classes, so that's more than half pretty easy to get rid of [18:08:11] (03PS17) 10Damilare Adedoyin: WIP: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [18:11:54] (03PS18) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [18:20:05] 10Fundraising-Backlog: New Adyen recurrings from the audit file are missing their recurring_token and creating Error: INVALID_MESSAGE Recurring donation, but no subscription ID failmail - https://phabricator.wikimedia.org/T307602 (10AnnWF) seems that we already have this detection if need tokenize before sending... [18:31:10] (03CR) 10Ejegg: "This looks really good! Just one question about the placement of the new files - for now I think they need to go in the existing gateway c" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [18:35:04] (03PS19) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [18:37:23] (03CR) 10jerkins-bot: [V: 04-1] Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [18:38:54] ejegg: wanna hash out the tiebreaker stuff before jumping into that? [18:39:32] actually [18:48:28] ejegg: I don't even think we need that cfg object [18:49:00] that $mwConfig->get() call ends up calling returning $GLOBALS[$prefix . $name] [18:49:21] we could cut out sending in anything and just call the $mwvar in the factory [18:49:43] and it's already test friendly as it's an old-skool mw global [18:56:55] jgleeson: right, the idea is to get away from using the old skool globals [18:57:32] so yeah, tiebreaker stuff [18:57:58] want to use the videochat for the next meeting to talk about that? [18:58:14] sure [18:58:20] fr-tech want to weigh in on a couple of different approaches to the form chooser tie breaker rules? [18:58:24] (03PS1) 10Wfan: wip: Regerate recurring token if null for audit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/790415 (https://phabricator.wikimedia.org/T307602) [18:58:37] https://meet.google.com/mkm-dptq-dqq [19:06:31] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Refactor gateway adapter to use mediawiki Config object to access globals - https://phabricator.wikimedia.org/T307955 (10Ejegg) [19:08:17] (03PS1) 10Wfan: WIP: need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) [19:08:44] (03CR) 10jerkins-bot: [V: 04-1] WIP: need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [19:12:19] (03PS20) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [19:12:23] (03PS2) 10Wfan: WIP: need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) [19:12:38] (03CR) 10jerkins-bot: [V: 04-1] WIP: need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [19:13:04] (03PS3) 10Wfan: WIP: need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) [19:19:38] (03CR) 10Damilare Adedoyin: Combined gateway countries and tests (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [19:25:55] (03CR) 10jerkins-bot: [V: 04-1] WIP: need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [19:31:07] (03CR) 10Wfan: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [19:44:04] 10Fundraising-Backlog, 10FR-Email: Confirmation needed for database update export job - https://phabricator.wikimedia.org/T307811 (10Eileenmcnaughton) @KHaggard it is not a big deal from our end to do it - so up to your availability [19:47:43] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10AndyRussG) Checking a few UA strings on [[ http://w... [19:53:08] 10Fundraising-Backlog: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10DStrine) [19:53:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10DStrine) [20:07:16] (03Abandoned) 10Ejegg: WIP - DO NOT MERGE - GC DD: SEPA compliance [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/145731 (owner: 10Katie Horn) [20:07:57] (03CR) 10Eileen: [C: 03+2] Add e-mail greeting to silverpop [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/788807 (https://phabricator.wikimedia.org/T305483) (owner: 10AndyRussG) [20:09:49] (03Merged) 10jenkins-bot: Add e-mail greeting to silverpop [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/788807 (https://phabricator.wikimedia.org/T305483) (owner: 10AndyRussG) [20:11:23] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/790420 [20:11:35] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/790420 (owner: 10Eileen) [20:22:34] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10DStrine) @Eileenmcnaughton just talked with @KHaggard and t... [20:23:51] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, and 2 others: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10KHaggard) Actually, due to T3078... [20:25:47] 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10XenoRyet) [20:27:12] 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10Dwisehaupt) [20:28:48] 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10DStrine) [20:30:33] katers: the file should be up there now [20:30:47] Thanks eileen ! working on it now [20:31:51] 10Fundraising-Backlog: Verbiage on payment page re S.A. national ID requirement - https://phabricator.wikimedia.org/T307743 (10DStrine) [20:34:11] 10Fundraising-Backlog: Smashpig recurring job (for Adyen at least) is saving the capture ID as the gateway transaction ID instead of the authorise ID - https://phabricator.wikimedia.org/T306944 (10Dwisehaupt) [20:36:13] 10Fundraising-Backlog: Smashpig recurring job (for Adyen at least) is saving the capture ID as the gateway transaction ID instead of the authorise ID - https://phabricator.wikimedia.org/T306944 (10Dwisehaupt) [20:40:45] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10Dwisehaupt) [20:41:35] Hi eileen I'm mapping now but I don't see the email_greeting field in the csv, so I can't map to it [20:41:45] oh dang [20:43:08] checking [20:49:25] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Automatic thank you email from Civi for Organization Contact Types - https://phabricator.wikimedia.org/T306556 (10Dwisehaupt) [20:50:22] katers: ok - I'm just trying a slightly longer job-will take an hour [20:50:35] just gotta go kick off the sprinkler for the turf brb [20:53:41] ok no problem! I'm around, so ping me when the file is up there :) thanks [21:01:02] (03CR) 10Jgleeson: [C: 03+1] "happy for +2 when ready" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [21:13:23] ejegg: I'll catch you tomorrow. if you wanna maybe port my tests over to your WIP and then we can try to carry it forward thst way. I'll see what shape it's in tomorrow and try to get it over the line ready for final review. [21:13:39] sounds good jgleeson [21:14:04] fr-tech sorry for being so bad with my EOD emails. I'm gonna try and get better starting from tomorrow! I always leave it too late in the day [21:14:06] bye for now [21:29:13] katers: it has finished [21:33:14] thanks I'll take a look [21:37:16] eileen I'm at the mapping portion again and I still can't find the email greeting column in the file [21:37:29] hmm [21:37:36] could there perhaps be more than one sitting in the FTP? [21:38:41] I can only see one "DatabaseUpdate-*" file at a time, so if there's multiple versions I can try cancelling a remapping again [21:39:04] I'm just looking to see - do you see the filename? [21:39:54] I see more than one on the server so maybe! [21:40:24] Oh ok I will cancel out and see if when I try again it will pop up. If not it might wipe out the folder on FTP [21:40:58] I can't see the file name unfortunately, but it did pick up a file. I think it goes oldest to newest [21:41:22] ok - I think there may well be multiple files there [21:52:09] Ah ok eileen, it looks like there was an extra May 9th file for some reason that was blocking me from seeing the new mapping file. Unfortunately Acoustic ran DatabaseUpdate-20220509211631.csv [21:52:38] katers: ok - so do you need another file pushed up? [21:52:46] which I think was the file I needed to map but it's gone now :( [21:53:11] yes could you please add it back to the folder? [21:53:41] sorry about that [21:55:44] ok - I'm just not sure if it will send up the file you don't want again - if dwisehaupt turns up he can delete them from the server - cos at the moment we still have the one without the mapping on the server [21:56:22] oh really? strange I wonder if I click 'run' over and over again it will clear it out [21:56:58] katers: I think the problem is that the first time I told you it had updated & it hadn;t - that file won't be naturally deleted until tomorrow [21:58:15] Oh ok, yeah on my side it's now saying that FTP is empty [21:59:42] Do we wanna try anyway while waiting for dwisehaupt ? [21:59:53] I can push it again & we can see! [22:00:11] ok lets do it! [22:02:48] ok - first file is up [22:03:10] maybe if you try while the next is still getting there that is good? [22:03:32] actually it looks like *maybe* only the latest went up [22:04:08] Oh ok im trying it out now [22:13:21] howdy, sorry, was eating a late lunch and getting the dog outside. [22:13:32] need me to delete a file? [22:14:08] I found it in the mapping file! I think we're good for now dwisehaupt thanks! [22:14:11] dwisehaupt: not sure - but if you delete the csvs in /var/lib/silverpop_export then if we need to try again we can [22:14:21] oh katers maybe sorted it? [22:14:35] Yeah I found it so I'm just doing the mapping part now [22:14:39] cool [22:15:13] ok cool. well, if you need me, i'm still here for a few hours. [22:15:44] thanks [22:16:06] katers: on the failing-from-last-week issue - that was failing at your end not ours wasn't it? [22:16:30] (just trying to decide how much I need to regenerate) [22:24:17] ok I finished mapping and it's processing the file now [22:24:54] cool [22:25:37] eileen from what I understand, it seems like there was fail mail that caused the failures but after it was fixed Moska was having trouble with Acoustic's UI [22:26:29] I'm not sure I fully understand what happened last week but I don't think we needed to remap at all last week but she tried to [22:34:45] ok it looks like DatabaseUpdate-20220509211631.csv ran succesfully and the summary report looks normal eileen [22:37:56] so I think we might be set to send up the big one whenever you're ready [22:42:58] katers: ok - - it will take about 40 mins to get there [22:43:15] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) [22:44:17] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) CiviCRM accounts created and information sent regarding the setup and password reset procedure. A copy of the setup email also stored in the project vault. [22:53:33] 10fundraising-tech-ops: monitor expiration of fundraising puppet CA and client certs - https://phabricator.wikimedia.org/T307476 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Have adjusted where we are looking for the certs on disk and this is now in place and working. Commits: ` 35d519c0 Change nagios... [23:10:57] thanks!