[00:01:44] katers: the full file is up now [00:06:51] thanks! I'll try running it now [01:26:09] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10Eileenmcnaughton) Per comments above - we checked in with @... [01:39:11] Ok it took a while but the job finished! Looks like it was successful [01:39:15] I'll update the ticket [01:41:05] yay [01:51:45] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10KHaggard) We ran the big file an... [01:56:29] 10Fundraising-Backlog, 10FR-Email: Confirmation needed for database update export job - https://phabricator.wikimedia.org/T307811 (10KHaggard) 05Open→03Resolved a:03KHaggard Confirming here that we ran a full database overwrite today, so everyone in the _all_Wikimedia database is fully up-to-date now. Po... [01:57:59] thanks for collaborating on this with me eileen ! [01:58:15] thanks for sorting it ! [01:59:05] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10KHaggard) I'm just going to make... [02:39:33] (03PS1) 10Eileen: Expand access to Acoustic data in CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790458 (https://phabricator.wikimedia.org/T305505) [02:39:52] I just put up a pretty small patch that might be a quick review ^^ [03:44:11] (03CR) 10Ejegg: [C: 03+1] "I'm inclined to +2 this because the tests look really good, but there are still a bunch of countries mentioned in DonationInterfaceFormSet" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [03:44:32] looking eileen [03:45:44] eileen: what's the difference between 'check' and 'default' in that permissions key? [03:51:41] ejegg: so I am not sure why check was there but I suspect that I originally had an action of 'check' [03:51:54] & so it was doing nothing at all & falling back to 'Administer' [03:52:34] oh i see [03:53:12] (03CR) 10Ejegg: [C: 03+2] Expand access to Acoustic data in CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790458 (https://phabricator.wikimedia.org/T305505) (owner: 10Eileen) [03:53:20] thanks! [03:53:24] yw! [03:56:17] (03PS19) 10Ejegg: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [03:57:40] (03CR) 10Ejegg: [C: 03+2] "Great test! And it's a pretty good list of cases. We can add google pay and maybe more recurring variants in a follow-on. Thanks, WFan!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [04:00:01] (03Merged) 10jenkins-bot: Test cases for all available gateway from form chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/787512 (https://phabricator.wikimedia.org/T302891) (owner: 10Wfan) [04:01:44] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, and 2 others: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10Eileenmcnaughton) @SHust I've put out a patc... [04:05:45] (03Merged) 10jenkins-bot: Expand access to Acoustic data in CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790458 (https://phabricator.wikimedia.org/T305505) (owner: 10Eileen) [04:19:54] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/790464 [04:20:07] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/790464 (owner: 10Eileen) [04:33:39] !log revision changed from 852c1969 to 6d85f1cc [04:33:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [09:04:31] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10RKumar_WMF) The test donations were made in March and April. CID: 54914851 and 54911284. [11:51:31] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/324066 (owner: 10Hashar) [13:12:18] PROBLEM - check_mysql on frdb1002 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [13:12:38] this is me ^^^ restarting mariadb on frdb1002 [13:27:16] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 880 Threads: 10 Questions: 527197 Slow queries: 0 Opens: 2604812 Flush tables: 1 Open tables: 200 Queries per second avg: 599.087 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4881 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [13:33:37] (03PS21) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [13:36:58] (03PS22) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [13:37:17] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1921 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [13:39:48] (03PS23) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [13:41:52] (03CR) 10jerkins-bot: [V: 04-1] Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [13:42:11] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 1780 Threads: 10 Questions: 2036905 Slow queries: 0 Opens: 4263945 Flush tables: 1 Open tables: 200 Queries per second avg: 1144.328 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [13:43:26] (03PS24) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [13:47:21] (03CR) 10Damilare Adedoyin: "Thanks Elliot, I made some updates." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [13:52:56] howdy fr-tech! [14:05:10] (03PS25) 10Damilare Adedoyin: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) [14:37:26] 10Fundraising-Backlog, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10spatton) Hi @Sharvaniharan! TY so much for your work on this. I just realized tha... [14:58:51] 10Fundraising-Backlog, 10fundraising-tech-ops: Help me set up ssh access on a new machine - https://phabricator.wikimedia.org/T307930 (10spatton) Hi, following up with my public key as requested: ` ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDLwrLj8PGQT9oEBdNsW61X4qezoMqr/tgK097ei1mUzYxWYDd/M1gDrjqxrktdkdpNhaJrnVg... [15:11:04] (03PS26) 10Wfan: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [15:11:12] 10Fundraising-Backlog, 10fundraising-tech-ops: Help me set up ssh access on a new machine - https://phabricator.wikimedia.org/T307930 (10Jgreen) a:03Jgreen [15:41:54] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) @Ejegg This task was created on April 18th so I assume it would be a donation before that date. Both CIDs have donations from before this task. @RKumar_WMF could you tell u... [15:45:41] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade pfw to Junos 20+ - https://phabricator.wikimedia.org/T295691 (10Papaul) @Cmjohnson @Jclark-ctr I upload the junos-srxsme-20.1R1.11.tgz to apt.wikimedia.org under /srv/junos . if you have time this week can you please copy that i... [15:58:19] ejegg|away: I'm combining those tiebreaker patches. I noticed 'chooseGatewayByPriority' is not static. Is that intentional? [15:59:15] I guess it is as we're calling instances methods inside it [15:59:20] instance* [16:00:30] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade pfw to Junos 20+ - https://phabricator.wikimedia.org/T295691 (10Papaul) @Cmjohnson @Jclark-ctr the right image is junos-srxentedge-x86-64-20.4R3-S1.3.tgz and not junos-srxsme-20.1R1.11.tgz since codfw is using junos-srxentedge... [16:04:07] ejegg|away: get back to me on that one as I can't see any code instantiating GatewayFormChooser and it looks like the current pattern is to use it statically. ironically there is a constructor with some stuff going on but I can't see it used anywhere [16:05:48] thanks wfan for the rebase [16:07:18] oh it's a specialpage! so mw probably instantiates it in the internal when browsed too [16:07:39] ok I'll keep it as an instance method for now and we can change if needed [16:08:10] Ha, np, I actually get some yaml file permission deny error for the new test u have added, but ur patch did pass overall, so I am not plus 2 yet but look good~ [16:38:11] ohh that's interesting, you'd probably need to grant some additional permissions [16:38:37] 10Fundraising-Backlog: Ecuador Fraud needing blocking - https://phabricator.wikimedia.org/T308040 (10EMartin) [16:40:14] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) Both contributions on CID: 54914851 looks like they got the LATAM email template. CID 54911284 has one contribution and it too looks like it got the LATAM email. Im basing... [16:49:07] jgleeson: GatewayFormChooser is a special page, so it is instantiated by the MediaWiki framework [16:49:16] ah yeah [16:49:27] sorry, hadn't read all the way to the bottom before replying [16:56:41] no worries [16:59:17] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade pfw to Junos 20+ - https://phabricator.wikimedia.org/T295691 (10Papaul) @Jgreen hello. I am planning on doing this on the 16th at 10:00am CT . let me know it time works for you. Thanks [17:12:04] AndyRussG: think you'll have a chance to look back over those updated patches in the next couple hrs? [17:13:53] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks great!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:15:24] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: donor's preferred language should be updated by the latest donation. - https://phabricator.wikimedia.org/T308043 (10DStrine) [17:16:34] (03Merged) 10jenkins-bot: Combined gateway countries and tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789192 (https://phabricator.wikimedia.org/T302923) (owner: 10Damilare Adedoyin) [17:18:32] fr-tech anyone up for a last review push before end of sprint? [17:18:39] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/788894 [17:18:50] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/785963 [17:18:54] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/789730 [17:18:59] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/788895 [17:19:27] oh, that last one is already +2ed, just waiting for the parent to merge [17:19:39] or rather, waiting for CR on the parent [17:20:39] ejegg: yep just relocating [17:21:05] thanks! [17:21:16] 10Fundraising-Backlog: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) 05Open→03Declined Per @Ejegg the initial donations on these contacts got set to ES and subsequent donations did not update the language. That is worth investigating here... [17:26:10] (03PS1) 10Ejegg: Set Latin American Spanish as default Spanish locale [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790726 (https://phabricator.wikimedia.org/T306356) [17:27:29] dstrine another simple fix ^^^ - default to es_MX rather than es_ES for any es_?? where the template doesn't exist. Oughtta be the right default >90% of the time [17:28:46] oh hmm, maybe that fallback doesn't actually get hit either? looking [17:40:07] (03CR) 10jerkins-bot: [V: 04-1] Set Latin American Spanish as default Spanish locale [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790726 (https://phabricator.wikimedia.org/T306356) (owner: 10Ejegg) [17:43:12] 10Fundraising-Backlog, 10fundraising-tech-ops: Help me set up ssh access on a new machine - https://phabricator.wikimedia.org/T307930 (10Jgreen) 05Open→03Resolved Done. @spatton please reopen the task if you have any trouble with ssh access. [18:01:59] ejegg: there's some responses to you and AndyRussG on the first one [18:02:25] oh thanks jgleeson, sorry I didn't notice [18:06:42] (03CR) 10AndyRussG: [C: 03+1] Factory method for ConfigurationReader (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [18:07:11] jgleeson: if you'd like to do the honors on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/788894 pls don't hold back :) [18:08:21] all my concerns have been resolved but I didn't fully get to looking at all the code myself, so yeah, pls go ahead if you'd like to push it over the edge, and thx much for checking! :) [18:08:49] ejegg: on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/785963 my concern was that the static rates file, which i think the conversions depend on, might cause inaccurate min warnings if rates move. I noticed you had tests and wanted to debug through them fist to confirm this isn't a risk but haven't had chance [18:09:57] jgleeson ahh yeah, that BBD is a currency which is actually pegged to $0.50 [18:10:01] go for it AndyRussG [18:10:03] very handy for tests :) [18:10:16] jgleeson I'm not ready to do so myself since I haven't looked at all the code [18:10:28] so far it hasn't changed and broken tests [18:10:36] ha pegged. nice [18:10:47] np AndyRussG [18:10:49] but if Barbados changes their monetary policy we'll find out about it from Jenkins [18:11:05] LOL [18:11:21] or rather on that one sorry I did look at all the code, but I didn't smoke test the variant thing [18:11:34] the one I didn't look at the tests on rather is the min currency one [18:12:33] looks like we won't be doing any currency tests in the future on crypto stable coins [18:12:50] (pegged) [18:13:26] (03CR) 10Jgleeson: [C: 03+2] Factory method for ConfigurationReader [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [18:13:46] (03CR) 10AndyRussG: Allow specifying min/max amount in any currency (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [18:14:26] I'm mostly avoiding https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/785963 since it's not in the sprink [18:14:55] (03CR) 10Jgleeson: [C: 03+2] "retry" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788895 (https://phabricator.wikimedia.org/T302892) (owner: 10Ejegg) [18:15:38] jgleeson: ^ suggest u retry that with "resubmit" [18:15:44] (03Merged) 10jenkins-bot: Factory method for ConfigurationReader [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788894 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [18:15:46] (03Merged) 10jenkins-bot: Remove unused getBasedir function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/788895 (https://phabricator.wikimedia.org/T302892) (owner: 10Ejegg) [18:15:54] thanks! [18:15:56] oh that wokred! [18:16:27] ejegg: does this depend on the min/max one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/789730 [18:16:29] (03PS9) 10Ejegg: Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) [18:17:15] jgleeson: you can pull that down in fundraising-dev before pulling down the matching D-I patch and it shouldn't break anything [18:17:25] AndyRussG: now I'm thinking I usually type 'Recheck' [18:17:28] in fact, it's better to pull down the fr-dev config patch first [18:17:40] jgleeson yep, recheck is the usual magic word [18:17:48] ejegg: are there other things to push through that are actually in the sprint? [18:17:53] but resubmit I think works better if things get stuck [18:18:10] AndyRussG: we still need to agree on the rule for gateway tiebreakers [18:18:22] jgleeson and I both have patches with different approaches [18:18:24] and retry for a surprise third option [18:18:38] hmmm [18:18:39] ejegg: I'm in the middle of combining both approaches [18:18:42] need to break the tiebreaker tie [18:18:43] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/789731 vs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/789675 [18:18:46] and gettin the tests to work [18:18:52] heh exactly AndyRussG [18:18:55] as mentioned yesterday [18:18:55] oki thx [18:19:24] oh cool jgleeson [18:20:00] that's why i was asking about the static/instance stuff for GatewayFormChooser. The tests were complaining as it was previously accessed statically [18:20:36] lemme abandon the scoring one [18:21:23] (03Abandoned) 10Jgleeson: WIP: Create rules for gateway tiebreaking based on querystring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789675 (https://phabricator.wikimedia.org/T302935) (owner: 10Jgleeson) [18:24:23] fr-tech should we standardise on either gateway or processor when referring to payment processors in DI going forward? [18:24:42] In DI it's pretty heavily skewed towards 'gateway' [18:24:45] it looks like smashpig uses processors and DI uses gateway to mean the same thing [18:24:50] maybe stick with that in DI [18:25:00] when in fact a Payment Gateway is just a name for a hosted payments page [18:25:01] and then if we really want to later on we can change it all at once? [18:25:11] and processor is the 'ingenico' [18:25:41] sounds good ejegg, gateway in DI [18:25:59] although when we instantiate smashpig code in DI we use processor language [18:26:03] jgleeson: yeah, I think especially for formChooser, since we accept the param 'gateway' from the banners etc [18:26:12] which I guess is fine [18:26:41] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/790738 [18:26:57] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/790738 (owner: 10Ejegg) [18:27:39] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/790738 (owner: 10Ejegg) [18:30:17] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/790739 [18:30:26] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/790739 (owner: 10Ejegg) [18:40:26] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/790739 (owner: 10Ejegg) [18:42:02] hmmm the multi rule scenario is failing tests [18:42:39] ejegg: did you expect rules with multiple conditions to look like this [18:42:40] 'conditions' => [ 'payment_method' => 'cc', 'utm_medium' => 'endowment' ], [18:42:42] 'processors' => [ 'adyen' ] [18:43:17] lemme push up what I've added [18:45:10] (03PS4) 10Jgleeson: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [18:45:22] (03CR) 10jerkins-bot: [V: 04-1] Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [18:47:22] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10AndyRussG) I searched some recent logs for "Client... [18:47:45] oh I see what it might be [18:48:02] DonationInterfaceGatewayPriorityRules and wgDonationInterfaceProcessorPriorityRules [18:48:18] let's fix that [18:49:48] fr-tech just moved https://phabricator.wikimedia.org/T305603 into review... if anyone wants to glance at the conclusions in the last comment and, if appropriate, move it to "Done", that might be fun :) [18:51:50] Fr-tech I'm going to be a little bit late to sprint planning [18:51:55] (03PS5) 10Jgleeson: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [18:52:33] (03CR) 10jerkins-bot: [V: 04-1] Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [18:56:01] jgleeson: yep, that would be the multiple condition format [18:56:32] (03PS6) 10Jgleeson: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [18:56:54] ok those two tests for single and multi rule scenarios are now passing locally [18:56:59] awesome [18:58:36] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10KHaggard) 05Open→03Resolved... [18:59:08] maybe a couple more tests to confirm what it shouldn't do [18:59:18] but they could be a follow on [19:01:08] ~log updated payments-wiki from af621bad to c5be9c5d [19:01:12] !log updated payments-wiki from af621bad to c5be9c5d [19:01:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:01:19] AndyRussG: those conclusions look good to me on your ticket [19:01:32] and yep we do have some clientSideError.api thingy in DI [19:01:39] if that's what you meant [19:01:46] fr-tech also might be a 5 minutes late or so [19:01:53] I'll move it to done [19:01:59] jgleeson: cool! thx! [19:02:03] unless you wanted a wider audience [19:02:06] cool cool [19:03:15] yeah I meant some failmail or something if there are a lot of errors all at once [19:04:05] ah, maybe icinga could look at that? [19:07:59] jgleeson: if u agree I do think moving it to done would be great :) [19:08:05] thx!!! [19:08:09] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, and 2 others: Unit tests for Form Chooser - https://phabricator.wikimedia.org/T302891 (10DStrine) 05Open→03Resolved [19:08:11] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10Epic: Epic: chooser refactor - https://phabricator.wikimedia.org/T301797 (10DStrine) [19:09:12] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10Epic: Epic: chooser refactor - https://phabricator.wikimedia.org/T301797 (10DStrine) [19:09:14] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, and 2 others: Add supported country lists to gateway config - https://phabricator.wikimedia.org/T302923 (10DStrine) 05Open→03Resolved [19:09:32] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.12; 2022-05-16): Add flag for recurring to payment_methods.yaml entries - https://phabricator.wikimedia.org/T306151 (10DStrine) 05Open→0... [19:09:57] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog: Set India's minimum donation amount to $.65 USD - https://phabricator.wikimedia.org/T307942 (10DStrine) 05Open→03Resolved [19:10:21] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-Docker: Add ability to create and see failmail in Docker - https://phabricator.wikimedia.org/T305977 (10DStrine) 05Open→03Resolved [19:10:23] 10Fundraising-Backlog, 10FR-Docker, 10Epic: Epic: feature parity with vagrant on docker - https://phabricator.wikimedia.org/T262971 (10DStrine) [19:11:38] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog: Acoustic needs FTP file for recurring import - https://phabricator.wikimedia.org/T307597 (10DStrine) 05Open→03Resolved [19:12:51] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Civi Message Template dynamic content is not populating currency code correctly - https://phabricator.wikimedia.org/T306576 (10DStrine) 05Open→03Resolved [19:13:43] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, and 2 others: Remove unused imports / handling - https://phabricator.wikimedia.org/T286225 (10DStrine) 05Open→03Resolved [19:15:26] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10Patch-For-Review: Increase failure tolerance for Paypal IPN API endpoint - https://phabricator.wikimedia.org/T305553 (10DStrine) 05Open→03Resol... [19:17:41] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, and 3 others: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10DStrine) [19:17:44] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Refactor ConfigurationReader - https://phabricator.wikimedia.org/T305152 (10DStrine) 05Open→03Resolved [19:19:10] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint e^🥧👀=yum, 10Fundraising-Backlog, and 3 others: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (10DStrine) 05Open→03Resolved [19:19:22] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10Epic: Epic: chooser refactor - https://phabricator.wikimedia.org/T301797 (10DStrine) [19:19:25] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10FR-form-chooser-refactor, and 2 others: Move PayPal and Adyen to folders based on gateway code - https://phabricator.wikimedia.org/T302892 (10DStrine) 05Open→03Resolved [19:20:41] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Adyen audit is failing by timing out - https://phabricator.wikimedia.org/T306194 (10DStrine) 05Open→03Resolved [19:21:40] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, 10MediaWiki-extensions-DonationInterface: Debug payments-wiki javascript with Safari - https://phabricator.wikimedia.org/T305603 (10DStrine) 05Open→03Resolved [19:29:54] 10Fundraising Sprint High velocity swallows, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Genealogical theory of relativity, 10FR-Email: Importing the Email Greeting field from Civi to Acoustic - https://phabricator.wikimedia.org/T305483 (10RLewis) Thank you so much for th... [20:28:43] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10Eileenmcnaughton) [20:39:07] 10Fundraising-Backlog: Fix Recurring SmashPig Processor IDs (I'll write a better name) - https://phabricator.wikimedia.org/T308064 (10Cstone) [20:45:11] 10Fundraising-Backlog: Fix the Adyen Recurring SmashPig Processor so it saves the Authorize ID instead of the Capture ID as the Transaction ID - https://phabricator.wikimedia.org/T308064 (10Cstone) [20:45:40] 10Fundraising Sprint I 2022, 10Fundraising-Backlog: Fix the Adyen Recurring SmashPig Processor so it saves the Authorize ID instead of the Capture ID as the Transaction ID - https://phabricator.wikimedia.org/T308064 (10DStrine) [20:45:44] 10Fundraising Sprint I 2022, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10DStrine) [20:45:46] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10DStrine) [20:45:49] 10Fundraising Sprint I 2022, 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10DStrine) [20:45:52] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Client-side errors on Adyen ResultSwitcher due to missing config - https://phabricator.wikimedia.org/T307485 (10DStrine) [20:45:58] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10DStrine) [20:46:04] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Front-end calls to charge one-time donation via Braintree - https://phabricator.wikimedia.org/T303419 (10DStrine) [20:46:10] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor fail page logic - https://phabricator.wikimedia.org/T302938 (10DStrine) [20:46:16] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor & rename FormChooser::getOneValidForm - https://phabricator.wikimedia.org/T302936 (10DStrine) [20:46:20] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig, 10Patch-For-Review: Implement createClientToken mutation in Braintree GraphQL API - https://phabricator.wikimedia.org/T302948 (10DStrine) [20:46:24] 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig, 10Patch-For-Review: Establish basic communication with Braintree GraphQL API - https://phabricator.wikimedia.org/T302946 (10DStrine) [20:46:28] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Sprint Goal: small tasks then form chooser - https://phabricator.wikimedia.org/T305987 (10DStrine) [20:46:32] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint I 2022, 10Fundraising Sprint e^🥧👀=yum, and 2 others: Set valid Callback URL on DLocal Sandbox - https://phabricator.wikimedia.org/T303974 (10DStrine) [20:46:36] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10DStrine) [20:46:40] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint I 2022, and 4 others: Syn group to Acoustic should remove any existing queues before creating a new one - https://phabricator.wikimedia.org/T306855... [20:46:44] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Convert offline2civicrm to a drupal module - https://phabricator.wikimedia.org/T270669 (10DStrine) [20:46:48] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Cheese String Theory, and 42 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10DStrine) [20:46:54] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint I 2022, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, and 3 others: Create rules for gateway tiebreaking based on querystring - https://phabricator.wikimedia.org/T302935 (10DStrine) [21:16:33] (03CR) 10Jgleeson: [C: 03+1] "Happy to +2" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [21:27:26] bye for now fr-tech [22:45:24] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor & rename FormChooser::getOneValidForm - https://phabricator.wikimedia.org/T302936 (10AndyRussG) a:03AndyRussG [23:02:28] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Simplify FormChooser::buildPaymentsFormURL - https://phabricator.wikimedia.org/T302944 (10Ejegg) Discussing in Tech Talk we've realized it might make sense to do this in two parts - 1) Create a simplified version to... [23:28:32] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) [23:29:13] 10fundraising-tech-ops, 10Security-Team: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10Dwisehaupt) 05Open→03Resolved Verified dvargas has logged in successfully to each account. Closing.