[00:45:03] (03PS1) 10Ejegg: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) [00:46:53] (03CR) 10jerkins-bot: [V: 04-1] Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) (owner: 10Ejegg) [00:52:00] (03PS2) 10Ejegg: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) [00:53:33] ah dang, US cc form is showing Visa twice [00:53:58] (03CR) 10jerkins-bot: [V: 04-1] Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) (owner: 10Ejegg) [00:54:00] fr-tech I'm going to see if there's a quick roll-forward fix [00:54:07] and if not I'm going to roll back [00:54:57] ohhhh [00:55:01] i see [00:55:16] the visa-electron thing [00:56:25] so because of Dami's new test we can't filter it out with a bogus country list [00:57:16] oh, we CAN use an empty arry [00:57:18] *array [01:00:34] (03PS1) 10Ejegg: Re-hide extra Visa logo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790781 [01:01:12] fr-tech can anyone do a quick review of that? It's to fix a visual ugliness (extra Visa logo) on all Ingenico forms that's currently in production. [01:03:58] hmm I can look in 1.5 hrs about [01:04:15] Code looks good to me, but I'm not set up to smoke test it. [01:04:25] ok, I think I might just self-merge as it's just a yaml change [01:04:37] technically I could do it as a config deploy I guess [01:04:49] If you tell me it looks fine, I'll believe you and I can +2 [01:05:01] well, it looks good locally [01:05:27] fr-tech smol nag, don't forget to read draft communication guidelines ahead of meeting :) [01:05:28] (03CR) 10XenoRyet: [C: 03+2] Re-hide extra Visa logo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790781 (owner: 10Ejegg) [01:05:28] and it has the same logical effect as the list that only included XX, removed today [01:05:39] thanks XenoRyet [01:05:42] No worries [01:05:43] thanks for the reminder AndyRussG [01:05:47] Like you said, simple one. [01:06:48] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/790783 [01:06:59] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/790783 (owner: 10Ejegg) [01:07:33] (03Merged) 10jenkins-bot: Re-hide extra Visa logo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790781 (owner: 10Ejegg) [01:07:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/790783 (owner: 10Ejegg) [01:08:03] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/790784 [01:08:06] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/790784 (owner: 10Ejegg) [01:16:43] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/790784 (owner: 10Ejegg) [01:32:50] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Use ReferenceData to decode Ingenico submethods - https://phabricator.wikimedia.org/T308088 (10Ejegg) [01:33:20] !log updated payments-wiki from c5be9c5d to f06e390b [01:33:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:34:19] ok, forms back to normal [01:34:21] thanks again! [01:35:28] (03PS1) 10Ejegg: Use ReferenceData to decode Ingenico submethods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790788 (https://phabricator.wikimedia.org/T308088) [01:35:57] and I think that's the non-hacky solution, for whenever we find time to prioritize reviewing it ^^^ [01:46:46] (03PS7) 10Ejegg: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) [01:46:48] (03PS3) 10Ejegg: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) [01:53:51] (03PS1) 10Ejegg: Stop overwriting countries files when running tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790789 [01:55:47] (03CR) 10jerkins-bot: [V: 04-1] Stop overwriting countries files when running tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790789 (owner: 10Ejegg) [01:57:30] (03PS2) 10Ejegg: Stop overwriting countries files when running tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790789 [01:59:16] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor & rename FormChooser::getOneValidForm - https://phabricator.wikimedia.org/T302936 (10Ejegg) @AndyRussG here's a patch with a simplified URL-building function... [02:08:43] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Create skeleton braintree adapter + config - https://phabricator.wikimedia.org/T302947 (10Ejegg) [06:14:04] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790926 (owner: 10L10n-bot) [06:31:21] (03PS2) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790926 (owner: 10L10n-bot) [06:31:26] (03CR) 10Raimond Spekking: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790926 (owner: 10L10n-bot) [07:23:14] 10WMSE-Content-partnerships-support-2021-Fundraising, 10WMSE-Association-Involvement-2022, 10User-Eric_Luth_WMSE: Develop systems for registering volunteer engagement and interests - https://phabricator.wikimedia.org/T261834 (10JosefineHellrothLarssonWMSE) [08:39:52] (03CR) 10Raimond Spekking: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790926 (owner: 10L10n-bot) [09:12:35] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: NGOs market research salary and conversion (direct debit to volunteers) F2F - https://phabricator.wikimedia.org/T257155 (10Jenny_Brandt_WMSE) Comparison has been made, results can be found here: [[ https://docs.google.com/document/... [09:15:26] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: NGOs market research salary and conversion (direct debit to volunteers) F2F - https://phabricator.wikimedia.org/T257155 (10Jenny_Brandt_WMSE) Conversions rates is difficult to get numbers on, and I will instead look at fundraising... [09:25:19] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Pick a CRM donation management software systems for the F2F campaign 2022 - https://phabricator.wikimedia.org/T281683 (10Jenny_Brandt_WMSE) [] Set up a list with all the suppliers that have been contacted - with structured notes to... [10:31:42] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10Damilare) a:03Damilare [12:10:48] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10CDenes_WMF) Hi! Adding on that pt-BR is having the same behavior: [[ https://civicr... [12:41:36] (03CR) 10Jgleeson: [C: 03+2] Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [12:42:09] damilare: I moved our call our 15 mins but I'm around now if you wanna start [12:42:26] sorry for the short notice. lunch took longer than I'd hoped to cook [12:42:53] 10Fundraising-Backlog, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10Jgiannelos) 05Open→03Resolved This is already deployed in production [12:44:24] (03Merged) 10jenkins-bot: Allow specifying min/max amount in any currency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/785963 (https://phabricator.wikimedia.org/T302922) (owner: 10Ejegg) [12:45:50] ohh np jgleeson, I'm on the call [12:54:12] (03CR) 10Hashar: "check experimental" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/787694 (https://phabricator.wikimedia.org/T307178) (owner: 10Hashar) [13:08:08] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "This works for me and is a dependency for Ia044c85c600d013f1a77e3f23eb71ab42e0519b3 so I'm +2ing it to remove errors for anyone who pulls " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789730 (https://phabricator.wikimedia.org/T307880) (owner: 10Ejegg) [13:31:15] 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CiviCRM CI jobs fails when migrating from Stretch to Bullseye - https://phabricator.wikimedia.org/T307178 (10hashar) I have deployed an experimental job which uses a Bullseye image and triggered it on https://gerrit... [14:05:20] 10fundraising-tech-ops, 10Security-Team, 10SecTeam-Processed: Fundraising access request for dvargas@bishopfox.com - https://phabricator.wikimedia.org/T307746 (10sbassett) [14:28:24] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: WMSE/ WMCH - https://phabricator.wikimedia.org/T308140 (10Jenny_Brandt_WMSE) [14:28:37] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: WMSE/ WMCH CRM Salesforce - https://phabricator.wikimedia.org/T308140 (10Jenny_Brandt_WMSE) [14:45:46] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Salesforce trial period - https://phabricator.wikimedia.org/T308148 (10Jenny_Brandt_WMSE) [14:50:50] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Salesforce trial period - https://phabricator.wikimedia.org/T308148 (10Jenny_Brandt_WMSE) Waiting for respons from Salesforce contact regarding the following questions: Vad är villkoren för trial-perioden. Är det någon typ av upp... [15:20:20] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Fix the Adyen Recurring SmashPig Processor so it saves the Authorize ID instead of the Capture ID as the Transaction ID - https://phabricator.wikimedia.org/T308064 (10Cstone) a:03Cstone [15:30:54] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor fail page logic - https://phabricator.wikimedia.org/T302938 (10AnnWF) a:03AnnWF [15:36:04] 10Fundraising-Backlog, 10Patch-For-Review: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10CDenes_WMF) Hi David, RE: > Im basing this off of the fact the LATAM email starts with ¡Hola and the valencian starts with Benvolgut/Benvolguda The mix up is *... [15:36:59] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Prepare presentation for board meeting on F2F - https://phabricator.wikimedia.org/T308156 (10Jenny_Brandt_WMSE) [15:40:10] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: PM Insamling - https://phabricator.wikimedia.org/T308157 (10Jenny_Brandt_WMSE) [15:43:20] hi fr-tech! is anyone else getting issues with ssh Gerrit interactions? [15:43:34] I'm getting some permission denied stuff since updating my laptop last night [15:46:54] let me try AndyRussG [15:48:05] an unhelpful it works for me AndyRussG [15:50:14] (03PS8) 10Jgleeson: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [15:51:36] catch you all in tech-talk! bye for now [15:53:12] (03CR) 10jerkins-bot: [V: 04-1] Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [15:55:28] cstone: thanks!! found it [15:55:40] https://confluence.atlassian.com/bitbucketserverkb/ssh-rsa-key-rejected-with-message-no-mutual-signature-algorithm-1026057701.html [15:57:21] (03PS4) 10AndyRussG: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) (owner: 10Ejegg) [15:57:39] ejegg|away: just rebased https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/790779 on top of most recent parent [16:00:54] (03CR) 10jerkins-bot: [V: 04-1] Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) (owner: 10Ejegg) [16:02:57] 10Fundraising-Backlog, 10Patch-For-Review: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10DStrine) Yeah @Ejegg corrected me on that. I still don't see a bug here with initial donations if the person is using the right links in the right country. Ell... [16:06:15] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Create skeleton braintree adapter + config - https://phabricator.wikimedia.org/T302947 (10DStrine) p:05Triage→03Medium [16:06:35] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10DStrine) p:05Triage→03Medium [16:06:42] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Verbiage on payment page re S.A. national ID requirement - https://phabricator.wikimedia.org/T307743 (10DStrine) p:05Triage→03High [16:06:51] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10DStrine) p:05Triage→03High [16:06:59] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10DStrine) p:05Triage→03Medium [16:07:08] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Client-side errors on Adyen ResultSwitcher due to missing config - https://phabricator.wikimedia.org/T307485 (10DStrine) p:05Triage→03Medium [16:07:19] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Front-end calls to charge one-time donation via Braintree - https://phabricator.wikimedia.org/T303419 (10DStrine) p:05Triage→03Medium [16:07:33] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig, 10Patch-For-Review: Implement createClientToken mutation in Braintree GraphQL API - https://phabricator.wikimedia.org/T302948 (10DStrine) p:05Triage→03Medium [16:07:43] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig, 10Patch-For-Review: Establish basic communication with Braintree GraphQL API - https://phabricator.wikimedia.org/T302946 (10DStrine) p:05Triage→03Medium [16:07:46] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor & rename FormChooser::getOneValidForm - https://phabricator.wikimedia.org/T302936 (10DStrine) p:05Triage→03Medium [16:08:04] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Fix the Adyen Recurring SmashPig Processor so it saves the Authorize ID instead of the Capture ID as the Transaction ID - https://phabricator.wikimedia.org/T308064 (10DStrine) p:05Triage→03Medium [16:08:07] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor fail page logic - https://phabricator.wikimedia.org/T302938 (10DStrine) p:05Triage→03Medium [16:08:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10DStrine) p:05Triage→03Medium [16:08:44] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Sprint Goal: form chooser brain tree - https://phabricator.wikimedia.org/T305987 (10DStrine) [16:52:39] 10Fundraising-Backlog: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) [17:06:12] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with Payment method not found - https://phabricator.wikimedia.org/T308166 (10Ejegg) [17:08:17] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10Ejegg) [17:09:09] dstrine we might want to pull those two into sprint ^^^ some donations are not going through for what seem to be problems with our calls. [17:09:39] For that 'Payment method not found' we might want to add more logging first as it's hard to tell what we're sending [17:09:53] oh, I guess I can turn on debug logging for dlocal [17:11:47] (03PS9) 10Ejegg: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) [17:12:10] (03PS10) 10Ejegg: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) [17:13:14] (03PS5) 10Ejegg: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) [17:13:54] damilare now that we've got those yaml files written I think we can take this bit out of the tests, right? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/790789/1 [17:14:23] (03CR) 10Damilare Adedoyin: [C: 03+2] Stop overwriting countries files when running tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790789 (owner: 10Ejegg) [17:14:28] thanks! [17:15:11] certainly ejegg [17:18:29] hi jgleeson I just adjusted the spacing on that tiebreaker patch to make jenkins happy [17:18:36] thanks for catching the array issue! [17:18:58] oh cool thanks ejegg [17:19:19] yeah I need to change my alias for git-review to run composer test beforehand [17:19:25] I always forget to run it [17:29:30] ejegg: is there any value in testing the scenario of competing rules? I was thinking at first maybe but now I think maybe not since the code will stop at the first condition(s) is matches [17:30:15] sure, you could add a test to verify that it does indeed stop at the first one! [17:32:16] Also whilst we're on the subject. Are we gonna have to stick to a convention of adding the the multi-condition rules top the $mgVar to avoid a broad rules being returned in all cases [17:32:33] ah yeah, good idea [17:32:48] to the top* [17:39:42] (03Merged) 10jenkins-bot: Stop overwriting countries files when running tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790789 (owner: 10Ejegg) [18:07:36] 10Fundraising-Backlog, 10Patch-For-Review: LATAM donors receiving esES thank you email instead of esMX - https://phabricator.wikimedia.org/T306356 (10CDenes_WMF) Thanks for the update David. The LATAM pre-test is running today. So we can investigate incoming donations and check that they are getting the esLATA... [18:52:15] (03PS11) 10Jgleeson: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [18:52:58] fr-tech I think this patch has decent coverage with tests and is ready for review if anyone wants to jump on it ^^ [18:53:56] happy for me to move that into review ejegg ? [18:54:32] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Create skeleton braintree adapter + config - https://phabricator.wikimedia.org/T302947 (10jgleeson) a:03jgleeson [19:14:05] jgleeson|brb: yes please let's get some CR [19:14:27] fr-tech it would be great if someone else could give it a glance, as both jgleeson and I have touched it [19:14:59] jgleeson|brb: I'm going to remove that TODO: tests from the commit message [19:16:22] (03PS12) 10Ejegg: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) [19:24:50] fr-tech I'm going to deploy the local-currency minimums along with a config update [19:25:45] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/791068 [19:25:47] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/791068 (owner: 10Ejegg) [19:26:45] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/791069 [19:29:50] sounds good [19:33:52] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/791069 (owner: 10Ejegg) [19:38:50] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email Greeting Field in Civi - blank for some donors - https://phabricator.wikimedia.org/T308181 (10RLewis) [19:53:14] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/791068 (owner: 10Ejegg) [20:07:34] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10JFishback_WMF) [20:07:41] hrm? [20:07:47] !log updated payments-wiki from f06e390b to cc2612d6 [20:07:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:08:40] that update doesn't look like it got many of the files it should have [20:08:43] huh?? [20:08:54] it rolled back to the previous deploy? [20:09:04] I did somethign wrong here [20:09:43] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/791075 [20:09:46] silly me [20:09:58] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/791075 (owner: 10Ejegg) [20:11:11] !log updated payments-wiki from cc2612d6 to 8f46af9d [20:11:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:11:25] ok, that looks better [20:11:30] testing INR minimum [20:11:56] cool, now shows up as exactly 50 INR [20:13:17] ah shoot I had that commit tagged with the wrong bug [20:13:39] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.12; 2022-05-16): Refactor base GatewayAdapter to take config as constructor arg - https://phabricator.wikimedia.org/T302922 (10Ejegg) oops, https://gerrit.wikimedia.org/r/785963 should h... [20:15:41] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Use specific currency for minimum donation amount - https://phabricator.wikimedia.org/T307880 (10Ejegg) https://gerrit.wikimedia.org/r/785963 should have been tagged with this task. It's deployed a... [20:16:02] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Use specific currency for minimum donation amount - https://phabricator.wikimedia.org/T307880 (10Ejegg) 05Open→03Resolved a:03Ejegg [20:28:20] (03CR) 10Damilare Adedoyin: [C: 03+2] "Looks good to me, I ran the tests with break points and was able to understand how the gateway was been set by the rules and priority." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [20:30:18] (03Merged) 10jenkins-bot: Tiebreaker rules for gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/789731 (https://phabricator.wikimedia.org/T302935) (owner: 10Ejegg) [20:34:58] 10Fundraising-Backlog, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10SHust) [20:44:35] thanks damilare !!! [20:44:50] np [20:45:51] (03PS1) 10Damilare Adedoyin: WIP: Add validation to employers field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) [20:46:01] bye for now fr-tech [20:46:09] later jgleeson [20:47:46] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add validation to employers field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) (owner: 10Damilare Adedoyin) [21:32:08] 10Fundraising-Backlog, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10Eileenmcnaughton) It is possible to add `{$currency}` into the templates to add the 3 letter code - there is some risk that in some cases it will be a duplication but if it's nev... [21:35:09] 10Fundraising-Backlog, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10DStrine) @TSkaff @TomaszGorski @SHust FYI also please add anyone else who is in charge of the TY email process. [21:42:24] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10DStrine) [21:58:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-AutoTY-Email: Is sender editable in email template UI? - https://phabricator.wikimedia.org/T306357 (10DStrine) 05Resolved→03Open [21:58:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-AutoTY-Email: Is sender editable in email template UI? - https://phabricator.wikimedia.org/T306357 (10DStrine) a:05DStrine→03None [22:00:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-AutoTY-Email: Is sender editable in email template UI? - https://phabricator.wikimedia.org/T306357 (10DStrine) I'm reopening this to note that the older TY emails still say Jimmy and will until the latest translations come in. This needs to be trac... [22:02:50] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-AutoTY-Email: Is sender editable in email template UI? - https://phabricator.wikimedia.org/T306357 (10TSkaff) @DStrine We're aware of this already [23:10:57] (03PS4) 10Ejegg: Set adyen config on resultswitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779563 [23:11:00] (03PS1) 10Ejegg: Stop using deprecated Hooks::register [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791099 [23:16:40] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10KHaggard) Thanks! So, @TSkaff @MNoorWMF and I split the work for coding the English versions of the TY emails. I'm not sure who coded Spanish, but I believe... [23:26:06] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Client-side errors on Adyen ResultSwitcher due to missing config - https://phabricator.wikimedia.org/T307485 (10Ejegg)