[00:01:34] (03PS5) 10Ejegg: Short-circuit Adyen JS on ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779563 (https://phabricator.wikimedia.org/T307485) [00:01:36] (03PS2) 10Ejegg: Stop using deprecated Hooks::register [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791099 [00:03:23] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Client-side errors on Adyen ResultSwitcher due to missing config - https://phabricator.wikimedia.org/T307485 (10Ejegg) OK, I worked out how to test this and chan... [00:05:07] (03PS6) 10Ejegg: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) [00:07:19] (03Abandoned) 10Ejegg: build: Bump mediawiki-codesniffer to 28.0.0 and make it pass [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/544436 (https://phabricator.wikimedia.org/T234597) (owner: 10MaxSem) [00:39:01] (03CR) 10Ejegg: "This looks pretty good so far! If you want to add client-side validation by making the new transformer implement ClientSideValidationHelpe" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) (owner: 10Damilare Adedoyin) [00:39:52] (03CR) 10Ejegg: WIP: Add validation to employers field (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) (owner: 10Damilare Adedoyin) [01:09:37] (03PS3) 10Ejegg: Ping Braintree GraphQL API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/769822 (https://phabricator.wikimedia.org/T302946) [01:09:39] (03PS3) 10Ejegg: WIP Implement createClientToken for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/769823 (https://phabricator.wikimedia.org/T302948) [01:32:07] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor fail page logic - https://phabricator.wikimedia.org/T302938 (10Ejegg) [01:35:51] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Refactor fail page logic - https://phabricator.wikimedia.org/T302938 (10Ejegg) [08:41:50] 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10CDenes_WMF) [08:46:26] 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10CDenes_WMF) @TSkaff FYI ^ [08:48:57] 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10CDenes_WMF) [08:50:27] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10TomaszGorski) Hi David, Eileen, Katers, Sandra, it has been amended with {$currency} in the [[ https://civicrm.wikimedia.org/civicrm/admin/messageTemplates?r... [08:57:38] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10krobinson) @KHancock99 pointed out this is an issue in English-language too - we had one confused Australian donor recently, whose receipt just shows $ in th... [09:01:25] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10CDenes_WMF) @Eileenmcnaughton please do let us know the exact code we should use per Kristie's request above, and Tomasz can apply it to the non-English temp... [09:11:03] 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10CDenes_WMF) [09:11:40] 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10CDenes_WMF) [09:35:26] 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10CDenes_WMF) [14:22:15] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1294 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [14:27:15] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 177280 Threads: 10 Questions: 6434252 Slow queries: 80 Opens: 37815766 Flush tables: 1 Open tables: 200 Queries per second avg: 36.294 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [14:34:06] (03PS2) 10Damilare Adedoyin: Add validation to employers field with test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) [14:35:22] (03PS3) 10Damilare Adedoyin: Add validation to employers field with test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) [14:37:11] (03CR) 10Damilare Adedoyin: Add validation to employers field with test (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) (owner: 10Damilare Adedoyin) [14:57:54] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Verbiage on payment page re S.A. national ID requirement - https://phabricator.wikimedia.org/T307743 (10Damilare) a:03Damilare [15:44:07] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: user messaging for LATAM, SA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10HNordeenWMF) @DStrine translations are ready, thanks Tomasz! Should I plan to add them to donation interface once its ready? Or... [15:44:27] 10Fundraising-Backlog: Address fields on India campaign payment pages need to be removed - https://phabricator.wikimedia.org/T308254 (10EMartin) [15:46:45] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10DStrine) @SHust Let us know how you feel about @Eilee... [15:48:53] (03PS1) 10Wfan: wip: get the error parameters without relay on ffname [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791400 (https://phabricator.wikimedia.org/T302938) [15:50:56] (03CR) 10jerkins-bot: [V: 04-1] wip: get the error parameters without relay on ffname [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791400 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [15:54:31] 10Fundraising-Backlog: Address fields on India campaign payment pages need to be removed - https://phabricator.wikimedia.org/T308254 (10EMartin) 05Open→03Resolved [16:00:13] (03PS2) 10Wfan: wip: get the error parameters without relay on ffname [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791400 (https://phabricator.wikimedia.org/T302938) [16:07:29] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10DStrine) p:05Triage→03High [16:14:01] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with Payment method not found - https://phabricator.wikimedia.org/T308166 (10DStrine) p:05Triage→03Medium [16:15:23] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10DStrine) p:05Triage→03High [16:17:50] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with Payment method not found - https://phabricator.wikimedia.org/T308166 (10DStrine) p:05Medium→03High [16:24:29] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10SHust) @Eileenmcnaughton apologies for missing your i... [16:41:16] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate keeping testmeister or re-creating it in civi - https://phabricator.wikimedia.org/T308262 (10DStrine) [17:18:04] (03PS1) 10Ejegg: Update preferred_language on new contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) [17:20:55] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Verbiage on payment page re S.A. national ID requirement - https://phabricator.wikimedia.org/T307743 (10EMartin) @Damilare @DStrine I was able to get Dlocal to allow us to remove this field entirely so we DO NOT need this language added. Ca... [18:30:46] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10KHaggard) @krobinson I believe the issue with English was resolved through T306576 - but I thought the issue was only with the footer in USD, so that's why E... [19:01:11] PROBLEM - check_memory on fran1001 is CRITICAL: CRIT Memory 97% used. Largest process: python3 (24150) = 91.1% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [19:04:50] (03PS2) 10Ejegg: Update preferred_language on new contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) [19:06:17] PROBLEM - check_memory on fran1001 is CRITICAL: CRIT Memory 97% used. Largest process: python3 (24150) = 91.1% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [19:11:11] PROBLEM - check_memory on fran1001 is CRITICAL: CRIT Memory 95% used. Largest process: python3 (24150) = 89.1% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [19:16:13] PROBLEM - check_memory on fran1001 is CRITICAL: CRIT Memory 95% used. Largest process: python3 (24150) = 89.1% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [19:17:01] ACKNOWLEDGEMENT - check_memory on fran1001 is CRITICAL: CRIT Memory 95% used. Largest process: python3 (24150) = 89.1% Dwisehaupt known - jupyter process https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_memory [19:17:31] (03CR) 10jerkins-bot: [V: 04-1] Update preferred_language on new contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) (owner: 10Ejegg) [20:59:39] (03PS3) 10Ejegg: Update preferred_language on new contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) [21:10:07] fr-tech so it wasn't exactly a regression in moving code from drupal to civi ^^^^ [21:10:55] The change happened when we decided to attach new contribs to contacts matching the name + email [21:11:12] ohhh nice catch! [21:11:22] before, we would create a new contact and the update would happen in the dedupe merge [21:13:30] ejegg: quick drive-by... if you happen to have handy the change-id of the room ^D^D^D^D change where it happened, and would like to add it to the commit msg, that'd be cool? [21:13:55] and thx again for the quick find 'n' fix! [21:21:43] fr-tech I'm creating Braintree sandbox users for folks [21:21:49] expect invite emails [21:21:56] thanks ejegg [21:24:15] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade pfw to Junos 20+ - https://phabricator.wikimedia.org/T295691 (10Papaul) The Junos image is now on both pfw ` root@pfw3-eqiad% ls /var/tmp/junos-srxentedge-x86-64-20.4R3-S1.3.tgz /var/tmp/junos-srxentedge-x86-64-20.4R3-S1.3.tgz... [21:24:51] note that the 'login with paypal' thing doesn't seem to work with our funky non-email-based paypal merchant usernames [21:25:04] so I just made a separate account for the Braintree sandbox [21:29:21] (03PS4) 10Ejegg: Update preferred_language on new contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) [21:29:50] AndyRussG: it was a sort of gradual process, but I added one of the key change IDs to the commit message ^^^ [21:30:09] so we added a setting that would let you turn on-way-in matching on or off [21:30:22] then we later made that the default behavior [21:30:41] or rather, we made it the only behavior [21:58:21] ah oki thx! [22:08:54] thanks for the login ejegg ! [22:09:06] fr-tech for braintree documentation should it be its own page or under paypal ? [22:09:54] (03CR) 10Jgleeson: [C: 03+2] "Working for me. Cuts out a lot of seemingly unnecessary stuff from the older method which I'm guessing we'll remove at a later date when w" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) (owner: 10Ejegg) [22:10:13] cstone: I'd say own page [22:10:19] and then our paypal one becomes legacy [22:11:47] yeah that makes sense [22:12:38] (03Merged) 10jenkins-bot: Simpler function to build payments form URLs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790779 (https://phabricator.wikimedia.org/T302944) (owner: 10Ejegg) [22:19:15] (03CR) 10Jgleeson: [C: 03+2] "Working well here. No errors on popup screen so looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779563 (https://phabricator.wikimedia.org/T307485) (owner: 10Ejegg) [22:21:20] (03Merged) 10jenkins-bot: Short-circuit Adyen JS on ResultSwitcher [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/779563 (https://phabricator.wikimedia.org/T307485) (owner: 10Ejegg) [22:28:43] (03CR) 10Jgleeson: [C: 03+2] "Hook still running as before. LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791099 (owner: 10Ejegg) [22:29:01] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Currency sign missing from LATAM ty emails - https://phabricator.wikimedia.org/T308184 (10KHancock99) @KHaggard Donor Relations are not receiving sufficient enough replies to TY emails across currencies to confirm the scope for you. A casual gla... [22:30:41] (03Merged) 10jenkins-bot: Stop using deprecated Hooks::register [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791099 (owner: 10Ejegg) [22:36:18] thanks for all the CR! [22:49:40] (03CR) 10Jgleeson: [C: 03+2] "Looks like a good start. took a while to find the sandbox api URL but got there in the end. pong." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/769822 (https://phabricator.wikimedia.org/T302946) (owner: 10Ejegg) [22:50:14] (03Merged) 10jenkins-bot: Ping Braintree GraphQL API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/769822 (https://phabricator.wikimedia.org/T302946) (owner: 10Ejegg) [23:09:23] (03PS1) 10Jgleeson: Skeleton files for Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791468 (https://phabricator.wikimedia.org/T302947) [23:11:12] (03CR) 10jerkins-bot: [V: 04-1] Skeleton files for Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791468 (https://phabricator.wikimedia.org/T302947) (owner: 10Jgleeson) [23:14:56] (03PS2) 10Jgleeson: Skeleton files for Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791468 (https://phabricator.wikimedia.org/T302947) [23:17:28] bye for now fr-tech [23:34:11] (03CR) 10Ejegg: [C: 04-1] "Client side validation looks good! I see one actual issue (with the server-side preg_match) and a few stylistic suggestions." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791078 (https://phabricator.wikimedia.org/T306645) (owner: 10Damilare Adedoyin)