[00:01:46] (03PS6) 10Wfan: fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) [00:04:30] AndyRussG: do you feel like deploying that special page rename? [00:05:01] Or would you rather wait a day in case the just-deployed patches cause trouble? [00:11:58] (03CR) 10Cstone: [C: 03+2] "Looks good! I like renaming cdId in the refactor. Tested with es-419 like your test and worked great as well as ignoring some gibberish to" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) (owner: 10Ejegg) [00:12:16] thanks cstone ! [00:12:50] np ejegg and thanks for deploying that earlier [00:14:35] (03PS7) 10Wfan: Clear adyen ffname replaced with showError as request param [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) [00:15:21] yw! [00:20:20] (03PS4) 10AndyRussG: PHPUnit tests: reset globals and use salt in API tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708645 (https://phabricator.wikimedia.org/T266088) [00:25:04] fr-tech I revived this old patch that makes DonationInterface tests pass on docker... many thx in advance for any CR :) https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/708645 [00:25:34] oh thanks AndyRussG [00:25:54] :) thank u! [00:27:55] (03Merged) 10jenkins-bot: Update preferred_language on new contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/791413 (https://phabricator.wikimedia.org/T308043) (owner: 10Ejegg) [00:29:34] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/792747 [00:29:37] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/792747 (owner: 10Ejegg) [00:41:12] (03PS1) 10AndyRussG: Remove ffname from tests of payments forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792750 (https://phabricator.wikimedia.org/T308622) [00:45:15] (03PS5) 10Ejegg: PHPUnit tests: reset globals and use salt in API tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708645 (https://phabricator.wikimedia.org/T266088) (owner: 10AndyRussG) [00:45:34] (03CR) 10Ejegg: [C: 03+2] "Thanks for the fix!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708645 (https://phabricator.wikimedia.org/T266088) (owner: 10AndyRussG) [00:48:58] thx ejegg! tests also passing with ffname removed ;) [00:49:48] great [00:50:11] whew, it was in a whole bunch of them, huh? [00:50:24] yeah [00:50:36] ah sorry I just saw your ping above about deploying the special page rename [00:50:47] well it should be a no-op [00:50:56] is there an ideal time to deploy it? [00:51:17] hmm, let's see what traffic patterns look like [00:52:09] AndyRussG: there's very little payments-wiki traffic now [00:55:30] (03Merged) 10jenkins-bot: PHPUnit tests: reset globals and use salt in API tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/708645 (https://phabricator.wikimedia.org/T266088) (owner: 10AndyRussG) [00:59:58] ejegg: hmmm I guess it makes sense to deploy separately from other form chooser stuff, so that if something dies, we have a better idea of the possible cause? [01:03:31] AndyRussG: that's what I was thinking [01:04:56] ejegg: oki cool... yeah I can do that now, or alternately a bit later after walking the dog... since it's been a while, I'd surely need hand-holding yet again, but that'd also be good to do [01:05:04] and thx in advance heheh [01:05:54] !log updated fundraising CiviCRM from d45afdfc to b8b8c177 [01:05:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:06:14] AndyRussG: I'm here to help now, but will have to sign off after an hour [01:06:45] ok, now to try to update my civi language preference with a new donation [01:07:06] ejegg: oki cool let's do this now then! thx much.... heheh yeah doggie can wait [01:08:19] ok, one sec, let me get headphones on [01:10:07] ok, let's use today's tech talk call? [01:10:10] okok [01:10:29] meet.google.com/rvq-ygtd-xgm [01:30:23] (03PS1) 10AndyRussG: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/792753 [01:32:30] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/792753 (owner: 10AndyRussG) [01:33:15] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/792753 (owner: 10AndyRussG) [01:42:52] (03PS1) 10AndyRussG: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/792754 [01:44:54] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/792754 (owner: 10AndyRussG) [01:53:04] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/792754 (owner: 10AndyRussG) [02:22:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: donor's preferred language should be updated by the latest donation. - https://phabricator.wikimedia.org/T308043 (10Ejegg) a:03Ejegg [02:23:55] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): DLocal responses with Payment method not found - https://phabricator.wikimedia.org/T308166 (10Ejegg) 05Open→03Resolved a:03Ejegg... [06:29:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10nisrael) Sorry @Eileenmcnaughton one more question. I'm trying to download the 600k contacts from Civi, but I think the file size is too large that my computer... [06:40:39] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10CDenes_WMF) @AnnWF does that mean Testmeister is officially deprecated? If so, is t... [07:11:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10Eileenmcnaughton) @nisrael what is the reason to download them all? I thought the idea was to unhold them in CiviCRM & then that would flow into Acoustic - I'm... [12:46:49] (03CR) 10Abijeet Patro: Replace use of <> with HTML character codes (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792449 (https://phabricator.wikimedia.org/T305134) (owner: 10Wangombe) [13:06:34] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) [13:35:15] 10fundraising-tech-ops: fr-tech DNS records incongruences - https://phabricator.wikimedia.org/T308672 (10Volans) p:05Triage→03Medium [13:44:24] (03Abandoned) 10Wangombe: Replace use of <> with HTML character codes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792449 (https://phabricator.wikimedia.org/T305134) (owner: 10Wangombe) [13:44:30] (03CR) 10Wangombe: Replace use of <> with HTML character codes (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792449 (https://phabricator.wikimedia.org/T305134) (owner: 10Wangombe) [15:00:23] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10DStrine) @Eileenmcnaughton I feel like this story keeps changing. As I understand i... [15:03:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10nisrael) @Eileenmcnaughton Adding them back into our database as a contact list will ensure that we can track and handle them separately. The goal is to send t... [15:17:29] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) [15:22:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10nisrael) @Eileenmcnaughton are there perhaps parameters I can add to the search query to reduce the size of the file download size? Such as 1) donors only bein... [15:36:47] (03PS4) 10Jgleeson: WIP: Add Braintree Dropin SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792289 (https://phabricator.wikimedia.org/T302949) [15:40:09] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) I switched over to the [[... [16:16:51] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Remove ffname from tests of payments forms - https://phabricator.wikimedia.org/T308622 (10DStrine) [16:17:30] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Turn on dlocal as default for South Africa - https://phabricator.wikimedia.org/T304627 (10DStrine) p:05Triage→03High [16:17:41] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10DStrine) p:05Triage→03Medium [16:17:52] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Remove ffname from tests of payments forms - https://phabricator.wikimedia.org/T308622 (10DStrine) p:05Triage→03Medium [16:18:25] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10DStrine) p:05Triage→03High [16:40:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10Ejegg) This is merged and ready to deploy as soon as th... [16:44:20] 10Fundraising-Backlog, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android Release FY2021-22): English fundraising message test for Android app users in India in June 2022 - https://phabricator.wikimedia.org/T305405 (10Sharvaniharan) >>! In T305405#7917715, @spatton wrote: > Hi @Sharvaniharan! TY so... [16:45:50] (03CR) 10Wfan: [C: 03+2] "haha, thanks for update the wired referral and remove all the ffname, looks good to me~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792750 (https://phabricator.wikimedia.org/T308622) (owner: 10AndyRussG) [17:14:33] wfan: thanks for the code review! [17:14:53] ahh oops fr-tech indeed I mispoke in standup, that wasn't merged yet ^ though now it is :) :) [17:14:56] Np :) [19:24:19] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) Ok so after much fumbling... [19:36:16] 10Fundraising-Backlog, 10FR-dlocal: PE and UY payment options missing? - https://phabricator.wikimedia.org/T308584 (10Pcoombe) Okay I've updated donatewiki as above Uruguay: [English](https://donate.wikimedia.org/?country=UY&uselang=en), [Spanish](https://donate.wikimedia.org/?country=UY&uselang=es-419) Peru:... [19:39:11] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10Eileenmcnaughton) @CDenes_WMF the UI for the mailing templates provides previews fo... [19:40:11] 10Fundraising-Backlog, 10FR-dlocal: PE and UY payment options missing? - https://phabricator.wikimedia.org/T308584 (10EMartin) Thank you, Peter! Evelyn Martin (She/Her) Sr. Manager Donation Processing | Wikimedia Foundation emartin@wikimedia.org | Wikimedia Foundation *... [19:59:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10DStrine) @nisrael could you re-explain why you think such a large group are worth re-trying? If a large portion of these are blocked for a good reason (i.e.... [20:09:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10Eileenmcnaughton) On the filter question - I've saved the search & added the language filter + filtered out email addresses that don't start with a letter ht... [20:12:10] AndyRussG: I'd like to deploy payments-wiki to get the UY/PE defaults out - are you around to help look out for issues with the rename? [20:23:34] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig, 10Patch-For-Review: Implement createClientToken mutation in Braintree GraphQL API - https://phabricator.wikimedia.org/T302948 (10Ejegg) a:03Ejegg [20:32:54] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10Damilare) a:03Damilare [21:21:08] (03CR) 10Ejegg: "resubmit" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792750 (https://phabricator.wikimedia.org/T308622) (owner: 10AndyRussG) [21:22:16] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) I'm struggling to link a s... [21:22:34] (03CR) 10Ejegg: [C: 03+2] Remove ffname from tests of payments forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792750 (https://phabricator.wikimedia.org/T308622) (owner: 10AndyRussG) [21:22:49] (03CR) 10Ejegg: [C: 03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792750 (https://phabricator.wikimedia.org/T308622) (owner: 10AndyRussG) [21:23:00] (03PS2) 10Ejegg: Remove ffname from tests of payments forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792750 (https://phabricator.wikimedia.org/T308622) (owner: 10AndyRussG) [21:24:30] (03PS5) 10Jgleeson: WIP: Add Braintree Paypal SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792289 (https://phabricator.wikimedia.org/T302949) [21:26:04] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) [21:26:37] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Implement PayPal account authorization using Braintree JS SDK - https://phabricator.wikimedia.org/T302949 (10jgleeson) [21:56:33] 10fundraising-tech-ops, 10Patch-For-Review: fr-tech DNS records incongruences - https://phabricator.wikimedia.org/T308672 (10Dwisehaupt) a:03Dwisehaupt [23:40:47] (03CR) 10Ejegg: "This looks like it's almost there! One logic change needed in the GatewayPage::showFailForm, and then we can also delete the testGetRapidF" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [23:56:51] (03CR) 10Ejegg: [C: 04-1] "Couple of suggestions for changing the buildGatewayPageUrl method signature. And we should either expand the scope of this patch to use sh" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan)