[01:17:13] PROBLEM - check_puppetrun on frdb2003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[megacli] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_puppetrun [01:22:13] PROBLEM - check_puppetrun on frdb2003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[megacli] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_puppetrun [06:32:13] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 2057 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:37:13] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1895 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:42:13] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1427 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:47:13] RECOVERY - check_procs on frdb2003 is OK: PROCS OK: 646 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [15:26:11] thanks Jeff_Green [15:26:25] jgleeson: no prob! [15:47:50] hi fr-tech! [15:48:02] AndyRussG: I put some answers to your questions at the end of that etherpad [15:48:29] hi ejegg [15:49:55] (03PS1) 10Wfan: Merge branch 'master' of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797333 [15:49:57] (03PS1) 10Wfan: wip: Amazon ffname to showError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797334 (https://phabricator.wikimedia.org/T302938) [15:50:28] heyyy Jeff_Green jgleeson ejegg fr-tech [15:50:39] hey AndyRussG [15:50:41] thx ejegg! [15:50:45] :) [15:51:15] ejegg: you know the test paypal accounts we've used in the past e.g. 'fr-tech+donor@wikimedia.org' and the other one. Di dyou set them up against your own developer.paypal.com account, or was it an fr-tech general one? [15:51:41] hey AndyRussG [15:52:42] (03PS2) 10Wfan: wip: update amazon ffname with error to showError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797333 (https://phabricator.wikimedia.org/T302938) [15:53:20] (03Abandoned) 10Wfan: wip: Amazon ffname to showError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797334 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [15:54:31] I'm asking because to use paypal with braintree, I needed to create a paypal developer 'app' to allow braintree to speak to paypal and this is done on the developer.paypal.com console and not sandbox.developer.com which those test accounts work with. [15:55:11] I ended up using my own develop.paypal.com account, which has it's own donor/facilitator sandbox accounts generated much like the fr-tech ones [15:58:02] (03CR) 10Ejegg: "Agreed about the gateway config layout needing encapsulation somewhere! But maybe we can leave that as a TODO for this round? What do you " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [15:58:41] jgleeson: that was an fr-tech general account, and I can't seem to sign in any more with the credentials I have saved [15:58:50] also, hello! [15:58:55] (03PS9) 10Jgleeson: WIP: Add Braintree Paypal SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792289 (https://phabricator.wikimedia.org/T302949) [15:59:10] (03CR) 10CI reject: [V: 04-1] wip: update amazon ffname with error to showError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797333 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [15:59:40] so it seems odd we would have to use production PayPal credentials to link with the sandbox Braintree account, but OK I guess [16:00:04] production? [16:00:19] err, you said "I needed to create a paypal developer 'app' to allow braintree to speak to paypal and this is done on the developer.paypal.com console and not sandbox.developer.com which those test accounts work with [16:00:42] developer/sandbox only [16:00:47] so sandbox.developer.pp.com doesn't have the ability to create app links with sandbox braintree? [16:01:24] ejegg: check out section one here https://developer.paypal.com/braintree/docs/guides/paypal/testing-go-live#linked-paypal-testing [16:02:38] it looks like paypal has overlap between developer and sandbox. developer seems to be the console where you create sandbox things [16:02:46] so all non-prod [16:02:57] ah, i see. thanks! [16:04:50] ok cool. so if we do have a fr general account for developer.paypal.com then we can move away from using my 'jgleeson@wikimedia.org' paypal sandbox account listed in here https://sandbox.braintreegateway.com/merchants/ms9fqmw9gxrm2bp3/paypal [16:20:31] (03PS10) 10Jgleeson: WIP: Add Braintree Paypal SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792289 (https://phabricator.wikimedia.org/T302949) [16:20:59] (03CR) 10Ejegg: [C: 04-1] "ut-oh, looks like this change got turned into a merge somehow!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797333 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [16:24:06] (03Abandoned) 10Wfan: wip: update amazon ffname with error to showError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797333 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [16:29:36] (03CR) 10Wfan: fail page logic (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [16:32:07] wfan ahh, that is a tricky problem for that URL [16:32:29] let me see if I can figure out how to display that message correctly [16:34:18] (03PS11) 10Jgleeson: WIP: Add Braintree Paypal SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792289 (https://phabricator.wikimedia.org/T302949) [16:35:53] Thanks Elliott :) The abandoned patch was for my linux to test amazon pay~ cause my mac still not able to have the proxy-forward working~ while the other patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/791628 can have initial review now without the amazon one as following~ [16:54:46] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Jgreen) [17:15:28] fr-techj heyyy quick question, is there any reason to have the GlobalCollect gateway enabled, locally, on CI, or on prod? [17:16:26] good question AndyRussG [17:17:11] RECOVERY - check_puppetrun on frdb2003 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_puppetrun [17:18:21] AndyRussG: just because of tests [17:18:40] we are testing some shared gc/ingenico behavior in gc tests [17:18:53] and haven't moved those over to ingenico tests yet [17:18:57] oh hrmm oki thx ejegg [17:19:16] we have that disentanglement slated for next quarter [17:19:20] right [17:19:42] ejegg: and so outside of tests, on prod and locally, it could be disabled, no? [17:19:57] yeah, it's basically disabled on prod [17:20:16] hmmm basically? [17:20:27] i think by turning off all the payment_methods in an override yaml [17:20:27] 10Fundraising-Backlog: Verbiage to state PAN field optional in India campaign - https://phabricator.wikimedia.org/T308332 (10HNordeenWMF) Hi fr-tech, currently all of our India banners point to a payments.wiki variant **variant:'panExplain'** Will these changes be made to that variant as well? That would be grea... [17:20:51] ah oki thx! [17:23:59] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw, 10Patch-For-Review: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Papaul) [17:41:13] 10Fundraising-Backlog: Verbiage to state PAN field optional in India campaign - https://phabricator.wikimedia.org/T308332 (10Pcoombe) I would also be happy dropping that variant completely if this language can be included on the default form for India. My understanding is that specifying a non-existent variant w... [17:49:07] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Papaul) switch configuration ` papaul@fasw-c-codfw# run show interfaces ge-[0-1]/0/11 descriptions Interface Admin Link Description ge-0/0/11 u... [17:54:56] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Papaul) [17:56:03] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Papaul) a:05Papaul→03Jgreen @Jgreen all yours [18:35:33] (03PS5) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) [18:37:19] PROBLEM - check_puppetrun on frmon2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[prometheus] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frmon2001&service=check_puppetrun [18:38:20] (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [18:42:19] PROBLEM - check_puppetrun on frmon2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[prometheus] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frmon2001&service=check_puppetrun [18:44:05] Ci reject is new [18:44:17] I think? [18:47:09] PROBLEM - check_disk on frdb1003 is CRITICAL: DISK CRITICAL - free space: /dev 257211 MB (100% inode=99%): /run 51252 MB (99% inode=99%): / 0 MB (0% inode=88%): /dev/shm 257229 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 257229 MB (100% inode=99%): /boot 155 MB (62% inode=99%): /srv 2827292 MB (54% inode=99%): /run/user/573 51445 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2& [18:47:09] 1003&service=check_disk [18:47:19] RECOVERY - check_puppetrun on frmon2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frmon2001&service=check_puppetrun [18:52:11] RECOVERY - check_disk on frdb1003 is OK: DISK OK - free space: /dev 257211 MB (100% inode=99%): /run 51252 MB (99% inode=99%): / 3745 MB (53% inode=88%): /dev/shm 257229 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 257229 MB (100% inode=99%): /boot 155 MB (62% inode=99%): /srv 2825982 MB (54% inode=99%): /run/user/573 51445 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fr [18:52:11] rvice=check_disk [19:14:55] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10jgleeson) Thanks for updating that! Looks much easier on the eye :) [19:17:36] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10jgleeson) Happy to +2 this. Thanks for this, it will help a bunch in the future. I won't move it to done as I'll let @XenoRyet confirm it meets... [19:22:55] (03PS12) 10Jgleeson: WIP: Add Braintree Paypal SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792289 (https://phabricator.wikimedia.org/T302949) [19:28:00] (03PS6) 10Jgleeson: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [19:28:15] Just rebasing over latest master ^^ [19:30:46] (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [19:56:18] (03PS7) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) [20:00:06] (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [20:11:19] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Jgreen) [20:25:47] 10Fundraising-Backlog: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Dwisehaupt) [20:26:19] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10Eileenmcnaughton) @CDenes_WMF yes - we should probably set up a contact in Civi cal... [20:27:27] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: review scrubbed logs before data destruction - https://phabricator.wikimedia.org/T309049 (10Jgreen) [20:30:02] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.12; 2022-05-16): Refactor base GatewayAdapter to take config as constructor arg - https://phabricator.wikimedia.org/T302922 (10Dwisehaupt) [20:31:02] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Jgreen) [20:33:41] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Jgreen) [20:34:04] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Jgreen) [20:36:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_common into an extension - probably wmf-civicrm - https://phabricator.wikimedia.org/T270681 (10Dwisehaupt) [20:38:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_common into an extension - probably wmf-civicrm - https://phabricator.wikimedia.org/T270681 (10Ejegg) Let's break this into 3 tasks: * Move base queue consumer classes and their settings * Move WMF transaction wrapper... [20:44:12] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:(Need By: TBD) rack/setup/install frbackup2002 - https://phabricator.wikimedia.org/T306842 (10Jgreen) [20:45:18] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_civicrm module into wmf-civicrm extension - https://phabricator.wikimedia.org/T270677 (10Dwisehaupt) [20:45:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert wmf_audit to an extension - https://phabricator.wikimedia.org/T270675 (10Dwisehaupt) [20:45:37] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert recurring global collect to an extension - or possibly fully deprecate it - https://phabricator.wikimedia.org/T270673 (10Dwisehaupt) [20:45:48] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert Queue2civicrm to civicrm extension - https://phabricator.wikimedia.org/T270672 (10Dwisehaupt) [20:45:55] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert orphan slayer to an extension - https://phabricator.wikimedia.org/T270670 (10Dwisehaupt) [20:46:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert contribution tracking module to an extension - https://phabricator.wikimedia.org/T270665 (10Dwisehaupt) [20:52:52] 10Fundraising-Backlog: "parseAsBlock" function when with href will return it as extra - https://phabricator.wikimedia.org/T308875 (10Dwisehaupt) [20:55:53] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: DonationInterface should have only one way to display maintenance message - https://phabricator.wikimedia.org/T308509 (10Dwisehaupt) [20:56:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert metrics reporting to a drupal module - https://phabricator.wikimedia.org/T270668 (10Ejegg) We could also remove it and replace Queue2civicrmTrxnCounter and the usages of report_metrics with Jack's StatsCollector code [21:12:11] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1044 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [21:22:13] RECOVERY - check_procs on frdb2003 is OK: PROCS OK: 671 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [21:50:08] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10XenoRyet) Looks great to me as well, thanks! Moving to Done. [22:39:04] (03PS9) 10Wfan: fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) [22:42:01] (03CR) 10CI reject: [V: 04-1] fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [22:43:55] (03PS10) 10Wfan: fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) [23:20:47] (03CR) 10Ejegg: [C: 04-1] "Looking pretty good, I just wonder why you moved all the getBestErrorForm logic in this commit when it's about to be deleted." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [23:31:24] (03PS10) 10Wfan: Clear adyen ffname replaced with showError as request param [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) [23:42:32] (03PS11) 10Wfan: fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) [23:44:43] (03PS12) 10Wfan: fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) [23:44:47] (03CR) 10CI reject: [V: 04-1] fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [23:46:37] (03CR) 10CI reject: [V: 04-1] fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [23:51:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert wmf_audit to an extension - https://phabricator.wikimedia.org/T270675 (10Ejegg)