[00:24:31] (03PS11) 10Wfan: Clear adyen ffname replaced with showError as request param [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) [00:46:46] (03CR) 10Ejegg: "Answers to a couple of comments," [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [01:00:27] 10Fundraising-Backlog: "parseAsBlock" function when with href will return it as extra - https://phabricator.wikimedia.org/T308875 (10AnnWF) the error was cased at gateway_common/GatewayPage.php displayFailPage $this->getOutput()->showErrorPage( 'donate_interface-error-msg-gene... [01:08:55] (03PS12) 10Wfan: Use showError as request param instead of error-xx from ffname so it doesn't need to consult a Config Remove DonationInterfaceRapidFail global, treat as true [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) [01:09:41] (03PS13) 10Wfan: Use showError as request param instead of error-xx from ffname so it doesn't need to consult a Config Remove DonationInterfaceRapidFail global, treat as true [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) [01:12:03] (03Abandoned) 10Wfan: fail page logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/792234 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [01:18:33] (03PS14) 10Ejegg: Use showError as request param instead of error-xx from ffname [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [01:19:00] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks great!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [01:21:45] (03Merged) 10jenkins-bot: Use showError as request param instead of error-xx from ffname [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [01:30:55] (03CR) 10Wfan: Use showError as request param instead of error-xx from ffname (035 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/791628 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [01:33:02] (03PS1) 10Wfan: remove depreciated globalcollect getForm function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/797750 (https://phabricator.wikimedia.org/T302938) [01:36:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Querying contacts from 'Reply Mail Block' events - https://phabricator.wikimedia.org/T300817 (10EYener) Hey @nisrael and fr-tech folks, this is done pending @nisrael's review. Here is a reference query for the output: ` SELECT COUNT(DISTINCT e.email) AS... [03:56:27] (03CR) 10Vaughn Walters: [C: 03+1] selenium: Use @wdio/spec-reporter [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/793784 (https://phabricator.wikimedia.org/T280331) (owner: 10Zfilipin) [06:07:12] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1021 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:17:12] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1598 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:22:12] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 2037 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:27:12] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1779 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:32:12] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 1301 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:34:01] (03CR) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser (0311 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [06:37:12] RECOVERY - check_procs on frdb2003 is OK: PROCS OK: 746 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [14:52:19] oh man UK energy prices going up again [14:52:37] https://www.bbc.co.uk/news/business-61562657 [15:12:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [15:17:10] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [15:37:19] 10fundraising-tech-ops: fr-tech DNS records incongruences - https://phabricator.wikimedia.org/T308672 (10Volans) 05Open→03Resolved I'm boldly resolving this as I think everything has been fixed and merged. Feel free to reopen if needed. [16:16:56] (03PS1) 10Wfan: Remove city and stree from IN Dlocal as required field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/798831 (https://phabricator.wikimedia.org/T308464) [16:25:14] (03PS2) 10Ejegg: fail page logic [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/792641 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [16:25:21] (03CR) 10Ejegg: [V: 03+2 C: 03+2] fail page logic [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/792641 (https://phabricator.wikimedia.org/T302938) (owner: 10Wfan) [16:26:37] back later! [16:26:38] (03PS1) 10Wfan: Remove street and city for india dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/798846 (https://phabricator.wikimedia.org/T308464) [16:31:14] 10Fundraising-Backlog, 10Patch-For-Review: Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10AnnWF) Hi Evelyn, city is not necessary when I test payment locally, so I am not sure should we also remove city for India dlocal since you mentioned less fields more conversio... [16:48:09] omg the paypal developer console is so darn frustrating [16:48:27] errors out every single time I try to generate a braintree access token [16:49:21] or delete or edit the misconfigured account with the fr-tech username [16:52:15] could waste hours pressing those buttons over and over again [16:56:36] https://giphy.com/gifs/HQGzdiNhg52oM [17:00:02] lol [17:00:09] trying to do it with curl [17:00:34] but there's a csrf token that's probably going to make that not work [17:37:32] ejegg|food: I think you're potentially running into the issues I had [17:37:56] and if so, I don't think you need to use the 'Braintree SDK' thing [17:38:31] check in when you get back, sounds like you might be doubling back on stuff I tried out when I set it up [17:40:42] also checkout my notes on https://phabricator.wikimedia.org/T302949 [17:52:46] (03CR) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [18:46:45] thanks jgleeson, I'll read those [18:47:18] so far I can test your patch with the other credentials I had and it does pop up the paypal window [18:47:34] I think that patch looks really clean too [18:48:00] if you want to just take it out of WIP I think it's totally mergeable and we can keep building from there [18:51:30] ejegg: I'm just testing adding the braintree path to the eslint config just to see how it performs and then I'll push that up with the patch and take it out of WIP [18:51:36] thanks for the review! [18:53:34] jgleeson ahh yeah, I was indeed clicking the dedicated braintree button on the apps page rather than just creating a new app [18:53:39] creating a new app worked fine [18:54:08] yeah I wasted a few days down that rabbit hole too. Such a pain isn't it [18:54:13] so now that i have that in the official WMF sandbox account I'm going to put those app credentials in the WMF braintree account's paypal section [18:54:16] seriously a pain [18:54:52] sounds good ejegg re:account [18:56:01] ok, linked [18:57:55] I'll also push up the config-private stuff in the cmt message to the config-private repo now that we're happy with that [18:58:32] the device data collector script is kinda WIP but I left it there as it's apparently needed for non-recurring vault trxn [18:58:36] trxns [18:58:45] scary named script that one [19:13:37] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Write documentation for how to create testing URLs - https://phabricator.wikimedia.org/T307964 (10XenoRyet) 05Open→03Resolved [19:13:39] (03PS8) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) [19:14:33] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Clean up remaining ffname use - https://phabricator.wikimedia.org/T302939 (10XenoRyet) [19:14:36] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Remove ffname from tests of payments forms - https://phabricator.wikimedia.org/T308622 (10XenoRyet) 05Open→03Resolved [19:15:26] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Make dlocal default for PE UY - https://phabricator.wikimedia.org/T303207 (10XenoRyet) 05Open→03Resolved [19:15:45] (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [19:15:57] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Agents in need of additional Civi permission - https://phabricator.wikimedia.org/T305505 (10XenoRyet) 05Open→03Resolved [19:16:17] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: donor's preferred language should be updated by the latest donation. - https://phabricator.wikimedia.org/T308043 (10XenoRyet) 05Open→03Resolved [19:17:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): user messaging for LATAM, ZA, India to improve donor conversion - https://phabricator.wikimedia.org/T307614 (10XenoRyet) 05Open→03Resolved [19:18:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Some LATAM donors still receiving esES thank you email instead of esLATAM - PART 2 - https://phabricator.wikimedia.org/T308215 (10XenoRyet) 05Open→03Resolved [19:18:43] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Establish basic communication with Braintree GraphQL API - https://phabricator.wikimedia.org/T302946 (10XenoRyet) 05Open→03Resolved [19:19:34] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Disable ZA national ID field - https://phabricator.wikimedia.org/T307743 (10XenoRyet) 05Open→03Resolved [19:19:40] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Don't accept an employer field that's just numbers - https://phabricator.wikimedia.org/T306645 (10XenoRyet) 05Open→03Resolved [19:20:00] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Create skeleton braintree adapter + config - https://phabricator.wikimedia.org/T302947 (10XenoRyet) 05Open→03Resolved [19:20:39] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity, and 3 others: Create rules for gateway tiebreaking based on querystring - https://phabricator.wikimedia.org/T302935 (10XenoRyet) 05Open... [19:20:43] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10Epic: Epic: chooser refactor - https://phabricator.wikimedia.org/T301797 (10XenoRyet) [19:21:05] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog: Fix the Adyen Recurring SmashPig Processor so it saves the Authorize ID instead of the Capture ID as the Transaction ID - https://phabricator.wikimedia.org/T308064 (10XenoRyet) 05Open→03Resolved [19:21:07] 10Fundraising-Backlog: Smashpig recurring job (for Adyen at least) is saving the capture ID as the gateway transaction ID instead of the authorise ID - https://phabricator.wikimedia.org/T306944 (10XenoRyet) [19:21:27] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.12; 2022-05-16): Client-side errors on Adyen ResultSwitcher due to missing config - https://phabricator.wikimedia.org/T307485 (10XenoRyet) 05Open→03Re... [19:22:38] (03CR) 10Ejegg: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [19:46:34] 10Fundraising Sprint Incantation optimisation, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Implement createClientToken mutation in Braintree GraphQL API - https://phabricator.wikimedia.org/T302948 (10XenoRyet) 05Open→03Resolved [19:52:28] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.12; 2022-05-16): Refactor base GatewayAdapter to take config as constructor arg - https://phabricator.wikimedia.org/T302922 (10AndyRussG) [19:52:30] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021) - https://phabricator.wikimedia.org/T291697 (10AndyRussG) [19:55:40] 10Fundraising-Backlog: "parseAsBlock" function when with href will return it as extra - https://phabricator.wikimedia.org/T308875 (10XenoRyet) 05Open→03Declined [20:02:22] 10Fundraising-Backlog, 10Patch-For-Review: Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10EMartin) @AnnWF Hi Ann, let's remove the city field too. Thanks for asking! It also is not a requirement and minimization is better. [20:08:16] 10Fundraising Sprint J 2022, 10Fundraising-Backlog: Verbiage to state PAN field optional in India campaign - https://phabricator.wikimedia.org/T308332 (10XenoRyet) [20:08:18] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10Patch-For-Review: Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10XenoRyet) [20:08:24] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10XenoRyet) [20:08:26] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Map Braintree error codes to SmashPig error types - https://phabricator.wikimedia.org/T303458 (10XenoRyet) [20:08:30] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Implement API call to capture one-time donation via Braintree - https://phabricator.wikimedia.org/T303410 (10XenoRyet) [20:08:32] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.12; 2022-05-16): Simplify FormChooser::buildPaymentsFormURL - https://phabricator.wikimedia.org/T302944 (10XenoRyet) [20:08:34] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Map Braintree statuses to SmashPig statuses - https://phabricator.wikimedia.org/T302987 (10XenoRyet) [20:08:37] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Clean up remaining ffname use - https://phabricator.wikimedia.org/T302939 (10XenoRyet) [20:08:39] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10fundraising sprint Genealogical theory of relativity: Sprint Goal: form chooser brain tree - https://phabricator.wikimedia.org/T305987 (10XenoRyet) [20:08:41] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10XenoRyet) [20:08:43] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, and 5 others: Syn group to Acoustic should remove any existing queues before c... - https://phabricator.wikimedia.org/T306855 [20:08:46] 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Front-end calls to charge one-time donation via Braintree - https://phabricator.wikimedia.org/T303419 (10XenoRyet) [20:08:48] 10Fundraising Sprint Fibonachos, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint J 2022, and 3 others: Set valid Callback URL on DLocal Sandbox - https://phabricator.wikimedia.org/T303974 (10XenoRyet) [20:08:52] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Cheese String Theory, and 43 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10XenoRyet) [20:08:56] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint J 2022, 10Fundraising-Backlog, and 3 others: Convert offline2civicrm to a drupal module - https://phabricator.wikimedia.org/T270669 (10XenoRyet) [20:09:02] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor, and 3 others: Refactor fail page logic - https://phabricator.wikimedia.org/T302938 (10XenoRyet) [20:09:08] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint J 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor, and 3 others: Refactor & rename FormChooser::getOneValidForm - https://phabricator.wikimedia.org/T302936 (10XenoRyet) [20:35:26] oh wow, back when Jim Henson was still doing ads, he made some for Faygo soda (which has come to be the official soft drink of Juggalo nation) [21:38:11] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10Ejegg) I can trigger it if I put a plus sign in an str... [21:44:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10Ejegg) If we're removing the address fields from the d... [23:48:53] (03PS1) 10Ejegg: Update country list for Ingenico [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799009 [23:52:00] (03CR) 10CI reject: [V: 04-1] Update country list for Ingenico [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799009 (owner: 10Ejegg)