[00:33:40] <wikibugs>	 (03PS1) 10Ejegg: Move showError logic up to GatewayPage [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800375 (https://phabricator.wikimedia.org/T302939)
[00:34:09] <ejegg>	 AndyRussG: Got a little separation-of-concerns patch right there ^^^
[00:34:38] <ejegg>	 wfan: That's the change I was mentioning wanting to make this morning
[00:35:50] <wfan>	 Thanks, I will take a look :)
[00:35:54] <ejegg>	 rockin!
[00:36:12] <ejegg>	 I like it because it keeps the showError out of the donationData object
[00:36:19] <ejegg>	 since showError is strictly a UI thing
[00:36:29] <ejegg>	 it seems better handled up at the SpecialPage layer
[00:37:13] <ejegg>	 then it also lets us save making API calls when we're trying to show an error page
[00:40:42] <wfan>	 Hmm, that looks very nice to me, and it pass the special page unit tests. Nice
[00:51:46] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] Move showError logic up to GatewayPage [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800375 (https://phabricator.wikimedia.org/T302939) (owner: 10Ejegg)
[00:52:56] <ejegg>	 thanks!
[00:54:33] <wfan>	 Then I will fix mine above this merge one :) thanks~
[00:54:44] <wikibugs>	 (03Merged) 10jenkins-bot: Move showError logic up to GatewayPage [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800375 (https://phabricator.wikimedia.org/T302939) (owner: 10Ejegg)
[01:01:33] <wikibugs>	 (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) (owner: 10Wfan)
[01:02:22] <wikibugs>	 (03PS8) 10Wfan: Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939)
[01:04:14] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) (owner: 10Wfan)
[01:33:09] <wikibugs>	 (03CR) 10Ejegg: "Ahh, so our error classification in SmashPig is still pretty messy, huh? If you have any ideas as to how to refactor our error classificat" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin)
[01:37:44] <wikibugs>	 (03PS9) 10Wfan: Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939)
[01:39:31] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) (owner: 10Wfan)
[01:40:56] <wikibugs>	 (03CR) 10Ejegg: WIP: Implement API call to capture one-time donation via Braintree (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[01:44:06] <wikibugs>	 (03PS10) 10Wfan: Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939)
[01:49:11] <wikibugs>	 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23): Turn on dlocal as default for South Africa - https://phabricator.wikimedia.org/T304627 (10Ejegg) @EMartin this is deployed
[01:51:27] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800444
[01:51:35] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800444 (owner: 10Ejegg)
[01:51:55] <wikibugs>	 (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800446
[01:51:58] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800446 (owner: 10Ejegg)
[01:54:51] <wfan>	 ejegg: I compared the previous buildPaymentsFormURL with our new buildGatewayPageUrl, find out they are not converting everything to xxxGateway, if ffname not exit they will return GatewayFormChooser, so I customized the buildGatewayPageUrl to see if gatewayadapter starts from Testing, then return GatewayChooser instead of the testinggateway to avoid the unit test error.
[01:58:33] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800444 (owner: 10Ejegg)
[01:59:45] <ejegg>	 hmm wfan i guess that would work, but it's always a bummer to see test-specific code in the production code
[02:07:09] <ejegg>	 !log updated payments-wiki from c7c2df36 to 7b65d520
[02:07:13] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[02:07:27] <ejegg>	 wfan do you want to comment on those India form tasks to tell emartin they're deployed now?
[02:07:55] <wfan>	 Sure, thanks
[02:09:29] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), 10Patch-For-Review: Verbiage to state PAN field optional in India campaign - https://phabricator.wikimedia.org/T308332 (10AnnWF) Hi @EMartin, this is deployed now, thanks @Ejegg :)
[02:09:55] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30): Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10AnnWF) Hi @EMartin, this is deployed now, thanks @Ejegg :)
[02:11:54] <wfan>	 And for that unit test maybe we can update the core wiki either add Alias for testinggateway or filter those dataprovider out based on is it for production?
[02:14:50] <ejegg>	 wfan did you look at the dataprovider for that core test to see if it lets special page classes opt out by marking themselves in some way?
[02:15:19] <wfan>	 i can check that tomorrow 😂
[02:19:05] <AndyRussG>	 ejegg: ah cool hey I'll check out the patch u mentioned above ^ :)
[02:22:10] <ejegg>	 AndyRussG: ok, thanks! wfan has merged it already but i'd be happy to hear any other comments you may have
[02:22:25] <ejegg>	 it's deployed even, and looks OK on prod so far
[02:22:54] <ejegg>	 that prod error log is super noisy with all the DBReadOnlyError unfortunately. I'd like to fix that soon
[02:24:07] <ejegg>	 oh darn wfan, we may need to roll back the IN address removal patch
[02:24:19] <ejegg>	 I'm seeing a bunch of 'empty param x_city' errors
[02:24:55] <ejegg>	 so again there may be a difference between their sandbox and production
[02:25:16] <ejegg>	 I think I can revert just that one
[02:26:50] <wikibugs>	 (03PS1) 10Ejegg: Revert "Remove city and stree from IN Dlocal as required field" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800462
[02:26:53] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Revert "Remove city and stree from IN Dlocal as required field" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800462 (owner: 10Ejegg)
[02:26:54] <wfan>	 Oh no! You mean without city the payment gateway will return error?
[02:27:30] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800463
[02:27:52] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800463 (owner: 10Ejegg)
[02:28:39] <wikibugs>	 (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800464
[02:28:55] <ejegg>	 wfan that's what it looks like from our error logs
[02:29:09] <ejegg>	 We can send them an email and re-deploy that patch when they fix it
[02:29:53] <ejegg>	 I'll make a comment on the task after I deploy. Can you maybe write the email tomorrow, or see if Evelyn will do it?
[02:30:03] <wfan>	 Ok, yeah cause I did test it with sandbox looks fine without city, and thanks for the comment.
[02:30:04] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800464 (owner: 10Ejegg)
[02:31:19] <wfan>	 I can ask Evelyn tomorrow see if she can email the dlocal team, 😊 or I can do that too
[02:31:59] <ejegg>	 thanks!
[02:32:58] <wfan>	 No problem 😊
[02:34:19] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30): Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10Ejegg) Darn, this seems to be another case where sandbox and production have different rules. I'm seeing error...
[02:34:52] <wikibugs>	 (03Merged) 10jenkins-bot: Revert "Remove city and stree from IN Dlocal as required field" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800462 (owner: 10Ejegg)
[02:35:33] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800463 (owner: 10Ejegg)
[02:37:11] <icinga-wm>	 PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[02:40:56] <ejegg>	 !log updated payments-wiki from 7b65d520 to 59c7239e
[02:41:00] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[02:41:18] <ejegg>	 ok wfan that one patch is rolled back. I've got to head to bed now. Have a good weekend!
[02:41:51] <wfan>	 U too! Enjoy the long weekend:)
[02:42:13] <icinga-wm>	 RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[03:01:31] <wikibugs>	 (03PS11) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936)
[03:03:56] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG)
[03:16:24] <wikibugs>	 (03PS12) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936)
[03:18:21] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG)
[11:00:47] <wikibugs>	 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Testmeister esMX email is different from what we have set up in the civi UI - https://phabricator.wikimedia.org/T307704 (10CDenes_WMF) Thank you, yes this is pretty...
[13:45:33] <wikibugs>	 (03PS6) 10Damilare Adedoyin: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[14:09:00] <wikibugs>	 (03PS7) 10Jgleeson: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410)
[14:09:27] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[15:20:43] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30): Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10EMartin) @ejegg.  Shall I get Dlocal involved?
[15:23:14] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30): Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10EMartin) I suggest directing questions to:  Sebastian Quintero <squintero@dlocal.com>
[15:29:50] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), 10Patch-For-Review: Verbiage to state PAN field optional in India campaign - https://phabricator.wikimedia.org/T308332 (10EMartin) This is great!  Many happy fundraisers over this.  Thank you!
[15:42:44] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30): Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10AnnWF) Yes we should.   >>! In T308464#7963362, @EMartin wrote: > @ejegg.  Shall I get Dlocal involved?  Ok, I...
[15:54:25] <wikibugs>	 (03PS8) 10Damilare Adedoyin: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[15:55:24] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[15:56:59] <wikibugs>	 (03PS9) 10Damilare Adedoyin: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[16:18:26] <wikibugs>	 (03PS13) 10AndyRussG: [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936)
[16:21:22] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] [WIP, ready for initial review, but pls do not merge] Refactor gateway chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG)
[16:32:55] <AndyRussG>	 fr-tech ^ here's the most recent gateway chooser refactor code
[16:33:16] <AndyRussG>	 also I solved my local setup issue... it was some bug related to xdebug. Fixed after I restarted my IDE
[16:33:45] <wikibugs>	 (03PS1) 10Wfan: City is necessary for Inda [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800767 (https://phabricator.wikimedia.org/T308464)
[16:34:05] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] City is necessary for Inda [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800767 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[16:36:05] <wikibugs>	 (03PS1) 10Wfan: conf [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800768
[16:36:37] <wikibugs>	 (03Abandoned) 10Wfan: City is necessary for Inda [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800767 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[16:36:57] <wikibugs>	 (03PS2) 10Wfan: City is necessary for Inda [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800768 (https://phabricator.wikimedia.org/T308464)
[16:37:06] <wikibugs>	 (03PS3) 10Wfan: City is necessary for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800768 (https://phabricator.wikimedia.org/T308464)
[16:40:50] <wikibugs>	 (03PS1) 10Wfan: Remove stree from required field for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800771 (https://phabricator.wikimedia.org/T308464)
[16:40:55] <wikibugs>	 (03Abandoned) 10Wfan: City is necessary for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800768 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[16:44:14] <wfan>	 Could anyone take a look for this one, very simple change haha, and then I can deploy it to production :) 
[16:44:29] <wfan>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/800771/
[16:47:27] <wfan>	 or could I plus 2 myself haha, since it's something tested already~ 😃
[16:49:24] <jgleeson>	 looking wfan 
[16:49:37] <wfan>	 Thanks! jgleeson:
[16:54:30] <jgleeson>	 wfan: that looks good to me. wanna just fix the typo in the commit message and I'll +2
[16:55:00] <jgleeson>	 also does it need to go out today? if not, we usually try not to deploy stuff on a friday
[16:58:48] <wikibugs>	 (03PS2) 10Wfan: Remove street from required field for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800771 (https://phabricator.wikimedia.org/T308464)
[16:59:49] <wfan>	 haha ok, I will ask Evelyn if we want this out today or wait until next Monday~
[17:02:24] <AndyRussG>	 yeah we do sometimes do Friday deploys, I have seen them happen heheh but the general convention I think is to avoid them if possible, to avoid having something broken over the weekend when people are mostly not around :)
[17:02:31] <jgleeson>	 thanks! it's only a small change but still we don't wanna risk waking up the Friday chaos monkeys if we don't need to 
[17:06:46] <AndyRussG>	 heheh that's a fun way to put it ;p
[17:07:49] <wfan>	 Haha, ok will see what's her thought and this typo is fixed thanks!
[17:09:08] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "Looks good to me! :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800771 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[17:11:48] <wikibugs>	 (03Merged) 10jenkins-bot: Remove street from required field for India [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800771 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[17:38:51] <wikibugs>	 (03PS10) 10Jgleeson: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410)
[17:39:21] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[17:40:03] <wikibugs>	 (03PS1) 10Jgleeson: Tests: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800779 (https://phabricator.wikimedia.org/T303410)
[17:40:34] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Tests: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800779 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[17:43:18] <wikibugs>	 (03PS11) 10Jgleeson: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410)
[17:43:44] <jgleeson>	 damilare|brb: I just broke up that patch into tests and implementation 
[17:43:46] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[17:50:28] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), 10Patch-For-Review: Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10AnnWF)
[17:53:36] <wikibugs>	 (03PS2) 10Jgleeson: Tests: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800779 (https://phabricator.wikimedia.org/T303410)
[17:54:03] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Tests: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800779 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[17:57:43] <wikibugs>	 (03PS12) 10Jgleeson: WIP: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410)
[17:58:14] <wikibugs>	 (03PS3) 10Jgleeson: Tests: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800779 (https://phabricator.wikimedia.org/T303410)
[18:00:27] <wikibugs>	 (03CR) 10Jgleeson: WIP: Implement API call to capture one-time donation via Braintree (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson)
[18:00:46] <jgleeson>	 ok damilare|brb they are both passing on Ci
[18:06:24] <wikibugs>	 (03PS1) 10Wfan: Set city as Mumbai for India as default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800781 (https://phabricator.wikimedia.org/T308464)
[18:07:40] <wfan>	 jgleeson: Hi Jack, Evelyn want to have Mumbai as default city instead of show the city, so could you see if this is working? I tested locally seems fine~ and she wants a deploy to production today since we are running the Campaign now 
[18:13:49] <jgleeson>	 hi wfan. that looks fine to me. However I feel like dstrine would push back on a change like this so close to the weekend
[18:14:31] <jgleeson>	 also, do we really wanna default to Mumbai even if folks aren't from there?
[18:14:37] <jgleeson>	 feels odd
[18:15:06] <jgleeson>	 XenoRyet: any thoughts on this short notice requirement?
[18:15:52] <XenoRyet>	 Let me take a look.  How risky is the change?
[18:16:46] <jgleeson>	 it's a pretty basic JS update but still needs a deployment
[18:17:53] <jgleeson>	 wfan: have you and cstone worked through a payments deploy before, updating submodule and all? 
[18:18:34] <XenoRyet>	 So the city field is invisible, but still populated with Mumbai?
[18:18:46] <jgleeson>	 yeah
[18:18:54] <wfan>	 Yeah, quote Evelyn "Yes, today if possible as the campaign launches next week.  It would be good to have this in place for that.  Thanks."
[18:19:01] <wfan>	 yep
[18:19:34] <wfan>	 Since we are using api 1.0 instead of 2.0, they need city for India, but we can set a default one as Sebastian said from DLocal
[18:19:49] <XenoRyet>	 I mean, it's weird, but I guess since we weren't planning on using city data anyway, it's fine.
[18:20:13] <wfan>	 It will be removed once we migrate to api 2.0
[18:20:25] <wfan>	 then we can pass null for city, but their 1.0 can not accept null
[18:20:26] <XenoRyet>	 I don't love a friday deploy, but given that it's low risk and the campaign is starting soon I guess it's ok.
[18:21:13] <wfan>	 Thanks, and Jack if you got time we can do the deploy together? I do have the note but want to have a second eye with me haha
[18:26:49] <jgleeson>	 wfan: I'll test it locally now and +2 if all is good but then I have to pop off for a bit  as I'm making Foo Yung for dinner. I have a new Wok I wanna try out! :) but when I get done with dinner in about an hour I'll come back and we can go through the deployment if that works for you
[18:26:55] <jgleeson>	 thanks XenoRyet 
[18:27:41] <wfan>	 Thanks Jack sure just let me know when u ready :)
[18:27:52] <wfan>	 And yes thanks Dylan for confirm that
[18:30:32] <jgleeson>	 wfan: do you have test card details for dlocal that you're using? 
[18:34:32] <jgleeson>	 ok looks like dlocal authorize any valid card numbers on sandbox
[18:34:32] <wfan>	 What do you mean by test card details? I am seeing the payment pass locally to their dashboard
[18:34:47] <jgleeson>	 yeah wfan to test a payment
[18:35:07] <wfan>	 ok yeah, I am using my real card number and it passed so I always use that one
[18:35:09] <jgleeson>	 I just tried and I can see dlocal are currently redirecting back to paymentstest3. are you tunneling wit that
[18:35:17] <jgleeson>	 with *
[18:35:43] <wfan>	 https://dashboard.dlocal.com/transactions?page=1&startDate=05/27/2022&endDate=05/27/2022
[18:36:56] <wfan>	 dlocal redirect me to https://sandbox.dlocal.com/xxx not the paymenttest2
[18:36:59] <wfan>	 dlocal redirect me to https://sandbox.dlocal.com/xxx not the paymenttest3
[18:38:17] <wfan>	 https://sandbox.dlocal.com/gmf/checkout/xxxxx
[18:38:36] <jgleeson>	 wfan: yeah but when you enter the card details it will send you back to a return URL 
[18:38:44] <jgleeson>	 or did do for me
[18:39:29] <jgleeson>	 I can see under integration settings here https://dashboard.dlocal.com/settings/integration that we currently have the callback URL set to https://paymentstest3.wmcloud.org/index.php?title=Special:AstropayGatewayResult&ffname=astropay
[18:39:52] <wfan>	 oh yes if you accept the payment then redirect to paymenttest3
[18:40:06] <jgleeson>	 lemme set up tunnelling and I'll try it out again
[18:40:59] <wfan>	 cool, and I saw couple of your transactions at sandbox dashboard already~
[18:48:17] <jgleeson>	 ok that one completed and sent me to the ty page
[18:48:31] <jgleeson>	 that last* one
[18:49:02] <wfan>	 Nice
[18:53:51] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "This works for me, nice work. It feels strange sending Mumbai as the city for all transactions but if this field is ignored at the dlocal-" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800781 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[18:54:11] <wfan>	 Thanks jack~
[18:54:19] <jgleeson>	 ok wfan gonna go cook. back later and we can deploy!
[18:54:26] <wfan>	 sounds good~
[18:55:51] <wikibugs>	 (03Merged) 10jenkins-bot: Set city as Mumbai for India as default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800781 (https://phabricator.wikimedia.org/T308464) (owner: 10Wfan)
[20:21:35] <jgleeson>	 hey wfan. I'm back if you still wanna do that deploy :)
[20:21:38] <wfan>	 yep
[20:21:48] <wfan>	 let's use today's stand up?
[20:21:52] <jgleeson>	 awesome. wanna join today's ... yep that one
[20:21:55] <jgleeson>	 ha
[20:27:55] <damilare>	 thanks jgleeson
[20:29:15] <wikibugs>	 (03PS1) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800798
[20:30:56] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800798 (owner: 10Wfan)
[20:31:42] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/800798 (owner: 10Wfan)
[20:39:38] <jgleeson>	 np damilare !
[20:51:22] <wikibugs>	 (03PS1) 10Wfan: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800800
[21:08:38] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800800 (owner: 10Wfan)
[21:17:52] <wikibugs>	 (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/800800 (owner: 10Wfan)
[21:30:02] <wfan>	 !log payments-wiki change from 59c7239e to 225d946e
[21:30:06] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:34:16] <jgleeson>	 well done wfan !
[21:34:17] <wfan>	 Thanks Jack and good night 
[21:34:25] <jgleeson>	 have a great weekend fr-tech
[21:34:28] <jgleeson>	 bye for now
[21:36:40] <wikibugs>	 10Fundraising Sprint Juggalology 2022, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), 10Patch-For-Review: Remove address fields on India payment forms - https://phabricator.wikimedia.org/T308464 (10AnnWF) Hi @EMartin, we it's deployed now, as Sebastian's suggested for our 1.0 Api, we n...