[00:04:53] ejegg: didja see the minor comment here? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/800033 [00:09:57] ahh oops apologies ejegg ah heheh u did acknowledge that here, sorry my brain is scattered!! [00:10:18] also no rush and apologies again [00:15:51] (03PS2) 10Eileen: Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [00:19:43] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [00:20:40] AndyRussG: I replied on your follow-up task with my opinion on what to do for all the different test cases [00:43:02] (03PS3) 10Eileen: Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [00:52:42] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [00:54:48] (03PS4) 10Eileen: Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [01:01:38] ejegg: yeee thx so much! :) [01:04:58] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [01:20:07] (03PS5) 10Eileen: Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [01:21:18] ejegg: how did u extract currencies and countries from https://epayments.developer-ingenico.com/payment-product/mastercard/countries-and-currencies? via the html source? [01:21:53] yep AndyRussG , good ol grep [01:23:31] (03PS3) 10Eileen: Remove Googlesheets publish & composer google api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801809 [01:23:47] (03CR) 10Eileen: "done" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801809 (owner: 10Eileen) [01:23:51] heheh oki cool [01:23:57] so I won't repeat that process [01:24:07] and will assume grepping accuracy [01:24:22] heh, i didn't visually check, but the diff looks reasonable [01:30:25] ejegg: I amended locally the currency one to remove the added double space to see a noice diff [01:31:09] so I see all the currencies that had been commented out many moons ago are now reinstaed eh? [01:31:14] *reinstated [01:31:57] ah yeah, might as well have the currently supported ones [01:32:14] and as noted, we should later on add submethod-specific lists [01:32:20] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [01:33:39] (03PS4) 10Ejegg: Remove Googlesheets publish & composer google api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801809 (owner: 10Eileen) [01:33:50] (03CR) 10Ejegg: [C: 03+2] "Thanks for the clean-up!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801809 (owner: 10Eileen) [01:33:55] (03PS6) 10Eileen: Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [01:34:06] (03PS5) 10Ejegg: Move exchange rates classes to own files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/701605 [01:34:16] k right [01:35:10] ejegg: what was your verdict on the test of Amazon recurring? [01:35:16] is it supported and I missed it? [01:35:41] it does give you a form on prod [01:35:43] AndyRussG: we never went all the way to make it work [01:35:49] I think I wrote all the front-end code [01:35:52] (but I didn't try using that to make a recurring donation) [01:36:04] but we never prioritized doing the backend charge [01:36:26] ejegg: ok so it's correct that the gateway chooser should not output a form if Amazon recurring is requested, right? [01:36:36] correct (for now) [01:36:49] K so I'll also remove that test [01:36:56] ejegg: those own files make sense - I just wonder if we should put them in the 'final resting place' - probably an extension clalled 'exchangerates' ? [01:37:44] eileen: oh sure, that's somewhere on the roadmap [01:38:14] AndyRussG: here's the amazon recurring epic with only one task outstanding: https://phabricator.wikimedia.org/T107391 [01:38:23] ejegg: yeah - I just thought make it's pretty quick to spin up an extension & more the files there instead [01:38:32] but I'm OK with it how it si [01:38:36] oh hah you found that [01:39:06] eileen: sure, if you think it's that easy, I'd be happy for it to be a Civi extension earlier rather than later [01:39:18] but there's a bit of db logic that'll need updating [01:40:02] I'd want to make that one pretty clean if possible ( i.e. avoid WMF-specific logging ) since it seems pretty widely useful [01:45:17] not sure if I found it, or it found me [01:45:45] (03Merged) 10jenkins-bot: Remove Googlesheets publish & composer google api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801809 (owner: 10Eileen) [01:46:11] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [01:56:46] (03PS1) 10Eileen: Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 [01:56:59] (03CR) 10CI reject: [V: 04-1] Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 (owner: 10Eileen) [01:57:28] ejegg: ^^ - only does the exceptions - but at least it gives us somewhere to move things to as we work through it [01:57:42] oho, nice [02:06:16] huh I guess Ingenico thinks AN _is_ a country [02:06:39] heh, yeah, apparently Visa works down there [02:08:30] well I mean the islands in question still exist [02:08:40] they're just different countries now [02:08:55] ohh AN is antilles [02:08:56] https://en.wikipedia.org/wiki/Netherlands_Antilles [02:09:03] I was thinking of AT [02:10:54] better to delete AN then? [02:11:11] ejegg: well if it's in the Ingenico list, we can leav eit [02:11:20] ok, easier that way [02:11:31] at least one of the constituent islands, Curaçao (CW) is also there [02:11:44] I was just surprised that you got it from Ingenico [02:11:58] yep, it's right there with the old flag: https://epayments.developer-ingenico.com/payment-product/visa/countries-and-currencies [02:12:05] hehehe [02:12:10] https://epayments.developer-ingenico.com/payment-methods/view-by-country/?country=an [02:12:20] and visa also does still work in Austria too [02:12:33] ahhh yeah, AT is austria [02:12:43] for some reason i was thinking antartica [02:13:10] that's AQ [02:13:19] ahhh ohh hehehe [02:13:21] and yeah it says they have a bunch of supported payment methods [02:13:30] https://epayments.developer-ingenico.com/payment-methods/view-by-country/?country=aq [02:13:46] not much to do besides read Wikipedia when you're there maybe [02:14:09] heheheh also not a country too [02:14:26] I guess Ingenico is not picky [02:44:19] ah right AN doesn't work also because our check doesn't recognize it as a country [02:47:51] ok, let's leave out AN then [02:48:02] yep yep [02:48:09] I'm sorting 'em too [02:48:20] oh I thought i'd done that [02:51:16] in the yaml yes u did [02:51:20] doing it the test cases now [02:51:52] (03CR) 10AndyRussG: [C: 03+2] "Yay thanks!!!!!!!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799009 (https://phabricator.wikimedia.org/T302936) (owner: 10Ejegg) [02:52:15] (03CR) 10AndyRussG: [C: 03+2] "Coool :) :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801828 (https://phabricator.wikimedia.org/T302936) (owner: 10Ejegg) [02:52:19] ah thanks, that'll also be nice to have sorted [02:52:34] yee thank u also :) [02:54:22] (03Merged) 10jenkins-bot: Update country list for Ingenico [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799009 (https://phabricator.wikimedia.org/T302936) (owner: 10Ejegg) [02:54:24] (03Merged) 10jenkins-bot: More currencies for Ingenico [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801828 (https://phabricator.wikimedia.org/T302936) (owner: 10Ejegg) [02:55:02] (03CR) 10Ejegg: "This is looking great! I like the cleanliness of having the queries in separate files. One question about possibly using a different param" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson) [02:55:08] woohoo [02:58:34] (03PS20) 10AndyRussG: Refactor gateway chooser logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) [02:58:54] ejegg: ^ should work [02:59:03] pulling it down now [03:01:21] bt is only supported in one country? Pretty sure we have it in a bunch of them [03:01:29] ahh, we need to add test cases [03:01:40] most of the astropay countries have some bank transfer option [03:02:05] i think the generator script just picked up the first payment method [03:02:33] and since cc is the only one that has real overlap between providers I thought it was OK for a first go round [03:03:55] there's also the 'cash' method we could check for [03:04:49] but let's do that in a following patch [03:05:01] ejegg: ok I'll just remove that comment then [03:05:17] ok cool [03:05:19] ejegg: you had suggested removing bt? btw on prod it takes us to GlobalCollect [03:05:28] obt [03:05:42] no idea why it was a different top-level code [03:05:58] but it's specifically for an australian bank transfer [03:06:21] where we basically just give them a number to fill in to some other form someplace [03:06:38] ohhh oki oops sorry [03:06:45] anyway, we haven't surfaced it anywhere for a long time [03:06:56] and never implemented it in Ingenico [03:07:45] hmmm [03:07:46] looks like it's somewhat widely used for utility bills there [03:07:56] but not as omnipresent as iDEAL in NL [03:08:00] you can get it via the ingenico gateway page [03:08:10] Hrm? [03:08:46] whoa [03:09:16] hah, continue button gives an error [03:09:16] https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&recurring=&uselang=en&language=en¤cy=AUD&amount=10&country=AU&payment_method=obt [03:09:36] wait, was it working before we snipped out some bits last sprint? [03:09:59] no idea [03:10:24] prod also has https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&recurring=&uselang=en&language=en¤cy=AUD&amount=10&country=AU&payment_method=obt [03:10:27] ok, no: Displaying fail page for exception: Configuration key 'payment-provider/obt/class' does not exist. [03:11:09] anyway add a TODO about adding tests for cash payment method u said? [03:11:22] AndyRussG: right, that GC one fails with 'Invalid payment method' [03:11:38] AndyRussG: sure, TODO: cash and more bt tests [03:11:52] I guess right next to the GPay todo [03:11:59] yep yep [03:13:03] (03PS21) 10AndyRussG: Refactor gateway chooser logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) [03:13:44] for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/800033, how do I smoke test? not getting an AstroPay form that asks for address fields [03:13:55] AndyRussG: it's for India [03:14:07] country=IN¤cy=INR [03:14:33] https://localhost:9001/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&payment_method=cc&recurring=0&uselang=en&language=en¤cy=INR&amount=500&country=IN&ffname=astropay-in&first_name=Jimmy&last_name=Wales&street_address=10+Easy+Street%2C+Lbs+Marg%2C+Bhandup&city=Mumbai&fiscal_number=AAAAA9999C&email=jwales%40example.com&debug=true [03:14:42] so the fields just don't show? [03:15:40] same on prod [03:15:41] AndyRussG: oh, were we able to remove them after all? wfan had a patch for that but it caused errors when we deployed so we had reverted it as of thursday night [03:15:50] looking [03:15:58] sorry, i still need to read email too [03:16:30] oh hah!!!! 'Set city as Mumbai for India as default' [03:16:44] DLocal, what a hoot [03:17:02] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/800771 [03:17:26] so.... I guess we don't really need my patch right now [03:17:35] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/800781 [03:17:46] hmmm oki [03:18:17] in that case I'll not worry about it tonite [03:18:22] let's see, can we get a US form? [03:18:52] yeah, ok, no need to do it tonight [03:19:19] oh one question of a thing I noticed [03:19:38] payments has no favicon? [03:19:56] ahh, I guess not... we should fix that, huh? [03:20:45] didn't know if we used to have one and something killed it I guess [03:21:46] no git history for that path [03:22:16] hmm don't see any phab tasks either [03:22:37] (03PS7) 10Eileen: Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [03:22:57] https://phabricator.wikimedia.org/rMW7e9072c2d571cd18e0128bc534d23b3a356d1204 [03:23:27] 2012 commit by k4 that somehow 'no longer exists in the repository.' [03:31:44] heheh wow [03:31:48] "Repository Importing: This repository is still importing." [03:31:56] that's a loooooong import proces [03:34:00] ejegg: ah also gonna update the commit message for the refactor patch, one sec [03:34:31] AndyRussG: thanks! I'm nitpicking a bit on the default rules, one sec, will publish those comments [03:34:41] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [03:35:38] (03CR) 10Ejegg: "nitpicks on value for priority rules" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [03:37:32] (03PS22) 10AndyRussG: Refactor gateway chooser logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) [03:47:43] (03CR) 10AndyRussG: Refactor gateway chooser logic (033 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [03:48:48] ejegg: there might be some dandruff mixed in with ur nits? [03:49:02] (03CR) 10Ejegg: Refactor gateway chooser logic (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [03:49:44] AndyRussG: so we only need the rule for cases where there are multiple gateways supported, in this case payment_method=cc [03:50:16] It seems nice to be as narrow as possible [03:50:41] you can add a payment_method key to the conditions after the countries [03:50:59] oh I see [03:51:02] then we only have to list the gateways that support cc [03:51:08] and for the case of the AstroPay ones? [03:51:32] feels like it's getting complex [03:51:48] so we only need to list countries where astropay supports cc [03:52:18] what about bt? [03:52:30] ah right that'll go to the right place without the rule [03:52:40] hopefully! [03:52:44] I dunno I kinda feel like narrowness is a lower priority than simplicity [03:53:12] more important is just expressing the stakeholder determination, "X country goes to Y gateway" [03:53:27] it just doesn't seem right to have paypal show up in a rule we really just mean to steer users from X countries to astropay for credit cards [03:54:15] I mean in that case when they request paypal as a payment method they'll get it, no? [03:54:32] I feel like it's best to just make the rules easy to read and understand without having to look elsewhere [03:54:54] AndyRussG: yeah, I think it's plenty easy to read with a payment method and a country list [03:55:57] so, if you see "countries X, Y and Z" with gateways "I, II and PayPal", then you know that when those countries have paypal as a method they'll go there, and all other stuff will go first to I and then to II [03:55:57] and the motivation for the rule is less confusing with a shorter gateway list [03:56:18] I'd agree with removing the gateways that are not supported for those countries [03:56:30] and it's not a huge issue [03:56:36] here's a potentially confusing scenario tho: [03:57:07] let's say we have the payment_method = cc and country = X, Y and Z rule enabled [03:57:39] but from the stakeholder perspective it's all countries X Y and Z are all going in general to a specified processor [03:57:59] (except for paypal?) [03:58:20] right [03:58:24] and then we enable change the [03:58:34] i think the stakeholders understand that we only need to steer people for CC [03:58:43] ** then we change the availability of some rtbt methods for some processors and countries [03:59:17] so we'll never have "rtbt" or "cash" available from multiple processors for the same country? [03:59:33] and thus will never have to steer donors using priority rules for those methods? [03:59:35] when we do, we can add a rule for it! [03:59:47] sure [03:59:52] but we'll have to remember to do so [03:59:59] for now i would only expect to see amazon and paypal in the default rule [04:00:20] and to be able to remember to do so we'll have to remember that cash is available in multiple processors for X country [04:00:37] that's why I like rule simplicity over rule narowness [04:01:11] though really I can go either way [04:01:48] amazon is us-only and paypal is everywhere, no? [04:02:07] so when we want to steer donors from X country to braintree for paypal donations it seems like it will be confusing to have paypal_ec in some unrelated country rules [04:02:24] yeah, paypal is pretty widely supported [04:02:56] and I guess Amazon is a lot more widely supported now than it was when we integrated - maybe we should ask if they want to expand where we offer it? [04:03:14] hmmm I guess we may want to direct the different paypal gateways on their own rules [04:03:33] K I'll update the rules to add payment methods [04:03:41] thanks! [04:03:48] now that the microscope said it was infact a nit ;p [04:03:50] thank u! [04:06:35] ugh, ingenico has so much cruft in payment_methods.yaml [04:06:58] there's a 'bt' method that doesn't actually correspond to any working code [04:07:17] but I think will mess up the narrow rules [04:07:28] so... maybe another ticket to clean it up and narrow the rules? [04:08:23] ohhh hmmm [04:08:33] however u prefer [04:08:50] also did we want to add PY (Paraguay) to Astropay? [04:10:31] I mean I guess that's an argument for having specific rules also for other payment methods? [04:11:17] (03PS1) 10Ejegg: Clean up Ingenico config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801837 [04:12:30] AndyRussG: we've never been asked to add the PY payment methods for DLocal, so it would need at least the logos added as well as the config change [04:15:00] (03PS8) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [04:15:03] oh man, it got too late here... I'm going to have to pick this up tomorrow [04:15:39] sorry, I think this is mergeable right now. I'll try to do the extra tests and narrower rules tomorrow [04:16:05] I want to give wfan a chance to rebase her stuff over this [04:18:05] ejegg: sure all good :) [04:18:23] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [04:18:40] (03CR) 10Ejegg: [C: 03+2] "Feels good! Thanks a ton. I still want to narrow those rules, but we need a little Ingenico config cleanup first. And we can look again at" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [04:19:17] k, I gotta hit the hay. have a good night! [04:20:40] (03Merged) 10jenkins-bot: Refactor gateway chooser logic [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [04:22:21] ejegg|away: thx! [04:22:45] same! [04:32:27] (03CR) 10AndyRussG: Refactor gateway chooser logic (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/793834 (https://phabricator.wikimedia.org/T302936) (owner: 10AndyRussG) [05:18:41] (03PS9) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [05:21:39] (03Abandoned) 10Eileen: Move geocoder install to Module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801449 (owner: 10Eileen) [05:23:19] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [05:28:46] (03PS2) 10Eileen: Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 [05:30:43] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [05:40:40] (03CR) 10CI reject: [V: 04-1] Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 (owner: 10Eileen) [08:13:22] (03PS10) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [08:27:33] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [10:19:47] (03PS11) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [10:37:11] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [11:23:09] (03PS6) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [11:23:51] (03CR) 10CI reject: [V: 04-1] Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [11:24:15] (03PS7) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [11:24:48] (03CR) 10CI reject: [V: 04-1] Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [11:26:20] (03PS8) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [11:26:47] (03CR) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types (035 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [11:27:44] (03PS9) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [11:31:31] (03PS10) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [11:31:57] (03CR) 10CI reject: [V: 04-1] Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [11:33:55] (03PS11) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [11:46:26] (03PS12) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [11:59:15] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [12:07:56] (03PS13) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [12:20:37] (03CR) 10CI reject: [V: 04-1] Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [13:14:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10MDemosWMF) ^^Apologies I meant **Q2** not Q1! Sprint 'L' this task is in works for us, but if July/August is needed that's ok on our end. [15:50:56] (03PS17) 10Damilare Adedoyin: Implement API call to capture one-time donation via Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/799413 (https://phabricator.wikimedia.org/T303410) (owner: 10Jgleeson) [15:56:53] (03CR) 10Wfan: [C: 03+1] "Looks good to me 😊 and thanks for the comments for those normalized fields" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [16:34:55] (03PS14) 10Wfan: Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) [16:37:48] (03CR) 10CI reject: [V: 04-1] Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) (owner: 10Wfan) [16:42:08] AndyRussG: Hey Andy, why are we adding a new function as getGatewayPageName? [16:42:44] wfan: hiii! right the idea there is just better encapsulation and separation of concerns [16:43:49] GatewayPage is the class that should contain the logic about what names are allowed for gateway pages, and how to convert from a gateway adapter class name to a gateway page name [16:43:50] Oh ok, then I thought the config will filter out the TestingAdapters, but seems like it's not, so I will then add the Testing if condition back to this new function and make some commends as remove later once the TestingAdapters gone :) [16:44:40] oh oki yes looking forward to taking a look at all that, thanks so much! [16:45:28] (03PS15) 10Wfan: Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) [16:45:29] also of course if it were the case that you disagreed with the creation of the getGatewayPageName function, pls don't hesitate to say so :) [16:46:47] wfan: ^ like many decisions about where to put different bits of code, it's not something where there's clearly only one 100% correct solution, so discussion is great always :) [16:47:29] (03CR) 10CI reject: [V: 04-1] Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) (owner: 10Wfan) [16:49:05] haha, I just feel there is no other place using this function so maybe it can move back to the GatewayChooser? [16:49:23] hmmm that would be a possibility [16:49:49] I had also put it in GatewayAdapter originally but ejegg suggested GatewayPage [16:50:14] I do like it better in GatewayPage though... ;) [16:50:42] the basic philosophy that I have for this kind of stuff is that each component should know as little as possible [16:51:06] and should only "know" about things related to one topic [16:51:31] so in this sense the GatewayChooser knows only how to get the name of the gateway page it should redirect to [16:51:45] it doesn't need to know about the relationship between names of gateway pages and gateway adapters [16:52:04] ok I get your point, will keep it this way :) [16:52:32] oki :) thanks for thinking about this stuff and asking :) :) [16:52:59] (03PS16) 10Wfan: Remove more ffname related depreciated functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/799382 (https://phabricator.wikimedia.org/T302939) [19:26:52] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [19:37:36] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [19:43:39] 10Fundraising-Backlog, 10FR-dlocal: PE and UY payment options missing? - https://phabricator.wikimedia.org/T308584 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Confirming that I added Bank Transfer and Cash in Peru banners today at 19:35 UTC - [diff](https://meta.wikimedia.org/w/index.php?title=MediaWiki:Fu... [19:43:55] 10Fundraising-Backlog, 10FR-LATAM, 10MW-1.38-notes (1.38.0-wmf.25; 2022-03-07): DLOCAL forms for Uruguay and Peru - https://phabricator.wikimedia.org/T274578 (10Pcoombe) 05Open→03Resolved [19:44:42] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [19:48:41] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) For SIEM role, logs up to 2022-05-22 were processed, checked, and used to clobber the unprocessed logs.... [19:50:34] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) For the payments role, general logs are rotated out after 28 days. Apache and nginx are stored longer,... [19:53:12] v /ac [21:00:49] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [21:01:58] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) The payments-listener role doesn't need anything. System logs rotate off after 28 days, and apache2 log... [21:03:12] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [21:13:05] 10Fundraising-Backlog: Add PIX in Civi - https://phabricator.wikimedia.org/T309740 (10EMartin) [21:37:37] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [21:41:45] I'm sorry - I missed some meetings this am - my sleep has been so bad lately I had to let myself sleep when I could - ejegg was there anything that mattered? [21:42:23] nothing big eileen - one minor UI bug reported by Jayme with the 'Merge and return to listing' button [21:42:44] and letting the core team know about David's new job [21:44:39] was the bug this? https://lab.civicrm.org/dev/core/-/issues/3421 [21:44:54] yep, that's the one eileen! [21:45:33] ok - I seem to recall the fix wasn't obvious & I wanted to check with Coleman [21:47:41] whoa never thought I'd be please to see 'just' the `testUK` fail - https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/8041/console [22:03:37] (03CR) 10Wfan: "I think this looks fine while seems like we no longer use street nor city for astropay based on the countries.yaml file, do we still need " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800033 (https://phabricator.wikimedia.org/T308167) (owner: 10Ejegg) [22:07:37] (03PS14) 10Eileen: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 [22:07:58] woohoo - it finally passed [22:20:48] ejegg: I have an email from Sandra asking about Civi tz " We thought it used to be UTC, but I recall DR pushing it back to Hawaii time for the end of year fundraising push, to ensure US donors furthest west would have their donations included in the right calendar year for tax purposes" [22:21:02] - it's only Beach time for EOY isn't it? & otherwise UTC? [22:22:44] eileen: I think maybe beach time for all TY letters? [22:22:54] ah is it? [22:23:05] we should put in tz info (except for EOY) [22:23:22] and I think some stuff was using Pacific time even [22:23:34] actually - I can't see where we set it - [22:23:40] congrats on the geocoder pass [22:23:45] lemme try to find that [22:25:13] getReceiveDate in Action/ThankYou/Render [22:25:22] // For tax reasons, any donation made in the US on Jan 1 UTC should have a timestring in HST. [22:25:25] // So do 'em all that way. [22:25:27] return strftime('%Y-%m-%d', $date - (60 * 60 * 10)); [22:25:31] yep just found it [22:27:51] the guts of the geocoder was this - https://github.com/eileenmcnaughton/org.wikimedia.geocoder/commit/140edebfcaa1c761527c1a9569c0940c48017e69 [22:27:59] plus a few fixes outside the extension [22:28:13] but - if anyone can review it will allow me to see if civi passes now [22:28:58] oh sure, one sec [22:53:34] (03CR) 10Ejegg: [C: 03+2] "Looks good! System.flush successfully recreates the deleted geocoders and adds the new one, while leaving the us zip one as the only enabl" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [22:54:24] yay thanks ejegg [22:55:39] :) [23:01:14] ejegg: FYI - there is a new proximity search feature in search kit now - but we would need to add a function to geocoder. Also there is this https://github.com/eileenmcnaughton/org.wikimedia.geocoder/issues/32 [23:04:51] oh hah, yeah, that's a pretty big insert [23:05:12] I did a small break up - around every 5k lines [23:05:18] oh thanks! [23:06:59] (03PS1) 10Ejegg: Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/802215 [23:07:13] (03CR) 10Ejegg: [C: 03+2] Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/802215 (owner: 10Ejegg) [23:08:32] (03Merged) 10jenkins-bot: Update to latest geocoder & move install to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801822 (owner: 10Eileen) [23:16:46] (03CR) 10CI reject: [V: 04-1] Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/802215 (owner: 10Ejegg)