[03:45:12] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Update DonationInterface code style for php5.5 - https://phabricator.wikimedia.org/T166613 (10AndyRussG) Noooooooo [05:22:32] (03CR) 10AndyRussG: "Hey... thanks for this! On this patch, by running civibuild, I was able to reproduce locally the same error seen here in CI:" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801440 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [05:22:58] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/802991 (owner: 10L10n-bot) [05:24:27] AndyRussG: that's super helpful - I hadn't gotten as far as figuring out where it was failing [05:24:54] something about the upgrade means that load-order stuff is stricter - not sure what but I guess I need a new role fix [05:28:17] eileen: hiii! ah glad to hear it [05:28:35] I don't quite know the answer - but at least I know the problem now :-) [05:30:15] there's a long chain of calls in the call stack between the call to $role->getAllModulePerms() and the handler exportpermission_civicrm_permission() on master, and I just got lost in it and couldn't spot the difference following the point release [05:30:27] looking at the install file (in buildkit) it looks like we should have the extension installed by that point - maybe it's caching [05:30:47] hmmm so it'd be the extension not installed? [05:31:14] I mean the hook handler is called prior to when we hit the error, even in the point-release patches [05:31:29] eileen: I do have my setup with breakpoints and all to debug into that, in case you'd like to look at it quickly on a call [05:31:40] ok sure [05:31:45] cool! [05:33:06] eileen: here now: https://meet.google.com/mkm-dptq-dqq [06:07:39] (03PS1) 10Eileen: Update phpleague/csv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/803082 [06:13:18] (03PS3) 10Eileen: Stock 5.50.1 [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/792294 (https://phabricator.wikimedia.org/T308502) [06:14:38] (03CR) 10AndyRussG: [C: 03+2] "Yaaaayyyyyyy :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/803082 (owner: 10Eileen) [06:17:18] (03CR) 10CI reject: [V: 04-1] Stock 5.50.1 [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/792294 (https://phabricator.wikimedia.org/T308502) (owner: 10Eileen) [06:18:52] (03CR) 10CI reject: [V: 04-1] Update phpleague/csv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/803082 (owner: 10Eileen) [06:19:52] AndyRussG: arg - I'm gonna have to force that cos it conflicts with the old one :-( [06:19:56] tomorrow will do [06:21:01] eileen: sure sounds good thx!! :) [06:23:10] (03CR) 10AndyRussG: "Just for anyone curious, underlying error was:" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801440 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [06:29:14] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/802991 (owner: 10L10n-bot) [11:43:37] 10fundraising-tech-ops: Add out.adyen.com group to ipset for payments servers - https://phabricator.wikimedia.org/T309976 (10Dwisehaupt) [12:18:41] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team (Radar), 10Platform Team Workboards (Clinic Duty Team), 10Sustainability (Incident Followup): High frequency warning logged in production: Cookies set on {url} with Cache-Control "{ca... - https://phabricator.wikimedia.org/T285210 [12:25:49] 10fundraising-tech-ops: Add out.adyen.com group to ipset for payments servers - https://phabricator.wikimedia.org/T309976 (10Dwisehaupt) `[frack::puppet] 27883e25 Add adyen.out ipset entry and apply to payments role` [14:46:07] (03PS12) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [15:37:42] (03PS1) 10Jgreen: Improve error reporting for bad YAML syntax [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/803310 (https://phabricator.wikimedia.org/T161858) [15:40:46] (03CR) 10Jgreen: "Does this look ok?" [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/803310 (https://phabricator.wikimedia.org/T161858) (owner: 10Jgreen) [15:50:49] 10Fundraising-Backlog: Improve process-control logging around locks - https://phabricator.wikimedia.org/T165072 (10Jgreen) 05Open→03Resolved a:03Jgreen Done! [15:54:51] 10Fundraising-Backlog: Minor process-control lock refactor for separation of concerns - https://phabricator.wikimedia.org/T177296 (10Jgreen) 05Open→03Resolved a:03Jgreen Done! [17:00:50] 10Fundraising-Backlog, 10fundraising-tech-ops: process-control repeated failure handling - https://phabricator.wikimedia.org/T161567 (10Jgreen) I'm thinking about this and am not really sure what we need. Looking at the silverpop case, it's a job that runs once daily and I believe if it fails fr-tech reruns i... [17:13:38] 10Fundraising-Backlog, 10fundraising-tech-ops: process-control repeated failure handling - https://phabricator.wikimedia.org/T161567 (10Jgreen) a:03Jgreen [17:44:14] 10Fundraising-Backlog, 10fundraising-tech-ops: process-control repeated failure handling - https://phabricator.wikimedia.org/T161567 (10Jgreen) p:05High→03Medium [19:26:05] fr-tech has anyone seen this when doing a donation on a fresh install Your session has expired. Please try reloading the page and submitting the form again [19:49:07] I feel like I have cstone but no idea why [19:57:00] 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: Payment submethods should list supported currencies - https://phabricator.wikimedia.org/T309667 (10DStrine) [20:01:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Geocoder composer issues - https://phabricator.wikimedia.org/T309657 (10Eileenmcnaughton) @reedy - what is your feeling on https://github.com/wikimedia/composer-merge-plugin/issues/221 & making the merging of 'replace' configurable per that github issue -... [20:39:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Geocoder composer issues - https://phabricator.wikimedia.org/T309657 (10Reedy) [20:56:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Geocoder composer issues - https://phabricator.wikimedia.org/T309657 (10Reedy) It feels like you're misusing `replace`. I understand it's to stop bringing in guzzle (etc) that Civi includes itself. But it does feels like "doing it wrong" when you're "rep... [21:12:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Geocoder composer issues - https://phabricator.wikimedia.org/T309657 (10Eileenmcnaughton) We don't install CiviCRM via composer (when we get off Drupal 7 we will) - so we have the entire tarball of CiviCRM on our site (and we just manage it to avoid confl... [22:33:21] (03PS1) 10Eileen: Update Composer in Civi package [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/803365 (https://phabricator.wikimedia.org/T309250) [22:33:41] AndyRussG: if you can +2 ^^ I'll have to force merge it & then run the CRM one again.... [22:33:53] (it's just the vendor update on our current civi) [22:37:43] (03CR) 10CI reject: [V: 04-1] Update Composer in Civi package [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/803365 (https://phabricator.wikimedia.org/T309250) (owner: 10Eileen) [22:44:13] 10Fundraising-Backlog: Civi error when accessing search kit - https://phabricator.wikimedia.org/T310030 (10EMartin)