[00:33:54] (03CR) 10Wfan: [C: 03+2] "See another audit parse fail mail, this should stop that "Unknown bank code: LD" FailMail" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/803993 (owner: 10Ejegg) [00:34:44] (03Merged) 10jenkins-bot: Add a few more DLocal payment method codes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/803993 (owner: 10Ejegg) [01:44:09] thanks wfan! [01:47:27] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig: Add missing payment methods for DLocal - https://phabricator.wikimedia.org/T310245 (10Ejegg) [02:20:36] (03PS13) 10Ejegg: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [02:22:48] (03CR) 10Ejegg: [C: 03+2] "This looks pretty good! The VALIDATION_ERROR constant seems a bit out of place since we have a whole other class for validation errors, bu" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [02:22:55] (03PS14) 10Ejegg: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [02:55:14] (03PS1) 10Ejegg: Add Pix payment instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804018 (https://phabricator.wikimedia.org/T309740) [02:55:16] (03PS1) 10Ejegg: Add missing payment instruments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804019 (https://phabricator.wikimedia.org/T310245) [02:55:45] wfan: are you available to check those two patches? ^^^ [02:56:26] So I had already made a patch locally for Pix and was waiting for Evelyn to respond whether she wanted the rest of the BT methods broken out. [02:56:40] then we got this audit issue and needed to add some more methods anyway [02:57:12] so i figured I would add all the missing BT ones in CiviCRM at the same time I added the ones matching the SmashPig patch you just merged [03:19:41] (03PS1) 10Wfan: add more countries for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 [03:20:13] (03PS2) 10Wfan: add more countries for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) [03:22:16] (03CR) 10CI reject: [V: 04-1] add more countries for adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) (owner: 10Wfan) [03:25:46] (03CR) 10Ejegg: [C: 04-1] "Wenjun, let's not make Adyen the default for these countries just yet - the banner team will be explicitly specifying the gateway in the q" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) (owner: 10Wfan) [03:33:57] oh dang, silverpop export failed [03:34:44] "Duplicate entry '55657316' for key 'PRIMARY' [03:34:51] probably another employer relationship? [03:39:47] deleted the dupe, re-running the job [03:57:35] ok, heading out for the night [05:34:22] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/804072 (owner: 10L10n-bot) [09:39:26] 10Fundraising-Backlog: Merge and go to listing redirect fail - https://phabricator.wikimedia.org/T309801 (10Aklapper) [14:43:29] howdy fr-tech [15:00:25] hi jgleeson [15:03:36] hi jgleeson cstone [15:03:51] hi damilare [15:05:36] :0 [15:05:43] :) * [15:08:15] hi cstone damilare :) [15:08:33] (◕‿◕✿) [15:26:55] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Braintree-Integration, 10FR-Smashpig: Download and parse Braintree audit files - https://phabricator.wikimedia.org/T303442 (10Cstone) a:03Cstone [15:49:08] (03PS3) 10Wfan: add more countries for adyen, not set as default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) [15:53:36] (03CR) 10Wfan: [C: 03+2] Add Pix payment instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804018 (https://phabricator.wikimedia.org/T309740) (owner: 10Ejegg) [15:56:44] (03CR) 10Wfan: Add missing payment instruments (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804019 (https://phabricator.wikimedia.org/T310245) (owner: 10Ejegg) [16:10:35] (03Merged) 10jenkins-bot: Add Pix payment instrument [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804018 (https://phabricator.wikimedia.org/T309740) (owner: 10Ejegg) [16:35:05] (03CR) 10Ejegg: "Thanks WFan - it should be OK to reuse the update function with a new number." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804019 (https://phabricator.wikimedia.org/T310245) (owner: 10Ejegg) [17:08:58] (03CR) 10Wfan: [C: 03+2] Add missing payment instruments (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804019 (https://phabricator.wikimedia.org/T310245) (owner: 10Ejegg) [17:28:11] (03Merged) 10jenkins-bot: Add missing payment instruments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804019 (https://phabricator.wikimedia.org/T310245) (owner: 10Ejegg) [17:39:25] (03PS5) 10Jgleeson: WIP: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [17:41:54] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "Cool, thanks so much!! :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/800169 (owner: 10Ejegg) [17:44:14] (03PS4) 10AndyRussG: Enable Braintree gateway [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/800169 (https://phabricator.wikimedia.org/T302949) (owner: 10Ejegg) [17:45:36] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "PS4: Just restored the bug tag added in the commit message by @jgleeson. Thanks again!!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/800169 (https://phabricator.wikimedia.org/T302949) (owner: 10Ejegg) [17:55:47] (03CR) 10Jgleeson: [C: 03+1] "The code looks good to me. Nice job. I posted a couple of minor comments but nothing that couldn't be added in a follow-on." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [18:10:17] (03PS15) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [18:10:47] (03CR) 10CI reject: [V: 04-1] Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [18:12:27] (03PS16) 10Damilare Adedoyin: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) [18:14:53] 10Fundraising-Backlog: City field only on international Gpay checkout page - https://phabricator.wikimedia.org/T310307 (10EMartin) [18:20:57] ejegg|away, damilare has asked me to review the braintree error codes. it looks good to me and ready for +2. are you ok with it? [18:36:08] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Error message when accessing Searchkit in Civi - https://phabricator.wikimedia.org/T310088 (10EMartin) @Cstone Data is still taking a long time to download. The download is usually immediate but now it is... [19:11:57] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Error message when accessing Searchkit in Civi - https://phabricator.wikimedia.org/T310088 (10Cstone) @EMartin can you tell me the steps you are doing to get to this download? [19:44:28] jgleeson: oh I thought I already had +2ed it! [19:44:33] sure, go ahead [19:44:45] ahhh right, I submitted an edit right after to get rid of that .cache file [19:51:36] oh looks like he's probably out to get to sleep early, I'll reapply my own C+2 [19:52:13] (03CR) 10Ejegg: [C: 03+2] Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [20:00:00] (03Merged) 10jenkins-bot: Map Braintree error codes to SmashPig error types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/800236 (https://phabricator.wikimedia.org/T303458) (owner: 10Damilare Adedoyin) [20:05:30] (03PS1) 10Ejegg: Update SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804438 [20:05:59] (03CR) 10Ejegg: [C: 03+2] Update SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804438 (owner: 10Ejegg) [20:15:26] (03PS1) 10Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/804443 [20:15:30] (03CR) 10Ejegg: [C: 03+2] Update SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/804443 (owner: 10Ejegg) [20:15:55] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/804444 [20:15:57] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/804444 (owner: 10Ejegg) [20:18:57] (03Merged) 10jenkins-bot: Update SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/804438 (owner: 10Ejegg) [20:31:42] (03Merged) 10jenkins-bot: Update SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/804443 (owner: 10Ejegg) [20:55:48] !log updated fundraising CiviCRM from b0b400ae to 3cb5e6dd [20:55:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:16:35] thanks ejegg. just signing off [21:16:42] have a good weekend all [21:17:36] dstrine: it's been a pleasure. If in doubt, always follow your nose o/ [21:24:05] ejegg: did you just deploy the missing payment patches [21:24:14] there might be some more based on the failmail we just got [21:24:31] INVALID_MESSAGE No payment type found for message [21:42:30] oh crud [21:42:55] did I break something with that? [21:43:33] oh weird, those are pix [21:43:41] i thought this would make it work [21:44:05] hmm, maybe it was the time between the new code deploy and the updb to add the instruments? [21:44:13] let me try requeueing those [21:48:09] ok, yep, Pix donations are now showing up in a contributions search [21:48:44] Ooh okay thanks ejegg ! [21:49:08] cstone so the moral of the story is that when we deploy a patch with that combo of adding methods to the instrument table and adding them to the switch statement, we need to stop queues. Oops! [22:07:31] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog: Add PIX in Civi - https://phabricator.wikimedia.org/T309740 (10Ejegg) I was mucking about in the payment instruments to fix the audit parser, so I went ahead and added these BT methods too [22:17:44] (03PS4) 10Ejegg: add more countries for adyen, not set as default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) (owner: 10Wfan) [22:17:51] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) (owner: 10Wfan) [22:20:50] (03Merged) 10jenkins-bot: add more countries for adyen, not set as default [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804020 (https://phabricator.wikimedia.org/T310095) (owner: 10Wfan) [22:40:44] (03PS1) 10Ejegg: Add gateway chooser test cases for bt and cash [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804462 (https://phabricator.wikimedia.org/T302936) [22:41:09] fr-tech if all of those pass, I'm fixing to deploy those gateway chooser changes [22:41:21] there's a fair amount queued up for deploy in DonationInterface [22:41:32] anyone object to doing that deploy today? [22:42:23] Sounds good ejegg [22:44:55] Welp, they passed! [23:04:45] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/804479 [23:04:50] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/804479 (owner: 10Ejegg) [23:05:43] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/804480 [23:05:46] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/804480 (owner: 10Ejegg) [23:25:00] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/804479 (owner: 10Ejegg) [23:35:08] man, zuul is really backed up