[00:17:44] ok, that's ready to deploy [00:23:12] !log updated payments-wiki from 8c6208c2 to 05139a0c [00:23:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:33:46] !log rolled back payments-wiki from 05139a0c to 8c6208c2 [00:33:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:36:16] Ahh shoot, so the 'edge case' of the gateway form chooser routing with unsupported currencies is not so edgy [00:36:34] We need it for PayPal in a lot of south american currencies [00:54:04] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: GatewayChooser edge case: allow choosing gateway that doesn't support currency when CurrencyFallback is on - https://phabricator.wikimedia.org/T309755 (10Ejegg) Oops,... [00:54:47] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10FR-form-chooser-refactor, 10MediaWiki-extensions-DonationInterface: GatewayChooser edge case: allow choosing gateway that doesn't support currency when CurrencyFallback is on - https://phabricator.wikimedia.org/T309755 (10Ejegg) a:03E... [01:18:33] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog: Add PIX in Civi - https://phabricator.wikimedia.org/T309740 (10EMartin) Super! Thanks Elliott! [01:19:21] (03PS1) 10Ejegg: Consider FallbackCurrency when choosing gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804485 (https://phabricator.wikimedia.org/T309755) [01:21:17] (03CR) 10CI reject: [V: 04-1] Consider FallbackCurrency when choosing gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804485 (https://phabricator.wikimedia.org/T309755) (owner: 10Ejegg) [01:28:56] (03PS2) 10Ejegg: Consider FallbackCurrency when choosing gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804485 (https://phabricator.wikimedia.org/T309755) [13:33:24] (03PS1) 10Esanders: Remove unnecessary vendor prefix [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/804579 [15:18:22] (03CR) 10Wfan: [C: 03+2] "test cases all pass, thanks for adding the cash payment method 😊" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804462 (https://phabricator.wikimedia.org/T302936) (owner: 10Ejegg) [15:20:51] (03Merged) 10jenkins-bot: Add gateway chooser test cases for bt and cash [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/804462 (https://phabricator.wikimedia.org/T302936) (owner: 10Ejegg) [16:01:13] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, and 3 others: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10AnnWF) Still seeing the invalid control error and... [16:40:43] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Centralnotices leaves lots of entries in LocalStorage - https://phabricator.wikimedia.org/T197463 (10Esanders) The kvStore does store expiry times (defaulting to 1/2year), but these just causes the data to be ignored once it has elapsed, and nothing... [17:57:44] 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10SHust) [18:03:49] 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10SHust) [18:05:39] 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10SHust) [18:36:28] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Centralnotices leaves lots of entries in LocalStorage - https://phabricator.wikimedia.org/T197463 (10AndyRussG) >>! In T197463#7995190, @Esanders wrote: > The kvStore does store expiry times (defaulting to 1/2year), but these just causes the data to... [20:38:34] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Centralnotices leaves lots of entries in LocalStorage - https://phabricator.wikimedia.org/T197463 (10Esanders) Ah, I see that the clearing happens in s separate file. I think a lot of the queueing and idle callback stuff is probably unnecessary give... [21:01:17] 10fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227 (10Jgreen) [21:01:19] 10Fundraising-Backlog, 10fundraising-tech-ops: TASK FORCE Investigate parent task "Adjust modsecurity rules to work for us" - https://phabricator.wikimedia.org/T246711 (10Jgreen) 05Open→03Declined Closing this task due to it being stalled for two years with no action. [21:02:30] 10fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227 (10Jgreen) [21:08:19] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Centralnotices leaves lots of entries in LocalStorage - https://phabricator.wikimedia.org/T197463 (10AndyRussG) >>! In T197463#7995711, @Esanders wrote: > Hopefully this approach will be good enough for CN to be able to drop the expiry code. Sounds... [21:13:27] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937 (10Jgreen) @Ejegg Was this task completed already? While testing ModSecurity the payments form appeared to check LUHN when I tried putti... [21:26:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Shut down the new style fundraising kafakatee collection in codfw - https://phabricator.wikimedia.org/T279097 (10Jgreen) 05Stalled→03Open a:03Jgreen [21:32:09] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Centralnotices leaves lots of entries in LocalStorage - https://phabricator.wikimedia.org/T197463 (10Esanders) I created https://www.measurethat.net/Benchmarks/Show/19293/1/localstoragesessionstorage-set-and-remove On the slowest browser we support... [21:42:30] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Centralnotices leaves lots of entries in LocalStorage - https://phabricator.wikimedia.org/T197463 (10Esanders) Looking then at @TheDJ 's original bug report, the items appear to have expiry dates, although they appear to be at least a year in the fut... [21:50:26] 10Fundraising-Backlog: Epic: Look at currency exchange rates, settlement amounts, and what more data could be saved - https://phabricator.wikimedia.org/T310402 (10Cstone) [21:50:54] 10Fundraising-Backlog, 10Epic: Epic: Look at currency exchange rates, settlement amounts, and what more data could be saved - https://phabricator.wikimedia.org/T310402 (10Cstone) [21:51:39] Thanks Christine for creating this epic story 😊 [22:48:21] 10Fundraising-Backlog: Large Searchkit result has a delay displaying pagination links and total amount of results - https://phabricator.wikimedia.org/T310406 (10Cstone) [22:49:07] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Error message when accessing Searchkit in Civi - https://phabricator.wikimedia.org/T310088 (10Cstone) @EMartin I created a separate ticket for the download issue here T310406