[00:12:43] dwisehaupt: can you check this is the timeslot - https://www.worldtimebuddy.com/?qm=1&lid=2643743,5391959,5,2193733&h=2643743&date=2022-6-30&sln=2-5&hf=1 (your link is today I think) [00:16:34] or alternatively https://www.timeanddate.com/worldclock/meetingdetails.html?year=2022&month=6&day=30&hour=1&min=0&sec=0&p1=2099&p2=179&p3=136&p4=224&p5=47 [00:26:44] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Add Braintree audit to the civi wmf_audit module - https://phabricator.wikimedia.org/T310758 (10AnnWF) a:03AnnWF [00:57:49] eileen: yeah. the 2nd one looks good to me. [00:58:17] so that's the time / day we agreed? [01:01:27] dwisehaupt: [01:03:18] yes [01:20:52] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Add Braintree audit to the civi wmf_audit module - https://phabricator.wikimedia.org/T310758 (10AnnWF) Test tips: https://github.com/civic... [07:26:50] 10Fundraising-Backlog, 10Thank-You-Page: Spanish Latam donors seeing English survey - https://phabricator.wikimedia.org/T281731 (10krobinson) Thanks @KHaggard We have asked for feedback on these and will let you know if donors confirm that to us (as we had the same idea). We have only seen this in Latam, and... [14:11:28] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10AMJohnson) TY @SHust! I haven't seen any others so I think it's cool to close this out. Possibly just donor error. [15:20:29] (03PS1) 10Mabualruz: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/807571 (https://phabricator.wikimedia.org/T255319) [15:39:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Shut down the new style fundraising kafakatee collection in codfw - https://phabricator.wikimedia.org/T279097 (10Jgreen) 05Open→03Resolved Done! [15:54:20] (03PS2) 10Mabualruz: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/807571 (https://phabricator.wikimedia.org/T255319) [15:57:28] (03PS14) 10Damilare Adedoyin: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) [16:32:37] our google meet calls keep breaking [16:32:57] or is it just me fr-tech? [16:33:08] https://meet.google.com/cxu-wjqo-twp [16:33:12] jgleeson: and yeah its broken [16:33:25] ah thanks [16:33:59] fr-tech ^ [16:45:15] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Dwisehaupt) [17:13:23] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912 (10Jgreen) [17:16:52] 10Fundraising-Backlog: Do not log CC exp date - https://phabricator.wikimedia.org/T86234 (10Jgreen) Worldpay is long gone and this task is specific to Worldpay. We should either make it a more general task because we are logging expiration elsewhere, or close it. Throwing it back into Triage to sort it out. [17:21:37] ok fr-tech, the IPN forwarding should be working. The puppet config key had changed. I updated the hiera values on this doc page: https://wikitech.wikimedia.org/wiki/Fundraising/Development_tools/Fundraising-dev#Setup_and_Administration [17:24:49] 10Fundraising-Backlog: paymentsipntest*.wmcloud.org addresses not working - https://phabricator.wikimedia.org/T308361 (10Ejegg) OK, this is fixed. The puppet config keys had changed. We needed to change it to profile::ssh::server::gateway_ports: true [17:25:22] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog: paymentsipntest*.wmcloud.org addresses not working - https://phabricator.wikimedia.org/T308361 (10Ejegg) p:05Triage→03Medium a:03Ejegg [17:26:39] ejegg: cool!!! thx! [17:30:25] fr-tech I'll be there soon [17:34:18] nice ejegg. I guess we'll have to keep an eye on the cloud services emails for stuff like that [18:32:03] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Implement Braintree Webhook signature validation - https://phabricator.wikimedia.org/T311169 (10jgleeson) [19:10:17] (03PS5) 10Jgleeson: WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [19:12:29] (03CR) 10CI reject: [V: 04-1] WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [19:40:41] (03PS1) 10Damilare Adedoyin: Add failed status when braintree payment errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/807608 [19:44:34] fr-tech if nobody is looking at those duplicate paypal donations, I'll pick up that ticket [19:51:34] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10fr-donorservices: Civi shows duplicate PayPal donations - https://phabricator.wikimedia.org/T311078 (10Ejegg) a:03Ejegg [19:54:27] (03PS15) 10Damilare Adedoyin: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) [19:59:23] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10fr-donorservices: Civi shows duplicate PayPal donations - https://phabricator.wikimedia.org/T311078 (10Ejegg) Looks like the audit parser is incorrectly tagging some donations as legacy 'paypal' instead of 'paypal_ec'. Since we sear... [20:01:14] (03CR) 10Jgleeson: Front-end calls to charge one-time donation via Braintree (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [20:10:32] (03PS6) 10Jgleeson: WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [20:11:06] (03PS1) 10Ejegg: PayPal audit: search one-time donations under both tags [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/807612 (https://phabricator.wikimedia.org/T311078) [20:11:30] ok fr-tech, I think that very small fix should stop those duplicates ^^^ [20:11:40] (03PS7) 10Jgleeson: WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [20:13:55] (03CR) 10CI reject: [V: 04-1] WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [20:14:52] that line looks good to me ejegg. just opening up fundraising tool to see how easy to test it is [20:15:32] tools* [20:17:04] ejegg: fancy adding a unit test to https://github.com/wikimedia/wikimedia-fundraising-tools/blob/2c82452c0af88052aa70fdfa58da11bbac2acc44/audit/paypal/tests/test_trr_file.py to cover that change in behaviour ? [20:18:26] gotta drop off but will check in tomorrow. bye for now fr-tech [20:44:26] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, and 4 others: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10Ejegg) I'm not findin... [20:56:39] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912 (10Jgreen) [20:57:27] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912 (10Jgreen) [20:58:54] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912 (10Jgreen) Decoupled a tree of WorldPay tasks because it's no longer relevant to this task. [21:02:21] fr-tech is anyone else having trouble getting a shell inside the docker containers? [21:02:24] OCI runtime exec failed: exec failed: unable to start container process: open /dev/pts/0: operation not permitted: unknown [21:02:54] I get that whether trying to run the payments phpunit tests with the script or just trying to docker-compose exec payments bash [21:04:12] let's see if restarting the container helps [21:04:54] yep, restart fixed it [21:05:12] shrug [21:06:35] hmm, donation queue consumer failmail? [21:06:38] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Documentation, 10Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (10Jgreen) [21:06:40] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912 (10Jgreen) [21:08:07] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912 (10Jgreen) 05Open→03Resolved a:03Jgreen [21:10:18] (03PS4) 10Ejegg: Filter out + signs from DLocal address fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/800033 (https://phabricator.wikimedia.org/T308167) [21:11:43] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, and 4 others: DLocal responses with 'Invalid control' - https://phabricator.wikimedia.org/T308167 (10Ejegg) OK, patch is u... [21:15:59] ooh, TypeError: Return value of CRM_Contact_Tokens::getTokenMetadata() must be of the type array, null returned in CRM_Contact_Tokens->getTokenMetadata() [21:15:59] where does that get called from? [21:33:17] hi XenoRyet, i'm in the meeting [21:33:34] Whoops, sorry, brt [22:37:29] (03CR) 10Ejegg: "Looking pretty good! Just a couple comments from a quick look at the code." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [22:40:02] (03PS2) 10Ejegg: Remove city as required field for gpay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805914 (https://phabricator.wikimedia.org/T310307) (owner: 10Wfan) [22:40:15] (03CR) 10Ejegg: [C: 03+2] "Thanks, looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805914 (https://phabricator.wikimedia.org/T310307) (owner: 10Wfan) [22:57:37] (03Merged) 10jenkins-bot: Remove city as required field for gpay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805914 (https://phabricator.wikimedia.org/T310307) (owner: 10Wfan) [23:59:44] (03CR) 10Jdlrobson: "AndyRussG could I please request your review on this one?" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/807571 (https://phabricator.wikimedia.org/T255319) (owner: 10Mabualruz)