[01:39:45] (03PS2) 10Ejegg: Remove unnecessary vendor prefix [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/804579 (owner: 10Esanders) [01:40:29] (03CR) 10Ejegg: [C: 03+2] "Yep, looks good. Seems to have been unnecessary for the last 10 years" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/804579 (owner: 10Esanders) [01:43:21] (03Merged) 10jenkins-bot: Remove unnecessary vendor prefix [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/804579 (owner: 10Esanders) [02:02:07] (03PS2) 10Ejegg: PayPal audit: search one-time donations under both tags [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/807612 (https://phabricator.wikimedia.org/T311078) [06:39:27] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/807721 (owner: 10L10n-bot) [09:07:35] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE, 10User-LokalProfil: Create internal documentation on Scrive use - https://phabricator.wikimedia.org/T257023 (10Jenny_Brandt_WMSE) Document is here: [[ https://docs.google.com/document/d/18hhMbffGceI-5fW5AzzVUyaHLFmH7vb_gJ9DqoE4Z9... [09:21:18] 10Fundraising-Backlog: Renewal of gcsip.com certificates - https://phabricator.wikimedia.org/T311211 (10RKumar_WMF) [11:52:02] (03PS16) 10Damilare Adedoyin: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) [11:56:23] (03CR) 10Damilare Adedoyin: "Thanks jgleeson and ejegg for the comments. Requested changes have been added to the new patchset." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [12:21:02] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/807721 (owner: 10L10n-bot) [12:45:52] 10Fundraising-Backlog, 10Data-Engineering, 10Event-Platform, 10MediaWiki-extensions-EventLogging, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [14:28:50] (03PS8) 10Jgleeson: WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [14:30:54] (03CR) 10CI reject: [V: 04-1] WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [14:56:15] (03CR) 10Jgreen: [C: 03+2] Improve error reporting for bad YAML syntax [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/803310 (https://phabricator.wikimedia.org/T161858) (owner: 10Jgreen) [14:57:26] (03Merged) 10jenkins-bot: Improve error reporting for bad YAML syntax [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/803310 (https://phabricator.wikimedia.org/T161858) (owner: 10Jgreen) [14:57:43] (03PS1) 10Wfan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808006 [14:57:44] (03PS1) 10Wfan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808007 [14:57:46] (03PS1) 10Wfan: wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) [14:58:15] (03PS2) 10Wfan: wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) [14:58:26] (03CR) 10CI reject: [V: 04-1] wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) (owner: 10Wfan) [14:58:38] (03CR) 10CI reject: [V: 04-1] wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) (owner: 10Wfan) [14:59:30] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Patch-For-Review: process-control should handle bad YAML syntax - https://phabricator.wikimedia.org/T161858 (10Jgreen) 05Open→03Resolved Patch is tested and merged for the next package release. [15:10:44] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Jgreen) [15:11:52] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Jgreen) [15:13:22] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Jgreen) [15:18:51] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Jgreen) [15:20:34] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Jgreen) [15:22:00] (03PS17) 10Jgleeson: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [15:22:02] (03PS9) 10Jgleeson: WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [15:28:01] (03PS1) 10Wfan: audit folder path typo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/808014 (https://phabricator.wikimedia.org/T310758) [15:30:34] (03CR) 10CI reject: [V: 04-1] WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [15:37:32] (03CR) 10Ejegg: [C: 03+2] audit folder path typo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/808014 (https://phabricator.wikimedia.org/T310758) (owner: 10Wfan) [15:52:40] (03Merged) 10jenkins-bot: audit folder path typo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/808014 (https://phabricator.wikimedia.org/T310758) (owner: 10Wfan) [16:03:46] (03PS3) 10Wfan: wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) [16:04:22] (03CR) 10CI reject: [V: 04-1] wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) (owner: 10Wfan) [16:20:24] (03PS4) 10Wfan: wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) [16:28:39] (03Abandoned) 10Ejegg: Use better-supported way to get username [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/788896 (owner: 10Ejegg) [16:53:51] (03Abandoned) 10Wfan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808006 (owner: 10Wfan) [16:53:58] (03Abandoned) 10Wfan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808007 (owner: 10Wfan) [16:54:31] (03PS5) 10Wfan: wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) [17:15:26] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Figure out best way to get Braintree audit files and then get them - https://phabricator.wikimedia.org/T310756 (10AnnWF) @Ejegg Since we a... [17:41:00] AndyRussG: I saw someone requesting review on this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/807571 [17:41:11] looks like a pretty safe one to merge as far as I can tell [17:41:37] the new hook fires at a slightly later time but seems to have the same effect [17:41:54] ejegg: ahh cool thx for the headsup! [17:42:21] I guess the idea is to stop using the SpecialPage hook first, then add the deprecation tag [17:42:26] to keep all the tests happy [17:42:48] at least that's what it seems like from the direction of the depends-on tag [17:43:42] k looking :) heheh I should open my Gerrit start page more often..... [17:43:51] 10Fundraising-Backlog, 10fundraising-tech-ops: Redis queues should use a key prefix - https://phabricator.wikimedia.org/T216633 (10Jgreen) @ejegg is this task still relevant? [17:44:20] (03CR) 10AndyRussG: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/807571 (https://phabricator.wikimedia.org/T255319) (owner: 10Mabualruz) [17:45:49] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Figure out best way to get Braintree audit files and then get them - https://phabricator.wikimedia.org/T310756 (10AnnWF) [17:46:49] 10Fundraising-Backlog, 10fundraising-tech-ops: Investigate increase syslog volume on civi1001 after buster upgrade - https://phabricator.wikimedia.org/T260000 (10Jgreen) 05Open→03Declined Closing this task because it's ~2 years old with no updates. We're still losing a small amount of logs at peak due to e... [17:49:13] 10Fundraising-Backlog, 10fundraising-tech-ops: make frdata inaccesible or delete everything - https://phabricator.wikimedia.org/T297893 (10Jgreen) 05Stalled→03Declined Closing because the task is not actionable as written. We would need to stop sending visitors to the site from various wikis first. [17:50:47] 10Fundraising-Backlog, 10fundraising-tech-ops: Investigate increase syslog volume on civi1001 after buster upgrade - https://phabricator.wikimedia.org/T260000 (10Jgreen) 05Declined→03Resolved [17:53:51] 10Fundraising-Backlog, 10FR-Tech-Analytics: Create a table showing failed attempted recurring charges per month - https://phabricator.wikimedia.org/T291214 (10Jgreen) [17:55:53] ok finally got those tests running ejegg. I needed to upgrade pip3 and after successfully installing the requirements I still see " /home/jack/.local/lib/python3.6/site-packages/redis/utils.py:12: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography and will be removed in a future release." [17:56:21] I guess I need to upgrade python too [17:56:26] oh hmm, good to know [17:56:49] mine seems to be 3.10.5 [17:57:05] but the one on prod is probably closer to 3.6 [17:57:32] prod has 3.7 [18:03:54] (03PS6) 10Wfan: wip: Add report or search for transactions (report is limited to paymentLevel) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) [18:18:03] (03CR) 10Jgleeson: [C: 03+2] "Code looks good to me and test confirms the alternative name is checked, which I confirmed locally. Thanks!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/807612 (https://phabricator.wikimedia.org/T311078) (owner: 10Ejegg) [18:19:22] (03Merged) 10jenkins-bot: PayPal audit: search one-time donations under both tags [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/807612 (https://phabricator.wikimedia.org/T311078) (owner: 10Ejegg) [18:29:55] thanks jgleeson! [18:29:59] deploying now [18:31:21] (03PS1) 10Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/808049 [18:37:27] 10fundraising-tech-ops: fundraising tech operations GDPR tracking task - https://phabricator.wikimedia.org/T226749 (10Jgreen) [18:38:50] np [18:39:14] donate wiki access! what a milestone [18:41:29] yep! Glad that we get it woohoo [18:42:36] Thanks Dylan and Peter ~ :) [18:45:26] +1 [19:15:58] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/808049 (owner: 10Ejegg) [19:17:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/808049 (owner: 10Ejegg) [19:21:34] !log fundraising python tools updated from 40d376d4 to acf89fb2 [19:21:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:35:01] fr-tech I'm gonna tag a new version of smashpig and update payments to pull it in so that the tests on this patch pass on CI https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/805906 [19:35:54] the tests are failing because of the version of smashpig being loaded in via the composer update during build doesn't have any braintree code [19:36:56] 👍 [19:38:53] (03CR) 10Jgleeson: [C: 03+2] "Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/807608 (owner: 10Damilare Adedoyin) [19:39:07] makes sense to merge that one first before we tag [19:39:22] (03Merged) 10jenkins-bot: Add failed status when braintree payment errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/807608 (owner: 10Damilare Adedoyin) [19:40:45] fr-tech, smashpig is currently at v0.7.9.9. Any objections to me tipping it over to 0.8 with the inclusion of braintree? [19:41:07] feels minor-increment worthy [19:41:11] at least [19:42:40] No objection here [19:42:56] cool cool [19:43:43] v0.8 lives https://packagist.org/packages/wikimedia/smash-pig#v0.8 [19:44:24] back in a bit kids going to bed [21:01:08] fr-tech: i'm going to start the db refresh of the staging dbs that eileen requested. i'll let her know it's running when i see her. it should complete in about 3 days and shouldn't have any impact on normal frdev functionality. [21:01:23] 10-4 [21:01:39] Have fun! [21:15:31] (03PS1) 10Jgleeson: Update smashpig to v0.8 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/808076 [21:17:20] fr-tech, is anyone around to +2 a composer version bump for smashpig on DI? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/808076/ [21:18:01] jgleeson: sure one sec [21:18:07] thanks [21:21:15] wow 8.0 oki [21:22:32] (03CR) 10AndyRussG: [C: 03+2] "A small step in a version number, a great leap for pig-smashing-ness!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/808076 (owner: 10Jgleeson) [21:24:49] (03Merged) 10jenkins-bot: Update smashpig to v0.8 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/808076 (owner: 10Jgleeson) [21:25:26] thanks AndyRussG !!! [21:25:59] :) thank u! [21:26:31] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/808077 [21:28:58] (03PS1) 10Jgleeson: Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/808078 [21:29:39] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/808077 (owner: 10Jgleeson) [21:31:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/808077 (owner: 10Jgleeson) [21:31:25] oh hey fr-tech here's a fun link I learned about earlier today: https://gerrit.wikimedia.org/r/q/attention:self [21:33:28] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/808078 (owner: 10Jgleeson) [21:34:39] 5 separate patches needed to update one composer package [21:35:10] I guess the smashpig new tag isn't a patch but it's a stage [21:37:33] (1) smashpig new tag, push to packagist. (2) update DI to pull in new smashpig version on master (3) merge DI patch to deployment and push (4) update mediwiki/vendor to in new composer files related to new smashpig version (5) update payments to pull in new DI and vendor submodules with composer.lock update [21:43:29] (03Merged) 10jenkins-bot: Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/808078 (owner: 10Jgleeson) [21:43:50] ok let's see if our tests pass now [21:44:11] (03PS18) 10Jgleeson: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [21:44:21] (03PS10) 10Jgleeson: WIP: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [21:51:48] woohooo [21:51:55] damilare: we got tests passing on CI [21:53:02] yaaayyyyy [21:53:47] (03PS11) 10Jgleeson: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [21:53:48] :) [22:01:42] Awesome! [22:01:49] (03CR) 10Jgleeson: [C: 03+1] "I'm feeling like this is ready to be +2ed! How about you @ejegg?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [22:02:19] damilare: I'll wait until Elliot gets a chance to confirm your updates but for me it's looking good [22:02:38] Sounds good jgleeson [22:02:56] and now it's laptop closing time [22:03:00] bye for now fr-tech [22:03:02] o/ [23:46:49] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Dwisehaupt) [23:47:19] 10fundraising-tech-ops: Deactivate fundraising accounts for mshaver - https://phabricator.wikimedia.org/T311159 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt [23:51:35] (03PS3) 10Jdlrobson: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/807571 (https://phabricator.wikimedia.org/T255319) (owner: 10Mabualruz)