[00:27:50] (03PS1) 10Eileen: Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 [00:28:54] can I get a +2 on that cache flush removal - if tests pass then it is 'fine' - but I need to re-run other tests once it is merged [00:29:13] I'm still struggling with the repo dance [00:32:53] cstone: or AndyRussG ^^ [00:35:07] eileen: sure one sec [00:39:05] (03CR) 10CI reject: [V: 04-1] Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 (owner: 10Eileen) [00:44:17] AndyRussG: dont worry - it failed jenkins [00:44:50] eileen: ohh awww [00:44:52] hmmm [01:07:08] hmmm inded that's quite a few errors [01:07:22] eileen: can I help at all by digging in? looking at stuff locally? [01:07:50] where did you something indicating that removing that flush could be necessary? [01:09:13] talking with Tim- because that flush is breaking the build with latest code - but it's doing 'something' needed [01:11:59] hmmmm oki sounds complex [01:19:38] (03PS2) 10Eileen: Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 [01:27:58] (03CR) 10CI reject: [V: 04-1] Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 (owner: 10Eileen) [01:28:02] (03PS4) 10Eileen: 5.51rc CiviCRM upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/805246 [01:41:11] (03CR) 10CI reject: [V: 04-1] 5.51rc CiviCRM upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/805246 (owner: 10Eileen) [01:41:24] (03PS1) 10Eileen: Specify Geocoder_BAO rather than derive it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809340 [01:42:37] (03PS2) 10Eileen: Put our workflow templates in our extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) [01:42:46] AndyRussG: I think I'm down to the fails that this would fix [01:42:47] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/809040 [01:46:32] (03PS5) 10Eileen: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801439 (https://phabricator.wikimedia.org/T303883) [01:46:40] (03PS5) 10Eileen: Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801440 (https://phabricator.wikimedia.org/T303883) [01:46:55] (03CR) 10Ejegg: [C: 03+2] "Hardcoded string seems correct. Looks like a heck of a nasty problem you're working through!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809340 (owner: 10Eileen) [01:47:33] So is it that AllCoreTables::init function that's messing up with the BAO load order? [01:47:53] I think it's a complicating factor [01:48:27] (03CR) 10Ejegg: "Couple comments might be updated - that one about 'this is in core temporarily' is on a bunch of the message classes" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) (owner: 10Eileen) [01:48:33] I've just pulled in a patch from Tim into https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/805246 & now it's only failing on workflow templates - [01:49:47] ejegg: if you are ok with that templates one other than minor things I might do them as a follow up - just cos of the the repo-jengo [01:50:21] ok, sure, let me just get your latest version of the civicrm one locally to try it out [01:56:50] (03PS3) 10Eileen: Put our workflow templates in our extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) [01:57:25] (03PS4) 10Eileen: Put our workflow templates in our extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) [01:57:46] (03PS5) 10Eileen: Put our workflow templates in our extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) [01:58:01] well I did some fixes [01:59:23] (03Merged) 10jenkins-bot: Specify Geocoder_BAO rather than derive it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809340 (owner: 10Eileen) [02:01:00] (03CR) 10CI reject: [V: 04-1] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801439 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [02:05:05] whew, docker civicrm upgrade is taking forever [02:06:11] ejegg: is that setup.sh? or something else? [02:07:30] AndyRussG: no, https://wmff.localhost:32353/civicrm/upgrade [02:07:44] ohh right hmmm [02:07:58] I guess that's the way to test what will happen on prod? [02:08:38] ejegg: one thing wfan has run into is PHPstorm inadvertently blocking PHP CLI via xdebug... things then continued to do stuff when she existed the IDE [02:08:55] even though there were no apparent breakpoints or visible debugging sessions [02:10:46] just finished [02:11:03] but yeah, i should probably turn off debugging for upgrades [02:12:08] I was thinking of an easy way to do it for cli scripts like what's run in setup.sh, but to completely disable the xdebug module under php-apache, you'll have to restart the web server (so, the civicrm container) [02:12:31] (which I guess is also not difficult, just a tiny bit more of a pain) [02:12:37] dang, trying to go to the status page to upgrade the extensions and it just pops up an alert 'db error no such table' [02:13:01] ejegg: yeah - `drush cvapi Extension.upgrade` [02:13:05] it's a pain [02:13:09] ok [02:15:02] Error 1: Maximum execution time of 30 seconds exceeded in /srv/civi-sites/wmff/civicrm/packages/DB/DataObject.php, line 518 [02:15:11] dang it, how do we increase that again? [02:16:41] hmm, seemed to get through the ext-upgrade anyway [02:16:54] ok, checking the custom workflow messages [02:19:56] hmm, trying to preview and endowment ty gives Error: Class 'Civi\WorkflowMessage\Civi' not found in Civi\WorkflowMessage\ThankYou->getAmount() (line 186 of /srv/civi-sites/wmff/drupal/sites/default/civicrm/extensions/wmf-thankyou/Civi/WorkflowMessage/ThankYou.php). [02:20:07] *an [02:20:25] are the previews working for you eileen? [02:20:37] well, I could try another flush [02:22:07] sigh - they were a couple of dances with the devil ago - let me retry [02:22:20] still no [02:22:52] sorry, it might have been an upgrade problem locally, I'm not sure [02:23:19] eileen with your latest rebase, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/801440 now has now changes it seems? (apologies if I'm just distracting...) [02:23:39] ejegg: should I try the same here? [02:23:51] I'm on 565ccf4259eb20adaf23913ef776e8542787e411 for the crm repo and da8406c983b37ad0e7bc3ee83495ad2d15459f03 for the civicrm submodule [02:24:04] AndyRussG: sure, go for it [02:24:41] My civicrm upgrade ran with no issues, but there was that sql execution timeout on updating the extensions (an 'update log tables' step) [02:24:43] ejegg: oki just gonna start with a fresh Civi Docker install [02:25:48] Ok - so the git combo per ejegg above is correct [02:25:57] ejegg: which patches should I be trying the upgrade on? [02:26:02] But I have to retry since a bit has happened today [02:27:12] AndyRussG: if you're doing a fresh install just get the latest of eileen's 801440 in the parent repo and the civicrm patch 're-add settings location' [02:28:55] ejegg: K doing a fresh install from master on crm, civicrm and buildkit repos, then I'll switch to those patches for the upgrade, mebbe? [02:29:25] ejegg: yeah - you found a bug - I fixed it in a different template but not that one - one moment [02:29:58] (03PS6) 10Eileen: Put our workflow templates in our extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) [02:30:04] ejegg: try ^^ [02:31:59] (03CR) 10Eileen: Put our workflow templates in our extension (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) (owner: 10Eileen) [02:36:28] (03PS1) 10Eileen: Port late-breaking schema change [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809342 [02:41:49] oki it's upgrading [02:44:12] Congratulations! Your upgrade was successful! [02:44:22] huh that was fast for me [02:45:18] my laptop is also on the older side with a pretty full drive [02:45:53] (03PS3) 10Eileen: Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 [02:46:03] hmmm I mean my home partition is also full-ish [02:46:46] hmm also web xdebug autostart is on.... [02:46:55] how older side is older side? [02:47:53] as happened with ejegg, status page gives an error... doing drush cvapi Extension.upgrade [02:48:40] (03CR) 10CI reject: [V: 04-1] Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 (owner: 10Eileen) [02:49:34] (03CR) 10CI reject: [V: 04-1] Port late-breaking schema change [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809342 (owner: 10Eileen) [02:53:48] oki extension upgrade seems to have worked :) [02:54:25] https://wmff.localhost:32353/civicrm/a/#/status works now [02:56:40] where's the menu to test the templates again? [02:57:19] admin->communications->message templates [02:57:38] then click the workflow tab [02:57:48] then select one of the WMF custom ones [02:58:32] and the preview is hidden in a button next to the 'token' dropdown on the HTML content bar [03:02:10] ok eileen, they seem to preview fine now [03:02:24] well, except for the failed recurring which says it has no example data [03:03:04] oh wait, that's not part of this patch [03:03:10] should it be? [03:05:06] Hmm, I guess it needs no class because it has no custom tokens [03:06:56] oh i see, it's already in the smashpig extension [03:08:02] thx ejegg [03:10:53] eileen: looks like the latest version of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/801440/5 is just empty now? Is there nothing left needed in core, not even those angular JS fixes? [03:14:51] ejegg eileen maybe that was an accidental rebase onto master? I'm guessing it should follow https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/805246 (or maybe it previously followed another upgrade patch?) [03:15:54] ejegg: yeah I'll double check those - but the workflow templates are gone [03:17:32] workflowing in the wind [03:18:45] ok, that parent repo patch moving the messages in seems to be working for me now. I'll have to head to bed soon, though, so I can't stick around to +2 all the civicrm submodule patches just yet [03:19:17] any risk in just +2ing the parent repo patch for now? [03:19:47] eileen: ^ ? [03:20:16] ejegg: I'm also around for another 2 hours or so, if you'd like to head out and I can wait for confirmation and +2 it when eeded [03:20:28] *needed [03:25:46] ejegg: AndyRussG nope - the parent repo one should be good [03:30:44] cool cool [03:31:06] (03CR) 10Ejegg: [C: 03+2] "Great to get them in the extension where they belong!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) (owner: 10Eileen) [03:31:18] ok, heading out. have a good one, folks! [03:32:59] ejegg|away: thx sam! [03:33:02] *same [03:33:31] (sorry I wasn't confusing you with sam heheh) [03:34:34] once that is merged I will recheck the civi upgrade [03:35:16] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), 10Patch-For-Review: Some parameters dropped by Special:GatewayChooser for recurring donations - https://phabricator.wikimedia.org/T310895 (10Christianjade1) 05Resolved→03Invalid [03:35:30] eileen: quick unimportant question... why to some of the old files end in ex.php and their equivalent ones now in the extension don't? [03:35:49] ah because Tim changes what is searched for in the ClassFinder update [03:36:02] contract-change [03:38:01] ah oki [03:38:42] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), 10Patch-For-Review: Some parameters dropped by Special:GatewayChooser for recurring donations - https://phabricator.wikimedia.org/T310895 (10JJMC89) 05Invalid→03Resolved [03:42:51] (03Merged) 10jenkins-bot: Put our workflow templates in our extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809040 (https://phabricator.wikimedia.org/T309250) (owner: 10Eileen) [03:43:07] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/805246 (owner: 10Eileen) [03:46:26] eileen: passed ci!!!! [03:46:45] ahh no wait might be a different one sorry [03:47:17] lol [03:47:50] ahh yeah I was looking at a "recheck" and V+2 on a different on [03:47:53] *one [03:48:07] AndyRussG: I'm not too worried about getting it merged today - sometime tomorrow am - cos I'm still consolidating the upgrade script to speed it up [03:48:43] oki [04:36:05] but I do want to get to the point where tests are not blocking [05:12:12] (03PS1) 10Eileen: Rationalise table alters on upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809472 [05:18:41] eileen: oki gonna head to sleep in a few minutes but if there's anything straightforward u need before, I have still a few tired neurons available [05:18:56] lol - no I think I have tricky things to deal with [05:22:48] k good luck! [05:25:46] (03CR) 10CI reject: [V: 04-1] Rationalise table alters on upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809472 (owner: 10Eileen) [12:59:58] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Network configuration for Braintree integration - https://phabricator.wikimedia.org/T303457 (10Jgreen) >>! In T303457#8034931, @Dwisehaupt wrote: > As mentioned in the sprint meeti... [13:06:03] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.4.2 - https://phabricator.wikimedia.org/T311540 (10Jgreen) 1.4.2 is installed and seems to be working normally in my test environment [13:19:53] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, and 3 others: Investigate Braintree Fraud Filter requirements - https://phabricator.wikimedia.org/T311625 (10jgleeson) [13:33:26] Any thoughts on this? https://meta.wikimedia.org/wiki/Talk:Fundraising#IPv6_on_payments.wikimedia.org? [13:42:20] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, and 3 others: Investigate Braintree Fraud Filter requirements - https://phabricator.wikimedia.org/T311625 (10jgleeson) The current PayPal Express... [13:45:44] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, and 3 others: Investigate Braintree Fraud Filter requirements - https://phabricator.wikimedia.org/T311625 (10jgleeson) @XenoRyet mentioned on our... [13:52:28] pcoombe: I think it's something that just hasn't made it to the front burner. It will take a fair amount of focused attention to go through all the systems and processes to find and fix anything that isn't ipb6 ready. [13:55:04] "ipv6" :-P typing is hrad. [15:13:50] ejegg|away: XenoRyet could you take a peek at https://phabricator.wikimedia.org/T311625 when you get a minute today [15:17:57] (03CR) 10Jgleeson: "One last bit of clean up an then it's ready for +2!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [15:18:34] damilare|brb: just spotted some stray comments in the braintree adapater. once they go I'll +2 it [15:18:52] and then we can break out the champagne [15:20:56] (03PS24) 10Damilare Adedoyin: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) [15:21:19] (03CR) 10Damilare Adedoyin: Front-end calls to charge one-time donation via Braintree (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [15:25:09] (03CR) 10Jgleeson: [C: 03+2] "LGTM! Nice work. The only outstanding question is on the antifraud stuff mentioned in https://phabricator.wikimedia.org/T31162 but we can " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [15:25:26] (03PS15) 10Jgleeson: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [15:27:49] (03Merged) 10jenkins-bot: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/801734 (https://phabricator.wikimedia.org/T303419) (owner: 10Damilare Adedoyin) [15:31:13] 10Fundraising-Backlog, 10fundraising-tech-ops: Vendor to Contractor Civi access - https://phabricator.wikimedia.org/T311548 (10MDemosWMF) Got it @Dwisehaupt I just updated her email on the Civi record. I'm not sure of the permission levels, but she should have the full capabilities now that she is working unde... [15:32:30] (03CR) 10CI reject: [V: 04-1] Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [15:49:23] (03PS16) 10Jgleeson: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [15:50:37] fr-tech I won't be round for standup. Just sent the usual Wednesday text standup around. back later [15:51:48] (03CR) 10CI reject: [V: 04-1] Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [16:09:56] (03PS5) 10Eileen: 5.51rc CiviCRM upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/805246 [16:23:45] (03CR) 10CI reject: [V: 04-1] 5.51rc CiviCRM upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/805246 (owner: 10Eileen) [17:04:30] (03PS1) 10Wfan: wip: Add test for civi run audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809644 (https://phabricator.wikimedia.org/T310758) [17:12:16] (03CR) 10CI reject: [V: 04-1] wip: Add test for civi run audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809644 (https://phabricator.wikimedia.org/T310758) (owner: 10Wfan) [17:14:12] (03PS1) 10Eileen: Try statics [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809645 [17:17:54] (03PS1) 10Eileen: or the missing break [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809646 [17:26:50] (03PS2) 10Wfan: wip: Add test for civi run audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809644 (https://phabricator.wikimedia.org/T310758) [17:26:53] (03CR) 10CI reject: [V: 04-1] Try statics [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809645 (owner: 10Eileen) [17:29:24] (03PS2) 10Eileen: Try statics [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809645 [17:30:40] (03CR) 10CI reject: [V: 04-1] or the missing break [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809646 (owner: 10Eileen) [17:39:07] (03CR) 10CI reject: [V: 04-1] wip: Add test for civi run audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809644 (https://phabricator.wikimedia.org/T310758) (owner: 10Wfan) [17:41:38] (03CR) 10CI reject: [V: 04-1] Try statics [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809645 (owner: 10Eileen) [17:59:32] (03PS1) 10Eileen: Throw some spaghetti [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809651 [18:12:05] (03CR) 10CI reject: [V: 04-1] Throw some spaghetti [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809651 (owner: 10Eileen) [18:27:23] (03PS3) 10Eileen: Try statics [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809645 [18:36:50] (03Abandoned) 10Eileen: Throw some spaghetti [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809651 (owner: 10Eileen) [18:36:58] (03Abandoned) 10Eileen: Try statics [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809645 (owner: 10Eileen) [18:37:05] (03Abandoned) 10Eileen: or the missing break [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809646 (owner: 10Eileen) [18:38:07] 10Fundraising-Backlog: What do we do about the additional cases where end users accidentally put sensitive data in the wrong form input - https://phabricator.wikimedia.org/T311664 (10XenoRyet) [18:38:23] (03PS1) 10Eileen: Do we get debug in tests - doesn't fail locally.... [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809655 [18:44:56] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [18:50:34] (03CR) 10CI reject: [V: 04-1] Do we get debug in tests - doesn't fail locally.... [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809655 (owner: 10Eileen) [19:16:38] (03PS1) 10Jgleeson: Update smashpig to v0.8.0.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/809663 [19:18:32] (03CR) 10CI reject: [V: 04-1] Update smashpig to v0.8.0.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/809663 (owner: 10Jgleeson) [19:19:02] fr-tech, can anyone +2 a quicker composer version bump for smashpig? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/809663/ [19:19:08] quick* [19:19:45] 10Fundraising Sprint Kermit hopping principle, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), 10Patch-For-Review: Some parameters dropped by Special:GatewayChooser for recurring donations - https://phabricator.wikimedia.org/T310895 (10HNordeenWMF) Hi @Pcoombe and @AndyRussG The Opt-in... [19:19:49] I've tagged v0.8.0.1 to pull in the latest on braintree and now gonna move payments to it so that our latest tests pass on CI [19:21:01] oh interesting [19:21:17] (03PS2) 10Jgleeson: Update smashpig to v0.8.0.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/809663 [19:21:20] dwisehaupt: sounds like they can re-do the staging data - [19:22:37] ok. sorry about that. been looking for other routes and coming up with dead ends. [19:25:32] (03PS1) 10Jgleeson: Update smashpig to v0.8.0.1 [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809667 [19:25:34] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809668 [19:29:03] (03PS1) 10Jgleeson: Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/809669 [19:32:00] (03PS17) 10Jgleeson: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [19:34:03] hmm, eileen, if I do a system.flush it clears out that dyn directory [19:34:06] (03PS1) 10Eileen: Temp hack - please tests pass [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809670 [19:34:16] and then reloading some pages regenerates something in there [19:34:29] but the filenames don't correspond with what the site is trying to load [19:34:50] could those have been some prod-specific generated filenames restored to the staging db? [19:34:58] I just can't see where in the DB they would live [19:35:06] (03CR) 10CI reject: [V: 04-1] Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [19:35:12] dwisehaupt: yeah my fault but they seem OK with it - [19:36:01] ejegg: I can't see a civi folder in sites/default/files [19:36:15] on staging - but I can on live [19:36:20] ohhh i was looking under the other path [19:36:30] /srv/org.wikimedia.civicrm-files/ [19:37:40] (03Abandoned) 10Jgleeson: Update smashpig to v0.8.0.1 [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809667 (owner: 10Jgleeson) [19:37:42] ok, so it's a base dir setting that's wrong maybe? [19:38:07] or a symlink got clobbered? [19:38:38] hmm maybe a symlink [19:38:50] dwisehaupt: did you restore any files - or only db? [19:38:51] (03PS18) 10Jgleeson: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [19:39:06] huh, that civicrm dir isn't a symlink on prod [19:39:16] no - but I swear it used to be [19:39:26] but its contents are basically the same as the /srv/org.wikimedia.civicrm-files/ dir on staging [19:40:14] oh wait, it's the /files dir that's the symlink on prod [19:40:33] and not a symlink on staging [19:40:38] lemme try to fix that [19:41:05] ok, server let me make that link [19:41:15] going to do another flush and reload the page [19:41:20] (03CR) 10jenkins-bot: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [19:41:49] yay, menubar is back! [19:42:01] says extension upgrades are pending [19:42:09] shall I run those on staging via the UI? [19:42:22] or should we hold off till we get everything passing CI? [19:42:38] you can run them - I thought I did [19:42:42] k [19:42:44] but - go ahead [19:43:18] ok, done [19:43:25] AndyRussG: cstone wfan damilare|brb XenoRyet do y'all have a minute to checkout a quick composer version bump pls? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/809663 [19:43:40] looking jgleeson [19:43:56] thanks ejegg [19:43:57] seems fine to me jgleeson [19:44:13] will pull down just to test [19:45:12] I have flights [19:45:12] thanks. Ill check back in a bit later and push all the other patches on top of it out [19:48:32] (03PS2) 10Eileen: Temp hack - please tests pass [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809670 [19:49:12] ejegg: so tests finally passed - but with a big hack - probably as good as it's gonna get today (I just edited [19:49:12] the comments in the patch - but not the patch so it should pass again) [19:53:01] (03Abandoned) 10Eileen: Port late-breaking schema change [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809342 (owner: 10Eileen) [20:01:07] (03CR) 10Wfan: [C: 03+1] "Looks good, I compared the https://packagist.org/, the version tie ~ +1 incase others want to check too" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/809663 (owner: 10Jgleeson) [20:11:32] (03PS6) 10Eileen: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801439 (https://phabricator.wikimedia.org/T303883) [20:11:34] (03PS1) 10Eileen: Rationalise table alters on upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809679 [20:12:43] dwisehaupt: this is the list of slow sql queries - https://etherpad.wikimedia.org/p/up-grade - they took ages last night on staging - at the upper end of my estimates - but then I realised that today we don't have to do them one at a time since they each only touch one table [20:13:30] (03Abandoned) 10Eileen: Do we get debug in tests - doesn't fail locally.... [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809655 (owner: 10Eileen) [20:14:13] (03CR) 10Ejegg: [C: 03+2] Update smashpig to v0.8.0.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/809663 (owner: 10Jgleeson) [20:17:51] oh man, this is the hack? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/809670/2 [20:17:55] pretty weird [20:19:14] ejegg: it's doing my head in cos it passes locally & everywhere except jenkins I think [20:19:30] I was thinking about talking to AndyRussG about getting redis working locally [20:20:13] we have the container - but it's not being used & when I enabled it (in civicrm.settings.php it didn't connect - my best guess is the localhost' vs container name ) [20:21:29] (03Merged) 10jenkins-bot: Update smashpig to v0.8.0.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/809663 (owner: 10Jgleeson) [20:21:31] in civicrm.settings.php define('CIVICRM_DB_CACHE_CLASS', 'Redis'); switches to Redis [20:22:19] ah i would think the jenkins container should have the simplest cache possible [20:22:25] so as not to rely on additional services [20:22:38] but it really has redis running? [20:22:55] looking [20:24:15] that's what I read into the memory hit & miss lines in the output [20:25:17] NB the other things that can be defined for Redis are `CIVICRM_DB_CACHE_HOST` , `CIVICRM_DB_CACHE_PORT` , `CIVICRM_DB_CACHE_TIMEOUT` and `CIVICRM_DB_CACHE_PREFIX` [20:27:55] (03PS6) 10Eileen: Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801440 (https://phabricator.wikimedia.org/T303883) [20:28:11] (03Abandoned) 10Eileen: Rationalise table alters on upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809472 (owner: 10Eileen) [20:28:55] I'm gonna get some breakfast but the chain ending in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/801440 should me mergeable now [20:42:29] eileen: ok cool. i'll have a look. there are some limitations on the number of threads mysql can effectively handle but it would be good to run them concurrent if we can. [21:46:12] thanks ejegg and wfan [21:47:19] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809668 (owner: 10Jgleeson) [21:47:27] 👏 [22:15:56] (03PS5) 10Wfan: WIP: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/809201 (https://phabricator.wikimedia.org/T310757) [22:16:29] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809711 [22:16:41] (03PS6) 10Wfan: WIP: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/809201 (https://phabricator.wikimedia.org/T310757) [22:17:22] (03Abandoned) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809668 (owner: 10Jgleeson) [22:17:44] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809711 (owner: 10Jgleeson) [22:18:25] (03PS2) 10Jgleeson: Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/809669 [22:19:16] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:(Need By: TBD) rack/setup/install frlog1002 - https://phabricator.wikimedia.org/T306839 (10Cmjohnson) [22:22:55] fr-tech is there a task/patch that adds braintree to the payment processors in civi? [22:23:02] i cant find it [22:23:08] nope, no task yet [22:23:24] should be pretty simple i think with the managed entities file in the smashpig extension [22:23:35] yeah looks straightforward wasnt sure if it had already been done [22:24:04] it would be good to get those civi patches merged through - a couple of hours now before the outage [22:24:23] yep eileen, just trying the upgrade locally [22:24:38] cool [22:24:44] i was reinstalling on master and got a lot of 'mixin loader could not find scanclasses' [22:24:52] ahh, i should reinstall on deployment instead [22:24:58] yuck [22:25:55] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/809711 (owner: 10Jgleeson) [22:26:51] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/809669 (owner: 10Jgleeson) [22:28:15] funny how mixins, extensions and modules all rely on slightly different metaphors [22:33:51] my head goes to python and ruby when I see mixins/modules [22:34:06] and mediawiki when I see extensions [22:34:17] so many extensions... [22:34:39] (03Merged) 10jenkins-bot: Update DonationInterface and vendor submodules [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/809669 (owner: 10Jgleeson) [22:34:56] I used get excited by the idea of multiple inheritance but I can't say I've ever really done anything with it [22:36:00] lol [22:37:59] (03CR) 10Jgleeson: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [22:38:38] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Network configuration for Braintree integration - https://phabricator.wikimedia.org/T303457 (10Damilare) @Jgreen and @Dwisehaupt the list of hosts and IPs provided would have to be... [23:06:01] (03PS19) 10Jgleeson: Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) [23:07:51] (03CR) 10CI reject: [V: 04-1] Tests: Front-end calls to charge one-time donation via Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [23:15:29] (03CR) 10Jgleeson: "This test is failing locally due to the email being empty when we get to the queue message. However, the email is set in the fixture data " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/805906 (https://phabricator.wikimedia.org/T303419) (owner: 10Jgleeson) [23:17:25] (03CR) 10Ejegg: [V: 03+2 C: 03+2] 5.51rc CiviCRM upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/805246 (owner: 10Eileen) [23:17:58] (03CR) 10Ejegg: [C: 03+2] "Weird, but doesn't look like it should break anything" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809670 (owner: 10Eileen) [23:18:05] (03CR) 10Ejegg: [C: 03+2] Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801439 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [23:18:23] (03CR) 10Ejegg: [C: 03+2] "This worked on my local upgrade!" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809679 (owner: 10Eileen) [23:18:28] (03CR) 10Ejegg: [C: 03+2] Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801440 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [23:43:20] (03Merged) 10jenkins-bot: Temp hack - please tests pass [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809670 (owner: 10Eileen) [23:44:32] (03Merged) 10jenkins-bot: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801439 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen) [23:44:34] (03Merged) 10jenkins-bot: Rationalise table alters on upgrade [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/809679 (owner: 10Eileen) [23:56:20] (03Merged) 10jenkins-bot: Re-add WMF code to support our templates [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/801440 (https://phabricator.wikimedia.org/T303883) (owner: 10Eileen)