[05:52:41] (03CR) 10AndyRussG: Implement separate auth and capture steps for Braintree (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812016 (owner: 10Damilare Adedoyin) [05:55:16] (03CR) 10AndyRussG: Run second round of filters and fail out if Validation action isn't process. Also fixed a minor JS bug that causes a redirect to the Thank y (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [07:53:00] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/812738 (owner: 10L10n-bot) [07:53:35] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/812745 (owner: 10L10n-bot) [08:04:14] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/812738 (owner: 10L10n-bot) [08:06:40] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/812745 (owner: 10L10n-bot) [12:00:15] (03PS3) 10Damilare Adedoyin: Implement separate auth and capture steps for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812016 (https://phabricator.wikimedia.org/T312289) [12:00:42] (03PS6) 10Damilare Adedoyin: Run second round of filters and fail out if Validation action isn't process. Also fixed a minor JS bug that causes a redirect to the Thank you page when payment fails [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [12:02:58] (03CR) 10Damilare Adedoyin: "Thanks Andy, fixed now" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [12:03:04] (03CR) 10CI reject: [V: 04-1] Run second round of filters and fail out if Validation action isn't process. Also fixed a minor JS bug that causes a redirect to the Thank you page when payment fails [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [12:04:15] (03PS7) 10Damilare Adedoyin: Investigate Braintree Fraud Filter requirements [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [12:06:40] (03CR) 10CI reject: [V: 04-1] Investigate Braintree Fraud Filter requirements [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [15:46:34] hi fr-tech! heads up that Bundle part #1 launching is launching in 15 minutes at 16 UTC! [15:57:07] hi haley_ , thanks for the heads-up! [15:58:03] fr-tech does anyone have a minute to review this? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/812041 [15:58:10] It's for that bundle part 1 [15:58:46] ejegg: yes on it [15:58:47] though I had the idea it wasn't needed toll the 15th, oops! [15:58:49] thanks AndyRussG [15:58:53] *till [15:59:45] haley_: just to let you know, the bundle part 1 countries (AT, ES, LU, BE) are still pointing to Ingenico. We have something ready to swap them to Adyen but it's not on production yet [16:00:27] thanks ejegg ! I kept the banners the same as the pre-test, pointing to gateway:'adyen', variant:'monthlyConvert_011', so that should be ok right? [16:02:20] haley_: yep, if it's specified in the banner it should go directly to adyen [16:02:57] ejegg: did u smoke test in a browser? I see the unit tests are updated.. should I smoke test locally or just +2? otherwise looks great :) [16:03:13] smoke test would be great! I just trusted the tests [16:03:24] ejegg: oki [16:07:27] (03CR) 10AndyRussG: [C: 03+2] "yaaayyyyyyy" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/812041 (https://phabricator.wikimedia.org/T312155) (owner: 10Ejegg) [16:07:42] thanks AndyRussG [16:08:01] ejegg: haley_ I also smoke tested locally the gateway=adyen locally without that patch, and it also went to Adyen correctly [16:08:05] ejegg: thank u! :) [16:08:48] I guess we should still probably deploy for those folks who are reminded by a banner, don't click, and then go to the sidebar [16:09:37] (03Merged) 10jenkins-bot: Switch 4 countries to default to Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/812041 (https://phabricator.wikimedia.org/T312155) (owner: 10Ejegg) [16:12:01] thanks Andy & Elliott! yeah I figured keep the banners pointing there so its not a rush on your part but that its better to have them all switch over eventually [16:13:04] cool thx much haley_ :) [16:43:17] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/812910 [16:43:22] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/812910 (owner: 10Ejegg) [16:44:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/812910 (owner: 10Ejegg) [16:59:22] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/812914 [16:59:25] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/812914 (owner: 10Ejegg) [17:02:51] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Network configuration for Braintree integration - https://phabricator.wikimedia.org/T303457 (10Jgreen) I emailed Paypal on 2022-07-07 to... [17:10:18] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/812914 (owner: 10Ejegg) [18:10:31] (03CR) 10AndyRussG: Investigate Braintree Fraud Filter requirements (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [18:14:49] Hi AndyRussG:, this is the document Braintree fab ticket, Elliott created one before :) https://phabricator.wikimedia.org/T303452 [18:17:54] ah cool, thanks wfan :) [18:19:50] Hi Elliot, do you have a minutes for the audit parse ticket? [18:22:01] sure, let me just push up a settings change for review [18:22:21] thanks~ [18:26:38] (03CR) 10Ejegg: "Let's be consistent with the param name for the gateway_txn_id in approvePayment" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812016 (https://phabricator.wikimedia.org/T312289) (owner: 10Damilare Adedoyin) [18:30:02] (03PS1) 10Ejegg: Update MonthlyConvertCountries [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/812920 (https://phabricator.wikimedia.org/T312155) [18:31:29] AndyRussG: hi! Thanks for the CR earlier. There's a config setting to deploy too, for the MonthlyConvert by default. Would you have a minute to take a look at it on prod? I also added the setting to fundraising-dev ^^^. Not sure if we actually want US to be MC be default in dev, but it'll at least let you test the current prod setting if you want. [18:33:40] (03PS4) 10Damilare Adedoyin: Implement separate auth and capture steps for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812016 (https://phabricator.wikimedia.org/T312289) [18:35:24] (03PS8) 10Damilare Adedoyin: Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [18:37:54] (03CR) 10CI reject: [V: 04-1] Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [18:38:42] (03CR) 10Damilare Adedoyin: "Thanks alot Andy for the documentation. It's really helpful." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [18:41:29] (03CR) 10Damilare Adedoyin: "Thanks Ejegg." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812016 (https://phabricator.wikimedia.org/T312289) (owner: 10Damilare Adedoyin) [19:11:57] ejegg: oki cool looking [19:16:49] thanks AndyRussG [19:31:14] ejegg: prod change looks fine! though it seems now it's for all processors, not just Ingenico [19:31:27] is that correct, for example for Paypal and Amazrn [19:31:29] ? [19:53:08] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Ingenico/Worldline production key expiring 14 July - https://phabricator.wikimedia.org/T312662 (10XenoRyet) [19:54:24] AndyRussG: that's right, but it won't affect the ones which don't implement RecurringConversion [19:54:26] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Turn on Post-payment Monthly Convert as default for France & Netherlands - https://phabricator.wikimedia.org/T312596 (10XenoRyet) [19:55:24] ejegg: hmm oki also isn't it adding more countries than requested on the task? [20:09:54] AndyRussG: it should be adding the 4 countries on the task and alphabetizing the ones that were already on the list [20:21:25] ejegg: oh I see [20:21:45] ejegg: and also making them all have that for all processors, not just Ingenico [20:22:19] yep [20:22:38] but as mentioned that's all processors which implement RecurringConversion [20:22:45] and those are just Ingenico + Adyen [20:43:09] 10Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Smashpig: Add multiple currency support to Braintree - https://phabricator.wikimedia.org/T312808 (10Ejegg) [20:45:52] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Turn on Post-payment Monthly Convert as default for France & Netherlands - https://phabricator.wikimedia.org/T312596 (10Ejegg) @EMartin We should probably make sure the monthly convert language and amounts look good for each market before we defau... [20:48:43] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Turn on Post-payment Monthly Convert as default for France & Netherlands - https://phabricator.wikimedia.org/T312596 (10EMartin) @Ejegg Sure, I was more thinking that the capability is built and tested so why not turn it on for all. We wouldn't g... [21:36:17] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Turn on Post-payment Monthly Convert as default for France & Netherlands - https://phabricator.wikimedia.org/T312596 (10Ejegg) a:03Ejegg [21:42:17] AndyRussG: I've done local smoke tests with paypal ec using the new settings and there's no monthly convert showing [21:42:50] I also made a further change on prod to add France and NL to MonthlyConvertCountries (both were already defaulting to Adyen) [21:42:58] ejegg: cool thx! k I was just adding a braekpoint to showMonthlyConvert heheh [21:43:23] ejegg: I checked the changes to local settings for prod and it looks great :) [21:43:31] I'll add FR and NL to that dev settings patch [21:43:43] ah oki cool [21:44:20] (03PS2) 10Ejegg: Update MonthlyConvertCountries [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/812920 (https://phabricator.wikimedia.org/T312155) [21:44:36] ejegg: wait but why? they're not on the prod change? [21:44:51] Those two came in on a second ticket [21:45:04] so I just pushed a second prod settings change [21:45:08] with just those two [21:45:18] T312596 [21:45:18] T312596: Turn on Post-payment Monthly Convert as default for France & Netherlands - https://phabricator.wikimedia.org/T312596 [21:45:29] brb [21:48:20] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Turn on Post-payment Monthly Convert as default for France & Netherlands - https://phabricator.wikimedia.org/T312596 (10TSkaff) Hi EMartin! Let's keep this to the task at hand (France, NL) for now. For each new country where we run MC post-paymen... [21:49:19] ejegg: oki cool thx... yea second prod change looks fine too [21:50:27] only one additional thought... I see the bug numbers are linked in the localsettings commit messages, which makes them potentially findable... still might be nice to add them (both tasks for adding MC) in a comment in LocalSettings.php? again just a thought, not a blocker [21:52:34] AndyRussG: do you think the tickets add that much context? [21:52:58] for more complex changes I'd say sure, but here the ticket is just 'turn it on for xyz' [21:53:17] ejegg: ok sure yeah good point [23:22:10] (03PS9) 10Wfan: Add test for civi run audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809644 (https://phabricator.wikimedia.org/T310758) [23:25:44] (03PS7) 10Wfan: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) [23:26:11] (03CR) 10CI reject: [V: 04-1] Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) (owner: 10Wfan) [23:27:58] (03PS8) 10Wfan: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) [23:28:27] (03CR) 10CI reject: [V: 04-1] Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) (owner: 10Wfan) [23:31:55] (03PS9) 10Wfan: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) [23:34:08] (03PS10) 10Wfan: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) [23:35:49] (03CR) 10CI reject: [V: 04-1] Add test for civi run audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809644 (https://phabricator.wikimedia.org/T310758) (owner: 10Wfan) [23:36:15] Hi ejegg: the audit parse is ready for test now, three patches: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/808008/, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/812100/ and https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/809644/, thanks!