[00:12:12] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10XenoRyet) Ok, let me give a little more context on what we actually found. If the donor naturally picks a recurring donation in a market where we have monthly convert on by def... [00:21:56] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10TSkaff) That's super helpful context Dylan, thank you. So did many folks from fr-tech test/vet it then? I was going to keep trying a bit more this evening b/c this issue was on... [00:24:01] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10XenoRyet) @TSkaff I think if you got two successful attempts, then you're getting the flow that fr-tech expects, so probably no reason to keep trying, but I don't think we can us... [01:17:53] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Cstone) I just tested it three times and wasn't able to replicate, I will try again tomorrow though. [02:09:49] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10EMartin) @XenoRyet Thanks for the explanation, but if we have turned off MC presently by shutting down the campaign, how can we test this as being resolved? [02:24:26] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10XenoRyet) I think the way forward is to have some more folks try test recurring donations from the updated banner, with the monthly convert variant hardcoding removed, in a conte... [05:24:56] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/813416 (owner: 10L10n-bot) [05:26:45] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] (REL1_38) - 10https://gerrit.wikimedia.org/r/813422 (owner: 10L10n-bot) [06:22:07] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813531 (owner: 10L10n-bot) [06:28:32] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813531 (owner: 10L10n-bot) [07:06:28] 10Fundraising-Backlog, 10fr-donorservices: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10krobinson) Just catching up on this - thank you for all of the context. We will work to refund / cancel duplicates. As we saw this in the pretest (and I'm guessing the same co... [07:13:58] 10Fundraising-Backlog: Monthly Convert variant on a recurring donation is pausing on the modal - https://phabricator.wikimedia.org/T312905 (10AndyRussG) Hi all! OK figured out what's going on here... In summary, this is a due to a disconnect between client-side and server-side logic to determine whether or not... [07:27:51] (03PS1) 10AndyRussG: Check for monthly convert DOM elements in Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) [07:46:54] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10AndyRussG) Hi all! Thanks so so much everyone for the work on this... Quick update: I've tracked down the full t... [07:46:59] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10AndyRussG) [07:47:01] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10Patch-For-Review: Monthly Convert variant on a recurring donation is pausing on the modal - https://phabricator.wikimedia.org/T312905 (10AndyRussG) [09:55:38] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Pcoombe) >>! In T310915#8073934, @TSkaff wrote: > That's super helpful context Dylan, thank you. So did many folk... [09:57:05] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Pcoombe) >>! In T310915#8074043, @krobinson wrote: > Just catching up on this - thank you for all of the context.... [10:48:42] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Pcoombe) >>! In T310915#8073773, @EMartin wrote: > @Fr-Tech. I just forwarded a thread from Adyen with a question... [12:49:04] !log payments-wiki upgraded from 2f95d8b4 to 6a8aa302 [12:49:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:04:12] (03CR) 10Damilare Adedoyin: [C: 03+1] "Thanks for this patch AndyRussG, tested and looks good to me. Just left a tiny comment inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) (owner: 10AndyRussG) [14:06:06] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Pcoombe) Bundle banners went back up at 10:58 UTC without the variant=monthlyConvert_011 parameter, and I don't s... [14:17:16] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1612 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [14:22:16] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 428959 Threads: 10 Questions: 9541976 Slow queries: 221 Opens: 81330418 Flush tables: 1 Open tables: 200 Queries per second avg: 22.244 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1002&service=check_mysql [14:32:08] (03CR) 10Cstone: [C: 03+1] "Looks good to me too and I agree with Dami's name clarification suggestion" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) (owner: 10AndyRussG) [14:43:26] hi fr-tech - looks like you figured out a monthly convert problem yesterday? [14:45:20] hi ejegg and yeah https://phabricator.wikimedia.org/T312905 [14:46:25] oh fun. [14:47:01] (03CR) 10Jforrester: [C: 03+2] Bump minimum required version for upgrade to 1.31 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/784336 (owner: 10Umherirrender) [14:47:04] I wonder what the best redesign for monthly convert would be [14:47:22] seems best if we could avoid it being a variant at all [14:47:41] (03CR) 10Jforrester: [C: 03+2] schema: Move all sql files to own folder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/787910 (owner: 10Umherirrender) [14:47:42] but I guess we still want to allow variants to change the text [14:48:12] (03CR) 10Jforrester: [C: 03+2] Standardise type for timestamp columns [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/804774 (https://phabricator.wikimedia.org/T310447) (owner: 10Umherirrender) [14:52:26] (03CR) 10Jforrester: [C: 03+2] schema: Move inital inserts from sql file to extension update [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/805242 (owner: 10Umherirrender) [14:53:34] (03CR) 10Jforrester: [C: 03+2] Convert to abstract schema [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/805233 (https://phabricator.wikimedia.org/T268539) (owner: 10Umherirrender) [15:05:29] (03Merged) 10jenkins-bot: Bump minimum required version for upgrade to 1.31 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/784336 (owner: 10Umherirrender) [15:05:31] (03Merged) 10jenkins-bot: schema: Move all sql files to own folder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/787910 (owner: 10Umherirrender) [15:05:33] (03Merged) 10jenkins-bot: Standardise type for timestamp columns [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/804774 (https://phabricator.wikimedia.org/T310447) (owner: 10Umherirrender) [15:05:35] (03Merged) 10jenkins-bot: schema: Move inital inserts from sql file to extension update [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/805242 (owner: 10Umherirrender) [15:05:37] (03Merged) 10jenkins-bot: Convert to abstract schema [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/805233 (https://phabricator.wikimedia.org/T268539) (owner: 10Umherirrender) [15:07:20] hi ejegg cstone fr-tech [15:07:38] (03CR) 10Wfan: Braintree Audit parse donation, refund and chargeback (035 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) (owner: 10Wfan) [15:08:30] damilare: do you still review on that second step? [15:08:48] let's try and get that through today to help us hit the thursday EOD target [15:13:31] damilare: thx for the review on the mc fix! [15:14:06] jgleeson: damilare: yeah sorry I didn't continue reviewing yesterday..... was just focused on monthly convert [15:14:29] also hi damilare jgleeson fr-tech :) [15:14:50] hi AndyRussG ! [15:14:51] cstone also thx for the review and also hi cstone ejegg! [15:15:21] howdy fr-tech. I'm back from the airport now, but looks like the meeting with Peter and Emma got pushed? [15:15:47] yeah XenoRyet [15:16:05] hi XenoRyet [15:16:16] XenoRyet: jgleeson ohhh oki that explains why noone was there [15:17:54] pcoombe: sent an email a little earlier AndyRussG [15:19:08] ah thx jgleeson [15:20:00] yeah, sorry for the short notice [15:20:12] AndyRussG: is this a fix for the bug on last night's call? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/813583 [15:20:21] at least I'll get to chat with some of you next week \o/ [15:20:36] ah no worries pcoombe and thx for all the work yesterday :) and yeah! [15:21:09] jgleeson: yep! just gonna push up a quick update following CR from damilare and cstone [15:21:17] ah nice [15:23:11] I guess with that being an UBN we should push that out first [15:23:42] once +2ed by damilare or cstone [15:26:14] Yea, with the banner workaround it's not an emergency anymore, but I think still best to get it wrapped up before we set it down. [15:26:58] (03PS2) 10AndyRussG: Check for monthly convert DOM elements in Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) [15:28:14] jgleeson: hi jgleeson, yes please. I’ve deployed the update to smashpig [15:28:43] AndyRussG: no problem [15:28:55] yep! I can see it passing on CI. I'm doing an end to end test locally as I haven't tried out the new two-step stuff yet [15:30:03] No p, thanks [15:30:26] (03PS3) 10AndyRussG: Check for monthly convert DOM elements in Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) [15:32:10] :) [15:35:13] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) (owner: 10AndyRussG) [15:39:53] (03PS1) 10Ejegg: Fix Adyen API param names [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813648 (https://phabricator.wikimedia.org/T312906) [15:40:09] jgleeson: that'll get rid of our warnings ^^^ [15:40:38] thanks AndyRussG and damilare for that work + CR on the monthly convert problem! [15:41:16] ejegg: thank u :) [15:41:29] So it's a bit ugly that we have to build MC logic into the API response handler code for each separate gateway, huh? [15:41:58] Should we have some kind of hook that is always called, which the MC script can attach to? [15:43:03] sounds good [15:43:11] I'll write a ticket to refactor MonthlyCovert [15:43:43] ejegg: yeah was gonna suggest exactly that, thx :) [15:48:50] looking ejegg [15:51:15] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Refactor MonthlyConvert feature - https://phabricator.wikimedia.org/T312958 (10Ejegg) [15:53:08] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Platform Team Initiatives (Abstract Schema): Convert CentralNotice to AbstractSchema - https://phabricator.wikimedia.org/T268539 (10Jdforrester-WMF) [15:53:22] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10PostgreSQL: CentralNotice doesn't work with Postgres: ERROR: relation "cn_notices" does not exist - https://phabricator.wikimedia.org/T271002 (10Jdforrester-WMF) [15:53:50] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Platform Team Initiatives (Abstract Schema): Convert CentralNotice to AbstractSchema - https://phabricator.wikimedia.org/T268539 (10Jdforrester-WMF) 05Open→03Resolved This is now landed in master but not wmf-deploy; I guess that's sufficient... [15:54:13] (03Merged) 10jenkins-bot: Check for monthly convert DOM elements in Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813583 (https://phabricator.wikimedia.org/T312905) (owner: 10AndyRussG) [15:59:08] (03CR) 10Wfan: [C: 03+2] Fix Adyen API param names [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813648 (https://phabricator.wikimedia.org/T312906) (owner: 10Ejegg) [15:59:41] thanks wfan [16:00:05] :) looks good and np [16:01:11] (03CR) 10Jgleeson: [C: 03+2] "LGTM. Tested locally and warnings are now removed!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813648 (https://phabricator.wikimedia.org/T312906) (owner: 10Ejegg) [16:02:54] (03Merged) 10jenkins-bot: Fix Adyen API param names [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813648 (https://phabricator.wikimedia.org/T312906) (owner: 10Ejegg) [16:17:02] 10Fundraising-Backlog, 10fr-donorservices: Report potential unintended duplicate donations - https://phabricator.wikimedia.org/T312964 (10Pcoombe) [16:19:12] 10Fundraising-Backlog: Turn on Adyen & Post-payment convert for Bundle #2 countries: DK, IL, NO, PT, MY - https://phabricator.wikimedia.org/T312965 (10HNordeenWMF) [16:20:45] 10Fundraising-Backlog: Turn on Adyen & Post-payment convert for Bundle #2 countries: DK, IL, NO, PT, MY - https://phabricator.wikimedia.org/T312965 (10HNordeenWMF) [16:21:44] (03PS1) 10Wfan: Add report or search result for transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/813655 (https://phabricator.wikimedia.org/T310756) [16:23:27] (03Abandoned) 10Wfan: Add report or search result for transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/808008 (https://phabricator.wikimedia.org/T310756) (owner: 10Wfan) [16:23:33] (03Abandoned) 10Wfan: Braintree Audit parse donation, refund and chargeback [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) (owner: 10Wfan) [16:23:34] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Turn on Adyen & Post-payment convert for Bundle #2 countries: DK, IL, NO, PT, MY - https://phabricator.wikimedia.org/T312965 (10XenoRyet) [16:29:23] ejegg: I have both smashpig commits to one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/813655/ Thanks :) [16:29:56] fr-tech it looks like the only imports that are running slow are recurring [16:30:02] oops wrong chan [16:38:49] thanks wfan [17:55:17] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10PostgreSQL: CentralNotice doesn't work with Postgres: ERROR: relation "cn_notices" does not exist - https://phabricator.wikimedia.org/T271002 (10Umherirrender) 05Stalled→03Resolved a:03Umherirrender A postgres schema was added as part of ht... [17:55:54] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Platform Team Initiatives (Abstract Schema): Convert CentralNotice to AbstractSchema - https://phabricator.wikimedia.org/T268539 (10Umherirrender) >>! In T268539#8075337, @Jdforrester-WMF wrote: > This is now landed in master but not wmf-deploy;... [18:40:17] (03PS10) 10Damilare Adedoyin: Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [18:46:51] (03PS11) 10Damilare Adedoyin: Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [19:06:14] (03CR) 10Jgleeson: [C: 03+1] "end-to-end test worked well!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [19:07:54] (03PS12) 10Damilare Adedoyin: Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [19:12:44] (03CR) 10CI reject: [V: 04-1] Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [19:22:57] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Delete Globalcollect adapter, fold still-used code into Ingenico adapter - https://phabricator.wikimedia.org/T260725 (10Jgreen) [19:23:09] (03PS13) 10Damilare Adedoyin: Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) [19:27:13] (03CR) 10Damilare Adedoyin: "Thanks for the review everyone." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [19:28:04] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [19:28:25] (03CR) 10AndyRussG: [C: 03+2] "Wooohhooo congrats everyone!!!! :) :) :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [19:28:39] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [19:46:05] (03Merged) 10jenkins-bot: Add second round of filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/811746 (https://phabricator.wikimedia.org/T311625) (owner: 10Damilare Adedoyin) [21:55:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate queue consumer slowdown in pretest of June 13 2022 - https://phabricator.wikimedia.org/T313000 (10Ejegg) [21:55:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate queue consumer slowdown in pretest of June 13 2022 - https://phabricator.wikimedia.org/T313000 (10Ejegg) [23:04:37] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree local settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) [23:05:12] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree credentials to config on production - https://phabricator.wikimedia.org/T312144 (10AndyRussG) [23:05:14] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree local settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) [23:10:50] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree credentials to config on production - https://phabricator.wikimedia.org/T312144 (10AndyRussG) [23:11:34] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) [23:19:27] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) [23:19:48] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Add Braintree settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) [23:30:04] (03PS1) 10AndyRussG: Add Braintree at the end of GatewayChooser defaults [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813722 (https://phabricator.wikimedia.org/T313001) [23:31:12] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10Patch-For-Review: Add Braintree settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) Update for payments-wiki-staging/LocalSettings.php pushed to localsettings repo on frpm1001 for revi... [23:32:02] fr-tech if anyone would like to review the patch for braintree config in the localsettings repo, and the update to the gateway chooser rules in extension.json ^ many thanks in advance!! [23:48:31] AndyRussG: that settings patch looks fine [23:49:24] though now i'm wondering if we actually use that resultswitcher page ever [23:49:33] we don't seem to send it as a URL anywhere [23:50:28] since donors log in to their paypal account in a popup rather than a redirect, we don't need it for that flow [23:52:29] (03CR) 10Ejegg: [C: 03+2] Add Braintree at the end of GatewayChooser defaults [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813722 (https://phabricator.wikimedia.org/T313001) (owner: 10AndyRussG) [23:52:49] ejegg: ah oki yeah I wasn't sure, just saw it in fr-dev [23:52:58] if you like add a patch to remove it? [23:53:26] ejegg: also if you'd like u could have a peek at the above task ^ to see if I've missed/mistaken anything (very likely) [23:53:29] maybe after we implement Venmo if that doesn't use a redirect either [23:53:33] thx also for the review! [23:53:50] mmm better to leave it off for now if we don't need it? [23:54:47] (03Merged) 10jenkins-bot: Add Braintree at the end of GatewayChooser defaults [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813722 (https://phabricator.wikimedia.org/T313001) (owner: 10AndyRussG) [23:55:10] Venmo isn't in the requirements for internal test, but if it's quick and we're waiting on credentials anyway... [23:55:11] nothing else occurs to me right now [23:55:29] AndyRussG: well we should delete the whole page + class if we really don't need it [23:57:45] oh so the page and class are there? hmmm [23:59:48] https://developer.paypal.com/braintree/docs/guides/3d-secure/overview