[00:00:47] ejegg: oki so let's leave the class in the DI codebase, since it's fine as a placeholder, but keep it off the allow list on prod/staging until we know it's used... that feels like the best combination of security and not undoing something potentially useful sometime not to far from now? [00:01:21] XenoRyet: I have no idea how venmo would work... I imagine we'd need creds from braintree for that too? [00:02:25] yes, that's a but more setup [00:02:40] ok, sure, let's keep it off the allowlist [00:03:00] oki :) thanks for noting that :) [00:22:04] ejegg: oki pushed the updated LocalSettings.php for staging [00:24:36] if you're good with that I can deploy the whole shtick in about 2 hrs or so [00:26:47] just the Braintree to staging shtick I mean [00:27:19] unless or others would be around, I'd wait until more folks are online to do a live payments deploy, since there is a campaign running [00:34:31] *unless u or others [01:03:24] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Add Braintree settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) [01:13:49] AndyRussG: yeah that all looks OK for staging [01:34:45] (03PS1) 10Ejegg: Switch four countries to Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813731 (https://phabricator.wikimedia.org/T312965) [01:42:06] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10Patch-For-Review: Turn on Adyen & Post-payment convert for Bundle #2 countries: DK, IL, NO, PT, MY - https://phabricator.wikimedia.org/T312965 (10Ejegg) a:03Ejegg [01:42:08] AndyRussG: does that look OK? ^^^ [01:47:46] AndyRussG: I think there's not a full campaign running right now - just three hour tests, right? [01:55:36] (03PS2) 10Ejegg: Add report or search result for transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/813655 (https://phabricator.wikimedia.org/T310756) (owner: 10Wfan) [02:00:59] ejegg: great thanks! I'll take a look in about 25 minutes, still gotta walky wog [02:02:01] thanks AndyRussG [02:21:56] (03CR) 10Ejegg: "Hi Wfan, it looked like the first squashed version didn't get all the fixes from PS13 of If33b7ed1c0b3d18aade07fc6fba027fbcd790b41. I trie" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) (owner: 10Wfan) [02:26:18] Thanks ejegg, afk now, will take a look tmr morning 😊 [02:44:27] (03CR) 10AndyRussG: [C: 03+2] "Coool thx for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813731 (https://phabricator.wikimedia.org/T312965) (owner: 10Ejegg) [02:46:55] AndyRussG: thanks for the CR! Maybe we can get that and the matching settings out tomorrow morning before the pretest mentioned on that ticket [02:47:02] (03Merged) 10jenkins-bot: Switch four countries to Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813731 (https://phabricator.wikimedia.org/T312965) (owner: 10Ejegg) [02:47:03] will do those settings now [02:49:39] ok, settings pushed [02:49:45] have a good night all [04:38:10] (03PS1) 10AndyRussG: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/813732 [04:39:52] (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/813732 (owner: 10AndyRussG) [04:40:47] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/813732 (owner: 10AndyRussG) [04:44:47] (03PS1) 10AndyRussG: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/813733 [04:45:21] (03CR) 10AndyRussG: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/813733 (owner: 10AndyRussG) [04:55:51] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/813733 (owner: 10AndyRussG) [05:07:53] !log update payments-wiki-staging 10304f69 -> be11fac2 [05:07:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:56:00] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Add Braintree settings on production - https://phabricator.wikimedia.org/T313001 (10AndyRussG) As much as possible of this is done for payments-wiki-staging. Once we have... [06:06:18] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, and 3 others: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10AndyRussG) This seem... [06:54:43] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813772 (owner: 10L10n-bot) [09:00:27] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813772 (owner: 10L10n-bot) [11:06:19] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] (REL1_38) - 10https://gerrit.wikimedia.org/r/813422 (owner: 10L10n-bot) [13:19:43] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, and 3 others: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10Jgreen) >>! In T3034... [13:43:14] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, and 3 others: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10Jgreen) @andyrussg n... [14:41:56] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [14:49:03] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [14:59:22] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:10:10] !log updated payments-wiki from 6a8aa302 to be11fac2 [15:10:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:14:06] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:15:50] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:20:56] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:22:04] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:22:46] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:46:41] (03PS3) 10Wfan: Add report or search result for transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/813655 (https://phabricator.wikimedia.org/T310756) [15:47:02] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:48:03] (03CR) 10Wfan: Braintree Audit parse donation, refund and chargeback (034 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/812100 (https://phabricator.wikimedia.org/T310757) (owner: 10Wfan) [15:50:36] hi fr-tech, thanks again for all the work with monthly convert! Heads up that the Bundle #2 pre-test in 10 minutes: just adding on Bundle #2 countries & languages (da, no, fr, he, pt in DK, IL, NO, PT, MY) onto existing campaign. [15:51:06] (03CR) 10CI reject: [V: 04-1] Add report or search result for transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/813655 (https://phabricator.wikimedia.org/T310756) (owner: 10Wfan) [15:51:52] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [15:52:36] (03PS4) 10Wfan: Add report or search result for transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/813655 (https://phabricator.wikimedia.org/T310756) [15:54:48] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs and other places outside civi - https://phabricator.wikimedia.org/T306360 (10Jgreen) [16:43:54] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clean up trailing numbers from email addresses in payment provider audit files - https://phabricator.wikimedia.org/T313062 (10Jgreen) [16:44:34] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs - https://phabricator.wikimedia.org/T306360 (10Jgreen) [16:44:55] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs - https://phabricator.wikimedia.org/T306360 (10Jgreen) [16:44:57] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clean up trailing numbers from email addresses in payment provider audit files - https://phabricator.wikimedia.org/T313062 (10Jgreen) [16:45:58] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Privacy Engineering: clear trailing number from email addresses in logs - https://phabricator.wikimedia.org/T306360 (10Jgreen) 05In progress→03Resolved Log processing is done, and I created a separate task for audit files. [16:49:51] 10Fundraising-Backlog, 10Privacy Engineering: clean up trailing numbers from email addresses in payment provider audit files - https://phabricator.wikimedia.org/T313062 (10Jgreen) a:05Jgreen→03None [17:14:59] 10Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Don't send failmail on Adyen unsupported card - https://phabricator.wikimedia.org/T313069 (10Ejegg) [17:17:38] haley_: belated thanks :) [18:09:41] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Network configuration for Braintree integration - https://phabricator.wikimedia.org/T303457 (10Dwisehaupt) Removed the gstatic.braintreeg... [18:45:47] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Ingenico/Worldline pre-production key expiring 14 July - https://phabricator.wikimedia.org/T312662 (10Ejegg) [18:52:07] (03CR) 10VolkerE: [C: 03+2] Fix syntax error in email_forms/i18n/qqq.json and add to CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813191 (owner: 10Samwilson) [18:54:26] (03Merged) 10jenkins-bot: Fix syntax error in email_forms/i18n/qqq.json and add to CI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813191 (owner: 10Samwilson) [19:44:17] 10Fundraising-Backlog, 10Technical-Debt: Migrate usage of Database::select to SelectQueryBuilder in FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T312444 (10Southparkfan) 05Open→03Invalid Impacted code is not used by this extension. [20:28:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Invalid language codes should not break donation queue consumer - https://phabricator.wikimedia.org/T313092 (10Ejegg) [20:48:01] (03PS1) 10Ejegg: Enable Braintree gateway for chooser test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813976 [21:14:47] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Turn on Adyen & Post-payment convert for Bundle #2 countries: DK, IL, NO, PT, MY - https://phabricator.wikimedia.org/T312965 (10HNordeenWMF) thank you @Ejegg ! [21:16:08] (03CR) 10AndyRussG: [C: 03+2] "Nice catch! yay!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813976 (owner: 10Ejegg) [21:17:53] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Monthly Convert variant on a recurring donation is pausing on the modal - https://phabricator.wikimedia.org/T312905 (10HNordeenWMF) Hi @Pcoombe or @AndyRussG - could you confirm: are we ok to use variant:'monthlyConvert_011' in banners again? - a... [21:18:11] (03Merged) 10jenkins-bot: Enable Braintree gateway for chooser test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/813976 (owner: 10Ejegg) [21:20:19] AndyRussG: re haley_'s question on the ticket - your JS fix went out with today's deploy so I had moved that ticket into done [21:20:34] though I haven't actually tested in production myself [21:24:45] ejegg: ah thanks... I'll test it on prod this evening and reply on the task [21:26:25] Somewhat interesting wikivandalism story: https://www.vice.com/en/article/pkgbwm/chinese-woman-fake-russian-history-wikipedia [21:28:33] wth [21:30:05] new zen koan: if nobody checks the citations are they citations? [21:30:53] It was so well-written it was selected as a featured article and translated into other languages, including English, Arabic, and Russian, spreading the damage to other language editions of Wikipedia. [21:32:47] maybe shes just from another timeline [21:33:34] my mind wonders what it would have been like if Tolkien was around today got up to similar mischief [21:33:58] 😂 [21:37:53] ahhhh crazy stuff indeed, good question bd808 :) [21:38:54] hi fr-tech, quick question: if we were to do next week's 6C pretest on Tuesday, July 19 from 20 - 23 UTC (21 - 24 Dublin time) would that work for you to enable Paypal if its ready by then? we're trying to move it away from Wednesday since that's the city activities day [21:41:52] haley_: PayPal via Braintree almost definitely won't be ready for donor testing by next Tuesday [21:48:36] ok, good to know! I think we'll go ahead and move the test up to Tuesday. I feel like it has enough going on already with Adyen w/ post-payment. We'll wait to hear about Paypal maybe its possible for the July 27 test - tskaff fyi [21:49:02] noted thanks all! [21:49:49] I don't think much work will be happening during the offisite haley_ tskaff so the 27 is probably still too soon [21:50:18] also noted! :) We'll figure it out ...