[00:18:24] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10KHancock99) I'm not sure if this helps, but I just did a manual count through the transaction pages at Adyen of the Authentication Required refusal codes via Car... [05:07:13] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 2059 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [05:12:11] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 2207 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [05:17:13] RECOVERY - check_procs on frdb2003 is OK: PROCS OK: 248 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [06:26:32] 10Fundraising-Backlog: Recurring set up at Adyen but not in Civi - https://phabricator.wikimedia.org/T313702 (10RKumar_WMF) [09:15:30] 10Fundraising-Backlog, 10Patch-For-Review: Civi emails and donations have different timestamps in the activities tab - https://phabricator.wikimedia.org/T313510 (10krobinson) I know for the end of year donations push, we move something back to PT or Hawaiian time so donors donating on 31st Dec from anywhere in... [09:27:04] 10Fundraising-Backlog, 10Patch-For-Review: Civi emails and donations have different timestamps in the activities tab - https://phabricator.wikimedia.org/T313510 (10Eileenmcnaughton) Yes the date on the letters is in 'beach time' - to ensure that US people get things in the correct year. I think we use the same... [09:48:02] hey jgleeson - how are you feeling? [09:54:06] 10Fundraising-Backlog: Unknown Payment Method cartebancaire_applepay - https://phabricator.wikimedia.org/T313710 (10jgleeson) [09:56:19] hey eileen! I'm fine thanks, how are you? Was Ireland good? It's been pretty mild for all of us. I haven't tested the last few days as we're out of tests. I need to ask my mum or someone else close by to pick us a few up [09:57:01] yeah - it was really good to see everyone. Quite a few people said how disappointed they were not to see you :-( [09:57:28] glad to hear you are doing OK [10:00:12] ah good to hear. Yeah, hopefully I can catch up with everyone at the next one. It's ironic that when we have an offsite in a country that's 50 minute flight away, I can't go ha! After all those long haul flights before... [10:00:20] speaking of which, how was your flights eileen ? [10:01:41] yeah so far so good with the flights - I'm in Manchester now & hoping the train to Exeter tomorrow goes ok given the strikes the day after. I took a RyanAir back from Dublin to Leeds though & the luggage was 90 mins late with no information given to us at all [10:03:29] ah [10:03:56] yeah ryanair tends to be the airline things like that happen with [10:04:13] cheap but sometimes problematic [10:04:30] who did you fly with from NZ? [10:40:56] jgleeson: that was Qantas - because of the complexities with having to take Luke to Sheffield WMF flew me to London & back & I did RyanAir to Dublin & back [11:02:16] I find it odd being online BEFORE the US [11:21:13] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10jgleeson) Hi all. I can also see in the logs a large number of Carte Bancaire failures from Adyen coming back with the 'Authentication required' response. Ady... [11:21:19] ha eileen [11:21:30] I've gotta break for a bit. back soon [12:18:08] 10Fundraising-Backlog: Adyen Carte Bancaire transaction log weirdness - https://phabricator.wikimedia.org/T313720 (10jgleeson) [15:07:22] (03PS1) 10Ejegg: Add another Adyen Apple Pay submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/816799 [15:12:36] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10EMartin) Hi All, we are roughly at the same decline % since turning on 3DS. I have also set rules in the console to invoke 3DS which has been confirmed as valid... [15:15:10] (03CR) 10Damilare Adedoyin: [C: 03+1] Add another Adyen Apple Pay submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/816799 (owner: 10Ejegg) [15:19:10] hi ejegg. looks like this ticket is related to your patch https://phabricator.wikimedia.org/T313710 [15:24:58] hi FRTech, we have a bit of a NL campaign show stopper involving iDeal that is in progress that was identified last week. Could this get some attention when possible: https://phabricator.wikimedia.org/T313325 [15:25:08] looking emartin [15:27:26] ejegg: we might wanna roll out your monthly convert control patch to fix this https://phabricator.wikimedia.org/T313325 [15:27:53] it looks like MC is being displayed before the redirect to the bank [15:29:12] pcoombe: when you tested that yourself, did you come in via a specific URL? I'm trying to rule out a variant query param [15:29:53] greg-g: we're gonna need our own Adyen DRI team from the looks of it [15:30:55] jgleeson: I simply tested via https://donate.wikimedia.org/?country=NL, which doesn't look to apply any variant parameters [15:32:32] thanks pcoombe I can also replicate it [15:32:41] fr-tech this might be an UBN [15:33:11] hmm did we change the MC JS recently? [15:34:56] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10EMartin) @jgleeson Thanks Jack, I have added FRTech to the thread with Adyen concerning this matter and included your findings. Much appreciated. [15:39:13] @eeggleston re: https://phabricator.wikimedia.org/T313333. Did you determine a fix for these GPay errors? I see you have a patch for review. [15:40:58] (03CR) 10Wfan: [C: 03+2] "Based on "Jul 22 20:17:05 civi1001 drupal: https://civicrm.wikimedia.org|1658521025|adyen_audit|127.0.0.1|https://civicrm.wikimedia.org/||" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/816799 (owner: 10Ejegg) [15:41:04] emartin: that patch ejegg pushed up should hopefully fix 'em both. I was just testing it locally but I can't replicate the iDEAL error locally, only in production, which is odd [15:41:40] (03Merged) 10jenkins-bot: Add another Adyen Apple Pay submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/816799 (owner: 10Ejegg) [15:50:06] jgleeson: ooh, was it really? [15:50:30] OK, let's get that fix out soon [15:50:49] ah right, we only added NL to the MC countries list a couple weeks ago [15:50:54] fr-tech it looks like our check here for the MC modal assumes that the redirect is the last step https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/adyen_gateway/forms/adyen.js#L359 but in this case it's first and we also probably don't wat MC on iDEAL [15:51:04] I guess nobody ever came in with payment_method=ideal&variant=monthlyconvert [15:51:05] ahh ejegg that'll be it [15:51:20] want* [15:52:00] lemme add that config and then I'll be able to recreate it locally, fix it with your patch (hopefully), and plus 2 it [15:52:31] heh pretty nice to have a prebaked UBN fix [15:54:52] :) [15:55:04] next we try for no UBNs in the first place... [15:55:35] ok I can see it breaking locally, now for the patch [15:57:47] 10fundraising-tech-ops: Fix Fundraising prometheus-mysqld-exporter config for Bullseye - https://phabricator.wikimedia.org/T313623 (10Jgreen) p:05Triage→03Medium [16:01:32] (03CR) 10Jgleeson: [C: 03+2] "Thanks, LGTM. Fixes the UBN issue with iDEAL and should also fix GPay due to how it works!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/814900 (https://phabricator.wikimedia.org/T313333) (owner: 10Ejegg) [16:02:22] ejegg: are you on childcare? if so I can push thatout [16:02:30] that out* [16:04:35] (03Merged) 10jenkins-bot: Check method to decide whether to show MC modal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/814900 (https://phabricator.wikimedia.org/T313333) (owner: 10Ejegg) [16:06:48] 10Fundraising-Backlog, 10fr-donorservices: iDeal donation flow broken - https://phabricator.wikimedia.org/T313325 (10jgleeson) Hi All We were able to replicate this error locally, and luckily @Ejegg had already written a patch to fix this bug after arriving back from the future in his Delorean :) We will dep... [16:08:10] jgleeson: oh good :) [16:08:50] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/816814 [16:09:06] jgleeson: I can deploy! [16:09:20] oh I see you're doing it now [16:09:37] sorry, was helping briefly with household things but am now back at the keyboard [16:09:45] Great news, thank you ejegg and lol Jack the Delorean [16:11:06] ejegg: feel free to take the wheel [16:11:59] (03PS1) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/816817 [16:12:07] those two patches just need merging [16:12:58] tskaff: :) [16:13:15] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/816814 (owner: 10Jgleeson) [16:13:21] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/816817 (owner: 10Jgleeson) [16:13:52] thanks for setting that up jgleeson ! [16:14:13] and for the code review and local testing [16:15:13] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/816814 (owner: 10Jgleeson) [16:15:33] thanks for fixing it! [16:22:41] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/816817 (owner: 10Jgleeson) [16:31:44] !log updated payments-wiki from f56e9391 to 4487bd31 [16:31:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:44:24] (03PS1) 10Wfan: update smashpig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816823 [16:45:04] (03CR) 10Wfan: [C: 03+2] update smashpig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816823 (owner: 10Wfan) [16:48:25] (03Merged) 10jenkins-bot: update smashpig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816823 (owner: 10Wfan) [17:07:06] 10Fundraising-Backlog, 10fr-donorservices: iDeal donation flow broken - https://phabricator.wikimedia.org/T313325 (10Pcoombe) Thanks, just checked on production and it looks fixed to me! [17:55:20] (03PS1) 10Wfan: Update SmashPig to 0.8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/816830 [17:56:21] (03CR) 10Wfan: [C: 03+2] Update SmashPig to 0.8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/816830 (owner: 10Wfan) [18:09:12] (03CR) 10CI reject: [V: 04-1] Update SmashPig to 0.8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/816830 (owner: 10Wfan) [18:09:30] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10netops, 10WMF-NDA: rsyslog TLS errors on frlog hosts from frack pfws - https://phabricator.wikimedia.org/T312601 (10Jgreen) [18:10:17] 10fundraising-tech-ops: Fix Fundraising prometheus-mysqld-exporter config for Bullseye - https://phabricator.wikimedia.org/T313623 (10Jgreen) 05Open→03Resolved [18:28:46] wfan: oh man, that test failure is annoying as heck [18:29:26] So I guess we now have some code in DonationInterface that only works under Mediawiki [18:29:50] and yet is in the code path that is called when donation-interface is used under CRM [18:30:56] wow, this is going to be really annoying to work around [18:31:22] so it has to do with the ConfigurationReader refactor [18:32:58] Our adapter constructor now needs to call a static method on MediaWiki\MediaWikiServices [18:33:54] to get an instance of a Config object and pass that into the ConfigurationReader [18:34:33] the problem is that neither the Config interface nor the MediaWikiServices class are defined when we call that constructor under CRM [18:34:55] So what on earth do we do.... [18:35:29] In other places where the DI logic calls mediawiki framework functions, we wrap it in a WmfFramework call [18:36:17] and alias a different WmfFramework implementation depending on whether we are running on mediawiki or CRM [18:36:59] 10Fundraising-Backlog: Adyen Carte Bancaire 3D Secure Headers not being set - https://phabricator.wikimedia.org/T313756 (10jgleeson) [18:39:04] but those functions all return primitives - we haven't had to shim MW classes under CRM yet [18:39:21] jgleeson: odd, it looks like we're relying on the Adyen component to collect that info [18:39:28] if ( state.data.browserInfo ) { [18:39:35] on line 312 of adyen.js [18:39:59] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10jgleeson) [18:40:01] 10Fundraising-Backlog: Adyen Carte Bancaire 3D Secure Headers not being set - https://phabricator.wikimedia.org/T313756 (10jgleeson) [18:40:10] jgleeson: ahh, but that's not the ua [18:40:17] I guess we add the ua server-side? [18:40:19] let's see [18:40:46] yeah [18:40:52] well... we should do [18:41:22] ejegg: wanna jump on a call? I'm trying to work out why [18:41:55] sure, it does look a little fragile [18:42:20] https://meet.google.com/mkm-dptq-dqq [19:51:28] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Adyen Carte Bancaire 3D Secure Headers not being set - https://phabricator.wikimedia.org/T313756 (10greg) [19:52:13] 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10greg) [19:54:08] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Unknown Payment Method cartebancaire_applepay - https://phabricator.wikimedia.org/T313710 (10greg) [19:57:08] 10Fundraising-Backlog: Recurring set up at Adyen but not in Civi - https://phabricator.wikimedia.org/T313702 (10greg) Heya @RKumar_WMF , how are you searching for this in Civi? By email? Transaction ID? [20:01:26] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) 05Resolved→03Open [20:03:30] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) a:05Dwisehaupt→03Jgreen [20:07:02] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Do not send PayPal Authorize and capture to queue to prevent 3 times records at civi and you email email - https://phabricator.wikimedia.org/T313512 (10greg) p:05Triage→03Medium [20:08:52] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10Patch-For-Review: Civi emails and donations have different timestamps in the activities tab - https://phabricator.wikimedia.org/T313510 (10greg) [20:13:56] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices: iDeal donation flow broken - https://phabricator.wikimedia.org/T313325 (10greg) [20:15:19] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices: iDeal donation flow broken - https://phabricator.wikimedia.org/T313325 (10EMartin) @RKumar_WMF Rakhi is working on a local (NL) user test and will report here. [20:16:50] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Alerts, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Don't send failmail on Adyen unsupported card - https://phabricator.wikimedia.org/T313069 (10greg) [20:23:53] 10Fundraising-Backlog: clean up trailing numbers from email addresses in payment provider audit files - https://phabricator.wikimedia.org/T313062 (10greg) Questions from Jeff: Can we just make the audit processor just delete them after a set time? There's also somethings with no updates for 3 years so can we a... [20:28:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate queue consumer slowdown in pretest of June 13 2022 - https://phabricator.wikimedia.org/T313000 (10greg) Is QC debug logging enabled? [20:35:02] 10Fundraising-Backlog, 10fr-donorservices: Report potential unintended duplicate donations - https://phabricator.wikimedia.org/T312964 (10greg) Maybe a searchkit dashboard for DR, eg: in the past day here are the multiple donations from the same user/email/whatever? Also, this brings up what our overall alert... [20:36:46] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Refactor MonthlyConvert feature - https://phabricator.wikimedia.org/T312958 (10greg) [20:36:52] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: [Epic] Architecture, separation of concerns and refactors in DonationInterface and SmashPig (2021) - https://phabricator.wikimedia.org/T291697 (10greg) [20:38:32] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Adyen api response with unrecognized parameters - https://phabricator.wikimedia.org/T312906 (10greg) [20:48:40] 10Fundraising-Backlog: Name changes required for Ingenico 3S2.0 - https://phabricator.wikimedia.org/T312877 (10greg) Putting in the next sprint to see what we need before any call with Ingenico. [20:54:36] 10Fundraising-Backlog: Name changes required for Ingenico 3S2.0 - https://phabricator.wikimedia.org/T312877 (10EMartin) @greg. We need the call with Ingenico to understand their proposition on this, then we can assess in next sprint. [21:55:19] (03PS1) 10Jgleeson: Remove payment submethod check during Adyen 3DSecure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) [22:00:56] (03PS2) 10Jgleeson: Remove payment submethod check during Adyen 3DSecure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) [22:03:09] (03CR) 10CI reject: [V: 04-1] Remove payment submethod check during Adyen 3DSecure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) (owner: 10Jgleeson) [22:04:41] (03PS3) 10Jgleeson: Remove payment submethod check during Adyen 3DSecure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) [22:05:56] (03PS4) 10Jgleeson: Remove payment submethod check during Adyen 3DSecure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) [22:12:40] fr-tech ejegg|brb I've tested that patch locally ^^^ and it gets 3D Secure working for the suspected broken Carte Bancaire payments. To test this, you need to add 'FR' to the 'EUR' array under your $wgDonationInterface3DSRules in config-private. you can then comment out lines 308-310 in adyen.js(submethod param on/off) and try a 3D Secure test donation on the French Adyen form locally with and [22:12:42] without the patch applied. When applied, you should get redirected to 3D Secure (Happy path). When not applied it should go straight to the thank you page and skip 3D Secure(Error path). Test card data here https://docs.adyen.com/development-resources/testing/test-card-numbers#test-3d-secure-2-authentication I'll paste these instructions on the patch too [22:13:29] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10Patch-For-Review: Adyen Carte Bancaire 3D Secure Headers not being set - https://phabricator.wikimedia.org/T313756 (10jgleeson) I've tested that patch locally ^^^ and it gets 3D Secure working for the suspected broken Carte Bancaire payments.... [22:14:29] (03CR) 10Jgleeson: "testing instructions here: https://phabricator.wikimedia.org/T313756#8103281" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) (owner: 10Jgleeson) [22:15:57] bye for now o/ [22:36:17] AndyRussG: I have a slightly different code organization idea to achieve the same result as jgleeson|away's patch for Adyen 3DS [22:36:51] If you're not too busy I'll code that up and push it for review [22:37:01] otherwise I'll just go with jgleeson|away's version [22:42:11] ejegg: pls go ahead, happy to take a look [22:42:19] rockin! [22:46:49] ah dang, I forgot the GlobalCollect3DSecure class is still kicking around. Will have to do a bit of code duplication for the time being [22:48:09] (03PS1) 10Ejegg: 3DS: make canSet abstract, change Adyen implementation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) [22:48:54] so AndyRussG I'm stating something in that commit message that i /think/ is true, but am waiting for the Adyen tech to confirm. [22:49:20] it's the exact same effect as jgleeson|away's patch [22:49:29] but more changes and some copypaste [22:52:55] so... maybe not actually better [23:00:24] wfan: did you see my explanation of the test failures up a ways in this IRC channel? And do you have any ideas on the best way to avoid the MediawikiServices getConfig call when running under CRM? [23:01:15] The comments are from a bit before we had that call with jgleeson|away to talk about Carte Bancaire [23:01:39] Oh, why don't I copy them to the patch on gerrit [23:02:44] Oh ok, thanks, then could I update the payment first then come back for this MediawikiServices? [23:04:58] (03CR) 10Ejegg: "Argh, this test failure is because of some ugly tech debt." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/816830 (owner: 10Wfan) [23:05:20] wfan: so it's going to be pretty ugly to solve [23:05:46] I think you will have to add a getConfig() method to the WmfFramework implementations [23:06:16] and also find a way to declare the Config interface when it is missing [23:06:46] that is, declare the Config interface, but only when running under CRM [23:07:18] either that, or we just delete the PayPal orphan rectifier right now and get rid of the donation-interface package under crm :) [23:07:28] is it really rectifying many orphans? [23:07:56] and how much tech debt are they worth? [23:08:35] Oh, for the MediaWikiServices we were use them for ffname rewrite also ~ [23:09:02] yep! [23:09:16] we don't use the gateway chooser under CRM, fortunately [23:09:22] so that part doesn't need to be touched [23:09:59] yeah, btw, we could not delete the old paypal code yet until braintree right? [23:17:31] wfan right, we need to keep supporting old paypal for now [23:18:10] that suggestion to delete the paypal orphan rectifier was mostly a joke [23:20:05] another probably-bad option would be to fork the donationinterface repo at some point before the ConfigurationReader refactor [23:20:42] and just edit the composer.json there to allow newer smash-pig, then re-tag it with a higher version [23:21:11] but that could get us in trouble if we've made some incompatible changes in smash-pig since then [23:23:06] wfan: so do you see what we're doing here? https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/WmfFramework.php https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/WmfFramework.mediawiki.php https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/WmfFramework.drupal.php [23:23:38] This is the nasty hack that's letting us use a mediawiki extension outside of mediawiki [23:24:11] and which we'll have to extend a bit here, unless you think of a better way [23:24:33] that first php file is just detecting whether we're running under real-mediawiki [23:24:56] and aliasing the WmfFramework to the _Mediawiki version in that case [23:25:09] otherwise aliasing it to WmfFramework_Drupal [23:26:32] so WmfFramework_Mediawiki contains functions which wrap all the parts of Mediawiki core which DonationInterface needs to instantiate an adaptor and do a basic charge [23:26:50] mostly global functions for session access and message translation [23:27:35] I see what are those three docs doing, I will try debug the unit test and see what should I do to make those them pass. [23:27:41] then WmfFramework_Drupal has alternate implementations of all those same functions, but either using Drupal framework calls, or just stubbing those out [23:28:19] wfan: so I /think/ it will mean adding a 'getConfig' function to both classes. [23:28:58] in WmfFramework_Mediawiki, getConfig with just return the same MediaWikiServices::getInstance()->getMainConfig() [23:29:37] but under WmfFramework_Drupal it will have to return something else that implements the Config interface [23:30:33] and what's more, we will have to define the Config interface when we are running under Drupal. That last part will probably happen in that first WmfFramework.php file, maybe adding a require_once call to the else block [23:32:52] OK, need to process those info and will ask you for help when I am getting there ~ Thanks :) ejegg: [23:33:20] Heh, all I can say is... we warned you back in the job interview that DonationInterface was crazy, and you still took the job :) [23:35:43] ejegg: hey sorry just saw the follow up pings now [23:36:55] I'll actually look in about 15 min